agent-canvas 0.2.0 → 0.2.1

package/daemon/src/files-api.test.ts

@@ -0,0 +1,78 @@
+import { afterEach, expect, test } from "bun:test";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "fs";
+import { tmpdir } from "os";
+import { join } from "path";
+import { SessionManager } from "@fabrika/canvas-kernel/server";
+import { dispatch } from "@fabrika/daemon-kit";
+import { createFileHandlers } from "./handlers/files";
+
+const directories: string[] = [];
+
+afterEach(() => {
+  for (const directory of directories.splice(0)) {
+    rmSync(directory, { recursive: true, force: true });
+  }
+});
+
+function setup() {
+  const directory = mkdtempSync(join(tmpdir(), "agent-canvas-files-"));
+  directories.push(directory);
+  const projectRoot = join(directory, "project");
+  const outsideRoot = join(directory, "project-other");
+  mkdirSync(projectRoot);
+  mkdirSync(outsideRoot);
+  writeFileSync(join(projectRoot, "local.ts"), "export const local = true;");
+  writeFileSync(join(outsideRoot, "external.ts"), "export const external = true;");
+  writeFileSync(join(outsideRoot, "image.svg"), "<svg xmlns=\"http://www.w3.org/2000/svg\" />");
+  const manager = new SessionManager(join(directory, "sessions"));
+  manager.upsert("files", new Map([["plan.jsx", "<Section />"]]), projectRoot);
+  const routes = createFileHandlers(manager);
+
+  async function get(endpoint: string, path: string) {
+    const url = new URL(`http://localhost:19400/api/${endpoint}`);
+    url.searchParams.set("session", "files");
+    url.searchParams.set("path", path);
+    const response = dispatch(routes, new Request(url), url);
+    if (!response) throw new Error(`No route for ${endpoint}`);
+    return response;
+  }
+
+  return { get, projectRoot, outsideRoot };
+}
+
+test("serves relative paths and absolute paths inside and outside the project root", async () => {
+  const { get, projectRoot, outsideRoot } = setup();
+  for (const path of ["local.ts", join(projectRoot, "local.ts"), join(outsideRoot, "external.ts")]) {
+    const response = await get("file", path);
+    expect(response.status).toBe(200);
+    expect(await response.json()).toEqual({
+      content: path.endsWith("external.ts") ? "export const external = true;" : "export const local = true;",
+      language: "typescript",
+    });
+  }
+});
+
+test("serves absolute image and directory paths outside the project root", async () => {
+  const { get, outsideRoot } = setup();
+  const image = await get("image", join(outsideRoot, "image.svg"));
+  expect(image.status).toBe(200);
+  expect(image.headers.get("Content-Type")).toBe("image/svg+xml");
+  const tree = await get("tree", outsideRoot);
+  expect(tree.status).toBe(200);
+  expect(await tree.json()).toEqual({ entries: [
+    { name: "external.ts", type: "file" },
+    { name: "image.svg", type: "file" },
+  ] });
+});
+
+test("rejects relative traversal into a sibling with the same root prefix", async () => {
+  const { get } = setup();
+  for (const endpoint of ["file", "image", "tree"]) {
+    expect((await get(endpoint, "../project-other/external.ts")).status).toBe(403);
+  }
+});
+
+test("returns 404 for a missing absolute file", async () => {
+  const { get, outsideRoot } = setup();
+  expect((await get("file", join(outsideRoot, "missing.ts"))).status).toBe(404);
+});

package/daemon/src/handlers/files.ts

@@ -1,4 +1,4 @@
-import { join, resolve } from "path";
+import { isAbsolute, relative, resolve, sep } from "path";
 import { readdir } from "fs/promises";
 import type { SessionManager } from "@fabrika/canvas-kernel/server";
 import { jsonResponse, type Route } from "@fabrika/daemon-kit";
@@ -18,8 +18,9 @@ function resolveSessionPath(
   const session = sessionManager.get(sessionId);
   if (!session) return jsonResponse({ error: "Session not found" }, 404);
 
-  const fullPath = resolve(join(session.projectRoot, relPath));
-  if (!fullPath.startsWith(resolve(session.projectRoot))) {
+  const fullPath = resolve(session.projectRoot, relPath);
+  const relativePath = relative(resolve(session.projectRoot), fullPath);
+  if (!isAbsolute(relPath) && (relativePath === ".." || relativePath.startsWith(`..${sep}`))) {
     return jsonResponse({ error: "Path traversal rejected" }, 403);
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-canvas",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Interactive visual canvas for Claude Code — rich annotatable documents in the browser",
   "bin": {
     "agent-canvas": "bin/agent-canvas.js"

package/skills/canvas/SKILL.md

@@ -29,6 +29,10 @@ fresh, so the variable will not survive between commands.
 
 ## Instructions
 
+Always use absolute filesystem paths for local file references in canvas components
+(such as `FilePreview`), and verify that the referenced files exist. Resolve them
+against the user's project directory, not the temporary directory containing the JSX.
+
 Run these commands from the user's project root before using Canvas:
 
 ```bash