agemon 6.0.0 → 6.3.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +424 -89
- package/assets/skills/design/agemon-design/NOTICE.md +34 -0
- package/assets/skills/design/agemon-design/SKILL.md +95 -358
- package/assets/skills/design/agemon-design/references/actions.md +215 -0
- package/assets/skills/design/agemon-design/references/brief.md +13 -9
- package/assets/skills/design/agemon-design/references/core-rules.md +166 -0
- package/assets/skills/design/agemon-design/references/craft-intent.md +16 -14
- package/assets/skills/design/agemon-design/references/dashboard.md +1 -1
- package/assets/skills/design/agemon-design/references/dataviz.md +8 -8
- package/assets/skills/design/agemon-design/references/finish-bar.md +1 -1
- package/assets/skills/design/agemon-design/references/heuristics.md +56 -140
- package/assets/skills/design/agemon-design/references/inspiration.md +6 -6
- package/assets/skills/design/agemon-design/references/loops.md +9 -9
- package/assets/skills/design/agemon-design/references/motion.md +1 -1
- package/assets/skills/design/agemon-design/references/personas.md +4 -4
- package/assets/skills/design/{agemon-design-dashboard/SKILL.md → agemon-design/references/preset-dashboard.md} +8 -12
- package/assets/skills/design/{agemon-design-editorial/SKILL.md → agemon-design/references/preset-editorial.md} +5 -9
- package/assets/skills/design/{agemon-design-minimal/SKILL.md → agemon-design/references/preset-minimal.md} +8 -12
- package/assets/skills/design/agemon-design/references/principles-catalog.md +3 -3
- package/assets/skills/design/agemon-design/references/recipe-auth.md +3 -3
- package/assets/skills/design/agemon-design/references/recipe-dashboard.md +2 -2
- package/assets/skills/design/agemon-design/references/recipe-landing.md +9 -11
- package/assets/skills/design/agemon-design/references/review.md +7 -7
- package/assets/skills/design/agemon-design/references/routing.md +143 -0
- package/assets/skills/design/agemon-design/references/spec.md +8 -8
- package/assets/skills/design/agemon-design/references/stack.md +1 -1
- package/assets/skills/design/agemon-design/references/stage-assets.md +106 -0
- package/assets/skills/design/agemon-design/references/stage-build.md +46 -0
- package/assets/skills/design/agemon-design/references/stage-critique.md +34 -0
- package/assets/skills/design/agemon-design/references/stage-directions.md +44 -0
- package/assets/skills/design/agemon-design/references/stage-intake.md +34 -0
- package/assets/skills/design/agemon-design/references/stage-verify.md +44 -0
- package/assets/skills/design/agemon-design/references/state-design.md +1 -1
- package/assets/skills/design/agemon-design/references/tells-2026-11.md +32 -0
- package/assets/skills/design/agemon-design/references/themes.md +24 -20
- package/assets/skills/design/agemon-design/references/third-party-licenses.md +323 -0
- package/assets/skills/design/agemon-design/references/typography.md +11 -9
- package/assets/skills/design/agemon-design/scripts/audit-page.js +532 -0
- package/assets/skills/design/agemon-design/scripts/check-source.mjs +358 -0
- package/assets/skills/design/agemon-design/scripts/deal.mjs +231 -0
- package/assets/skills/design/agemon-design/scripts/inventory.mjs +676 -0
- package/assets/skills/{design/agemon-design-dashboard → essentials/web-design-guidelines}/LICENSE +1 -1
- package/assets/skills/essentials/web-design-guidelines/NOTICE.md +14 -0
- package/assets/skills/essentials/web-design-guidelines/SKILL.md +18 -0
- package/assets/skills/essentials/web-design-guidelines/references/guidelines.md +184 -0
- package/assets/skills/{design/agemon-design-minimal → essentials/writing-guidelines}/LICENSE +1 -1
- package/assets/skills/essentials/writing-guidelines/NOTICE.md +14 -0
- package/assets/skills/essentials/writing-guidelines/SKILL.md +18 -0
- package/assets/skills/essentials/writing-guidelines/references/guidelines.md +250 -0
- package/assets/skills/founder/agemon-founder-board/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-board/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-board/SKILL.md +111 -0
- package/assets/skills/founder/agemon-founder-board/lenses.md +84 -0
- package/assets/skills/founder/agemon-founder-brand/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-brand/NOTICE.md +12 -0
- package/assets/skills/founder/agemon-founder-brand/SKILL.md +77 -0
- package/assets/skills/founder/agemon-founder-cfo/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-cfo/NOTICE.md +12 -0
- package/assets/skills/founder/agemon-founder-cfo/SKILL.md +109 -0
- package/assets/skills/founder/agemon-founder-cfo/example.json +27 -0
- package/assets/skills/founder/agemon-founder-cfo/unit_economics.py +270 -0
- package/assets/skills/founder/agemon-founder-competitors/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-competitors/NOTICE.md +12 -0
- package/assets/skills/founder/agemon-founder-competitors/SKILL.md +84 -0
- package/assets/skills/founder/agemon-founder-consumer/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-consumer/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-consumer/SKILL.md +126 -0
- package/assets/skills/founder/agemon-founder-consumer/customer.example.json +34 -0
- package/assets/skills/founder/agemon-founder-consumer/panel.py +424 -0
- package/assets/skills/founder/agemon-founder-consumer/pitch.example.md +3 -0
- package/assets/skills/founder/agemon-founder-launch/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-launch/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-launch/SKILL.md +65 -0
- package/assets/skills/founder/agemon-founder-marketing/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-marketing/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-marketing/SKILL.md +80 -0
- package/assets/skills/founder/agemon-founder-offer/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-offer/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-offer/SKILL.md +75 -0
- package/assets/skills/founder/agemon-founder-ops/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-ops/NOTICE.md +12 -0
- package/assets/skills/founder/agemon-founder-ops/SKILL.md +77 -0
- package/assets/skills/founder/agemon-founder-plan/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-plan/NOTICE.md +11 -0
- package/assets/skills/founder/agemon-founder-plan/SKILL.md +88 -0
- package/assets/skills/founder/agemon-founder-plan/compile.py +178 -0
- package/assets/skills/founder/agemon-founder-pricing/LICENSE +21 -0
- package/assets/skills/founder/agemon-founder-pricing/NOTICE.md +12 -0
- package/assets/skills/founder/agemon-founder-pricing/SKILL.md +92 -0
- package/assets/skills/founder/agemon-founder-pricing/van_westendorp.py +172 -0
- package/assets/skills/{design/agemon-design-editorial → output-style/agemon-adhd}/LICENSE +1 -1
- package/assets/skills/output-style/agemon-adhd/NOTICE.md +13 -0
- package/assets/skills/output-style/agemon-adhd/SKILL.md +138 -0
- package/assets/skills/security/agemon-security-audit/AI-AND-LLM.md +83 -0
- package/assets/skills/security/agemon-security-audit/ATTACK-CLASSES.md +130 -0
- package/assets/skills/security/agemon-security-audit/CLIENT-SIDE.md +83 -0
- package/assets/skills/security/agemon-security-audit/CLOUD-AND-DEPLOYMENT.md +86 -0
- package/assets/skills/security/agemon-security-audit/DATA-ISOLATION-AND-LIFECYCLE.md +84 -0
- package/assets/skills/security/agemon-security-audit/DESKTOP-MOBILE-AND-LOCAL-IPC.md +89 -0
- package/assets/skills/security/agemon-security-audit/HUNTING.md +251 -0
- package/assets/skills/security/agemon-security-audit/LICENSE +21 -0
- package/assets/skills/security/agemon-security-audit/MEMORY-SAFETY-AND-BINARY.md +101 -0
- package/assets/skills/security/agemon-security-audit/NOTICE.md +12 -0
- package/assets/skills/security/agemon-security-audit/PROTOCOLS-RPC-AND-MESSAGING.md +81 -0
- package/assets/skills/security/agemon-security-audit/RECONNAISSANCE.md +156 -0
- package/assets/skills/security/agemon-security-audit/RESOURCE-EXHAUSTION-AND-AVAILABILITY.md +78 -0
- package/assets/skills/security/agemon-security-audit/SKILL.md +192 -0
- package/assets/skills/security/agemon-security-audit/SUPPLY-CHAIN-AND-RELEASE.md +73 -0
- package/assets/skills/security/agemon-security-audit/VALIDATION-AND-REPORTING.md +186 -0
- package/assets/skills/security/agemon-security-audit/WEB-PROTOCOL-AND-AUTH.md +105 -0
- package/assets/skills/security/agemon-security-audit/report-schema.json +461 -0
- package/assets/skills/security/agemon-security-audit/validate-coverage-ledger.cjs +872 -0
- package/assets/skills/security/agemon-security-audit/validate-findings.cjs +773 -0
- package/assets/skills/workflow/agemon-brainstorming/LICENSE +21 -0
- package/assets/skills/workflow/agemon-brainstorming/NOTICE.md +14 -0
- package/assets/skills/workflow/agemon-brainstorming/SKILL.md +287 -0
- package/assets/skills/workflow/agemon-brainstorming/builder-check-prompt.md +23 -0
- package/assets/skills/workflow/agemon-dispatching-parallel-agents/LICENSE +21 -0
- package/assets/skills/workflow/agemon-dispatching-parallel-agents/NOTICE.md +13 -0
- package/assets/skills/workflow/agemon-dispatching-parallel-agents/SKILL.md +167 -0
- package/assets/skills/workflow/agemon-executing-plans/LICENSE +21 -0
- package/assets/skills/workflow/agemon-executing-plans/NOTICE.md +15 -0
- package/assets/skills/workflow/agemon-executing-plans/SKILL.md +322 -0
- package/assets/skills/workflow/agemon-executing-plans/scripts/task-done +55 -0
- package/assets/skills/workflow/agemon-executing-plans/scripts/task-start +32 -0
- package/assets/skills/workflow/agemon-finishing-a-development-branch/LICENSE +21 -0
- package/assets/skills/workflow/agemon-finishing-a-development-branch/NOTICE.md +13 -0
- package/assets/skills/workflow/agemon-finishing-a-development-branch/SKILL.md +225 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/LICENSE +21 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/NOTICE.md +15 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/SKILL.md +339 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/code-reviewer.md +198 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/implementer-prompt.md +154 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/re-review-prompt.md +116 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/batching.md +11 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/cannot-verify.md +10 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/final-review.md +49 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/fix-loop.md +77 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/handling-reports.md +15 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/preflight.md +26 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/resuming.md +12 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/role-scout.md +18 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/references/role-worker.md +19 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/scripts/review-package +64 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/scripts/sdd-repo +54 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/scripts/sdd-workspace +110 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/scripts/task-brief +108 -0
- package/assets/skills/workflow/agemon-subagent-driven-development/task-reviewer-prompt.md +209 -0
- package/assets/skills/workflow/agemon-test-driven-development/LICENSE +21 -0
- package/assets/skills/workflow/agemon-test-driven-development/NOTICE.md +14 -0
- package/assets/skills/workflow/agemon-test-driven-development/SKILL.md +330 -0
- package/assets/skills/workflow/agemon-test-driven-development/writing-good-tests.md +198 -0
- package/assets/skills/workflow/agemon-using-git-worktrees/LICENSE +21 -0
- package/assets/skills/workflow/agemon-using-git-worktrees/NOTICE.md +13 -0
- package/assets/skills/workflow/agemon-using-git-worktrees/SKILL.md +167 -0
- package/assets/skills/workflow/agemon-writing-plans/LICENSE +21 -0
- package/assets/skills/workflow/agemon-writing-plans/NOTICE.md +13 -0
- package/assets/skills/workflow/agemon-writing-plans/SKILL.md +204 -0
- package/dist/{chunk-5LATHJYU.js → chunk-ZZBF3GOV.js} +369 -944
- package/dist/chunk-ZZBF3GOV.js.map +1 -0
- package/dist/{fake-subprocess-2BETWZVZ.js → fake-subprocess-IV4ML77S.js} +3 -33
- package/dist/fake-subprocess-IV4ML77S.js.map +1 -0
- package/dist/index.js +3477 -731
- package/dist/index.js.map +1 -1
- package/package.json +8 -1
- package/assets/skills/design/agemon-design/references/agents.md +0 -63
- package/assets/skills/design/agemon-design-dashboard/NOTICE.md +0 -9
- package/assets/skills/design/agemon-design-editorial/NOTICE.md +0 -9
- package/assets/skills/design/agemon-design-minimal/NOTICE.md +0 -9
- package/dist/chunk-5LATHJYU.js.map +0 -1
- package/dist/fake-subprocess-2BETWZVZ.js.map +0 -1
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
MIT License
|
|
2
|
+
|
|
3
|
+
Copyright (c) 2025 Jesse Vincent
|
|
4
|
+
|
|
5
|
+
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
6
|
+
of this software and associated documentation files (the "Software"), to deal
|
|
7
|
+
in the Software without restriction, including without limitation the rights
|
|
8
|
+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
9
|
+
copies of the Software, and to permit persons to whom the Software is
|
|
10
|
+
furnished to do so, subject to the following conditions:
|
|
11
|
+
|
|
12
|
+
The above copyright notice and this permission notice shall be included in all
|
|
13
|
+
copies or substantial portions of the Software.
|
|
14
|
+
|
|
15
|
+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
16
|
+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
17
|
+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
18
|
+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
19
|
+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
20
|
+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
21
|
+
SOFTWARE.
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
# Vendored skill
|
|
2
|
+
|
|
3
|
+
- Source: https://github.com/obra/superpowers
|
|
4
|
+
- Path in source: skills/subagent-driven-development
|
|
5
|
+
- Commit: 22f0b463e7a5e579904dd6211a520321035526f7
|
|
6
|
+
- Retrieved: 2026-11-05
|
|
7
|
+
- License: MIT — see `LICENSE` in this directory.
|
|
8
|
+
|
|
9
|
+
## agemon modifications
|
|
10
|
+
|
|
11
|
+
- Renamed from `subagent-driven-development` to `agemon-subagent-driven-development`, and updated references to upstream's other skills to their agemon names (`systematic-debugging` is `agemon-root-cause`, `verification-before-completion` is `agemon-verify-before-done`, both in the `self-review` group).
|
|
12
|
+
- Moved working files from `.superpowers/` to `.agemon-workflow/` and documents from `docs/superpowers/` to `docs/`.
|
|
13
|
+
- One of several skills cherry-picked from the superpowers framework; its `using-superpowers` bootstrap and session hook are not vendored, so nothing forces these skills to load.
|
|
14
|
+
- Added upstream's `skills/requesting-code-review/code-reviewer.md` as `code-reviewer.md`, so this group works without the `self-review` group.
|
|
15
|
+
- Added `references/role-scout.md` and `references/role-worker.md`, written by agemon, as the briefs of the `agemon-scout` and `agemon-worker` subagents.
|
|
@@ -0,0 +1,339 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agemon-subagent-driven-development
|
|
3
|
+
description: Use when executing implementation plans with independent tasks in the current session
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Subagent-Driven Development
|
|
7
|
+
|
|
8
|
+
Execute plan by dispatching a fresh implementer subagent per task, a task review (spec compliance + code quality) after each, and a broad whole-branch review at the end.
|
|
9
|
+
|
|
10
|
+
**Why subagents:** You delegate tasks to specialized agents with isolated context. By precisely crafting their instructions and context, you ensure they stay focused and succeed at their task. They should never inherit your session's context or history — you construct exactly what they need. This also preserves your own context for coordination work.
|
|
11
|
+
|
|
12
|
+
**Core principle:** Fresh subagent per task + task review (spec + quality) + broad final review = high quality, fast iteration
|
|
13
|
+
|
|
14
|
+
**Narration:** between tool calls, narrate at most one short line — the
|
|
15
|
+
ledger and the tool results carry the record.
|
|
16
|
+
|
|
17
|
+
**Continuous execution:** Do not pause to check in with your human partner between tasks. Execute all tasks from the plan without stopping. The only reasons to stop are the four named below, or all tasks complete. "Should I continue?" prompts and progress summaries waste their time — they asked you to execute the plan, so execute it.
|
|
18
|
+
|
|
19
|
+
**Rulings, not stalls.** A running plan does not wait on a human. Conflicts,
|
|
20
|
+
ambiguities, plan defects, a cap you would have asked to exceed — decide
|
|
21
|
+
them. The spec is the binding authority, the plan is its argument, and your
|
|
22
|
+
judgment settles what neither answers. Record every decision in the ledger as
|
|
23
|
+
`Ruling: <what you decided> — <why> — <what it costs if wrong>`, and keep
|
|
24
|
+
going. A wrong ruling costs rework your human partner can see and undo; a
|
|
25
|
+
session parked on a question costs their whole day and buys nothing.
|
|
26
|
+
|
|
27
|
+
Four things stop you, and only these: an irreversible or destructive
|
|
28
|
+
operation; a security-sensitive action; a side effect outside this worktree
|
|
29
|
+
that norms say you ask about first (a merge, a push to a shared branch, a
|
|
30
|
+
publish); and a plan so broken that every path forward is a guess. For those,
|
|
31
|
+
stop and ask.
|
|
32
|
+
|
|
33
|
+
## When to Use
|
|
34
|
+
|
|
35
|
+
```dot
|
|
36
|
+
digraph when_to_use {
|
|
37
|
+
"Have implementation plan?" [shape=diamond];
|
|
38
|
+
"Tasks mostly independent?" [shape=diamond];
|
|
39
|
+
"Partner chose inline, or no subagent tool?" [shape=diamond];
|
|
40
|
+
"subagent-driven-development" [shape=box];
|
|
41
|
+
"executing-plans" [shape=box];
|
|
42
|
+
"Manual execution or brainstorm first" [shape=box];
|
|
43
|
+
|
|
44
|
+
"Have implementation plan?" -> "Tasks mostly independent?" [label="yes"];
|
|
45
|
+
"Have implementation plan?" -> "Manual execution or brainstorm first" [label="no"];
|
|
46
|
+
"Tasks mostly independent?" -> "Partner chose inline, or no subagent tool?" [label="yes"];
|
|
47
|
+
"Tasks mostly independent?" -> "Manual execution or brainstorm first" [label="no - tightly coupled"];
|
|
48
|
+
"Partner chose inline, or no subagent tool?" -> "executing-plans" [label="yes"];
|
|
49
|
+
"Partner chose inline, or no subagent tool?" -> "subagent-driven-development" [label="no"];
|
|
50
|
+
}
|
|
51
|
+
```
|
|
52
|
+
|
|
53
|
+
**vs. Executing Plans (inline):**
|
|
54
|
+
- Fresh subagent per task (no context pollution) instead of one context doing every task
|
|
55
|
+
- Review after each task (spec compliance + code quality) instead of only at the end
|
|
56
|
+
- Costs a fresh context per task and per review; inline costs one context plus one final reviewer
|
|
57
|
+
- Both run in this session, share the same plan workspace and ledger, and never pause between tasks
|
|
58
|
+
|
|
59
|
+
## The Process
|
|
60
|
+
|
|
61
|
+
```dot
|
|
62
|
+
digraph process {
|
|
63
|
+
rankdir=TB;
|
|
64
|
+
|
|
65
|
+
subgraph cluster_per_task {
|
|
66
|
+
label="Per Task";
|
|
67
|
+
"Dispatch implementer subagent (./implementer-prompt.md)" [shape=box];
|
|
68
|
+
"Implementer asks questions?" [shape=diamond];
|
|
69
|
+
"Answer questions, provide context" [shape=box];
|
|
70
|
+
"Implementer implements, tests, commits, self-reviews" [shape=box];
|
|
71
|
+
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" [shape=box];
|
|
72
|
+
"Spec ✅ and quality approved?" [shape=diamond];
|
|
73
|
+
"Fix loop: read references/fix-loop.md before every round" [shape=box];
|
|
74
|
+
"Append completion to ledger, mark todo complete" [shape=box];
|
|
75
|
+
}
|
|
76
|
+
|
|
77
|
+
"Setup: worktree, ledger check, read plan, pre-flight review" [shape=box];
|
|
78
|
+
"More tasks remain?" [shape=diamond];
|
|
79
|
+
"Final review and finish: read references/final-review.md" [shape=box];
|
|
80
|
+
"Final review clean: delete this plan's workspace" [shape=box];
|
|
81
|
+
"Use agemon-finishing-a-development-branch" [shape=box style=filled fillcolor=lightgreen];
|
|
82
|
+
|
|
83
|
+
"Setup: worktree, ledger check, read plan, pre-flight review" -> "Dispatch implementer subagent (./implementer-prompt.md)";
|
|
84
|
+
"Dispatch implementer subagent (./implementer-prompt.md)" -> "Implementer asks questions?";
|
|
85
|
+
"Implementer asks questions?" -> "Answer questions, provide context" [label="yes"];
|
|
86
|
+
"Answer questions, provide context" -> "Implementer implements, tests, commits, self-reviews";
|
|
87
|
+
"Implementer asks questions?" -> "Implementer implements, tests, commits, self-reviews" [label="no"];
|
|
88
|
+
"Implementer implements, tests, commits, self-reviews" -> "Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)";
|
|
89
|
+
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" -> "Spec ✅ and quality approved?";
|
|
90
|
+
"Spec ✅ and quality approved?" -> "Append completion to ledger, mark todo complete" [label="yes"];
|
|
91
|
+
"Spec ✅ and quality approved?" -> "Fix loop: read references/fix-loop.md before every round" [label="no"];
|
|
92
|
+
"Fix loop: read references/fix-loop.md before every round" -> "Append completion to ledger, mark todo complete" [label="addressed, or parked at the cap"];
|
|
93
|
+
"Append completion to ledger, mark todo complete" -> "More tasks remain?";
|
|
94
|
+
"More tasks remain?" -> "Dispatch implementer subagent (./implementer-prompt.md)" [label="yes"];
|
|
95
|
+
"More tasks remain?" -> "Final review and finish: read references/final-review.md" [label="no"];
|
|
96
|
+
"Final review and finish: read references/final-review.md" -> "Final review clean: delete this plan's workspace";
|
|
97
|
+
"Final review clean: delete this plan's workspace" -> "Use agemon-finishing-a-development-branch";
|
|
98
|
+
}
|
|
99
|
+
```
|
|
100
|
+
|
|
101
|
+
## Setup
|
|
102
|
+
|
|
103
|
+
Ensure the work happens in an isolated workspace: use
|
|
104
|
+
agemon-using-git-worktrees to create one or verify the existing one.
|
|
105
|
+
Never start implementation on a main/master branch without your human
|
|
106
|
+
partner's explicit consent.
|
|
107
|
+
|
|
108
|
+
Conversation memory does not survive compaction. In real sessions,
|
|
109
|
+
controllers that lost their place have re-dispatched entire completed task
|
|
110
|
+
sequences — the single most expensive failure observed. Track progress in
|
|
111
|
+
a ledger file, not only in todos.
|
|
112
|
+
|
|
113
|
+
- Each plan owns a workspace: at skill start, run this skill's
|
|
114
|
+
`bash scripts/sdd-workspace PLAN_FILE` by its absolute path, from the
|
|
115
|
+
working tree you're executing in — it prints the plan's git-ignored
|
|
116
|
+
directory (under `<repo-root>/.agemon-workflow/sdd/`), home to
|
|
117
|
+
every artifact for THIS plan: ledger, briefs, reports, review packages.
|
|
118
|
+
Another plan's directory is never yours to read or write.
|
|
119
|
+
- Check for this plan's ledger at `<workspace>/progress.md`. If one exists,
|
|
120
|
+
read [references/resuming.md](references/resuming.md) before anything
|
|
121
|
+
else: it says whose ledger it is and where to resume.
|
|
122
|
+
- Create the ledger with its identity as the first line:
|
|
123
|
+
`# SDD ledger — plan: <plan file path>`.
|
|
124
|
+
- The ledger is your recovery map: the commits it names exist in git even
|
|
125
|
+
when your context no longer remembers creating them. After compaction,
|
|
126
|
+
trust the ledger and `git log` over your own recollection.
|
|
127
|
+
- `git clean -fdx` will destroy the workspace (it's git-ignored scratch); if
|
|
128
|
+
that happens, recover from `git log`.
|
|
129
|
+
|
|
130
|
+
Read the plan once, note its context and Global Constraints, and create a
|
|
131
|
+
todo per task. If the plan names a Spec, read that too: the spec is the
|
|
132
|
+
authority the plan argues from, and conflicts inside the plan resolve
|
|
133
|
+
against it. A plan with no reachable spec gets a ledger note saying so —
|
|
134
|
+
rulings made without one are provisional.
|
|
135
|
+
|
|
136
|
+
Before dispatching Task 1, read [references/preflight.md](references/preflight.md)
|
|
137
|
+
and run the conflict scan it describes. Its table and rulings go in the
|
|
138
|
+
ledger.
|
|
139
|
+
|
|
140
|
+
## Model Selection
|
|
141
|
+
|
|
142
|
+
Use the least powerful model that can handle each role to conserve cost and increase speed.
|
|
143
|
+
|
|
144
|
+
**Mechanical implementation tasks** (isolated functions, clear specs, 1-2 files): use a fast, cheap model. Most implementation tasks are mechanical when the plan is well-specified.
|
|
145
|
+
|
|
146
|
+
**Integration and judgment tasks** (multi-file coordination, pattern matching, debugging): use a standard model.
|
|
147
|
+
|
|
148
|
+
**Architecture and design tasks**: use the most capable available model.
|
|
149
|
+
The final whole-branch review is one of these — dispatch it on the most
|
|
150
|
+
capable available model, not the session default.
|
|
151
|
+
|
|
152
|
+
**Review tasks**: choose the model with the same judgment, scaled to the
|
|
153
|
+
diff's size, complexity, and risk. A small mechanical diff does not need the
|
|
154
|
+
most capable model; a subtle concurrency change does. Scoped re-reviews of
|
|
155
|
+
small fix diffs take a cheap-to-mid tier.
|
|
156
|
+
|
|
157
|
+
**Fix-loop escalation (rounds 4-5)**: use a model at least one tier above
|
|
158
|
+
the implementer that got stuck.
|
|
159
|
+
|
|
160
|
+
**Always specify the model explicitly when dispatching a subagent.** An
|
|
161
|
+
omitted model inherits your session's model — often the most capable and
|
|
162
|
+
most expensive — which silently defeats this section.
|
|
163
|
+
|
|
164
|
+
**Turn count beats token price.** Wall-clock and context cost scale with how
|
|
165
|
+
many turns a subagent takes, and the cheapest models routinely take 2-3× the
|
|
166
|
+
turns on multi-step work — costing more overall. Use a mid-tier model as the
|
|
167
|
+
floor for reviewers and for implementers working from prose descriptions.
|
|
168
|
+
When the task's plan text contains the complete code to write, the
|
|
169
|
+
implementation is transcription plus testing: use the cheapest tier for
|
|
170
|
+
that implementer. Single-file mechanical fixes also take the cheapest tier.
|
|
171
|
+
|
|
172
|
+
**Task complexity signals (implementation tasks):**
|
|
173
|
+
- Touches 1-2 files with a complete spec → cheap model
|
|
174
|
+
- Touches multiple files with integration concerns → standard model
|
|
175
|
+
- Requires design judgment or broad codebase understanding → most capable model
|
|
176
|
+
|
|
177
|
+
## The Task Loop
|
|
178
|
+
|
|
179
|
+
**Small same-shape work:** when the plan lists several small edits of the
|
|
180
|
+
same kind across files, read [references/batching.md](references/batching.md)
|
|
181
|
+
before dispatching them.
|
|
182
|
+
|
|
183
|
+
Everything you paste into a dispatch prompt — and everything a subagent
|
|
184
|
+
prints back — stays resident in your context for the rest of the session
|
|
185
|
+
and is re-read on every later turn. Hand artifacts over as files.
|
|
186
|
+
|
|
187
|
+
**Waiting on dispatched subagents:** never poll a wait interface with
|
|
188
|
+
short timeouts, and never sit in one silent, open-ended wait either.
|
|
189
|
+
While you have local work — ledger updates, packaging the next review,
|
|
190
|
+
reading reports — keep working; child results arrive on their own.
|
|
191
|
+
When you are genuinely idle, wait in bounded stretches (five to ten
|
|
192
|
+
minutes, where your platform allows), and between stretches post one
|
|
193
|
+
line of status and reconcile your live children: list them, and chase
|
|
194
|
+
any that finished without reporting. A bounded stretch keeps nearly
|
|
195
|
+
all of a long wait's efficiency while guaranteeing a stuck or lost
|
|
196
|
+
child is noticed within minutes, not at the end of the session.
|
|
197
|
+
|
|
198
|
+
### 1. Dispatch the implementer
|
|
199
|
+
|
|
200
|
+
Record BASE (`git rev-parse HEAD`) before dispatching — the review package
|
|
201
|
+
and fix-round diffs need it.
|
|
202
|
+
|
|
203
|
+
- **Task brief:** before dispatching an implementer, run this skill's
|
|
204
|
+
`bash scripts/task-brief PLAN_FILE N` by its absolute path, from the
|
|
205
|
+
working tree you're executing in — it extracts the task's full text to a
|
|
206
|
+
uniquely named file and prints the path. Compose the dispatch so the
|
|
207
|
+
brief stays the single source of
|
|
208
|
+
requirements. Your dispatch should contain: (1) one line on where this
|
|
209
|
+
task fits in the project; (2) the brief path, introduced as "read this
|
|
210
|
+
first — it is your requirements, with the exact values to use verbatim";
|
|
211
|
+
(3) interfaces and decisions from earlier tasks that the brief cannot
|
|
212
|
+
know; (4) your resolution of any ambiguity you noticed in the brief;
|
|
213
|
+
(5) the report-file path and report contract. Exact values (numbers,
|
|
214
|
+
magic strings, signatures, test cases) appear only in the brief. Never
|
|
215
|
+
make a subagent read the whole plan file.
|
|
216
|
+
- **Report file:** name the implementer's report file after the brief
|
|
217
|
+
(brief `…/task-N-brief.md` → report `…/task-N-report.md`) and put it in
|
|
218
|
+
the dispatch prompt. The implementer writes the full report there and
|
|
219
|
+
returns only status, commits, a one-line test summary, and concerns.
|
|
220
|
+
- A dispatch prompt describes one task, not the session's history. Do not
|
|
221
|
+
paste accumulated prior-task summaries ("state after Tasks 1-3") into
|
|
222
|
+
later dispatches — a real session's dispatch hit 42k chars of which 99%
|
|
223
|
+
was pasted history. A fresh subagent needs its task, the interfaces it
|
|
224
|
+
touches, and the global constraints. Nothing else.
|
|
225
|
+
- The dispatch carries the no-subagents contract (it is in the
|
|
226
|
+
implementer template): the implementer never dispatches subagents —
|
|
227
|
+
not helpers, and never a reviewer. Review arrives from you, after the
|
|
228
|
+
report. In real sessions, every reviewer a worker spawned duplicated
|
|
229
|
+
the task review the controller dispatched anyway — a full extra
|
|
230
|
+
review seat per task.
|
|
231
|
+
- If an earlier task parked a finding in the area this task touches, carry
|
|
232
|
+
a pointer to that ledger entry in the dispatch.
|
|
233
|
+
- Record the implementer's agent identity from the dispatch result —
|
|
234
|
+
fix-loop rounds 1-3 resume this agent.
|
|
235
|
+
- Never dispatch multiple implementation subagents in parallel (conflicts).
|
|
236
|
+
|
|
237
|
+
Template: [implementer-prompt.md](implementer-prompt.md)
|
|
238
|
+
|
|
239
|
+
### 2. Handle the report
|
|
240
|
+
|
|
241
|
+
Implementer subagents report one of four statuses. Handle each appropriately:
|
|
242
|
+
|
|
243
|
+
**DONE:** Generate the review package (`bash scripts/review-package PLAN_FILE BASE HEAD` by its absolute path, from the working tree you're executing in — it prints the unique file path it wrote; BASE is the commit you recorded before dispatching the implementer — never `HEAD~1`, which silently drops all but the last commit of a multi-commit task), then dispatch the task reviewer with the printed path.
|
|
244
|
+
|
|
245
|
+
**Any other status** (DONE_WITH_CONCERNS, NEEDS_CONTEXT, BLOCKED): read
|
|
246
|
+
[references/handling-reports.md](references/handling-reports.md) and follow
|
|
247
|
+
it, every time you get one.
|
|
248
|
+
|
|
249
|
+
If the implementer asks questions — before starting or mid-task — answer
|
|
250
|
+
clearly and completely, provide additional context if needed, and don't
|
|
251
|
+
rush it into implementation.
|
|
252
|
+
|
|
253
|
+
### 3. Review the task
|
|
254
|
+
|
|
255
|
+
Per-task reviews are task-scoped gates. The broad review happens once, at the
|
|
256
|
+
final whole-branch review. Never skip the task review, and never accept a
|
|
257
|
+
report missing either verdict — spec compliance AND task quality are both
|
|
258
|
+
required. Implementer self-review never replaces the task review; both are
|
|
259
|
+
needed.
|
|
260
|
+
|
|
261
|
+
- Hand the reviewer its diff as a file: run this skill's
|
|
262
|
+
`bash scripts/review-package PLAN_FILE BASE HEAD` by its absolute path, from
|
|
263
|
+
the working tree you're executing in, and pass the reviewer the file path
|
|
264
|
+
it prints (or, without bash: `git log --oneline`, `git diff --stat`,
|
|
265
|
+
and `git diff -U10` for the range, redirected to one uniquely named
|
|
266
|
+
file). The output never enters your own context, and the reviewer sees
|
|
267
|
+
the commit list, stat summary, and full diff with context in one Read
|
|
268
|
+
call. Use the BASE you recorded before dispatching the implementer —
|
|
269
|
+
never `HEAD~1`, which silently truncates multi-commit tasks. Never
|
|
270
|
+
dispatch a task reviewer without a diff file.
|
|
271
|
+
- **Reviewer inputs:** the task reviewer gets three paths — the same brief
|
|
272
|
+
file, the report file, and the review package — plus the global
|
|
273
|
+
constraints that bind the task.
|
|
274
|
+
- The global-constraints block you hand the reviewer is its attention
|
|
275
|
+
lens. Copy the binding requirements verbatim from the plan's Global
|
|
276
|
+
Constraints section or the spec: exact values, exact formats, and the
|
|
277
|
+
stated relationships between components ("same layout as X", "matches
|
|
278
|
+
Y"). The reviewer's template already carries the process rules (YAGNI,
|
|
279
|
+
test hygiene, review method) — the constraints block is for what THIS
|
|
280
|
+
project's spec demands.
|
|
281
|
+
- Do not add open-ended directives like "check all uses" or "run race tests
|
|
282
|
+
if useful" without a concrete, task-specific reason
|
|
283
|
+
- Do not ask a reviewer to re-run tests the implementer already ran on the
|
|
284
|
+
same code — the implementer's report carries the test evidence
|
|
285
|
+
- Do not pre-judge findings for the reviewer — never instruct a reviewer to
|
|
286
|
+
ignore or not flag a specific issue. If you believe a finding would be a
|
|
287
|
+
false positive, let the reviewer raise it and adjudicate it in the review
|
|
288
|
+
loop. If the prompt you are writing contains "do not flag," "don't treat X
|
|
289
|
+
as a defect," "at most Minor," or "the plan chose" — stop: you are
|
|
290
|
+
pre-judging, usually to spare yourself a review loop.
|
|
291
|
+
If the reviewer reports "⚠️ Cannot verify from diff" items, read
|
|
292
|
+
[references/cannot-verify.md](references/cannot-verify.md) before you mark
|
|
293
|
+
the task complete.
|
|
294
|
+
|
|
295
|
+
Template: [task-reviewer-prompt.md](task-reviewer-prompt.md)
|
|
296
|
+
|
|
297
|
+
### 4. The fix loop
|
|
298
|
+
|
|
299
|
+
The loop triggers when the review reports spec ❌, any Critical or Important
|
|
300
|
+
finding, or a ⚠️ item you confirmed as a real gap.
|
|
301
|
+
|
|
302
|
+
When it triggers, read [references/fix-loop.md](references/fix-loop.md) and
|
|
303
|
+
follow it. Read it again before every round, even if you read it earlier in
|
|
304
|
+
this session: it holds the round cap, the breaker, and the ledger line each
|
|
305
|
+
round writes, and your memory of it does not survive compaction.
|
|
306
|
+
|
|
307
|
+
### 5. Complete the task
|
|
308
|
+
|
|
309
|
+
When the review comes back clean — or every open finding is parked with a
|
|
310
|
+
ruling at the cap — append the completion line to the ledger in the same
|
|
311
|
+
message as your other bookkeeping:
|
|
312
|
+
|
|
313
|
+
- `Task <N>: complete (commits <base7>..<head7>, review clean)`
|
|
314
|
+
- `Task <N>: complete (commits <base7>..<head7>, <K> parked)` after a
|
|
315
|
+
tripped breaker
|
|
316
|
+
|
|
317
|
+
Then mark the todo complete and move on. Never move to the next task while
|
|
318
|
+
the review has open Critical/Important issues that are neither fixed nor
|
|
319
|
+
parked-with-ruling at the cap.
|
|
320
|
+
|
|
321
|
+
## Final Review
|
|
322
|
+
|
|
323
|
+
When every task is complete, read
|
|
324
|
+
[references/final-review.md](references/final-review.md) and follow it. It
|
|
325
|
+
covers the whole-branch review, its single fix wave, and how you finish.
|
|
326
|
+
|
|
327
|
+
## Common Rationalizations
|
|
328
|
+
|
|
329
|
+
| Excuse | Reality |
|
|
330
|
+
|--------|---------|
|
|
331
|
+
| "Close enough on spec compliance" | Reviewer found spec gaps = not done. Fix or hit the cap and adjudicate — those are the only exits. |
|
|
332
|
+
| "I'll fix it myself, dispatching is overhead" | Controller fixes pollute your context and skip review. Resume the implementer. |
|
|
333
|
+
| "One more round will converge" | Past the cap, rounds don't converge — the failure is structural. Adjudicate and route. |
|
|
334
|
+
| "The reviewer will just find something new anyway" | Scoped re-reviews verify fixes; they cannot wander. New findings on untouched code go to the ledger, not the loop. |
|
|
335
|
+
| "This finding is obviously wrong, I'll drop it" | You adjudicate only at the cap, and every ruling is a ledger entry. Silent discards are forbidden. |
|
|
336
|
+
| "The fix was small, skip the re-review" | Unreviewed fixes are how regressions land. Every round ends with a scoped re-review. |
|
|
337
|
+
| "Reviews slow the loop down" | The loop without reviews is just unverified churn. Reviews are the loop's brakes and steering. |
|
|
338
|
+
| "Ledger bookkeeping is overhead" | The ledger is what survives compaction. Controllers without one have re-dispatched entire completed task sequences. |
|
|
339
|
+
| "The implementer spawned its own reviewer — free extra assurance" | It's a duplicate seat reviewing the same diff; the task review is the gate. A worker-spawned reviewer is a defect to flag, not rigor. |
|
|
@@ -0,0 +1,198 @@
|
|
|
1
|
+
# Code Reviewer Prompt Template
|
|
2
|
+
|
|
3
|
+
Use this template when dispatching a code reviewer subagent.
|
|
4
|
+
|
|
5
|
+
**Purpose:** Review completed work against requirements and code quality standards before it cascades into more work.
|
|
6
|
+
|
|
7
|
+
```
|
|
8
|
+
Subagent (general-purpose):
|
|
9
|
+
description: "Review code changes"
|
|
10
|
+
prompt: |
|
|
11
|
+
You are a Senior Code Reviewer with expertise in software architecture,
|
|
12
|
+
design patterns, and best practices. Your job is to review completed work
|
|
13
|
+
against its plan or requirements and identify issues before they cascade.
|
|
14
|
+
|
|
15
|
+
## What Was Implemented
|
|
16
|
+
|
|
17
|
+
[DESCRIPTION]
|
|
18
|
+
|
|
19
|
+
## Requirements / Plan
|
|
20
|
+
|
|
21
|
+
[PLAN_OR_REQUIREMENTS]
|
|
22
|
+
|
|
23
|
+
## Git Range to Review
|
|
24
|
+
|
|
25
|
+
**Base:** [BASE_SHA]
|
|
26
|
+
**Head:** [HEAD_SHA]
|
|
27
|
+
|
|
28
|
+
```bash
|
|
29
|
+
git diff --stat [BASE_SHA]..[HEAD_SHA]
|
|
30
|
+
git diff [BASE_SHA]..[HEAD_SHA]
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
## The spec is a vision document
|
|
34
|
+
|
|
35
|
+
The spec says what the software must do. It does not enumerate every
|
|
36
|
+
input, environment, or condition the software will meet. For behavior
|
|
37
|
+
the spec is silent on, judge by what a reasonable person using this
|
|
38
|
+
software would expect: a reasonable person's expectation is a
|
|
39
|
+
requirement, and a spec's silence is not permission. Grade such
|
|
40
|
+
findings by their effect on that person, not by whether the spec
|
|
41
|
+
mentions the trigger.
|
|
42
|
+
|
|
43
|
+
## Declined to judge
|
|
44
|
+
|
|
45
|
+
Before your verdict, list every behavior you considered and set aside
|
|
46
|
+
as outside the plan or spec, one line each, with the reason. The
|
|
47
|
+
executor rules on each line; nothing you set aside is dropped
|
|
48
|
+
silently. An empty list means you set nothing aside.
|
|
49
|
+
|
|
50
|
+
## Read-Only Review
|
|
51
|
+
|
|
52
|
+
Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.
|
|
53
|
+
|
|
54
|
+
## You Do Not Dispatch Subagents
|
|
55
|
+
|
|
56
|
+
Do all of this review yourself. Never spawn a subagent to review part
|
|
57
|
+
of the diff, and never spawn another reviewer for a second opinion.
|
|
58
|
+
This process already provides every review seat the work gets; a
|
|
59
|
+
reviewer you spawn duplicates one of them at full cost, and its
|
|
60
|
+
verdict counts for nothing. If the diff feels too large for one
|
|
61
|
+
pass, review it in passes yourself and say so in your report.
|
|
62
|
+
|
|
63
|
+
## What to Check
|
|
64
|
+
|
|
65
|
+
**Plan alignment:**
|
|
66
|
+
- Does the implementation match the plan / requirements?
|
|
67
|
+
- Are deviations justified improvements, or problematic departures?
|
|
68
|
+
- Is all planned functionality present?
|
|
69
|
+
|
|
70
|
+
**Code quality:**
|
|
71
|
+
- Clean separation of concerns?
|
|
72
|
+
- Proper error handling?
|
|
73
|
+
- Type safety where applicable?
|
|
74
|
+
- DRY without premature abstraction?
|
|
75
|
+
- Edge cases handled?
|
|
76
|
+
|
|
77
|
+
**Architecture:**
|
|
78
|
+
- Sound design decisions?
|
|
79
|
+
- Reasonable scalability and performance?
|
|
80
|
+
- Security concerns?
|
|
81
|
+
- Integrates cleanly with surrounding code?
|
|
82
|
+
|
|
83
|
+
**Testing:**
|
|
84
|
+
- Tests verify real behavior, not mocks?
|
|
85
|
+
- Edge cases covered?
|
|
86
|
+
- Integration tests where they matter?
|
|
87
|
+
- All tests passing?
|
|
88
|
+
|
|
89
|
+
**Production readiness:**
|
|
90
|
+
- Migration strategy if schema changed?
|
|
91
|
+
- Backward compatibility considered?
|
|
92
|
+
- Documentation complete?
|
|
93
|
+
- No obvious bugs?
|
|
94
|
+
|
|
95
|
+
## Calibration
|
|
96
|
+
|
|
97
|
+
Categorize issues by actual severity. Not everything is Critical.
|
|
98
|
+
Acknowledge what was done well before listing issues — accurate praise
|
|
99
|
+
helps the implementer trust the rest of the feedback.
|
|
100
|
+
|
|
101
|
+
If you find significant deviations from the plan, flag them specifically
|
|
102
|
+
so the implementer can confirm whether the deviation was intentional.
|
|
103
|
+
If you find issues with the plan itself rather than the implementation,
|
|
104
|
+
say so.
|
|
105
|
+
|
|
106
|
+
## Output Format
|
|
107
|
+
|
|
108
|
+
### Strengths
|
|
109
|
+
[What's well done? Be specific.]
|
|
110
|
+
|
|
111
|
+
### Issues
|
|
112
|
+
|
|
113
|
+
#### Critical (Must Fix)
|
|
114
|
+
[Bugs, security issues, data loss risks, broken functionality]
|
|
115
|
+
|
|
116
|
+
#### Important (Should Fix)
|
|
117
|
+
[Architecture problems, missing features, poor error handling, test gaps]
|
|
118
|
+
|
|
119
|
+
#### Minor (Nice to Have)
|
|
120
|
+
[Code style, optimization opportunities, documentation polish]
|
|
121
|
+
|
|
122
|
+
For each issue:
|
|
123
|
+
- File:line reference
|
|
124
|
+
- What's wrong
|
|
125
|
+
- Why it matters
|
|
126
|
+
- How to fix (if not obvious)
|
|
127
|
+
|
|
128
|
+
### Recommendations
|
|
129
|
+
[Improvements for code quality, architecture, or process]
|
|
130
|
+
|
|
131
|
+
### Assessment
|
|
132
|
+
|
|
133
|
+
**Ready to merge?** [Yes | No | With fixes]
|
|
134
|
+
|
|
135
|
+
**Reasoning:** [1-2 sentence technical assessment]
|
|
136
|
+
|
|
137
|
+
## Critical Rules
|
|
138
|
+
|
|
139
|
+
**DO:**
|
|
140
|
+
- Categorize by actual severity
|
|
141
|
+
- Be specific (file:line, not vague)
|
|
142
|
+
- Explain WHY each issue matters
|
|
143
|
+
- Acknowledge strengths
|
|
144
|
+
- Give a clear verdict
|
|
145
|
+
|
|
146
|
+
**DON'T:**
|
|
147
|
+
- Say "looks good" without checking
|
|
148
|
+
- Mark nitpicks as Critical
|
|
149
|
+
- Give feedback on code you didn't actually read
|
|
150
|
+
- Be vague ("improve error handling")
|
|
151
|
+
- Avoid giving a clear verdict
|
|
152
|
+
```
|
|
153
|
+
|
|
154
|
+
**Placeholders:**
|
|
155
|
+
- `[DESCRIPTION]` — brief summary of what was built
|
|
156
|
+
- `[PLAN_OR_REQUIREMENTS]` — what it should do (plan file path, task text, or requirements)
|
|
157
|
+
- `[BASE_SHA]` — starting commit
|
|
158
|
+
- `[HEAD_SHA]` — ending commit
|
|
159
|
+
|
|
160
|
+
**Reviewer returns:** Strengths, Issues (Critical / Important / Minor), Recommendations, Assessment
|
|
161
|
+
|
|
162
|
+
## Example Output
|
|
163
|
+
|
|
164
|
+
```
|
|
165
|
+
### Strengths
|
|
166
|
+
- Clean database schema with proper migrations (db.ts:15-42)
|
|
167
|
+
- Comprehensive test coverage (18 tests, all edge cases)
|
|
168
|
+
- Good error handling with fallbacks (summarizer.ts:85-92)
|
|
169
|
+
|
|
170
|
+
### Issues
|
|
171
|
+
|
|
172
|
+
#### Important
|
|
173
|
+
1. **Missing help text in CLI wrapper**
|
|
174
|
+
- File: index-conversations:1-31
|
|
175
|
+
- Issue: No --help flag, users won't discover --concurrency
|
|
176
|
+
- Fix: Add --help case with usage examples
|
|
177
|
+
|
|
178
|
+
2. **Date validation missing**
|
|
179
|
+
- File: search.ts:25-27
|
|
180
|
+
- Issue: Invalid dates silently return no results
|
|
181
|
+
- Fix: Validate ISO format, throw error with example
|
|
182
|
+
|
|
183
|
+
#### Minor
|
|
184
|
+
1. **Progress indicators**
|
|
185
|
+
- File: indexer.ts:130
|
|
186
|
+
- Issue: No "X of Y" counter for long operations
|
|
187
|
+
- Impact: Users don't know how long to wait
|
|
188
|
+
|
|
189
|
+
### Recommendations
|
|
190
|
+
- Add progress reporting for user experience
|
|
191
|
+
- Consider config file for excluded projects (portability)
|
|
192
|
+
|
|
193
|
+
### Assessment
|
|
194
|
+
|
|
195
|
+
**Ready to merge: With fixes**
|
|
196
|
+
|
|
197
|
+
**Reasoning:** Core implementation is solid with good architecture and tests. Important issues (help text, date validation) are easily fixed and don't affect core functionality.
|
|
198
|
+
```
|