agemon 0.1.0 → 6.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +732 -28
- package/assets/skills/architecture/agemon-architecture/LICENSE +21 -0
- package/assets/skills/architecture/agemon-architecture/NOTICE.md +9 -0
- package/assets/skills/architecture/agemon-architecture/SKILL.md +275 -0
- package/assets/skills/code-quality/agemon-clean-code/LICENSE +21 -0
- package/assets/skills/code-quality/agemon-clean-code/NOTICE.md +9 -0
- package/assets/skills/code-quality/agemon-clean-code/SKILL.md +78 -0
- package/assets/skills/code-quality/agemon-house-rules/SKILL.md +103 -0
- package/assets/skills/commit/agemon-commit/SKILL.md +87 -0
- package/assets/skills/design/agemon-design/LICENSE +21 -0
- package/assets/skills/design/agemon-design/NOTICE.md +9 -0
- package/assets/skills/design/agemon-design/SKILL.md +391 -0
- package/assets/skills/design/agemon-design/references/accessibility.md +182 -0
- package/assets/skills/design/agemon-design/references/agents.md +63 -0
- package/assets/skills/design/agemon-design/references/ai-chat.md +158 -0
- package/assets/skills/design/agemon-design/references/brief.md +186 -0
- package/assets/skills/design/agemon-design/references/color.md +216 -0
- package/assets/skills/design/agemon-design/references/components.md +91 -0
- package/assets/skills/design/agemon-design/references/copy.md +300 -0
- package/assets/skills/design/agemon-design/references/craft-intent.md +160 -0
- package/assets/skills/design/agemon-design/references/dashboard.md +131 -0
- package/assets/skills/design/agemon-design/references/dataviz.md +197 -0
- package/assets/skills/design/agemon-design/references/finish-bar.md +243 -0
- package/assets/skills/design/agemon-design/references/forms.md +192 -0
- package/assets/skills/design/agemon-design/references/heuristics.md +403 -0
- package/assets/skills/design/agemon-design/references/inspiration.md +287 -0
- package/assets/skills/design/agemon-design/references/layout.md +236 -0
- package/assets/skills/design/agemon-design/references/loops.md +155 -0
- package/assets/skills/design/agemon-design/references/metadata.md +98 -0
- package/assets/skills/design/agemon-design/references/modern-css.md +448 -0
- package/assets/skills/design/agemon-design/references/motion.md +434 -0
- package/assets/skills/design/agemon-design/references/personas.md +206 -0
- package/assets/skills/design/agemon-design/references/principles-catalog.md +299 -0
- package/assets/skills/design/agemon-design/references/recipe-auth.md +88 -0
- package/assets/skills/design/agemon-design/references/recipe-dashboard.md +130 -0
- package/assets/skills/design/agemon-design/references/recipe-landing.md +122 -0
- package/assets/skills/design/agemon-design/references/responsive.md +168 -0
- package/assets/skills/design/agemon-design/references/review.md +340 -0
- package/assets/skills/design/agemon-design/references/sound.md +150 -0
- package/assets/skills/design/agemon-design/references/spec.md +123 -0
- package/assets/skills/design/agemon-design/references/stack.md +522 -0
- package/assets/skills/design/agemon-design/references/state-design.md +188 -0
- package/assets/skills/design/agemon-design/references/themes.md +229 -0
- package/assets/skills/design/agemon-design/references/tokens.md +350 -0
- package/assets/skills/design/agemon-design/references/typography.md +246 -0
- package/assets/skills/design/agemon-design-dashboard/LICENSE +21 -0
- package/assets/skills/design/agemon-design-dashboard/NOTICE.md +9 -0
- package/assets/skills/design/agemon-design-dashboard/SKILL.md +113 -0
- package/assets/skills/design/agemon-design-editorial/LICENSE +21 -0
- package/assets/skills/design/agemon-design-editorial/NOTICE.md +9 -0
- package/assets/skills/design/agemon-design-editorial/SKILL.md +98 -0
- package/assets/skills/design/agemon-design-minimal/LICENSE +21 -0
- package/assets/skills/design/agemon-design-minimal/NOTICE.md +9 -0
- package/assets/skills/design/agemon-design-minimal/SKILL.md +97 -0
- package/assets/skills/geo-seo/geo/LICENSE +21 -0
- package/assets/skills/geo-seo/geo/NOTICE.md +18 -0
- package/assets/skills/geo-seo/geo/SKILL.md +145 -0
- package/assets/skills/geo-seo/geo-audit/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-audit/NOTICE.md +17 -0
- package/assets/skills/geo-seo/geo-audit/SKILL.md +371 -0
- package/assets/skills/geo-seo/geo-audit/references/ai-visibility.md +233 -0
- package/assets/skills/geo-seo/geo-audit/references/content.md +329 -0
- package/assets/skills/geo-seo/geo-audit/references/platform-analysis.md +294 -0
- package/assets/skills/geo-seo/geo-audit/references/schema.md +383 -0
- package/assets/skills/geo-seo/geo-audit/references/technical.md +368 -0
- package/assets/skills/geo-seo/geo-brand-mentions/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-brand-mentions/NOTICE.md +15 -0
- package/assets/skills/geo-seo/geo-brand-mentions/SKILL.md +459 -0
- package/assets/skills/geo-seo/geo-citability/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-citability/NOTICE.md +14 -0
- package/assets/skills/geo-seo/geo-citability/SKILL.md +320 -0
- package/assets/skills/geo-seo/geo-content/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-content/NOTICE.md +14 -0
- package/assets/skills/geo-seo/geo-content/SKILL.md +352 -0
- package/assets/skills/geo-seo/geo-crawlers/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-crawlers/NOTICE.md +15 -0
- package/assets/skills/geo-seo/geo-crawlers/SKILL.md +388 -0
- package/assets/skills/geo-seo/geo-llmstxt/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-llmstxt/NOTICE.md +14 -0
- package/assets/skills/geo-seo/geo-llmstxt/SKILL.md +433 -0
- package/assets/skills/geo-seo/geo-platform-optimizer/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-platform-optimizer/NOTICE.md +14 -0
- package/assets/skills/geo-seo/geo-platform-optimizer/SKILL.md +282 -0
- package/assets/skills/geo-seo/geo-report/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-report/NOTICE.md +14 -0
- package/assets/skills/geo-seo/geo-report/SKILL.md +406 -0
- package/assets/skills/geo-seo/geo-report-pdf/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-report-pdf/NOTICE.md +20 -0
- package/assets/skills/geo-seo/geo-report-pdf/SKILL.md +153 -0
- package/assets/skills/geo-seo/geo-report-pdf/templates/geo-report-template.html +548 -0
- package/assets/skills/geo-seo/geo-schema/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-schema/NOTICE.md +16 -0
- package/assets/skills/geo-seo/geo-schema/SKILL.md +396 -0
- package/assets/skills/geo-seo/geo-technical/LICENSE +21 -0
- package/assets/skills/geo-seo/geo-technical/NOTICE.md +15 -0
- package/assets/skills/geo-seo/geo-technical/SKILL.md +566 -0
- package/assets/skills/performance/agemon-performance/NOTICE.md +1 -0
- package/assets/skills/performance/agemon-performance/SKILL.md +76 -0
- package/assets/skills/security/agemon-security/LICENSE +21 -0
- package/assets/skills/security/agemon-security/NOTICE.md +8 -0
- package/assets/skills/security/agemon-security/SKILL.md +356 -0
- package/assets/skills/self-review/agemon-review-intake/LICENSE +21 -0
- package/assets/skills/self-review/agemon-review-intake/NOTICE.md +9 -0
- package/assets/skills/self-review/agemon-review-intake/SKILL.md +205 -0
- package/assets/skills/self-review/agemon-review-request/LICENSE +21 -0
- package/assets/skills/self-review/agemon-review-request/NOTICE.md +9 -0
- package/assets/skills/self-review/agemon-review-request/SKILL.md +104 -0
- package/assets/skills/self-review/agemon-review-request/code-reviewer.md +188 -0
- package/assets/skills/self-review/agemon-root-cause/LICENSE +21 -0
- package/assets/skills/self-review/agemon-root-cause/NOTICE.md +10 -0
- package/assets/skills/self-review/agemon-root-cause/SKILL.md +283 -0
- package/assets/skills/self-review/agemon-root-cause/condition-based-waiting-example.ts +158 -0
- package/assets/skills/self-review/agemon-root-cause/condition-based-waiting.md +115 -0
- package/assets/skills/self-review/agemon-root-cause/defense-in-depth.md +122 -0
- package/assets/skills/self-review/agemon-root-cause/find-polluter.sh +72 -0
- package/assets/skills/self-review/agemon-root-cause/root-cause-tracing.md +169 -0
- package/assets/skills/self-review/agemon-root-cause/test-academic.md +14 -0
- package/assets/skills/self-review/agemon-root-cause/test-pressure-1.md +58 -0
- package/assets/skills/self-review/agemon-root-cause/test-pressure-2.md +68 -0
- package/assets/skills/self-review/agemon-root-cause/test-pressure-3.md +69 -0
- package/assets/skills/self-review/agemon-verify-before-done/LICENSE +21 -0
- package/assets/skills/self-review/agemon-verify-before-done/NOTICE.md +9 -0
- package/assets/skills/self-review/agemon-verify-before-done/SKILL.md +120 -0
- package/assets/skills/team-lead/agemon-plan-rfc/SKILL.md +317 -0
- package/assets/skills/team-lead/prd-generator/SKILL.md +437 -0
- package/assets/skills/team-lead/skill-headofit-audit/SKILL.md +72 -0
- package/assets/skills/team-lead/skill-incident-rca/SKILL.md +66 -0
- package/assets/skills/team-lead/skill-meeting-lifecycle/SKILL.md +63 -0
- package/assets/skills/team-lead/skill-obsidian-vault-sync/SKILL.md +69 -0
- package/assets/skills/team-lead/skill-prd-decomposer/SKILL.md +71 -0
- package/assets/skills/team-lead/skill-sec-check/SKILL.md +70 -0
- package/assets/skills/team-lead/skill-task-extractor/SKILL.md +79 -0
- package/assets/skills/team-lead/skill-tech-spike/SKILL.md +57 -0
- package/assets/skills/team-lead/skill-techlead-reviewer/SKILL.md +81 -0
- package/assets/tools/code-review-graph-constraints.txt +1418 -0
- package/assets/tools/package-lock.json +111 -0
- package/assets/tools/package.json +6 -0
- package/dist/chunk-5LATHJYU.js +4026 -0
- package/dist/chunk-5LATHJYU.js.map +1 -0
- package/dist/fake-subprocess-2BETWZVZ.js +666 -0
- package/dist/fake-subprocess-2BETWZVZ.js.map +1 -0
- package/dist/index.js +21101 -1956
- package/dist/index.js.map +1 -1
- package/package.json +30 -17
|
@@ -0,0 +1,104 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agemon-review-request
|
|
3
|
+
description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Requesting Code Review
|
|
7
|
+
|
|
8
|
+
Dispatch a code reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history.
|
|
9
|
+
|
|
10
|
+
**Core principle:** Review early, review often.
|
|
11
|
+
|
|
12
|
+
## When to Request Review
|
|
13
|
+
|
|
14
|
+
**Mandatory:**
|
|
15
|
+
- After each task in subagent-driven development
|
|
16
|
+
- After completing major feature
|
|
17
|
+
- Before merge to main
|
|
18
|
+
|
|
19
|
+
**Optional but valuable:**
|
|
20
|
+
- When stuck (fresh perspective)
|
|
21
|
+
- Before refactoring (baseline check)
|
|
22
|
+
- After fixing complex bug
|
|
23
|
+
|
|
24
|
+
## How to Request
|
|
25
|
+
|
|
26
|
+
**1. Get git SHAs:**
|
|
27
|
+
```bash
|
|
28
|
+
BASE_SHA=$(git rev-parse HEAD~1) # or origin/main
|
|
29
|
+
HEAD_SHA=$(git rev-parse HEAD)
|
|
30
|
+
```
|
|
31
|
+
|
|
32
|
+
**2. Dispatch code reviewer subagent:**
|
|
33
|
+
|
|
34
|
+
Dispatch a `general-purpose` subagent, filling the template at [code-reviewer.md](code-reviewer.md)
|
|
35
|
+
|
|
36
|
+
**Placeholders:**
|
|
37
|
+
- `{DESCRIPTION}` - Brief summary of what you built
|
|
38
|
+
- `{PLAN_OR_REQUIREMENTS}` - What it should do
|
|
39
|
+
- `{BASE_SHA}` - Starting commit
|
|
40
|
+
- `{HEAD_SHA}` - Ending commit
|
|
41
|
+
|
|
42
|
+
**3. Act on feedback:**
|
|
43
|
+
- Fix Critical issues immediately
|
|
44
|
+
- Fix Important issues before proceeding
|
|
45
|
+
- Fix Important readability issues by simplifying or splitting the code; do not mask them with explanatory comments.
|
|
46
|
+
- Note Minor issues for later
|
|
47
|
+
- Push back if reviewer is wrong (with reasoning)
|
|
48
|
+
|
|
49
|
+
## Mandatory Readability Gate
|
|
50
|
+
|
|
51
|
+
Every review must explicitly assess whether the changed code is self-documenting. The reviewer must confirm that names, function boundaries, and control flow make the code understandable without ordinary explanatory comments.
|
|
52
|
+
|
|
53
|
+
Treat code that needs comments to explain routine logic, variable meaning, or control flow as an **Important** issue. The required fix is to rewrite or split the code until the comment is unnecessary. Comments remain appropriate only for non-obvious context that cannot be expressed in code, such as compatibility constraints or external contracts.
|
|
54
|
+
|
|
55
|
+
Do not mark work ready to merge while an Important readability issue remains unresolved.
|
|
56
|
+
|
|
57
|
+
## Example
|
|
58
|
+
|
|
59
|
+
```
|
|
60
|
+
[Just completed Task 2: Add verification function]
|
|
61
|
+
|
|
62
|
+
You: Let me request code review before proceeding.
|
|
63
|
+
|
|
64
|
+
BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
|
|
65
|
+
HEAD_SHA=$(git rev-parse HEAD)
|
|
66
|
+
|
|
67
|
+
[Dispatch code reviewer subagent]
|
|
68
|
+
DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
|
|
69
|
+
PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
|
|
70
|
+
BASE_SHA: a7981ec
|
|
71
|
+
HEAD_SHA: 3df7661
|
|
72
|
+
|
|
73
|
+
[Subagent returns]:
|
|
74
|
+
Strengths: Clean architecture, real tests
|
|
75
|
+
Issues:
|
|
76
|
+
Important: Missing progress indicators
|
|
77
|
+
Minor: Magic number (100) for reporting interval
|
|
78
|
+
Assessment: Ready to proceed
|
|
79
|
+
|
|
80
|
+
You: [Fix progress indicators]
|
|
81
|
+
[Continue to Task 3]
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
## Common Rationalizations
|
|
85
|
+
|
|
86
|
+
| Excuse | Reality |
|
|
87
|
+
|--------|---------|
|
|
88
|
+
| "I'll just review the diff myself instead of dispatching a reviewer" | You're the coordinator — reviewing the diff inline burns the context window you need to keep driving the work. Dispatch a reviewer subagent: the diff and the evaluation live in its context, and only the findings come back to you. |
|
|
89
|
+
| "The reviewer needs my whole session history to understand the change" | Hand it precisely crafted context, never your session's history. That keeps the reviewer on the work product, not your thought process. |
|
|
90
|
+
|
|
91
|
+
## Red Flags
|
|
92
|
+
|
|
93
|
+
**Never:**
|
|
94
|
+
- Skip review because "it's simple"
|
|
95
|
+
- Ignore Critical issues
|
|
96
|
+
- Proceed with unfixed Important issues
|
|
97
|
+
- Argue with valid technical feedback
|
|
98
|
+
|
|
99
|
+
**If reviewer wrong:**
|
|
100
|
+
- Push back with technical reasoning
|
|
101
|
+
- Show code/tests that prove it works
|
|
102
|
+
- Request clarification
|
|
103
|
+
|
|
104
|
+
See template at: [code-reviewer.md](code-reviewer.md)
|
|
@@ -0,0 +1,188 @@
|
|
|
1
|
+
# Code Reviewer Prompt Template
|
|
2
|
+
|
|
3
|
+
Use this template when dispatching a code reviewer subagent.
|
|
4
|
+
|
|
5
|
+
**Purpose:** Review completed work against requirements and code quality standards before it cascades into more work.
|
|
6
|
+
|
|
7
|
+
```
|
|
8
|
+
Subagent (general-purpose):
|
|
9
|
+
description: "Review code changes"
|
|
10
|
+
prompt: |
|
|
11
|
+
You are a Senior Code Reviewer with expertise in software architecture,
|
|
12
|
+
design patterns, and best practices. Your job is to review completed work
|
|
13
|
+
against its plan or requirements and identify issues before they cascade.
|
|
14
|
+
|
|
15
|
+
## What Was Implemented
|
|
16
|
+
|
|
17
|
+
[DESCRIPTION]
|
|
18
|
+
|
|
19
|
+
## Requirements / Plan
|
|
20
|
+
|
|
21
|
+
[PLAN_OR_REQUIREMENTS]
|
|
22
|
+
|
|
23
|
+
## Git Range to Review
|
|
24
|
+
|
|
25
|
+
**Base:** [BASE_SHA]
|
|
26
|
+
**Head:** [HEAD_SHA]
|
|
27
|
+
|
|
28
|
+
```bash
|
|
29
|
+
git diff --stat [BASE_SHA]..[HEAD_SHA]
|
|
30
|
+
git diff [BASE_SHA]..[HEAD_SHA]
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
## Read-Only Review
|
|
34
|
+
|
|
35
|
+
Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.
|
|
36
|
+
|
|
37
|
+
## You Do Not Dispatch Subagents
|
|
38
|
+
|
|
39
|
+
Do all of this review yourself. Never spawn a subagent to review part
|
|
40
|
+
of the diff, and never spawn another reviewer for a second opinion.
|
|
41
|
+
This process already provides every review seat the work gets; a
|
|
42
|
+
reviewer you spawn duplicates one of them at full cost, and its
|
|
43
|
+
verdict counts for nothing. If the diff feels too large for one
|
|
44
|
+
pass, review it in passes yourself and say so in your report.
|
|
45
|
+
|
|
46
|
+
## What to Check
|
|
47
|
+
|
|
48
|
+
**Plan alignment:**
|
|
49
|
+
- Does the implementation match the plan / requirements?
|
|
50
|
+
- Are deviations justified improvements, or problematic departures?
|
|
51
|
+
- Is all planned functionality present?
|
|
52
|
+
|
|
53
|
+
**Code quality:**
|
|
54
|
+
- Clean separation of concerns?
|
|
55
|
+
- Proper error handling?
|
|
56
|
+
- Type safety where applicable?
|
|
57
|
+
- DRY without premature abstraction?
|
|
58
|
+
- Edge cases handled?
|
|
59
|
+
|
|
60
|
+
**Readability and self-documenting code (mandatory):**
|
|
61
|
+
- Can a maintainer understand the changed code from its names, function boundaries, and control flow without ordinary explanatory comments?
|
|
62
|
+
- Are functions focused enough that distinct responsibilities are split into readable units?
|
|
63
|
+
- Are comments limited to non-obvious context that cannot be expressed in code, such as compatibility constraints or external contracts?
|
|
64
|
+
- Flag comments that explain routine logic, variable meaning, or control flow as an **Important** issue. Require the implementation to be simplified or split instead of retaining explanatory comments.
|
|
65
|
+
|
|
66
|
+
**Architecture:**
|
|
67
|
+
- Sound design decisions?
|
|
68
|
+
- Reasonable scalability and performance?
|
|
69
|
+
- Security concerns?
|
|
70
|
+
- Integrates cleanly with surrounding code?
|
|
71
|
+
|
|
72
|
+
**Testing:**
|
|
73
|
+
- Tests verify real behavior, not mocks?
|
|
74
|
+
- Edge cases covered?
|
|
75
|
+
- Integration tests where they matter?
|
|
76
|
+
- All tests passing?
|
|
77
|
+
|
|
78
|
+
**Production readiness:**
|
|
79
|
+
- Migration strategy if schema changed?
|
|
80
|
+
- Backward compatibility considered?
|
|
81
|
+
- Documentation complete?
|
|
82
|
+
- No obvious bugs?
|
|
83
|
+
|
|
84
|
+
## Calibration
|
|
85
|
+
|
|
86
|
+
Categorize issues by actual severity. Not everything is Critical.
|
|
87
|
+
Acknowledge what was done well before listing issues — accurate praise
|
|
88
|
+
helps the implementer trust the rest of the feedback.
|
|
89
|
+
|
|
90
|
+
If you find significant deviations from the plan, flag them specifically
|
|
91
|
+
so the implementer can confirm whether the deviation was intentional.
|
|
92
|
+
If you find issues with the plan itself rather than the implementation,
|
|
93
|
+
say so.
|
|
94
|
+
|
|
95
|
+
## Output Format
|
|
96
|
+
|
|
97
|
+
### Strengths
|
|
98
|
+
[What's well done? Be specific.]
|
|
99
|
+
|
|
100
|
+
### Issues
|
|
101
|
+
|
|
102
|
+
#### Critical (Must Fix)
|
|
103
|
+
[Bugs, security issues, data loss risks, broken functionality]
|
|
104
|
+
|
|
105
|
+
#### Important (Should Fix)
|
|
106
|
+
[Architecture problems, missing features, poor error handling, test gaps]
|
|
107
|
+
|
|
108
|
+
#### Minor (Nice to Have)
|
|
109
|
+
[Code style, optimization opportunities, documentation polish]
|
|
110
|
+
|
|
111
|
+
For each issue:
|
|
112
|
+
- File:line reference
|
|
113
|
+
- What's wrong
|
|
114
|
+
- Why it matters
|
|
115
|
+
- How to fix (if not obvious)
|
|
116
|
+
|
|
117
|
+
### Recommendations
|
|
118
|
+
[Improvements for code quality, architecture, or process]
|
|
119
|
+
|
|
120
|
+
### Assessment
|
|
121
|
+
|
|
122
|
+
**Ready to merge?** [Yes | No | With fixes]
|
|
123
|
+
|
|
124
|
+
**Reasoning:** [1-2 sentence technical assessment]
|
|
125
|
+
|
|
126
|
+
## Critical Rules
|
|
127
|
+
|
|
128
|
+
**DO:**
|
|
129
|
+
- Categorize by actual severity
|
|
130
|
+
- Be specific (file:line, not vague)
|
|
131
|
+
- Explain WHY each issue matters
|
|
132
|
+
- Acknowledge strengths
|
|
133
|
+
- Give a clear verdict
|
|
134
|
+
|
|
135
|
+
**DON'T:**
|
|
136
|
+
- Say "looks good" without checking
|
|
137
|
+
- Mark nitpicks as Critical
|
|
138
|
+
- Give feedback on code you didn't actually read
|
|
139
|
+
- Be vague ("improve error handling")
|
|
140
|
+
- Avoid giving a clear verdict
|
|
141
|
+
- Approve work with unresolved Important readability or self-documenting-code issues
|
|
142
|
+
```
|
|
143
|
+
|
|
144
|
+
**Placeholders:**
|
|
145
|
+
- `[DESCRIPTION]` — brief summary of what was built
|
|
146
|
+
- `[PLAN_OR_REQUIREMENTS]` — what it should do (plan file path, task text, or requirements)
|
|
147
|
+
- `[BASE_SHA]` — starting commit
|
|
148
|
+
- `[HEAD_SHA]` — ending commit
|
|
149
|
+
|
|
150
|
+
**Reviewer returns:** Strengths, Issues (Critical / Important / Minor), Recommendations, Assessment
|
|
151
|
+
|
|
152
|
+
## Example Output
|
|
153
|
+
|
|
154
|
+
```
|
|
155
|
+
### Strengths
|
|
156
|
+
- Clean database schema with proper migrations (db.ts:15-42)
|
|
157
|
+
- Comprehensive test coverage (18 tests, all edge cases)
|
|
158
|
+
- Good error handling with fallbacks (summarizer.ts:85-92)
|
|
159
|
+
|
|
160
|
+
### Issues
|
|
161
|
+
|
|
162
|
+
#### Important
|
|
163
|
+
1. **Missing help text in CLI wrapper**
|
|
164
|
+
- File: index-conversations:1-31
|
|
165
|
+
- Issue: No --help flag, users won't discover --concurrency
|
|
166
|
+
- Fix: Add --help case with usage examples
|
|
167
|
+
|
|
168
|
+
2. **Date validation missing**
|
|
169
|
+
- File: search.ts:25-27
|
|
170
|
+
- Issue: Invalid dates silently return no results
|
|
171
|
+
- Fix: Validate ISO format, throw error with example
|
|
172
|
+
|
|
173
|
+
#### Minor
|
|
174
|
+
1. **Progress indicators**
|
|
175
|
+
- File: indexer.ts:130
|
|
176
|
+
- Issue: No "X of Y" counter for long operations
|
|
177
|
+
- Impact: Users don't know how long to wait
|
|
178
|
+
|
|
179
|
+
### Recommendations
|
|
180
|
+
- Add progress reporting for user experience
|
|
181
|
+
- Consider config file for excluded projects (portability)
|
|
182
|
+
|
|
183
|
+
### Assessment
|
|
184
|
+
|
|
185
|
+
**Ready to merge: With fixes**
|
|
186
|
+
|
|
187
|
+
**Reasoning:** Core implementation is solid with good architecture and tests. Important issues (help text, date validation) are easily fixed and don't affect core functionality.
|
|
188
|
+
```
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
MIT License
|
|
2
|
+
|
|
3
|
+
Copyright (c) 2025 Jesse Vincent
|
|
4
|
+
|
|
5
|
+
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
6
|
+
of this software and associated documentation files (the "Software"), to deal
|
|
7
|
+
in the Software without restriction, including without limitation the rights
|
|
8
|
+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
9
|
+
copies of the Software, and to permit persons to whom the Software is
|
|
10
|
+
furnished to do so, subject to the following conditions:
|
|
11
|
+
|
|
12
|
+
The above copyright notice and this permission notice shall be included in all
|
|
13
|
+
copies or substantial portions of the Software.
|
|
14
|
+
|
|
15
|
+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
16
|
+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
17
|
+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
18
|
+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
19
|
+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
20
|
+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
21
|
+
SOFTWARE.
|
|
@@ -0,0 +1,10 @@
|
|
|
1
|
+
# Vendored skill
|
|
2
|
+
|
|
3
|
+
- Source: https://github.com/obra/superpowers
|
|
4
|
+
- Path in source: skills/systematic-debugging
|
|
5
|
+
- Commit: b36e0829c6d0140e93cfef2ca599b1b07d4a7797
|
|
6
|
+
- Retrieved: 2026-08-17
|
|
7
|
+
- License: MIT — see `LICENSE` in this directory.
|
|
8
|
+
- One of several skills cherry-picked from the much larger superpowers framework; not a full vendor of that repo.
|
|
9
|
+
- Renamed from `systematic-debugging` to `agemon-root-cause` for agemon branding — installed skills should read as agemon's own, not a third-party project name.
|
|
10
|
+
- Left out upstream's `CREATION-LOG.md`: it records how upstream wrote the skill and is not part of the instructions.
|
|
@@ -0,0 +1,283 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: agemon-root-cause
|
|
3
|
+
description: Use when encountering any bug, test failure, or unexpected behavior, before proposing fixes
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Systematic Debugging
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
**Core principle:** ALWAYS find root cause before attempting fixes. Symptom fixes are failure.
|
|
11
|
+
|
|
12
|
+
**Violating the letter of this process is violating the spirit of debugging.**
|
|
13
|
+
|
|
14
|
+
## The Iron Law
|
|
15
|
+
|
|
16
|
+
```
|
|
17
|
+
NO FIXES WITHOUT ROOT CAUSE INVESTIGATION FIRST
|
|
18
|
+
```
|
|
19
|
+
|
|
20
|
+
If you haven't completed Phase 1, you cannot propose fixes.
|
|
21
|
+
|
|
22
|
+
## When to Use
|
|
23
|
+
|
|
24
|
+
Use for ANY technical issue:
|
|
25
|
+
- Test failures
|
|
26
|
+
- Bugs in production
|
|
27
|
+
- Unexpected behavior
|
|
28
|
+
- Performance problems
|
|
29
|
+
- Build failures
|
|
30
|
+
- Integration issues
|
|
31
|
+
|
|
32
|
+
**Use this ESPECIALLY when:**
|
|
33
|
+
- Under time pressure (emergencies make guessing tempting)
|
|
34
|
+
- "Just one quick fix" seems obvious
|
|
35
|
+
- You've already tried multiple fixes
|
|
36
|
+
- Previous fix didn't work
|
|
37
|
+
- You don't fully understand the issue
|
|
38
|
+
|
|
39
|
+
**Don't skip when:**
|
|
40
|
+
- Issue seems simple (simple bugs have root causes too)
|
|
41
|
+
- You're in a hurry (rushing guarantees rework)
|
|
42
|
+
- Manager wants it fixed NOW (systematic is faster than thrashing)
|
|
43
|
+
|
|
44
|
+
## The Four Phases
|
|
45
|
+
|
|
46
|
+
You MUST complete each phase before proceeding to the next.
|
|
47
|
+
|
|
48
|
+
### Phase 1: Root Cause Investigation
|
|
49
|
+
|
|
50
|
+
**BEFORE attempting ANY fix:**
|
|
51
|
+
|
|
52
|
+
1. **Read Error Messages Carefully**
|
|
53
|
+
- Don't skip past errors or warnings
|
|
54
|
+
- They often contain the exact solution
|
|
55
|
+
- Read stack traces completely
|
|
56
|
+
- Note line numbers, file paths, error codes
|
|
57
|
+
|
|
58
|
+
2. **Reproduce Consistently**
|
|
59
|
+
- Can you trigger it reliably?
|
|
60
|
+
- What are the exact steps?
|
|
61
|
+
- Does it happen every time?
|
|
62
|
+
- If not reproducible → gather more data, don't guess
|
|
63
|
+
|
|
64
|
+
3. **Check Recent Changes**
|
|
65
|
+
- What changed that could cause this?
|
|
66
|
+
- Git diff, recent commits
|
|
67
|
+
- New dependencies, config changes
|
|
68
|
+
- Environmental differences
|
|
69
|
+
|
|
70
|
+
4. **Gather Evidence in Multi-Component Systems**
|
|
71
|
+
|
|
72
|
+
**WHEN system has multiple components (CI → build → signing, API → service → database):**
|
|
73
|
+
|
|
74
|
+
**BEFORE proposing fixes, add diagnostic instrumentation:**
|
|
75
|
+
```
|
|
76
|
+
For EACH component boundary:
|
|
77
|
+
- Log what data enters component
|
|
78
|
+
- Log what data exits component
|
|
79
|
+
- Verify environment/config propagation
|
|
80
|
+
- Check state at each layer
|
|
81
|
+
|
|
82
|
+
Run once to gather evidence showing WHERE it breaks
|
|
83
|
+
THEN analyze evidence to identify failing component
|
|
84
|
+
THEN investigate that specific component
|
|
85
|
+
```
|
|
86
|
+
|
|
87
|
+
**Example (multi-layer system):**
|
|
88
|
+
```bash
|
|
89
|
+
# Layer 1: Workflow
|
|
90
|
+
echo "=== Secrets available in workflow: ==="
|
|
91
|
+
echo "IDENTITY: ${IDENTITY:+SET}${IDENTITY:-UNSET}"
|
|
92
|
+
|
|
93
|
+
# Layer 2: Build script
|
|
94
|
+
echo "=== Env vars in build script: ==="
|
|
95
|
+
env | grep IDENTITY || echo "IDENTITY not in environment"
|
|
96
|
+
|
|
97
|
+
# Layer 3: Signing script
|
|
98
|
+
echo "=== Keychain state: ==="
|
|
99
|
+
security list-keychains
|
|
100
|
+
security find-identity -v
|
|
101
|
+
|
|
102
|
+
# Layer 4: Actual signing
|
|
103
|
+
codesign --sign "$IDENTITY" --verbose=4 "$APP"
|
|
104
|
+
```
|
|
105
|
+
|
|
106
|
+
**This reveals:** Which layer fails (secrets → workflow ✓, workflow → build ✗)
|
|
107
|
+
|
|
108
|
+
5. **Trace Data Flow**
|
|
109
|
+
|
|
110
|
+
**WHEN error is deep in call stack:**
|
|
111
|
+
|
|
112
|
+
See `root-cause-tracing.md` in this directory for the complete backward tracing technique.
|
|
113
|
+
|
|
114
|
+
**Quick version:**
|
|
115
|
+
- Where does bad value originate?
|
|
116
|
+
- What called this with bad value?
|
|
117
|
+
- Keep tracing up until you find the source
|
|
118
|
+
- Fix at source, not at symptom
|
|
119
|
+
|
|
120
|
+
### Phase 2: Pattern Analysis
|
|
121
|
+
|
|
122
|
+
**Find the pattern before fixing:**
|
|
123
|
+
|
|
124
|
+
1. **Find Working Examples**
|
|
125
|
+
- Locate similar working code in same codebase
|
|
126
|
+
- What works that's similar to what's broken?
|
|
127
|
+
|
|
128
|
+
2. **Compare Against References**
|
|
129
|
+
- If implementing pattern, read reference implementation COMPLETELY
|
|
130
|
+
- Don't skim - read every line
|
|
131
|
+
- Understand the pattern fully before applying
|
|
132
|
+
|
|
133
|
+
3. **Identify Differences**
|
|
134
|
+
- What's different between working and broken?
|
|
135
|
+
- List every difference, however small
|
|
136
|
+
- Don't assume "that can't matter"
|
|
137
|
+
|
|
138
|
+
4. **Understand Dependencies**
|
|
139
|
+
- What other components does this need?
|
|
140
|
+
- What settings, config, environment?
|
|
141
|
+
- What assumptions does it make?
|
|
142
|
+
|
|
143
|
+
### Phase 3: Hypothesis and Testing
|
|
144
|
+
|
|
145
|
+
**Scientific method:**
|
|
146
|
+
|
|
147
|
+
1. **Form Single Hypothesis**
|
|
148
|
+
- State clearly: "I think X is the root cause because Y"
|
|
149
|
+
- Write it down
|
|
150
|
+
- Be specific, not vague
|
|
151
|
+
|
|
152
|
+
2. **Test Minimally**
|
|
153
|
+
- Make the SMALLEST possible change to test hypothesis
|
|
154
|
+
- One variable at a time
|
|
155
|
+
- Don't fix multiple things at once
|
|
156
|
+
|
|
157
|
+
3. **Verify Before Continuing**
|
|
158
|
+
- Did it work? Yes → Phase 4
|
|
159
|
+
- Didn't work? Form NEW hypothesis
|
|
160
|
+
- DON'T add more fixes on top
|
|
161
|
+
|
|
162
|
+
4. **When You Don't Know**
|
|
163
|
+
- Say "I don't understand X"
|
|
164
|
+
- Don't pretend to know
|
|
165
|
+
- Ask for help
|
|
166
|
+
- Research more
|
|
167
|
+
|
|
168
|
+
### Phase 4: Implementation
|
|
169
|
+
|
|
170
|
+
**Fix the root cause, not the symptom:**
|
|
171
|
+
|
|
172
|
+
1. **Create Failing Test Case**
|
|
173
|
+
- Simplest possible reproduction
|
|
174
|
+
- Automated test if possible
|
|
175
|
+
- One-off test script if no framework
|
|
176
|
+
- MUST have before fixing
|
|
177
|
+
- Use the `superpowers:test-driven-development` skill for writing proper failing tests
|
|
178
|
+
|
|
179
|
+
2. **Implement Single Fix**
|
|
180
|
+
- Address the root cause identified
|
|
181
|
+
- ONE change at a time
|
|
182
|
+
- No "while I'm here" improvements
|
|
183
|
+
- No bundled refactoring
|
|
184
|
+
|
|
185
|
+
3. **Verify Fix**
|
|
186
|
+
- Test passes now?
|
|
187
|
+
- No other tests broken?
|
|
188
|
+
- Issue actually resolved?
|
|
189
|
+
- Use the `superpowers:verification-before-completion` skill before claiming success
|
|
190
|
+
|
|
191
|
+
4. **If Fix Doesn't Work**
|
|
192
|
+
- STOP
|
|
193
|
+
- Count: How many fixes have you tried?
|
|
194
|
+
- If < 3: Return to Phase 1, re-analyze with new information
|
|
195
|
+
- **If ≥ 3: STOP and question the architecture (step 5 below)**
|
|
196
|
+
- DON'T attempt Fix #4 without architectural discussion
|
|
197
|
+
|
|
198
|
+
5. **If 3+ Fixes Failed: Question Architecture**
|
|
199
|
+
|
|
200
|
+
**Pattern indicating architectural problem:**
|
|
201
|
+
- Each fix reveals new shared state/coupling/problem in different place
|
|
202
|
+
- Fixes require "massive refactoring" to implement
|
|
203
|
+
- Each fix creates new symptoms elsewhere
|
|
204
|
+
|
|
205
|
+
**STOP and question fundamentals:**
|
|
206
|
+
- Is this pattern fundamentally sound?
|
|
207
|
+
- Are we "sticking with it through sheer inertia"?
|
|
208
|
+
- Should we refactor architecture vs. continue fixing symptoms?
|
|
209
|
+
|
|
210
|
+
**Discuss with your human partner before attempting more fixes**
|
|
211
|
+
|
|
212
|
+
This is NOT a failed hypothesis - this is a wrong architecture.
|
|
213
|
+
|
|
214
|
+
## Red Flags - STOP and Follow Process
|
|
215
|
+
|
|
216
|
+
If you catch yourself thinking:
|
|
217
|
+
- "Quick fix for now, investigate later"
|
|
218
|
+
- "Just try changing X and see if it works"
|
|
219
|
+
- "Add multiple changes, run tests"
|
|
220
|
+
- "Skip the test, I'll manually verify"
|
|
221
|
+
- "It's probably X, let me fix that"
|
|
222
|
+
- "I don't fully understand but this might work"
|
|
223
|
+
- "Pattern says X but I'll adapt it differently"
|
|
224
|
+
- "Here are the main problems: [lists fixes without investigation]"
|
|
225
|
+
- Proposing solutions before tracing data flow
|
|
226
|
+
- **"One more fix attempt" (when already tried 2+)**
|
|
227
|
+
- **Each fix reveals new problem in different place**
|
|
228
|
+
|
|
229
|
+
**ALL of these mean: STOP. Return to Phase 1.**
|
|
230
|
+
|
|
231
|
+
**If 3+ fixes failed:** Question the architecture (see Phase 4.5)
|
|
232
|
+
|
|
233
|
+
## your human partner's Signals You're Doing It Wrong
|
|
234
|
+
|
|
235
|
+
**Watch for these redirections:**
|
|
236
|
+
- "Is that not happening?" - You assumed without verifying
|
|
237
|
+
- "Will it show us...?" - You should have added evidence gathering
|
|
238
|
+
- "Stop guessing" - You're proposing fixes without understanding
|
|
239
|
+
- "Ultra-think this" - Question fundamentals, not just symptoms
|
|
240
|
+
- "We're stuck?" (frustrated) - Your approach isn't working
|
|
241
|
+
|
|
242
|
+
**When you see these:** STOP. Return to Phase 1.
|
|
243
|
+
|
|
244
|
+
## Common Rationalizations
|
|
245
|
+
|
|
246
|
+
| Excuse | Reality |
|
|
247
|
+
|--------|---------|
|
|
248
|
+
| "Issue is simple, don't need process" | Simple issues have root causes too. Process is fast for simple bugs. |
|
|
249
|
+
| "Emergency, no time for process" | Systematic debugging is FASTER than guess-and-check thrashing. |
|
|
250
|
+
| "Just try this first, then investigate" | First fix sets the pattern. Do it right from the start. |
|
|
251
|
+
| "I'll write test after confirming fix works" | Untested fixes don't stick. Test first proves it. |
|
|
252
|
+
| "Multiple fixes at once saves time" | Can't isolate what worked. Causes new bugs. |
|
|
253
|
+
| "Reference too long, I'll adapt the pattern" | Partial understanding guarantees bugs. Read it completely. |
|
|
254
|
+
| "I see the problem, let me fix it" | Seeing symptoms ≠ understanding root cause. |
|
|
255
|
+
| "One more fix attempt" (after 2+ failures) | 3+ failures = architectural problem. Question pattern, don't fix again. |
|
|
256
|
+
|
|
257
|
+
## Quick Reference
|
|
258
|
+
|
|
259
|
+
| Phase | Key Activities | Success Criteria |
|
|
260
|
+
|-------|---------------|------------------|
|
|
261
|
+
| **1. Root Cause** | Read errors, reproduce, check changes, gather evidence | Understand WHAT and WHY |
|
|
262
|
+
| **2. Pattern** | Find working examples, compare | Identify differences |
|
|
263
|
+
| **3. Hypothesis** | Form theory, test minimally | Confirmed or new hypothesis |
|
|
264
|
+
| **4. Implementation** | Create test, fix, verify | Bug resolved, tests pass |
|
|
265
|
+
|
|
266
|
+
## When Process Reveals "No Root Cause"
|
|
267
|
+
|
|
268
|
+
If systematic investigation reveals issue is truly environmental, timing-dependent, or external:
|
|
269
|
+
|
|
270
|
+
1. You've completed the process
|
|
271
|
+
2. Document what you investigated
|
|
272
|
+
3. Implement appropriate handling (retry, timeout, error message)
|
|
273
|
+
4. Add monitoring/logging for future investigation
|
|
274
|
+
|
|
275
|
+
**But:** 95% of "no root cause" cases are incomplete investigation.
|
|
276
|
+
|
|
277
|
+
## Supporting Techniques
|
|
278
|
+
|
|
279
|
+
These techniques are part of systematic debugging and available in this directory:
|
|
280
|
+
|
|
281
|
+
- **`root-cause-tracing.md`** - Trace bugs backward through call stack to find original trigger
|
|
282
|
+
- **`defense-in-depth.md`** - Add validation at multiple layers after finding root cause
|
|
283
|
+
- **`condition-based-waiting.md`** - Replace arbitrary timeouts with condition polling
|