ag-psd 32.0.0 → 34.0.0

package/TODO.md

@@ -1,94 +1,23 @@
-- remove RAW_IMAGE_DATA, use raw data instead (change tests to use get functions)
+- Alpha and spot channel pixels (saved selections, spot colors) are thrown away on read (psdReader.ts:1124) and never written. The writer still writes their names and display info, so a written file can describe channels it doesn't contain.
+- Composite transparency is lost in a few files (for example 4x4_8bit_rgba, adobehq_layers: 4 channels come back as 3). I haven't investigated why.
+- Extra layer channel IDs beyond -1/-2/-3 are dropped.
+- Per-layer XMP (shmd → cust → layerXMP) isn't kept; only layerTime is.
 
-- writing 1, 16, 32 bit documents
-'pths'
-- split decoding layer data from reading the document
-- writing paletted documents
-- cleanup errors from tests (make list of drawings that should ignore those errors)
-- writing zip/zip with prediction
 
+- Lab, Multichannel and Duotone can't be read (19 corpus files) or written. Duotone could be read as grayscale while keeping its color mode data.
+- 32-bit CMYK and 16-bit Indexed throw on read, and 32-bit CMYK can't be written.
+- Patterns are only written as 8-bit RGB (psdWriter.ts:1175); the source mode and depth are lost.
+- CMYK conversion ignores the embedded ICC profile and always uses the SWOP approximation.
 
-- can we remove sectionDivider property ?
-- can we remove nameSource property ?
-
-- improve vector fill / stroke help sections
-
-check: https://github.com/psd-tools/psd-tools
-check: https://github.com/TheNicker/libpsd
-
-- zip with prediction: https://github.com/TheNicker/libpsd/blob/master/src/psd_zip.c
-- also support saving with zip compression ?
-
+- Not parsed: Filter Gallery (GEfc), Lens Correction (LnCr), and adjustments used as smart filters: Hue/Saturation (HStr), Exposure, Vibrance, Color Balance, Black & White, Photo Filter, Gradient Map, Selective Color, Threshold, Channel Mixer, Color Lookup, Posterize, Shadows/Highlights.
 
 
+- Fuzzer
 
+- can we remove sectionDivider property ?
+- can we remove nameSource property ?
 
+- improve vector fill / stroke help sections
 
 
 - decompress image data in FEid section
-
-```ts
-  if (!channelLength) throw new Error('filterEffect: Empty channel');
-  const compression = readUint16(reader);
-  const data = createImageDataBitDepth(right - left, bottom - top, depth, 1);
-  const end = reader.offset + channelLength - 2;
-  readData(reader, channelLength - 2, data, compression, data.width, data.height, depth, 0, false, 1);
-  if (reader.offset != end) throw new Error(`Invalid offset after readData ${reader.offset} ${end}`);
-  channels.push(data);
-
-  const top = readInt32(reader);
-  const left = readInt32(reader);
-  const bottom = readInt32(reader);
-  const right = readInt32(reader);
-  if (readUint32(reader)) throw new Error('filterEffect: 64 bit length is not supported');
-  const extraLength = readUint32(reader);
-  const compression = readUint16(reader);
-  const data = createImageDataBitDepth(right - left, bottom - top, depth, 1);
-  readData(reader, extraLength - 2, data, compression, data.width, data.height, depth, 0, false, 1);
-  target.filterEffectsMasks[target.filterEffectsMasks.length - 1].extra = { top, left, bottom, right, data };
-```
-
-```ts
-export function decodeUtf16String(buffer: Uint8Array) {
-	let result = '';
-
-	for (let i = 0; i < buffer.byteLength;) {
-		const w1 = (buffer[i++] << 8) | buffer[i++];
-
-		if ((w1 & 0xF800) !== 0xD800) { // w1 < 0xD800 || w1 > 0xDFFF
-			result += String.fromCharCode(w1);
-			continue;
-		}
-
-		if ((w1 & 0xFC00) === 0xD800) { // w1 >= 0xD800 && w1 <= 0xDBFF
-			throw new Error('Invalid utf-16');
-		}
-
-		if (i === buffer.byteLength) {
-			throw new Error('Invalid utf-16');
-		}
-
-		const w2 = (buffer[i++] << 8) | buffer[i++];
-
-		if ((w2 & 0xFC00) !== 0xDC00) { // w2 < 0xDC00 || w2 > 0xDFFF)
-			throw new Error('Invalid utf-16');
-		}
-
-		result += String.fromCharCode(((w1 & 0x3ff) << 10) + (w2 & 0x3ff) + 0x10000);
-	}
-
-	return result;
-}
-
-export function encodeUtf16String(value: string) {
-	const buffer = new Uint8Array(value.length * 2);
-
-	for (let i = 0, j = 0; i < value.length; i++, j += 2) {
-		const word = value.charCodeAt(i);
-		buffer[j] = (word >> 8) & 0xff;
-		buffer[j + 1] = word & 0xff;
-	}
-
-	return buffer;
-}
-```

package/dist/abr.d.ts

@@ -85,6 +85,7 @@ interface DynamicBrushShape {
 }
 export interface Brush {
     name: string;
+    group?: string[];
     shape: BrushShape;
     shapeDynamics?: {
         sizeDynamics: BrushDynamics;
@@ -138,8 +139,8 @@ export interface Brush {
     transfer?: {
         flowDynamics: BrushDynamics;
         opacityDynamics: BrushDynamics;
-        wetnessDynamics: BrushDynamics;
-        mixDynamics: BrushDynamics;
+        wetnessDynamics?: BrushDynamics;
+        mixDynamics?: BrushDynamics;
     };
     brushPose?: {
         overrideAngle: boolean;
@@ -153,6 +154,7 @@ export interface Brush {
     };
     noise: boolean;
     wetEdges: boolean;
+    buildUp: boolean;
     protectTexture?: boolean;
     spacing: number;
     brushGroup?: undefined;
@@ -190,7 +192,12 @@ export interface Brush {
         strength?: number;
     };
 }
-export declare function readAbr(buffer: ArrayBufferView, options?: {
+export interface ReadAbrOptions {
     logMissingFeatures?: boolean;
-}): Abr;
+    /** Throw on unsupported or invalid parts of the file instead of skipping them */
+    throwForMissingFeatures?: boolean;
+    /** Memory limit for decoded data in bytes (2GB by default), set to `undefined` explicitly to disable */
+    totalMemoryLimit?: number;
+}
+export declare function readAbr(buffer: ArrayBufferView, options?: ReadAbrOptions): Abr;
 export {};