ag-grid-community 33.2.2 → 33.2.4

package/dist/ag-grid-community.js

@@ -23675,7 +23675,8 @@ class FocusService extends beanStub_1.BeanStub {
     // grid cell will still be focused as far as the grid is concerned,
     // however the browser focus will have moved somewhere else.
     getFocusCellToUseAfterRefresh() {
-        if (this.gos.get('suppressFocusAfterRefresh') || !this.focusedCell) {
+        const { gos, focusedCell } = this;
+        if (gos.get('suppressFocusAfterRefresh') || gos.get('suppressCellFocus') || !focusedCell) {
             return null;
         }
         // we check that the browser is actually focusing on the grid, if it is not, then
@@ -23684,7 +23685,7 @@ class FocusService extends beanStub_1.BeanStub {
         if (!this.doesRowOrCellHaveBrowserFocus()) {
             return null;
         }
-        return this.focusedCell;
+        return focusedCell;
     }
     getFocusHeaderToUseAfterRefresh() {
         if (this.gos.get('suppressFocusAfterRefresh') || !this.focusedHeader) {
@@ -25426,7 +25427,7 @@ class GridBodyScrollFeature extends beanStub_1.BeanStub {
     shouldBlockHorizontalScroll(scrollTo) {
         const clientWidth = this.centerRowsCtrl.getCenterWidth();
         const { scrollWidth } = this.centerRowsCtrl.eViewport;
-        if (this.enableRtl && (0, dom_1._isRtlNegativeScroll)()) {
+        if (this.enableRtl) {
             if (scrollTo > 0) {
                 return true;
             }
@@ -25471,7 +25472,7 @@ class GridBodyScrollFeature extends beanStub_1.BeanStub {
         // if this is call is coming from the alignedGridsSvc, we don't need to validate the
         // scroll, because it has already been validated by the grid firing the scroll event.
         if (!fromAlignedGridsService && this.shouldBlockScrollUpdate(ScrollDir.Horizontal, hScrollPosition)) {
-            if (this.enableRtl && (0, dom_1._isRtlNegativeScroll)()) {
+            if (this.enableRtl) {
                 hScrollPosition = hScrollPosition > 0 ? 0 : maxScrollLeft;
             }
             else {
@@ -43950,6 +43951,9 @@ class RowCtrl extends beanStub_1.BeanStub {
             this.allRowGuis.forEach(callback);
         }
     }
+    isRowRendered() {
+        return this.allRowGuis.length > 0;
+    }
     onRowHeightChanged(gui) {
         // check for exists first - if the user is resetting the row height, then
         // it will be null (or undefined) momentarily until the next time the flatten
@@ -44449,37 +44453,50 @@ class RowRenderer extends beanStub_1.BeanStub {
             this.allRowCtrls = liveList;
         }
     }
-    isCellRendered(rowIndex, column) {
+    /**
+     * Checks if the cell is rendered or not. Also returns true if row ctrl is present but has not rendered
+     * cells yet.
+     * @returns true if cellCtrl is present, or if the row is present but has not rendered rows yet
+     */
+    isCellBeingRendered(rowIndex, column) {
         const rowCtrl = this.rowCtrlsByRowIndex[rowIndex];
-        // if no column, simply check for row ctrl
-        if (!column) {
+        // if no column, simply check for row ctrl, if no rowCtrl then return false
+        if (!column || !rowCtrl) {
             return !!rowCtrl;
         }
-        if (rowCtrl && rowCtrl.isFullWidth()) {
+        if (rowCtrl.isFullWidth()) {
             return true;
         }
-        // check if this is spanned, if it has been rendered by the span renderer
+        // return true if:
+        // - spannedRowRenderer has a cell for this position,
+        // - or if the rowCtrl has a cell for this column
+        // - or if the row is not rendered yet, as it might try to render it
         const spannedCell = this.beans.spannedRowRenderer?.getCellByPosition({ rowIndex, column, rowPinned: null });
-        if (spannedCell) {
-            return true;
-        }
-        // otherwise, check if the cell is rendered
-        return !!rowCtrl?.getCellCtrl(column);
+        return !!spannedCell || !!rowCtrl.getCellCtrl(column) || !rowCtrl.isRowRendered();
     }
     /**
      * Notifies all row and cell controls of any change in focused cell.
      * @param event cell focused event
      */
+    updateCellFocus(event) {
+        this.getAllCellCtrls().forEach((cellCtrl) => cellCtrl.onCellFocused(event));
+        this.getFullWidthRowCtrls().forEach((rowCtrl) => rowCtrl.onFullWidthRowFocused(event));
+    }
+    /**
+     * Called when a new cell is focused in the grid
+     * - if the focused cell isn't rendered; re-draw rows to dry to render it
+     * - subsequently updates all cell and row controls with the new focused cell
+     * @param event cell focused event
+     */
     onCellFocusChanged(event) {
         // if the focused cell has not been rendered, need to render cell so focus can be captured.
         if (event && event.rowIndex != null && !event.rowPinned) {
             const col = this.beans.colModel.getCol(event.column) ?? undefined;
-            if (!this.isCellRendered(event.rowIndex, col)) {
+            if (!this.isCellBeingRendered(event.rowIndex, col)) {
                 this.redraw();
             }
         }
-        this.getAllCellCtrls().forEach((cellCtrl) => cellCtrl.onCellFocused(event));
-        this.getFullWidthRowCtrls().forEach((rowCtrl) => rowCtrl.onFullWidthRowFocused(event));
+        this.updateCellFocus(event);
     }
     onSuppressCellFocusChanged(suppressCellFocus) {
         this.getAllCellCtrls().forEach((cellCtrl) => cellCtrl.onSuppressCellFocusChanged(suppressCellFocus));
@@ -44490,10 +44507,8 @@ class RowRenderer extends beanStub_1.BeanStub {
     // all active cells.
     registerCellEventListeners() {
         this.addManagedEventListeners({
-            cellFocused: (event) => {
-                this.onCellFocusChanged(event);
-            },
-            cellFocusCleared: () => this.onCellFocusChanged(),
+            cellFocused: (event) => this.onCellFocusChanged(event),
+            cellFocusCleared: () => this.updateCellFocus(),
             flashCells: (event) => {
                 const { cellFlashSvc } = this.beans;
                 if (cellFlashSvc) {
@@ -44840,7 +44855,7 @@ class RowRenderer extends beanStub_1.BeanStub {
         }
         // if the grid lost focus, we need to try to bring it back
         if (!focusSvc.doesRowOrCellHaveBrowserFocus()) {
-            this.onCellFocusChanged((0, gridOptionsUtils_1._addGridCommonParams)(this.gos, {
+            this.updateCellFocus((0, gridOptionsUtils_1._addGridCommonParams)(this.gos, {
                 ...cellToFocus,
                 forceBrowserFocus: true,
                 preventScrollOnBrowserFocus: true,
@@ -52833,11 +52848,10 @@ exports._parseDateTimeFromString = _parseDateTimeFromString;
 
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports._createElement = exports.DataRefAttribute = exports._requestAnimationFrame = exports._preserveRangesWhile = exports._observeResize = exports._addOrRemoveAttribute = exports._isNodeOrElement = exports._formatSize = exports._setFixedHeight = exports._setFixedWidth = exports._setElementWidth = exports._isVerticalScrollShowing = exports._isHorizontalScrollShowing = exports._addStylesToElement = exports._insertWithDomOrder = exports._setDomChildOrder = exports._ensureDomOrder = exports._loadTemplate = exports._isVisible = exports._isInDOM = exports._removeFromParent = exports._clearElement = exports._setScrollLeft = exports._getScrollLeft = exports._isRtlNegativeScroll = exports._getElementRectWithOffset = exports._getAbsoluteWidth = exports._getAbsoluteHeight = exports._getInnerWidth = exports._getInnerHeight = exports._getElementSize = exports._isElementChildOfClass = exports._setDisabled = exports._setVisible = exports._setDisplayed = exports._isFocusableFormField = exports.FOCUSABLE_EXCLUDE = exports.FOCUSABLE_SELECTOR = exports._radioCssClass = void 0;
+exports._createElement = exports.DataRefAttribute = exports._requestAnimationFrame = exports._preserveRangesWhile = exports._observeResize = exports._addOrRemoveAttribute = exports._isNodeOrElement = exports._formatSize = exports._setFixedHeight = exports._setFixedWidth = exports._setElementWidth = exports._isVerticalScrollShowing = exports._isHorizontalScrollShowing = exports._addStylesToElement = exports._insertWithDomOrder = exports._setDomChildOrder = exports._ensureDomOrder = exports._loadTemplate = exports._isVisible = exports._isInDOM = exports._removeFromParent = exports._clearElement = exports._setScrollLeft = exports._getScrollLeft = exports._getElementRectWithOffset = exports._getAbsoluteWidth = exports._getAbsoluteHeight = exports._getInnerWidth = exports._getInnerHeight = exports._getElementSize = exports._isElementChildOfClass = exports._setDisabled = exports._setVisible = exports._setDisplayed = exports._isFocusableFormField = exports.FOCUSABLE_EXCLUDE = exports.FOCUSABLE_SELECTOR = exports._radioCssClass = void 0;
 const gridOptionsUtils_1 = __webpack_require__(7274);
 const aria_1 = __webpack_require__(5230);
 const browser_1 = __webpack_require__(8667);
-let rtlNegativeScroll;
 /**
  * This method adds a class to an element and remove that class from all siblings.
  * Useful for toggling state.
@@ -52980,52 +52994,17 @@ function _getElementRectWithOffset(el) {
     };
 }
 exports._getElementRectWithOffset = _getElementRectWithOffset;
-function _isRtlNegativeScroll() {
-    if (typeof rtlNegativeScroll === 'boolean') {
-        return rtlNegativeScroll;
-    }
-    const template = document.createElement('div');
-    template.style.direction = 'rtl';
-    template.style.width = '10px';
-    template.style.height = '5px';
-    template.style.position = 'fixed';
-    template.style.top = '0px';
-    template.style.overflow = 'hidden';
-    template.dir = 'rtl';
-    template.innerHTML =
-        /* html */
-        `<div style="width: 20px">
-            <span style="display: inline-block; width: 1px"></span>
-            <span style="display: inline-block; width: 1px"></span>
-        </div>`;
-    document.body.appendChild(template);
-    template.scrollLeft = 1;
-    rtlNegativeScroll = Math.floor(template.scrollLeft) === 0;
-    document.body.removeChild(template);
-    return rtlNegativeScroll;
-}
-exports._isRtlNegativeScroll = _isRtlNegativeScroll;
 function _getScrollLeft(element, rtl) {
     let scrollLeft = element.scrollLeft;
     if (rtl) {
-        // Absolute value - for FF that reports RTL scrolls in negative numbers
         scrollLeft = Math.abs(scrollLeft);
-        if ((0, browser_1._isBrowserChrome)() && !_isRtlNegativeScroll()) {
-            scrollLeft = element.scrollWidth - element.getBoundingClientRect().width - scrollLeft;
-        }
     }
     return scrollLeft;
 }
 exports._getScrollLeft = _getScrollLeft;
 function _setScrollLeft(element, value, rtl) {
     if (rtl) {
-        // Chrome and Safari when doing RTL have the END position of the scroll as zero, not the start
-        if (_isRtlNegativeScroll()) {
-            value *= -1;
-        }
-        else if ((0, browser_1._isBrowserSafari)() || (0, browser_1._isBrowserChrome)()) {
-            value = element.scrollWidth - element.getBoundingClientRect().width - value;
-        }
+        value *= -1;
     }
     element.scrollLeft = value;
 }
@@ -57389,7 +57368,7 @@ exports.VanillaFrameworkOverrides = VanillaFrameworkOverrides;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.VERSION = void 0;
 // DO NOT UPDATE MANUALLY: Generated from script during build time
-exports.VERSION = '33.2.2';
+exports.VERSION = '33.2.4';
 
 
 /***/ }),