aeo-ready 1.3.1 → 1.3.2

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 1.3.2
+
+- Fix broken `afdocs` fix command — was calling `npx afdocs <url>` instead of `npx afdocs check <url>`
+- Fix shell injection in `promptFix` — switched `execSync` to `execFileSync`
+- Add test suite (`node --test`)
+- Add GitHub Actions CI
+
 ## 1.3.1
 
 - Add progress indicator during scan

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aeo-ready",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "AEO benchmark aggregator. One scan, every score. Collects agentic-seo, Cloudflare, and Fern in one report.",
   "type": "module",
   "bin": {
@@ -37,7 +37,6 @@
     "bin/",
     "src/benchmark/",
     "src/history/",
-    "src/utils/",
     "src/index.js",
     "src/scan.js",
     "skills/",

package/src/benchmark/agentic-seo.js

@@ -1,4 +1,4 @@
-import { execSync } from "child_process";
+import { execFileSync } from "child_process";
 import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from "fs";
 import { tmpdir } from "os";
 import { join, dirname } from "path";
@@ -21,7 +21,8 @@ async function fetchText(url) {
     const res = await fetch(url, { redirect: "follow" });
     if (!res.ok) return null;
     return await res.text();
-  } catch {
+  } catch (err) {
+    console.warn(`Warning: failed to fetch ${url}: ${err.message}`);
     return null;
   }
 }
@@ -102,7 +103,7 @@ export async function runBenchmark(target) {
       scanDir = target || ".";
     }
 
-    const output = execSync(`npx agentic-seo ${scanDir} --json`, {
+    const output = execFileSync("npx", ["agentic-seo", scanDir, "--json"], {
       timeout: 60000,
       encoding: "utf8",
       stdio: ["pipe", "pipe", "pipe"],
@@ -135,7 +136,11 @@ export async function runBenchmark(target) {
     if (tempDir) {
       try {
         rmSync(tempDir, { recursive: true, force: true });
-      } catch {}
+      } catch (cleanupErr) {
+        console.warn(
+          `Warning: failed to clean up temp dir ${tempDir}: ${cleanupErr.message}`,
+        );
+      }
     }
   }
 }

package/src/benchmark/cloudflare.js

@@ -62,6 +62,9 @@ export async function runCloudflare(url) {
       available: true,
     };
   } catch (err) {
+    console.warn(
+      `Warning: Cloudflare benchmark failed for ${url}: ${err.message}`,
+    );
     return { available: false, reason: err.message?.slice(0, 100) };
   }
 }

package/src/benchmark/fern.js

@@ -46,6 +46,7 @@ export async function runFern(url) {
       available: true,
     };
   } catch (err) {
+    console.warn(`Warning: Fern benchmark failed for ${url}: ${err.message}`);
     return { available: false, reason: err.message?.slice(0, 100) };
   }
 }

package/src/scan.js

@@ -1,6 +1,6 @@
 import chalk from "chalk";
 import { createInterface } from "readline";
-import { execSync } from "child_process";
+import { execFileSync } from "child_process";
 import { runAllBenchmarks, printBenchmarks } from "./benchmark/index.js";
 import { saveResult } from "./history/index.js";
 
@@ -100,7 +100,10 @@ function printNextSteps(result) {
       (c) => c.status === "fail" || c.status === "warn",
     ) || [];
   if (fernFails.length > 0) {
-    steps.push([`npx afdocs ${result.url}`, `${fernFails.length} Fern issues`]);
+    steps.push([
+      `npx afdocs check ${result.url}`,
+      `${fernFails.length} Fern issues`,
+    ]);
   }
 
   steps.push([
@@ -138,7 +141,7 @@ async function promptFix(result, dir) {
 
   console.log(chalk.dim(`  Running: npx agentic-seo init ${targetDir}\n`));
   try {
-    execSync(`npx agentic-seo init ${targetDir}`, {
+    execFileSync("npx", ["agentic-seo", "init", targetDir], {
       stdio: "inherit",
     });
   } catch (err) {
@@ -150,9 +153,11 @@ async function promptFix(result, dir) {
       (c) => c.status === "fail" || c.status === "warn",
     ) || [];
   if (fernFails.length > 0) {
-    console.log(chalk.dim(`\n  Running: npx afdocs ${result.url}\n`));
+    console.log(chalk.dim(`\n  Running: npx afdocs check ${result.url}\n`));
     try {
-      execSync(`npx afdocs ${result.url}`, { stdio: "inherit" });
+      execFileSync("npx", ["afdocs", "check", result.url], {
+        stdio: "inherit",
+      });
     } catch (err) {
       console.log(chalk.red(`\n  afdocs failed: ${err.message}\n`));
     }

package/src/utils/fetch.js

@@ -1,42 +0,0 @@
-const DEFAULT_TIMEOUT = 10000;
-const USER_AGENT = "aeo-ready/1.3 (AEO benchmark aggregator)";
-
-export async function fetchUrl(url, opts = {}) {
-  const controller = new AbortController();
-  const timeout = setTimeout(
-    () => controller.abort(),
-    opts.timeout || DEFAULT_TIMEOUT,
-  );
-
-  try {
-    const res = await fetch(url, {
-      signal: controller.signal,
-      headers: {
-        "User-Agent": USER_AGENT,
-        ...opts.headers,
-      },
-      redirect: "follow",
-    });
-    const text = await res.text();
-    return {
-      status: res.status,
-      text,
-      headers: Object.fromEntries(res.headers),
-    };
-  } catch (err) {
-    if (err.name === "AbortError") {
-      return { status: 0, text: "", headers: {}, error: "timeout" };
-    }
-    return { status: 0, text: "", headers: {}, error: err.message };
-  } finally {
-    clearTimeout(timeout);
-  }
-}
-
-export function resolveUrl(base, path) {
-  try {
-    return new URL(path, base).href;
-  } catch {
-    return null;
-  }
-}