aegis-desktop 0.8.27 → 0.8.28

package/lib/local/engine.js

@@ -1392,6 +1392,17 @@ function createLocalEngine({
           system: opts.system,
           messages: opts.messages,
           maxTokens: opts.maxTokens,
+          // aegis1's byok_chat_completions has read and forwarded `tools`/
+          // `tool_choice` since 926069b (2026-09-10) — this call simply never
+          // sent them, so every BYOK turn (DeepSeek, Anthropic, OpenAI alike)
+          // ran with no write/exec/editFile schema at all. A model told in its
+          // system prompt that it "writes and edits files" but never given the
+          // JSON shape to do so improvises a DeepSeek-native DSML call from
+          // prose alone when it's confident, and falls back to prose ADVICE
+          // (a shell script to run by hand) when it isn't — which is exactly
+          // the bug this line closes.
+          tools: opts.tools,
+          toolChoice: opts.toolChoice,
           // Native effort knob, field and level both from the dialect table.
           // `bareModel` is already provider-less, so it matches the dialect
           // regexes without further stripping. Only a dialect whose field is
@@ -1530,12 +1541,19 @@ function createLocalEngine({
     const signal = controller.signal;
 
     // A caller can opt out of the agent loop entirely (`tools: false`) and get
-    // the old single-shot turn back. byok is ALWAYS single-shot: the
-    // stateless relay (aegis.byokChatCompletion, /api/v1/byok/chat/completions)
-    // has no tools/tool_choice parameter at all, so sending schemas here would
-    // build a prompt promising tool access the transport silently drops —
-    // the model would reason about exec/readFile and never see a result.
-    const toolsEnabled = cls !== 'byok' && !(payload && payload.tools === false);
+    // the old single-shot turn back. byok used to be forced into that same
+    // single-shot shape unconditionally: aegis1's byok relay had no
+    // tools/tool_choice parameter at all, so sending schemas would build a
+    // prompt promising tool access the transport silently dropped — the model
+    // would reason about exec/readFile and never see a result. That stopped
+    // being true at aegis1 926069b (2026-09-10, byok_chat_completions reads
+    // and forwards both), but this carve-out was never revisited, so every
+    // BYOK turn since kept running with no tool schema at all regardless —
+    // the model told in its own system prompt that it writes and edits files,
+    // and never given the JSON shape to do so. Reported live: asked to save a
+    // file to the Desktop, DeepSeek had no write tool to call and answered
+    // with a PowerShell script for the user to run by hand instead.
+    const toolsEnabled = !(payload && payload.tools === false);
     const toolSchemas = toolsEnabled ? T.toolsFor({ includeSubagent: depth < MAX_SUBAGENT_DEPTH }) : [];
     const toolChoice = (payload && payload.toolChoice) || null;
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "aegis-desktop",
   "productName": "AEGIS Desktop",
-  "version": "0.8.27",
+  "version": "0.8.28",
   "description": "Thin Electron host for AEGIS — a local chat UI over the shared client/aegis.js transport. Ships transport + UI only; engine logic stays server-side.",
   "author": {
     "name": "AEGIS Code",

package/vendor/aegis.js

@@ -1002,6 +1002,8 @@ function createClient(opts = {}) {
     maxTokens,
     effort,
     reasoningEffort,
+    tools,
+    toolChoice,
     stream = false,
     onStream,
     signal,
@@ -1035,6 +1037,13 @@ function createClient(opts = {}) {
       // failed turn, not a harmless extra key.
       ...(effort ? { effort } : {}),
       ...(reasoningEffort ? { reasoning_effort: reasoningEffort } : {}),
+      // Forwarded only when the caller actually supplied a schema — aegis1's
+      // byok_chat_completions (app.py) reads `tools`/`tool_choice` off the body
+      // and passes each to the provider only `if tools:`, so an empty array
+      // here would still be a behavioural change for a provider that treats
+      // `tools: []` differently from the field's plain absence.
+      ...(Array.isArray(tools) && tools.length ? { tools } : {}),
+      ...(toolChoice ? { tool_choice: toolChoice } : {}),
     };
     if (model) body.model = model;
     const headers = {

package/vendor/platform.js

@@ -871,6 +871,42 @@ function resolvePath(input, options = {}) {
   return { ok: true, path: resolved, error: null, expandedHome };
 }
 
+/**
+ * The last path segment of `input` — the NAME of a path, for display.
+ *
+ * This exists because `p.split('/').pop()` was the same expression in six CLI
+ * files, and it is wrong on half the hosts this product ships to: a real win32
+ * separator is `\`, so `C:\Users\you\proj` splits into ONE element and the
+ * "name" reported is the whole path. The status line, the session list, the
+ * resume picker and the `/export` file names all showed the full path there
+ * where linux and darwin showed `proj` — a cosmetic drift, but drifts are how
+ * the tool-layer bug shipped twice, and it is the same class of assumption
+ * (`/` is the separator) that `resolvePath` above exists to refuse.
+ *
+ * BOTH separators are accepted on every platform, unlike `resolvePath` which
+ * refuses a foreign path outright. That difference is deliberate: a name is not
+ * a security decision. The value can come from a git remote, a session recorded
+ * on another host, or a model's own output, and mis-slicing it produces a
+ * shorter label, never a write to the wrong file — so refusing it would trade a
+ * cosmetic bug for a worse one (an empty status line on a machine whose only
+ * oddity is a backslash).
+ *
+ * Returns `''` for an absent or empty path so each caller keeps its own
+ * fallback (`baseName(cwd) || '~'` is the CLI's "no cwd recorded" convention);
+ * a path that is nothing but separators ("/", "C:\") names no segment, so it is
+ * empty too rather than a stray "/" or a bare drive letter.
+ */
+function baseName(input) {
+  if (typeof input !== 'string') return '';
+  const trimmed = input.trim().replace(/[/\\]+$/, '');
+  if (!trimmed) return '';
+  // "C:" is a drive, not a name: it is the Windows spelling of "/" (the root of
+  // the current drive) and names no segment any more than a slash does.
+  if (/^[A-Za-z]:$/.test(trimmed)) return '';
+  const cut = Math.max(trimmed.lastIndexOf('/'), trimmed.lastIndexOf('\\'));
+  return cut === -1 ? trimmed : trimmed.slice(cut + 1);
+}
+
 const api = {
   IS_WIN32,
   resolveExecutable,
@@ -881,6 +917,7 @@ const api = {
   homeDir,
   desktopDir,
   resolvePath,
+  baseName,
   hasPosixModes,
   appLocale,
   languageName,