npm - aegis-bridge - Versions diffs - 2.4.0 → 2.5.0 - Mend

aegis-bridge 2.4.0 → 2.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (46) hide show

package/dashboard/dist/assets/{index-DPp-wise.css → index-B7DYf7vF.css} +1 -1
package/dashboard/dist/assets/{index-I_vW1gcQ.js → index-DxAes2EQ.js} +47 -47
package/dashboard/dist/index.html +2 -2
package/dist/auth.js +1 -2
package/dist/channels/index.js +0 -1
package/dist/channels/manager.js +0 -1
package/dist/channels/telegram-style.js +0 -1
package/dist/channels/telegram.js +0 -1
package/dist/channels/types.js +0 -1
package/dist/channels/webhook.js +0 -1
package/dist/cli.js +0 -1
package/dist/config.js +11 -5
package/dist/dashboard/assets/{index-DPp-wise.css → index-B7DYf7vF.css} +1 -1
package/dist/dashboard/assets/{index-I_vW1gcQ.js → index-DxAes2EQ.js} +47 -47
package/dist/dashboard/index.html +2 -2
package/dist/error-categories.js +0 -1
package/dist/events.d.ts +2 -0
package/dist/events.js +21 -3
package/dist/hook-settings.js +13 -7
package/dist/hook.js +0 -1
package/dist/hooks.js +21 -20
package/dist/jsonl-watcher.js +0 -1
package/dist/mcp-server.js +0 -1
package/dist/metrics.d.ts +2 -0
package/dist/metrics.js +30 -17
package/dist/monitor.js +1 -2
package/dist/permission-guard.js +0 -1
package/dist/pipeline.js +0 -1
package/dist/screenshot.js +0 -1
package/dist/server.js +88 -274
package/dist/session.js +14 -9
package/dist/signal-cleanup-helper.js +0 -1
package/dist/sse-limiter.js +0 -1
package/dist/sse-writer.js +0 -1
package/dist/ssrf.d.ts +4 -0
package/dist/ssrf.js +23 -2
package/dist/swarm-monitor.js +1 -3
package/dist/terminal-parser.js +3 -2
package/dist/tmux-capture-cache.js +0 -1
package/dist/tmux.js +1 -2
package/dist/transcript.js +53 -51
package/dist/utils/redact-headers.js +0 -1
package/dist/validation.d.ts +34 -2
package/dist/validation.js +20 -4
package/dist/ws-terminal.js +4 -3
package/package.json +3 -3

package/dist/dashboard/index.html CHANGED Viewed

@@ -5,8 +5,8 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Aegis Dashboard</title>
     <link rel="icon" type="image/svg+xml" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.9em' font-size='90'>🛡️</text></svg>" />
-    <script type="module" crossorigin src="/dashboard/assets/index-I_vW1gcQ.js"></script>
-    <link rel="stylesheet" crossorigin href="/dashboard/assets/index-DPp-wise.css">
+    <script type="module" crossorigin src="/dashboard/assets/index-DxAes2EQ.js"></script>
+    <link rel="stylesheet" crossorigin href="/dashboard/assets/index-B7DYf7vF.css">
   </head>
   <body class="bg-[#0a0a0f] text-gray-200 antialiased">
     <div id="root"></div>

package/dist/error-categories.js CHANGED Viewed

@@ -71,4 +71,3 @@ export function categorize(error) {
 export function shouldRetry(error) {
     return categorize(error).retryable;
 }
-//# sourceMappingURL=error-categories.js.map

package/dist/events.d.ts CHANGED Viewed

@@ -74,6 +74,8 @@ export declare class SessionEventBus {
     subscriberCount(sessionId: string): number;
     /** Global emitter for aggregating events across all sessions. */
     private globalEmitter;
+    /** #689: Pending setImmediate timers for cleanup on destroy. */
+    private pendingTimers;
     /** Subscribe to events from ALL sessions (new and existing). Returns unsubscribe function. */
     subscribeGlobal(handler: (event: GlobalSSEEvent) => void): () => void;
     /** Emit a session created event to global subscribers. */

package/dist/events.js CHANGED Viewed

@@ -98,7 +98,11 @@ export class SessionEventBus {
         }
         const emitter = this.emitters.get(sessionId);
         if (emitter) {
-            setImmediate(() => emitter.emit('event', event));
+            const imm = setImmediate(() => {
+                this.pendingTimers.delete(imm);
+                emitter.emit('event', event);
+            });
+            this.pendingTimers.add(imm);
         }
         // Forward to global subscribers
         if (this.globalEmitter) {
@@ -108,7 +112,11 @@ export class SessionEventBus {
             if (this.globalEventBuffer.length > SessionEventBus.BUFFER_SIZE) {
                 this.globalEventBuffer.splice(0, this.globalEventBuffer.length - SessionEventBus.BUFFER_SIZE);
             }
-            setImmediate(() => this.globalEmitter.emit('event', globalEvent));
+            const imm = setImmediate(() => {
+                this.pendingTimers.delete(imm);
+                this.globalEmitter?.emit('event', globalEvent);
+            });
+            this.pendingTimers.add(imm);
         }
     }
     /** Get events emitted after the given event ID for a session. */
@@ -217,6 +225,8 @@ export class SessionEventBus {
     // ── Global (all-session) SSE ──────────────────────────────────────
     /** Global emitter for aggregating events across all sessions. */
     globalEmitter = null;
+    /** #689: Pending setImmediate timers for cleanup on destroy. */
+    pendingTimers = new Set();
     /** Subscribe to events from ALL sessions (new and existing). Returns unsubscribe function. */
     subscribeGlobal(handler) {
         if (!this.globalEmitter) {
@@ -226,6 +236,10 @@ export class SessionEventBus {
         this.globalEmitter.on('event', handler);
         return () => {
             this.globalEmitter?.off('event', handler);
+            // #689: Nullify globalEmitter when all subscribers leave
+            if (this.globalEmitter && this.globalEmitter.listenerCount('event') === 0) {
+                this.globalEmitter = null;
+            }
         };
     }
     /** Emit a session created event to global subscribers. */
@@ -262,6 +276,11 @@ export class SessionEventBus {
     }
     /** Clean up all emitters. */
     destroy() {
+        // #689: Clear pending setImmediate timers before removing listeners
+        for (const imm of this.pendingTimers) {
+            clearImmediate(imm);
+        }
+        this.pendingTimers.clear();
         for (const emitter of this.emitters.values()) {
             emitter.removeAllListeners();
         }
@@ -272,4 +291,3 @@ export class SessionEventBus {
         this.globalEmitter = null;
     }
 }
-//# sourceMappingURL=events.js.map

package/dist/hook-settings.js CHANGED Viewed

@@ -13,10 +13,11 @@
  *
  * Issue #169: Phase 2 — Inject CC settings.json with HTTP hooks.
  */
-import { readFile, writeFile, unlink, mkdir } from 'node:fs/promises';
+import { readFile, writeFile, unlink, mkdir, rmdir } from 'node:fs/promises';
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { tmpdir } from 'node:os';
+import { randomBytes } from 'node:crypto';
 import { ccSettingsSchema } from './validation.js';
 /** CC hook events that support `type: "http"`.
  *
@@ -112,12 +113,13 @@ export async function writeHookSettingsFile(baseUrl, sessionId, workDir) {
             ...hookSettings.hooks,
         },
     };
-    const settingsDir = join(tmpdir(), 'aegis-hooks');
-    if (!existsSync(settingsDir)) {
-        await mkdir(settingsDir, { recursive: true });
-    }
+    // Issue #648: Use unpredictable directory name and restrictive permissions
+    // to prevent symlink attacks and information disclosure in /tmp.
+    const suffix = randomBytes(4).toString('hex');
+    const settingsDir = join(tmpdir(), `aegis-hooks-${suffix}`);
+    await mkdir(settingsDir, { recursive: true, mode: 0o700 });
     const filePath = join(settingsDir, `hooks-${sessionId}.json`);
-    await writeFile(filePath, JSON.stringify(combined, null, 2) + '\n', 'utf-8');
+    await writeFile(filePath, JSON.stringify(combined, null, 2) + '\n', { encoding: 'utf-8', mode: 0o600 });
     return filePath;
 }
 /**
@@ -129,10 +131,14 @@ export async function cleanupHookSettingsFile(filePath) {
     try {
         if (existsSync(filePath)) {
             await unlink(filePath);
+            // Issue #648: Also remove the randomized parent directory
+            const parentDir = join(filePath, '..');
+            await rmdir(parentDir).catch(() => {
+                // Non-fatal: directory may not be empty or already removed
+            });
         }
     }
     catch {
         // Non-fatal: temp file cleanup failed
     }
 }
-//# sourceMappingURL=hook-settings.js.map

package/dist/hook.js CHANGED Viewed

@@ -196,4 +196,3 @@ function install() {
     console.log(`Aegis hook installed in ${settingsPath}`);
 }
 main();
-//# sourceMappingURL=hook.js.map

package/dist/hooks.js CHANGED Viewed

@@ -14,7 +14,7 @@
  * Issue #169: Phase 1 — HTTP hooks infrastructure.
  * Issue #169: Phase 3 — Hook-driven status detection.
  */
-import { isValidUUID } from './validation.js';
+import { isValidUUID, hookBodySchema } from './validation.js';
 /** CC hook events that require a decision response. */
 const DECISION_EVENTS = new Set(['PreToolUse', 'PermissionRequest']);
 /** Permission modes that should be auto-approved via hook response. */
@@ -114,10 +114,15 @@ export function registerHookRoutes(app, deps) {
         if (!session) {
             return reply.status(404).send({ error: `Session ${sessionId} not found` });
         }
+        // Issue #665: Validate hook body with Zod instead of unsafe casts
+        const parseResult = hookBodySchema.safeParse(req.body);
+        if (!parseResult.success) {
+            return reply.status(400).send({ error: `Invalid hook body: ${parseResult.error.message}` });
+        }
+        const hookBody = parseResult.data;
         // Issue #88: Track active subagents
-        const hookBody = req.body;
         if (eventName === 'SubagentStart') {
-            const agentName = hookBody?.agent_name || hookBody?.tool_input?.command || 'unknown';
+            const agentName = hookBody.agent_name || hookBody.tool_input?.command || 'unknown';
             deps.sessions.addSubagent(sessionId, agentName);
             deps.eventBus.emit(sessionId, {
                 event: 'subagent_start',
@@ -127,7 +132,7 @@ export function registerHookRoutes(app, deps) {
             });
         }
         else if (eventName === 'SubagentStop') {
-            const agentName = hookBody?.agent_name || 'unknown';
+            const agentName = hookBody.agent_name || 'unknown';
             deps.sessions.removeSubagent(sessionId, agentName);
             deps.eventBus.emit(sessionId, {
                 event: 'subagent_stop',
@@ -149,16 +154,15 @@ export function registerHookRoutes(app, deps) {
         if (eventName === 'PreCompact' || eventName === 'PostCompact') {
             session.lastActivity = Date.now();
         }
-        // Forward the raw hook event to SSE subscribers
-        deps.eventBus.emitHook(sessionId, eventName, req.body);
+        // Forward the validated hook event to SSE subscribers
+        deps.eventBus.emitHook(sessionId, eventName, hookBody);
         // Issue #89 L25: Capture model field from hook payload for dashboard display
-        const hookPayload = req.body;
-        if (hookPayload?.model && typeof hookPayload.model === 'string') {
-            deps.sessions.updateSessionModel(sessionId, hookPayload.model);
+        if (hookBody.model) {
+            deps.sessions.updateSessionModel(sessionId, hookBody.model);
         }
         // Issue #89 L24: Validate permission_mode from PermissionRequest hook
         if (eventName === 'PermissionRequest') {
-            const rawMode = hookBody?.permission_mode;
+            const rawMode = hookBody.permission_mode;
             if (rawMode !== undefined && !VALID_PERMISSION_MODES.has(rawMode)) {
                 console.warn(`Hooks: invalid permission_mode "${rawMode}" from PermissionRequest, using "default"`);
                 hookBody.permission_mode = 'default';
@@ -167,8 +171,8 @@ export function registerHookRoutes(app, deps) {
         // Issue #169 Phase 3: Update session status from hook event
         // Issue #87: Extract timestamp from hook payload for latency calculation
         const hookReceivedAt = Date.now();
-        const hookEventTimestamp = hookPayload?.timestamp
-            ? new Date(hookPayload.timestamp).getTime()
+        const hookEventTimestamp = hookBody.timestamp
+            ? new Date(hookBody.timestamp).getTime()
             : undefined;
         // Issue #87: Record hook latency if we have a timestamp from the payload
         if (hookEventTimestamp && deps.metrics) {
@@ -202,22 +206,20 @@ export function registerHookRoutes(app, deps) {
                     deps.eventBus.emitStatus(sessionId, 'working', 'Elicitation result received (hook: ElicitationResult)');
                     break;
                 case 'PermissionRequest':
-                    deps.eventBus.emitApproval(sessionId, req.body?.permission_prompt
-                        || 'Permission requested (hook)');
+                    deps.eventBus.emitApproval(sessionId, hookBody.permission_prompt || 'Permission requested (hook)');
                     break;
             }
         }
         // Decision events need a response body that CC uses
         // Format: { hookSpecificOutput: { hookEventName, permissionDecision, reason? } }
         if (DECISION_EVENTS.has(eventName)) {
-            const hookBody = req.body;
-            const toolName = hookBody?.tool_name || '';
-            const permissionPrompt = hookBody?.permission_prompt || '';
+            const toolName = hookBody.tool_name || '';
+            const permissionPrompt = hookBody.permission_prompt || '';
             if (eventName === 'PreToolUse') {
                 // Issue #336: Intercept AskUserQuestion for headless question answering
                 if (toolName === 'AskUserQuestion') {
-                    const toolInput = hookBody?.tool_input;
-                    const toolUseId = hookBody?.tool_use_id || '';
+                    const toolInput = hookBody.tool_input;
+                    const toolUseId = hookBody.tool_use_id || '';
                     const questionText = extractQuestionText(toolInput);
                     // Emit ask_question SSE event for external clients
                     deps.eventBus.emit(sessionId, {
@@ -281,4 +283,3 @@ export function registerHookRoutes(app, deps) {
         return reply.status(200).send({ ok: true });
     });
 }
-//# sourceMappingURL=hooks.js.map

package/dist/jsonl-watcher.js CHANGED Viewed

@@ -156,4 +156,3 @@ export class JsonlWatcher {
         }
     }
 }
-//# sourceMappingURL=jsonl-watcher.js.map

package/dist/mcp-server.js CHANGED Viewed

@@ -786,4 +786,3 @@ export async function startMcpServer(port, authToken) {
     await server.connect(transport);
     // Server runs until stdin closes
 }
-//# sourceMappingURL=mcp-server.js.map

package/dist/metrics.d.ts CHANGED Viewed

@@ -93,6 +93,8 @@ export declare class MetricsCollector {
     recordPermissionResponse(sessionId: string, latencyMs: number): void;
     recordChannelDelivery(sessionId: string, latencyMs: number): void;
     private summarizeSamples;
+    /** Stream-aggregate a single latency field across all sessions without creating temp arrays. */
+    private aggregateLatencyField;
     getSessionLatency(sessionId: string): SessionLatencySummary | null;
     /** Clean up latency data for a session (called on session kill). */
     clearSessionLatency(sessionId: string): void;

package/dist/metrics.js CHANGED Viewed

@@ -150,6 +150,27 @@ export class MetricsCollector {
         }
         return { min, max, avg: Math.round(sum / samples.length), count: samples.length };
     }
+    /** Stream-aggregate a single latency field across all sessions without creating temp arrays. */
+    aggregateLatencyField(field) {
+        let min;
+        let max;
+        let sum = 0;
+        let count = 0;
+        for (const lat of this.latency.values()) {
+            const samples = lat[field];
+            for (const s of samples) {
+                if (min === undefined || s < min)
+                    min = s;
+                if (max === undefined || s > max)
+                    max = s;
+                sum += s;
+                count++;
+            }
+        }
+        if (count === 0)
+            return { min: null, max: null, avg: null, count: 0 };
+        return { min: min, max: max, avg: Math.round(sum / count), count };
+    }
     getSessionLatency(sessionId) {
         const lat = this.latency.get(sessionId);
         if (!lat)
@@ -173,17 +194,11 @@ export class MetricsCollector {
     getGlobalMetrics(activeSessionCount) {
         const avgMessages = this.global.sessionsCreated > 0
             ? Math.round(this.global.totalMessages / this.global.sessionsCreated) : 0;
-        // Issue #87: Aggregate latency across all sessions
-        const allHookLatency = [];
-        const allStateChange = [];
-        const allPermissionResponse = [];
-        const allChannelDelivery = [];
-        for (const lat of this.latency.values()) {
-            allHookLatency.push(...lat.hook_latency_ms);
-            allStateChange.push(...lat.state_change_detection_ms);
-            allPermissionResponse.push(...lat.permission_response_ms);
-            allChannelDelivery.push(...lat.channel_delivery_ms);
-        }
+        // Issue #87: Stream-aggregate latency across all sessions (no temp arrays)
+        const aggHook = this.aggregateLatencyField('hook_latency_ms');
+        const aggStateChange = this.aggregateLatencyField('state_change_detection_ms');
+        const aggPermission = this.aggregateLatencyField('permission_response_ms');
+        const aggChannel = this.aggregateLatencyField('channel_delivery_ms');
         return {
             uptime: Math.round((Date.now() - this.startTime) / 1000),
             sessions: {
@@ -207,12 +222,11 @@ export class MetricsCollector {
                 success_rate: this.global.promptsSent > 0
                     ? Math.round((this.global.promptsDelivered / this.global.promptsSent) * 100) : null,
             },
-            // Issue #87: Aggregate latency metrics
             latency: {
-                hook_latency_ms: this.summarizeSamples(allHookLatency),
-                state_change_detection_ms: this.summarizeSamples(allStateChange),
-                permission_response_ms: this.summarizeSamples(allPermissionResponse),
-                channel_delivery_ms: this.summarizeSamples(allChannelDelivery),
+                hook_latency_ms: aggHook,
+                state_change_detection_ms: aggStateChange,
+                permission_response_ms: aggPermission,
+                channel_delivery_ms: aggChannel,
             },
         };
     }
@@ -223,4 +237,3 @@ export class MetricsCollector {
         return this.global.sessionsCreated;
     }
 }
-//# sourceMappingURL=metrics.js.map

package/dist/monitor.js CHANGED Viewed

@@ -234,7 +234,7 @@ export class SessionMonitor {
                             await this.channels.statusChange(this.makePayload('status.permission_timeout', session, detail));
                         }
                         catch (e) {
-                            console.error(`Monitor: auto-reject failed for session ${session.id}: ${e.message}`);
+                            console.error(`Monitor: auto-reject failed for session ${session.id}: ${e instanceof Error ? e.message : String(e)}`);
                         }
                     }
                 }
@@ -619,4 +619,3 @@ export class SessionMonitor {
 function sleep(ms) {
     return new Promise(resolve => setTimeout(resolve, ms));
 }
-//# sourceMappingURL=monitor.js.map

package/dist/permission-guard.js CHANGED Viewed

@@ -194,4 +194,3 @@ export async function cleanOrphanedBackup(workDir, homeDir) {
         }
     }
 }
-//# sourceMappingURL=permission-guard.js.map

package/dist/pipeline.js CHANGED Viewed

@@ -220,4 +220,3 @@ export class PipelineManager {
         }
     }
 }
-//# sourceMappingURL=pipeline.js.map

package/dist/screenshot.js CHANGED Viewed

@@ -54,4 +54,3 @@ export async function captureScreenshot(opts) {
 export function isPlaywrightAvailable() {
     return playwrightAvailable;
 }
-//# sourceMappingURL=screenshot.js.map