adstxt-validator 1.2.5 → 1.2.7

package/dist/index.js

@@ -587,7 +587,8 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
     records.forEach((record) => {
         if (!record.is_valid)
             return; // Skip invalid records
-        const domain = record.domain.toLowerCase();
+        // CRITICAL FIX: Normalize domain by trimming whitespace
+        const domain = record.domain.toLowerCase().trim();
         // Initialize arrays if not exists
         if (!domainToSellerIds.has(domain)) {
             domainToSellerIds.set(domain, []);
@@ -600,6 +601,8 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
     // Batch fetch sellers for all domains
     const domainSellersMap = new Map();
     const domainMetadataMap = new Map();
+    // Track which domains actually have sellers.json (separate from whether matching sellers were found)
+    const domainHasSellersJsonMap = new Map();
     for (const [domain, sellerIds] of domainToSellerIds) {
         try {
             logger.info(`Fetching ${sellerIds.length} sellers for domain: ${domain}`);
@@ -609,8 +612,11 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
                 logger.info(`No sellers.json found for domain: ${domain}`);
                 domainSellersMap.set(domain, new Map());
                 domainMetadataMap.set(domain, {});
+                domainHasSellersJsonMap.set(domain, false);
                 continue;
             }
+            // Domain has sellers.json - record this explicitly before fetching matching sellers
+            domainHasSellersJsonMap.set(domain, true);
             // Batch fetch sellers
             const batchResult = await provider.batchGetSellers(domain, sellerIds);
             // Convert to Map for efficient lookup
@@ -628,6 +634,10 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
             logger.error(`Error fetching sellers for domain ${domain}:`, error);
             domainSellersMap.set(domain, new Map());
             domainMetadataMap.set(domain, {});
+            // On error, we can't confirm sellers.json exists
+            if (!domainHasSellersJsonMap.has(domain)) {
+                domainHasSellersJsonMap.set(domain, false);
+            }
         }
     }
     // Validate each record using the fetched data
@@ -635,10 +645,14 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
         if (!record.is_valid) {
             return record; // Skip invalid records
         }
-        const domain = record.domain.toLowerCase();
+        // CRITICAL FIX: Normalize domain by trimming whitespace (must match the same normalization as above)
+        const domain = record.domain.toLowerCase().trim();
         const sellersMap = domainSellersMap.get(domain) || new Map();
         const metadata = domainMetadataMap.get(domain) || {};
-        return await validateSingleRecordOptimized(record, publisherDomain, sellersMap, metadata, allEntries);
+        // Use explicit sellers.json existence flag to avoid false "noSellersJson" when
+        // sellers.json exists but no matching seller IDs were found
+        const hasSellersJson = domainHasSellersJsonMap.get(domain) ?? (sellersMap.size > 0 || Object.keys(metadata).length > 0);
+        return await validateSingleRecordOptimized(record, publisherDomain, sellersMap, metadata, allEntries, hasSellersJson);
     }));
     logger.info(`After optimized sellers.json validation: ${validatedRecords.length} records, ${validatedRecords.filter((r) => r.has_warning).length} with warnings`);
     return validatedRecords;
@@ -646,11 +660,15 @@ async function validateWithOptimizedProvider(publisherDomain, records, provider,
 /**
  * Validate a single record using optimized data structures
  */
-async function validateSingleRecordOptimized(record, publisherDomain, sellersMap, metadata, allEntries) {
+async function validateSingleRecordOptimized(record, publisherDomain, sellersMap, metadata, allEntries, hasSellersJson) {
     // Initialize validation result
     const validationResult = createInitialValidationResult();
-    // Check if sellers.json exists for this domain
-    validationResult.hasSellerJson = sellersMap.size > 0 || Object.keys(metadata).length > 0;
+    // Check if sellers.json exists for this domain.
+    // Use the explicit hasSellersJson flag when provided to correctly handle the case where
+    // sellers.json exists but no matching seller IDs were found (which produces an empty sellersMap).
+    validationResult.hasSellerJson = hasSellersJson !== undefined
+        ? hasSellersJson
+        : (sellersMap.size > 0 || Object.keys(metadata).length > 0);
     if (!validationResult.hasSellerJson) {
         return createWarningRecord(record, exports.VALIDATION_KEYS.NO_SELLERS_JSON, { domain: record.domain }, Severity.WARNING, { validation_results: validationResult });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "adstxt-validator",
-  "version": "1.2.5",
+  "version": "1.2.7",
   "description": "A TypeScript library for validating ads.txt files and sellers.json files",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",