ads-client 1.13.2 → 1.14.0

package/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.14.0] - 23.07.2022
+### Added
+- Created end-to-end testing for the library using Jest
+  - Separate PLC project required for testing: https://github.com/jisotalo/ads-client-test-plc-project
+  - Test is started using command `npm test`
+  - First version tests
+    - Connecting
+    - Reading
+    - Writing
+    - RPC methods
+
+### Changed
+- Bug fix: Value converted to Javascript variable incorrectly in some edge cases [See issue #94](https://github.com/jisotalo/ads-client/issues/94)
+
 ## [1.13.2] - 17.05.2022
 ### Changed
 - Bug fix: Incorrect parsing of ARRAY OF ARRAY, now works as should [See issue #91](https://github.com/jisotalo/ads-client/issues/91)

package/README.md

@@ -89,6 +89,7 @@ Check out the [node-red-contrib-ads-client](https://www.npmjs.com/package/node-r
   * [Enabling debug from code](#enabling-debug-from-code)
   * [Enabling debugging from terminal](#enabling-debugging-from-terminal)
 - [FAQ](#faq)
+- [Automatic testing](#automatic-testing)
 - [Documentation](#documentation)
 - [License](#license)
 
@@ -1755,7 +1756,12 @@ Another option is to use setting `bareClient: true` (since v.1.13.0). However, w
 
 I would suggest to use ads-client normally without any special settings. If the target is at config mode, use separate client instance to start it, and the again the normal instance to connect to a running system. This way the client works the best.
 
+# Automatic testing
+Since version 1.14.0 the library has automatic testing using Jest. Idea is to run the tests before updates to make sure everything works OK (this should have been done much earlier...)
 
+Separate PLC project is required for testing, see https://github.com/jisotalo/ads-client-test-plc-project for more project and more info.
+
+Tests are run with command `npm test` (not in npm version, please clone this repository).
 
 # Documentation
 

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "ads-client",
-  "version": "1.13.2",
+  "version": "1.14.0",
   "description": "Beckhoff TwinCAT ADS client library for Node.js (unofficial). Connects to Beckhoff TwinCAT automation systems using ADS protocol.",
   "main": "./src/ads-client.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
+    "test": "jest --runInBand",
     "generate-docs": "jsdoc ./src/ads-client.js ./README.md -c ./jsdoc-conf.json -d ./docs/ -t ./node_modules/docdash/"
   },
   "keywords": [
@@ -39,6 +39,7 @@
   },
   "devDependencies": {
     "docdash": "^1.2.0",
+    "jest": "^28.1.3",
     "jsdoc": "^3.6.7"
   },
   "files": [

package/src/ads-client.js

@@ -5230,8 +5230,8 @@ function _parseJsObjectToBuffer(value, dataType, objectPathStr = '', isArraySubI
 
   //Struct or array subitem - Go through each subitem 
   if ((dataType.arrayData.length === 0 || isArraySubItem) && dataType.subItems.length > 0) {
-    buffer = Buffer.alloc(dataType.offset + dataType.size)
-
+    buffer = Buffer.alloc(dataType.size)
+    
     for (const subItem of dataType.subItems) {
       //Try the find the subitem from javascript object
       let key = null