adelie-ai 0.3.2 → 0.3.3

package/adelie/__init__.py

@@ -12,4 +12,4 @@ def _get_version() -> str:
     except Exception:
         pass
     return "0.0.0"
-__version__ = "0.3.2"
+__version__ = "0.3.3"

package/adelie/agents/coder_ai.py

@@ -44,6 +44,41 @@ Output a single valid JSON array of files to create/update."""
 SYSTEM_PROMPT = load_prompt("coder", _FALLBACK_PROMPT)
 
 
+def _get_framework_guidelines(framework: str) -> str:
+    """Return framework-specific coding rules to inject into coder prompt."""
+    guidelines = {
+        "nextjs": (
+            "\n## ⚠️ Next.js App Router — MANDATORY Rules\n"
+            "- Any component using useState, useEffect, onClick, or other client hooks "
+            "MUST start with `'use client';` as the FIRST line.\n"
+            "- `layout.tsx` is a SERVER component — NEVER use client-side hooks, "
+            "context providers, or event handlers in it without `'use client'`.\n"
+            "- Dynamic routes use `[param]`, `[...catch]`, `[[...optional]]` syntax — "
+            "these are valid directory names.\n"
+            "- API routes go in `src/app/api/` as `route.ts` files.\n"
+            "- Use `next/navigation` (not `next/router`) for App Router.\n"
+            "- The package name for lucide icons is `lucide-react` (NOT `@lucide/react`).\n\n"
+        ),
+        "nuxt": (
+            "\n## ⚠️ Nuxt 3 — MANDATORY Rules\n"
+            "- Use `<script setup lang='ts'>` for composition API.\n"
+            "- Auto-imports: `ref`, `computed`, `useRoute` etc. are auto-imported.\n"
+            "- Pages go in `pages/`, layouts in `layouts/`.\n\n"
+        ),
+        "sveltekit": (
+            "\n## ⚠️ SvelteKit — MANDATORY Rules\n"
+            "- Pages go in `src/routes/` as `+page.svelte`.\n"
+            "- Server-only code uses `+page.server.ts` or `+server.ts`.\n"
+            "- Layouts use `+layout.svelte`.\n\n"
+        ),
+        "vite": (
+            "\n## ⚠️ Vite + React — MANDATORY Rules\n"
+            "- Entry point is `index.html` referencing `src/main.tsx`.\n"
+            "- Use `vite.config.ts` with `@vitejs/plugin-react`.\n\n"
+        ),
+    }
+    return guidelines.get(framework, "")
+
 def _get_coder_log_dir(layer: int, coder_name: str) -> Path:
     """Get or create the log directory for a coder."""
     log_dir = CODER_ROOT / "layer" / str(layer) / coder_name
@@ -174,6 +209,16 @@ def run_coder(
         f"## Lower Layer Coder Logs\n{lower_logs}\n\n"
     )
 
+    # Bug #7: Inject framework-specific coding rules to prevent common mistakes
+    try:
+        from adelie.agents.expert_ai import _detect_framework
+        fw = _detect_framework(workspace_root)
+        fw_guidelines = _get_framework_guidelines(fw)
+        if fw_guidelines:
+            user_prompt += fw_guidelines
+    except Exception:
+        pass
+
     if feedback:
         user_prompt += (
             f"## ⚠️ REVIEWER FEEDBACK (FIX THESE ISSUES)\n{feedback}\n\n"

package/adelie/agents/expert_ai.py

@@ -444,8 +444,9 @@ def _get_scaffolding_need() -> str:
         return ""
 
     lines = [
-        "⚠️ CRITICAL: The following entry files are MISSING. Without them, the build WILL FAIL.",
-        "Create a 'project_scaffolding' coder task (layer 0) to generate these BEFORE any feature tasks:",
+        "ℹ️ SCAFFOLDING NOTE: The following entry files are missing.",
+        "If no scaffolding coder has been created yet, create ONE scaffolding task (layer 0).",
+        "If scaffolding was ALREADY attempted in a previous cycle, SKIP this and focus on feature tasks:",
     ]
     for c in checks:
         lines.append(f"  - {c['file']}: {c['desc']}")

package/adelie/orchestrator.py

@@ -112,6 +112,9 @@ class Orchestrator:
         self._last_assembled_contexts: list | None = None
         self._last_build_errors: list[dict] = []
 
+        # Track coder/reviewer results for next cycle's Expert AI context (Bug #4)
+        self._last_coder_result: dict | None = None
+
         # Auto-scan: if KB is empty and project has existing code, scan first
         self._auto_scan_done = False
 
@@ -181,6 +184,10 @@ class Orchestrator:
         # Include recent build errors for Expert AI context
         if self._last_build_errors:
             state["build_errors"] = self._last_build_errors[:3]  # 최대 3개
+        # Include last cycle's coder/reviewer result so Expert AI can avoid
+        # re-issuing tasks that previously failed (Bug #4)
+        if self._last_coder_result:
+            state["last_coder_result"] = self._last_coder_result
         return state
 
     def get_agent_context(self, agent_type: AgentType | str) -> dict:
@@ -976,7 +983,10 @@ class Orchestrator:
                     )] or all_written_files
 
                     for retry in range(MAX_REVIEW_RETRIES + 1):
-                        review = run_review(coder_name=name, written_files=task_files)
+                        # Bug #6: pass STAGING_ROOT so reviewer reads files from
+                        # staging (where Coder wrote them), not PROJECT_ROOT.
+                        from adelie.agents.coder_ai import STAGING_ROOT as _REVIEW_STAGING
+                        review = run_review(coder_name=name, written_files=task_files, workspace_root=_REVIEW_STAGING)
                         score = review.get("overall_score", 5)
                         self._review_score_history.append(score)
 
@@ -1005,6 +1015,44 @@ class Orchestrator:
                 self._emit_agent_end("Reviewer", f"error: {e}")
             else:
                 self._emit_agent_end("Reviewer", "approved" if reviewer_approved else "rejected")
+
+            # Bug #3: Log review failures to KB so Expert AI avoids re-issuing
+            # the exact same task that was rejected.
+            if not reviewer_approved and all_written_files:
+                failed_files = [f.get("filepath", "") for f in all_written_files]
+                review_summary = review.get("summary", "N/A") if review else "N/A"
+                review_issues = ""
+                if review:
+                    for issue in review.get("issues", [])[:5]:
+                        review_issues += f"- [{issue.get('severity')}] {issue.get('title')}: {issue.get('suggestion', '')}\n"
+                failure_note = (
+                    f"# Review Failure Log (Cycle #{self.loop_iteration})\n\n"
+                    f"The following files were rejected by Reviewer AI after "
+                    f"{MAX_REVIEW_RETRIES + 1} attempts:\n"
+                    + "\n".join(f"- `{f}`" for f in failed_files) + "\n\n"
+                    f"**Review Summary**: {review_summary}\n\n"
+                    f"**Issues**:\n{review_issues}\n"
+                    f"Expert AI should NOT re-assign the same task until "
+                    f"the underlying issue is resolved.\n"
+                )
+                failure_path = WORKSPACE_PATH / "errors" / f"review_failure_{self.loop_iteration}.md"
+                failure_path.parent.mkdir(parents=True, exist_ok=True)
+                failure_path.write_text(failure_note, encoding="utf-8")
+                retriever.update_index(
+                    f"errors/{failure_path.name}",
+                    tags=["error", "review-failure"],
+                    summary=f"Review rejected cycle #{self.loop_iteration}: {', '.join(failed_files[:3])}",
+                )
+                console.print(f"[yellow]📝 Review failure logged to KB for Expert AI awareness[/yellow]")
+
+            # Bug #4: Record coder/reviewer results for next cycle context
+            self._last_coder_result = {
+                "cycle": self.loop_iteration,
+                "files_written": len(all_written_files),
+                "reviewer_approved": reviewer_approved,
+                "review_score": review.get("overall_score", 0) if review else 0,
+                "review_summary": review.get("summary", "")[:300] if review else "",
+            }
         elif all_written_files and self.phase != "initial":
             # Reviewer not scheduled this cycle — auto-approve staged files
             reviewer_approved = True

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "adelie-ai",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Adelie — Self-Communicating Autonomous AI Loop CLI",
   "bin": {
     "adelie": "bin/adelie.js"