addons-scanner-utils 4.11.0 → 6.2.0

package/dist/const.d.ts

@@ -1 +1 @@
-export declare const ECMA_VERSION = 12;
+export declare const ECMA_VERSION = 13;

package/dist/const.js

@@ -2,4 +2,4 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ECMA_VERSION = void 0;
 // This is the ECMAScript version officially supported by AMO.
-exports.ECMA_VERSION = 12; // a.k.a. 2021
+exports.ECMA_VERSION = 13; // a.k.a. 2022

package/dist/errors.d.ts

@@ -0,0 +1,6 @@
+export declare class InvalidZipFileError extends Error {
+    get name(): string;
+}
+export declare class DuplicateZipEntryError extends Error {
+    get name(): string;
+}

package/dist/errors.js

@@ -0,0 +1,16 @@
+"use strict";
+/* eslint-disable max-classes-per-file */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DuplicateZipEntryError = exports.InvalidZipFileError = void 0;
+class InvalidZipFileError extends Error {
+    get name() {
+        return 'InvalidZipFileError';
+    }
+}
+exports.InvalidZipFileError = InvalidZipFileError;
+class DuplicateZipEntryError extends Error {
+    get name() {
+        return 'DuplicateZipFileEntry';
+    }
+}
+exports.DuplicateZipEntryError = DuplicateZipEntryError;

package/dist/index.d.ts

@@ -2,3 +2,4 @@ export * from './const';
 export * from './functions';
 export * from './io';
 export * from './stdio';
+export * from './errors';

package/dist/index.js

@@ -14,3 +14,4 @@ __exportStar(require("./const"), exports);
 __exportStar(require("./functions"), exports);
 __exportStar(require("./io"), exports);
 __exportStar(require("./stdio"), exports);
+__exportStar(require("./errors"), exports);

package/dist/io/xpi.js

@@ -18,6 +18,7 @@ const first_chunk_stream_1 = __importDefault(require("first-chunk-stream"));
 const strip_bom_stream_1 = __importDefault(require("strip-bom-stream"));
 const common_tags_1 = require("common-tags");
 const base_1 = require("./base");
+const errors_1 = require("../errors");
 /*
  * Simple Promise wrapper for the Yauzl unzipping lib to unpack add-on .xpis.
  *
@@ -43,7 +44,17 @@ class Xpi extends base_1.IOBase {
                 resolve(this.zipfile);
                 return;
             }
-            this.zipLib.open(this.path, { autoClose: this.autoClose }, (err, zipfile) => {
+            this.zipLib.open(this.path, {
+                autoClose: this.autoClose,
+                // Enable checks on invalid chars in zip entries filenames.
+                strictFileNames: true,
+                // Decode automatically filenames and zip entries content from buffer into strings
+                // and autodetects their encoding.
+                //
+                // NOTE: this is also mandatory because without this option set to true
+                // strictFileNames option is ignored.
+                decodeStrings: true,
+            }, (err, zipfile) => {
                 if (err) {
                     return reject(err);
                 }
@@ -63,8 +74,8 @@ class Xpi extends base_1.IOBase {
         if (this.entries.includes(entry.fileName)) {
             this.stderr.info((0, common_tags_1.oneLine) `found duplicate file entry: "${entry.fileName}"
         in package`);
-            reject(new Error((0, common_tags_1.oneLine) `DuplicateZipEntry: Entry
-        "${entry.fileName}" has already been seen`));
+            reject(new errors_1.DuplicateZipEntryError((0, common_tags_1.oneLine) `Entry "${entry.fileName}" has already
+          been seen`));
             return;
         }
         this.entries.push(entry.fileName);
@@ -88,6 +99,9 @@ class Xpi extends base_1.IOBase {
             }
             const zipfile = yield this.open();
             return new Promise((resolve, reject) => {
+                zipfile.on('error', (err) => {
+                    reject(new errors_1.InvalidZipFileError(err.message));
+                });
                 zipfile.on('entry', (entry) => {
                     this.handleEntry(entry, reject);
                 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "addons-scanner-utils",
-  "version": "4.11.0",
+  "version": "6.2.0",
   "description": "Various addons related helpers to build CLIs.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -11,7 +11,7 @@
   "license": "MPL-2.0",
   "dependencies": {
     "@types/yauzl": "2.9.2",
-    "common-tags": "1.8.0",
+    "common-tags": "1.8.2",
     "first-chunk-stream": "3.0.0",
     "strip-bom-stream": "4.0.0",
     "upath": "2.0.1",
@@ -33,21 +33,20 @@
     "@types/safe-compare": "^1.1.0",
     "@types/sinon": "^10.0.0",
     "@types/supertest": "^2.0.8",
-    "@typescript-eslint/eslint-plugin": "^4.0.0",
-    "@typescript-eslint/parser": "^4.0.0",
+    "@typescript-eslint/eslint-plugin": "^5.0.0",
+    "@typescript-eslint/parser": "^5.0.0",
     "body-parser": "1.19.0",
-    "codecov": "^3.5.0",
     "download": "8.0.0",
-    "eslint": "^7.23.0",
-    "eslint-config-amo": "^4.0.0",
+    "eslint": "^8.1.0",
+    "eslint-config-amo": "^5.0.0",
     "eslint-plugin-amo": "^1.10.2",
     "express": "4.17.1",
     "jest": "^27.0.0",
-    "prettier": "2.4.1",
+    "prettier": "2.5.1",
     "pretty-quick": "^3.0.0",
     "rimraf": "^3.0.0",
     "safe-compare": "1.1.4",
-    "sinon": "^11.0.0",
+    "sinon": "^12.0.0",
     "supertest": "^6.0.0",
     "ts-jest": "^27.0.0",
     "type-coverage": "^2.3.0",
@@ -61,7 +60,7 @@
     "prettier-ci": "prettier --list-different '**' || (echo '\n\nThis failure means you did not run `yarn prettier-dev` before committing\n\n' && exit 1)",
     "prettier-dev": "pretty-quick --branch master",
     "test": "jest",
-    "test-ci": "yarn test --coverage && codecov",
+    "test-ci": "yarn test --coverage",
     "type-coverage": "type-coverage",
     "typecheck": "tsc --noEmit"
   },