adapt-authoring-docs 1.3.0 → 1.3.1

package/docsify/docsify.js

@@ -23,7 +23,7 @@ function generateSectionTitle (sectionName) {
 export default async function docsify (app, configs, outputdir, defaultPages) {
   const dir = path.resolve(outputdir, 'manual')
   const sectionsConf = app.config.get('adapt-authoring-docs.manualSections')
-  const defaultSection = Object.entries(sectionsConf).reduce((m, [id, data]) => data.default ? id : m)
+  const defaultSection = Object.entries(sectionsConf).find(([, data]) => data.default)?.[0]
   /**
    * init docsify folder
    */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "adapt-authoring-docs",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Tools for auto-generating documentation for the Adapt authoring tool",
   "homepage": "https://github.com/adapt-security/adapt-authoring-docs",
   "license": "GPL-3.0",

package/tests/docsify.spec.js

@@ -205,18 +205,7 @@ describe('docsify', () => {
   })
 
   describe('bugs', () => {
-    it('TODO: defaultSection reduce with single entry returns array tuple instead of string', async () => {
-      // BUG: In docsify.js line 26, Object.entries(sectionsConf).reduce((m, [id, data]) => ...)
-      // has no initial value. When there is only one section entry, reduce() returns
-      // the entry itself (an [id, data] array) without calling the callback.
-      // This causes generateSectionTitle to fail with:
-      //   TypeError: sectionName.slice(...).replaceAll is not a function
-      // because sectionName is an array, not a string.
-      //
-      // To fix: add an initial value to reduce, e.g.:
-      //   Object.entries(sectionsConf).reduce((m, [id, data]) => data.default ? id : m, undefined)
-      // or use Array.find instead:
-      //   Object.entries(sectionsConf).find(([, data]) => data.default)?.[0]
+    it('defaultSection reduce with single entry returns string section name', async () => {
       tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'docsify-test-'))
       const outputDir = tmpDir
       const docsSrcDir = await fs.mkdtemp(path.join(os.tmpdir(), 'docsify-src-'))
@@ -238,10 +227,8 @@ describe('docsify', () => {
       }]
 
       const { default: docsify } = await import('../docsify/docsify.js')
-      // This should work but fails due to the bug described above
-      await assert.rejects(
-        () => docsify(mockApp, configs, outputDir, {}),
-        TypeError
+      await assert.doesNotReject(
+        () => docsify(mockApp, configs, outputDir, {})
       )
 
       await fs.rm(docsSrcDir, { recursive: true, force: true })