adapt-authoring-courseassets 1.4.1 → 1.4.3

package/lib/courseassetsModule.js

@@ -68,20 +68,32 @@ class CourseAssetsModule extends AbstractApiModule {
     if (!contentId || !courseId) {
       return
     }
-    // delete any existing course assets for content
-    await this.deleteMany({ courseId, contentId })
-
     const data = isModify ? arg2 : arg1
     const schema = await this.content.getSchema(this.content.schemaName, data)
     const ids = extractAssetIds(schema.built.properties, data)
 
+    if (isModify) {
+      const existing = await this.find({ courseId, contentId })
+      const existingIds = existing.map(r => r.assetId.toString()).sort()
+      if (ids.length === existingIds.length && ids.slice().sort().every((id, i) => id === existingIds[i])) {
+        return
+      }
+    }
+    // delete any existing course assets for content
+    await this.deleteMany({ courseId, contentId })
+
     if (!ids.length) {
       return
     }
-    await Promise.all(ids.map(async _id => {
-      const asset = await this.assets.findOne({ _id })
-      await this.insert({ courseId, contentId, assetId: _id })
-    }))
+    const found = await this.assets.find({ _id: { $in: ids } })
+    const foundIds = new Set(found.map(a => a._id.toString()))
+    const validIds = ids.filter(id => foundIds.has(id))
+
+    if (validIds.length) {
+      const mongodb = await this.app.waitForModule('mongodb')
+      const docs = validIds.map(assetId => ({ courseId, contentId, assetId }))
+      await mongodb.getCollection(this.collectionName).insertMany(docs)
+    }
     this.log('debug', 'UPDATE', courseId, contentId)
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "adapt-authoring-courseassets",
-  "version": "1.4.1",
+  "version": "1.4.3",
   "description": "Module for managing course asset usage",
   "homepage": "https://github.com/adapt-security/adapt-authoring-courseassets",
   "license": "GPL-3.0",