adapt-authoring-api 1.2.0 → 1.3.1

package/.github/workflows/releases.yml

@@ -3,10 +3,16 @@ on:
   push:
     branches:
       - master
+
 jobs:
   release:
     name: Release
     runs-on: ubuntu-latest
+    permissions:
+      contents: write # to be able to publish a GitHub release
+      issues: write # to be able to comment on released issues
+      pull-requests: write # to be able to comment on released pull requests
+      id-token: write # to enable use of OIDC for trusted publishing and npm provenance
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -16,10 +22,11 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 'lts/*'
+      - name: Update npm
+        run: npm install -g npm@latest
       - name: Install dependencies
         run: npm ci
       - name: Release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ secrets.AAT_NPM_TOKEN }}
-        run: npx semantic-release
+        run: npx semantic-release

package/lib/AbstractApiModule.js

@@ -514,13 +514,15 @@ class AbstractApiModule extends AbstractModule {
    * @return {Promise} Rejects if access should be blocked
    */
   async checkAccess (req, data) {
+    if (req.auth.isSuper) {
+      return data
+    }
     const isArray = Array.isArray(data)
     const filtered = []
     let error
     await Promise.allSettled((isArray ? data : [data]).map(async r => {
       try {
-        if (!this.accessCheckHook.hasObservers || req.auth.isSuper ||
-          (await this.accessCheckHook.invoke(req, r)).some(Boolean)) {
+        if (!this.accessCheckHook.hasObservers || (await this.accessCheckHook.invoke(req, r)).some(Boolean)) {
           filtered.push(r)
         }
       } catch (e) {
@@ -573,11 +575,14 @@ class AbstractApiModule extends AbstractModule {
    * @param {external:MongoDBFindOptions} mongoOptions Options to be passed to the MongoDB function
    * @return {Promise} Resolves with the single DB document
    */
-  async findOne (query, options, mongoOptions) {
+  async findOne (query, options = {}, mongoOptions = {}) {
     const results = await this.find(query, options, mongoOptions)
     if (results.length > 1) {
       throw this.app.errors.TOO_MANY_RESULTS.setData({ actual: results.length, expected: 1, query })
     }
+    if (options.strict !== false && !results.length) {
+      throw this.app.errors.NOT_FOUND.setData({ id: query, type: options.schemaName })
+    }
     return results[0]
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "adapt-authoring-api",
-  "version": "1.2.0",
+  "version": "1.3.1",
   "description": "Abstract module for creating APIs",
   "homepage": "https://github.com/adapt-security/adapt-authoring-api",
   "license": "GPL-3.0",
@@ -17,15 +17,15 @@
     "adapt-authoring-mongodb": "github:adapt-security/adapt-authoring-mongodb"
   },
   "devDependencies": {
-    "standard": "^17.1.0",
-    "@semantic-release/commit-analyzer": "^9.0.2",
+    "@semantic-release/commit-analyzer": "^13.0.1",
     "@semantic-release/git": "^10.0.1",
-    "@semantic-release/github": "^8.0.5",
-    "@semantic-release/npm": "^9.0.1",
-    "@semantic-release/release-notes-generator": "^10.0.3",
-    "conventional-changelog-eslint": "^3.0.9",
-    "semantic-release": "^21.0.1",
-    "semantic-release-replace-plugin": "^1.2.7"
+    "@semantic-release/github": "^12.0.2",
+    "@semantic-release/npm": "^13.1.2",
+    "@semantic-release/release-notes-generator": "^14.1.0",
+    "conventional-changelog-eslint": "^6.0.0",
+    "semantic-release": "^25.0.2",
+    "semantic-release-replace-plugin": "^1.2.7",
+    "standard": "^17.1.0"
   },
   "release": {
     "plugins": [