ad2app-lib 1.36.0 → 1.37.0

package/dist/analytics/index.d.ts

@@ -254,7 +254,7 @@ export interface EventProperties {
         role: string;
     };
     [EVENTS.LOGGED_IN]: {
-        method?: 'email' | 'google';
+        method?: 'email' | 'google' | 'apple';
     };
     [EVENTS.SOCIAL_ACCOUNT_CONNECTED]: {
         platform: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ad2app-lib",
-  "version": "1.36.0",
+  "version": "1.37.0",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "type": "commonjs",

package/src/analytics/index.test.ts

@@ -86,7 +86,9 @@ const EVENT_PROPERTY_WITNESS: { [E in keyof EventProperties]: EventProperties[E]
   [EVENTS.PLAYBOOK_DOWNLOADED]: {},
   [EVENTS.SIGNED_UP]: { method: "email", role: "creator" },
   [EVENTS.PROFILE_COMPLETED]: { role: "creator" },
-  [EVENTS.LOGGED_IN]: {},
+  // Spec 161 T010: proves 'apple' type-checks alongside the pre-existing
+  // 'email' | 'google' union (compile-time, enforced by `tsc --noEmit`).
+  [EVENTS.LOGGED_IN]: { method: "apple" },
   [EVENTS.SOCIAL_ACCOUNT_CONNECTED]: { platform: "instagram" },
   [EVENTS.COMPOSE_STARTED]: {},
   [EVENTS.COMPOSE_STEP_VIEWED]: { step: "content" },
@@ -489,6 +491,17 @@ test("159 native_session_renewed carries no properties (the fact of the renewal
   assert.deepEqual(renewed, {});
 });
 
+test("161 logged_in.method accepts all three sign-in methods, and stays optional", () => {
+  const email: EventProperties[typeof EVENTS.LOGGED_IN] = { method: "email" };
+  const google: EventProperties[typeof EVENTS.LOGGED_IN] = { method: "google" };
+  const apple: EventProperties[typeof EVENTS.LOGGED_IN] = { method: "apple" };
+  const unset: EventProperties[typeof EVENTS.LOGGED_IN] = {};
+  assert.equal(email.method, "email");
+  assert.equal(google.method, "google");
+  assert.equal(apple.method, "apple");
+  assert.deepEqual(unset, {});
+});
+
 test("159 LAUNCH_CONTEXT_PROPS governs the build-attribution key (no raw 'app_build' string at the call site)", () => {
   assert.equal(LAUNCH_CONTEXT_PROPS.APP_BUILD, "app_build");
 });

package/src/analytics/index.ts

@@ -341,7 +341,11 @@ export interface EventProperties {
   [EVENTS.PLAYBOOK_DOWNLOADED]: { edition_version?: string; format?: string };
   [EVENTS.SIGNED_UP]: { method: 'email' | 'google'; role: string };
   [EVENTS.PROFILE_COMPLETED]: { role: string };
-  [EVENTS.LOGGED_IN]: { method?: 'email' | 'google' };
+  // Spec 161: widened to include 'apple' — the value was already missing from
+  // this union (Google/email only) even though native Apple sign-in has
+  // existed since spec 136; this closes that gap rather than inventing a new
+  // property.
+  [EVENTS.LOGGED_IN]: { method?: 'email' | 'google' | 'apple' };
   [EVENTS.SOCIAL_ACCOUNT_CONNECTED]: {
     platform: string;
     account_count?: number;