acuvo-code 0.4.0 → 0.4.2

package/lib/input-box.mjs

@@ -67,7 +67,20 @@ export function visibleWidth(s) {
  * @returns {{lines: string[], cursorColumn: number}} 1-based cursor column
  */
 export function renderBox({ value = '', cursor = 0, columns = 80, prompt = '› ' } = {}) {
-  const width = Math.max(20, Math.min(100, columns - 1));
+  /**
+   * ── ⚠️ FULL WIDTH. THE 100-COLUMN CAP WAS WRONG AND IT LOOKED WRONG ────────
+   *
+   * Roman, from a screenshot: *"ours isn't the entire width."* In a ~200-column
+   * terminal a 100-column box reads as a half-finished element rather than as a
+   * deliberate measure — it is the input, and the input should be as wide as the
+   * place you are typing.
+   *
+   * ⚠️ `columns - 1`, NOT `columns`. A box drawn to the very last column makes
+   * many terminals wrap to the next row the moment the final border character is
+   * written, which pushes everything down by one and breaks the cursor
+   * arithmetic for the rest of the session.
+   */
+  const width = Math.max(20, columns - 1);
   const inner = width - 2;
   const promptWidth = visibleWidth(prompt);
 
@@ -213,10 +226,37 @@ export function splitKeys(chunk) {
  */
 export function paint(output, state, { first = false } = {}) {
   const { lines, cursorColumn } = renderBox(state);
-  const up = first ? '' : `${CSI}3A`;
+
+  /**
+   * ── ⚠️⚠️ THE CURSOR MATH, AND MY FIRST VERSION ATE THE SCREEN ──────────────
+   *
+   * Roman: *"it moves upwards every time you type a character then deletes the
+   * design you did."* Exactly right, and the arithmetic says why.
+   *
+   * After a paint the cursor rests on the INPUT line — line 2 of 3, not below
+   * the box. The first version began each repaint with `ESC[3A`, which is where
+   * it would be if the cursor were below. From line 2, moving up 3 lands ONE
+   * LINE ABOVE the top border — and the `ESC[0J` that follows clears from there
+   * to the bottom of the screen. So every keystroke crept upward and erased
+   * another line of the banner.
+   *
+   * ⭐ THE INVARIANT, WRITTEN DOWN BECAUSE IT IS THE WHOLE FUNCTION: this
+   * routine ENTERS with the cursor on the input line and LEAVES it there. So a
+   * repaint moves up exactly ONE line to reach the top border, and the final
+   * reposition moves up exactly one from the last line written.
+   *
+   *   ╭────────╮   <- line 1   ESC[1A from the input line reaches here
+   *   │› …      │   <- line 2   cursor lives here, in and out
+   *   ╰────────╯   <- line 3   cursor is here after writing; ESC[1A returns
+   *
+   * ⚠️ NO TRAILING NEWLINE. Writing one after the last border scrolls the
+   * viewport when the box is at the bottom of the screen, and every subsequent
+   * `up` is then off by a row for the rest of the session.
+   */
+  const home = first ? '' : `\r${CSI}1A`;
   output.write(
-    `${CSI}?25l${up}\r${CSI}0J${lines.join('\n')}\n` +
-    `${CSI}2A\r${CSI}${cursorColumn}G${CSI}?25h`,
+    `${CSI}?25l${home}${CSI}0J${lines.join('\n')}` +
+    `${CSI}1A\r${CSI}${cursorColumn}G${CSI}?25h`,
   );
 }
 
@@ -247,7 +287,19 @@ export function readBoxedLine({ input, output, history = [], onInterrupt = null,
       input.off('data', onData);
       input.off('end', onEnd);
       try { input.setRawMode?.(false); } catch { /* not a TTY any more */ }
-      output.write('\n');
+      /**
+       * ── ⚠️⚠️ MOVE BELOW THE BOX BEFORE ANYTHING ELSE WRITES ─────────────────
+       *
+       * Seen in a screenshot: an MCP warning printed straight ON TOP of the
+       * bottom border, which was left visible only where the message was
+       * shorter than the box.
+       *
+       * The cursor rests on the INPUT line — line 2 of 3. A bare `\n` moves it
+       * to line 3, which IS the bottom border, so the very next thing anyone
+       * writes overwrites it. Down one FIRST, then a newline, so the cursor
+       * lands on fresh ground below a box that stays intact.
+       */
+      output.write(`${CSI}1B\n`);
       resolve({ value, reason });
     };