acstack 0.48.2 → 0.48.3

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "acstack",
   "description": "Agentic coding stack where planning grows only as far as needed: a map of decisions, tasks, checks, and handoffs behind a pluggable tracker.",
-  "version": "0.48.2",
+  "version": "0.48.3",
   "author": {
     "name": "ac8318740"
   },

package/README.md

@@ -101,9 +101,10 @@ Then, in your project, run `/acstack:setup`.
     ```
 
     - Set `"toolActivation": "eager"` in `~/.pi/agent/extensions/subagent/config.json` to offer the `subagent` tool from the first turn (restart pi after)
-- pi has no output styles, so the writing style is a toggle
-    - Run `/acstack-writing-style on` to add it to every pi session
-    - Run `/acstack-writing-style off` to remove it
+- pi gets the ACStack writing style from the extension by default
+    - Run `/acstack-writing-style default` to use the bundled style again
+    - Run `/acstack-writing-style off` to disable style injection
+    - Run `/acstack-writing-style custom <path>` to use a user-owned style file
 
 ## 2. The three commands, and which one to use
 

package/assets/terminal-workspace/config.example.yaml

@@ -217,7 +217,10 @@ pi:
   # markdown, code and artifact previews beside a decision, accepts freeform
   # answers and notes, and does not require a full-event telemetry env var.
   question_tool: true
-  # rpiv-todo, which adds a todo tool to pi.
+  # rpiv-todo, which adds a todo tool to pi. When this is on, apply also
+  # suggests a line for the user's global ~/.pi/agent/AGENTS.md if their Pi
+  # context file does not already mention todo discipline. It never edits that
+  # user-owned file for them.
   todo: true
   # pi-plugin-manager, which adds pi plugin management commands.
   plugin_manager: true

package/assets/terminal-workspace/setup.sh

@@ -3886,6 +3886,17 @@ pi_npm_pin() {  # pi_npm_pin <name>
   [ "$src" != "npm:$1" ]
 }
 
+pi_suggest_todo_discipline() {
+  local needle="When using a todo list, keep it current as work completes."
+  grep -qsF "$needle" "$PI_DIR"/AGENTS.override.md "$PI_DIR"/AGENTS.md "$PI_DIR"/AGENTS.MD \
+    "$PI_DIR"/CLAUDE.md "$PI_DIR"/CLAUDE.MD && return 0
+  say "pi: todo tool installed. For stricter todo discipline, ask the agent"
+  say "pi: running this setup to hand-edit $PI_DIR/AGENTS.md and add:"
+  say "pi: $needle Before reporting a task as done, check the todo list"
+  say "pi: and mark every completed step completed. Do not leave stale"
+  say "pi: in-progress or pending todos after a commit, PR, merge or workflow gate."
+}
+
 # The pin apply would move to, or nothing when the installed one is current
 # or newer. A newer pin is one the user chose, so it is never moved back.
 pi_acstack_behind() {
@@ -3977,6 +3988,7 @@ apply_pi() {
   pi_add npm:pi-subagents npm:pi-subagents
   if [ "$(cfg_get pi.todo true)" = "true" ]; then
     pi_add npm:@juicesharp/rpiv-todo npm:@juicesharp/rpiv-todo
+    pi_suggest_todo_discipline
   else
     pi_drop npm:@juicesharp/rpiv-todo
   fi

package/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "acstack-cli",
-  "version": "0.48.2",
+  "version": "0.48.3",
   "description": "CLI for the ACStack agentic coding stack",
   "type": "module",
   "license": "MIT",

package/docs/terminal-workspace.md

@@ -359,6 +359,7 @@ What `apply` does:
     - Setup leaves Claude Code and Codex alone, and removes bili from them if an older setup added it
     - Set `pi.billion_context: false` to leave it out, or to remove it later if this setup installed it
 - It installs `@juicesharp/rpiv-todo` and `pi-plugin-manager` by default
+    - When todo is on, `apply` suggests a todo-discipline line for the user's global Pi context file if it is missing
     - Set `pi.todo: false` or `pi.plugin_manager: false` to leave either package out
 - It installs `@juicesharp/rpiv-ask-user-question` as pi's question tool by default
     - ACStack uses it because decisions can include markdown, code and artifact previews

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "acstack",
-  "version": "0.48.2",
+  "version": "0.48.3",
   "private": false,
   "description": "Agentic coding stack with first-class Claude Code and pi support: skills, orchestrator instructions, and verification agents.",
   "license": "MIT",

package/pi/extension.ts

@@ -10,8 +10,8 @@
  *   before_agent_start   list ACStack's skills in the system prompt in every
  *                        session, and add orchestrator/AGENTS.md in a
  *                        acstack project            (hooks/session-start.sh)
- *                        add the writing style and its per-turn reminder when
- *                        the user turned it on      (hooks/ac-writing-style-reminder.sh)
+ *                        add the writing style and its per-turn reminder
+ *                        from the SSOT style file   (hooks/ac-writing-style-reminder.sh)
  *   agent_before_settle  nudge with a continuity-versus-freshness checkpoint
  *                        as context fills          (hooks/context-pressure.sh)
  *   session_compact      re-inject acstack/HANDOFF.md after a compaction, and
@@ -19,9 +19,9 @@
  *                                                    hooks/context-pressure.sh)
  *
  * It also registers /acstack <skill>, a /acstack:<skill> command per skill,
- * and /acstack-writing-style on|off. Those two forms are the only way a user
- * runs an ACStack skill on pi: package.json lists no skills, so pi adds no
- * /skill:<name> commands for them.
+ * and /acstack-writing-style for the bundled/default/custom style choice.
+ * The first two forms are the only way a user runs an ACStack skill on pi:
+ * package.json lists no skills, so pi adds no /skill:<name> commands for them.
  *
  * Only type imports come from pi, so Node can strip the types and load this
  * file in tests/test-pi-extension.sh with a stub API.
@@ -45,6 +45,12 @@ function agentDir(): string {
 	return process.env.PI_CODING_AGENT_DIR || path.join(os.homedir(), ".pi", "agent");
 }
 
+const settingsFile = (): string => path.join(agentDir(), "acstack.json");
+
+type WritingStyleMode = "default" | "off" | "custom";
+type WritingStyleSettings = { mode?: WritingStyleMode; path?: string };
+type AcstackSettings = { writingStyle?: boolean | WritingStyleSettings };
+
 function readText(file: string): string | undefined {
 	try {
 		return fs.readFileSync(file, "utf-8");
@@ -53,6 +59,34 @@ function readText(file: string): string | undefined {
 	}
 }
 
+function readSettings(): AcstackSettings {
+	try {
+		const parsed = JSON.parse(readText(settingsFile()) ?? "{}");
+		return parsed && typeof parsed === "object" ? parsed : {};
+	} catch {
+		return {};
+	}
+}
+
+function writeSettings(settings: AcstackSettings): void {
+	fs.mkdirSync(path.dirname(settingsFile()), { recursive: true });
+	fs.writeFileSync(settingsFile(), `${JSON.stringify(settings, null, 2)}\n`, "utf-8");
+}
+
+function writingStyleSettings(settings: AcstackSettings = readSettings()): WritingStyleSettings {
+	const value = settings.writingStyle;
+	if (value === false) return { mode: "off" };
+	if (value === true || value === undefined) return { mode: "default" };
+	if (value && typeof value === "object") return { mode: value.mode ?? "default", path: value.path };
+	return { mode: "default" };
+}
+
+function expandUserPath(file: string, cwd = process.cwd()): string {
+	if (file === "~") return os.homedir();
+	if (file.startsWith(`~${path.sep}`)) return path.join(os.homedir(), file.slice(2));
+	return path.isAbsolute(file) ? file : path.resolve(cwd, file);
+}
+
 function report(ctx: ExtensionContext, message: string, level: "info" | "warning" | "error" = "info"): void {
 	if (ctx.hasUI) ctx.ui.notify(message, level);
 	else process.stderr.write(`${message}\n`);
@@ -172,22 +206,6 @@ function linkClis(ctx: ExtensionContext): void {
 // Writing style
 // --------------------------------------------------------------------------
 
-const settingsFile = (): string => path.join(agentDir(), "acstack.json");
-
-function readSettings(): { writingStyle?: boolean } {
-	try {
-		const parsed = JSON.parse(readText(settingsFile()) ?? "{}");
-		return parsed && typeof parsed === "object" ? parsed : {};
-	} catch {
-		return {};
-	}
-}
-
-function writeSettings(settings: { writingStyle?: boolean }): void {
-	fs.mkdirSync(path.dirname(settingsFile()), { recursive: true });
-	fs.writeFileSync(settingsFile(), `${JSON.stringify(settings, null, 2)}\n`, "utf-8");
-}
-
 function stripFrontmatter(text: string): string {
 	const match = /^---\n[\s\S]*?\n---\n/.exec(text);
 	return (match ? text.slice(match[0].length) : text).trim();
@@ -616,10 +634,16 @@ export default function acstack(pi: ExtensionAPI): void {
 			else report(ctx, `acstack: could not read ${orchestratorFile}`, "warning");
 		}
 
-		if (!readSettings().writingStyle) return;
-		const style = readText(styleFile);
-		if (!style) return;
+		const styleCfg = writingStyleSettings();
+		if (styleCfg.mode === "off") return;
+		const resolvedStyleFile = styleCfg.mode === "custom" && styleCfg.path ? expandUserPath(styleCfg.path) : styleFile;
+		const style = readText(resolvedStyleFile);
+		if (!style) {
+			report(ctx, `acstack: could not read writing style at ${resolvedStyleFile}`, "warning");
+			return;
+		}
 		sections["acstack-writing-style"] = stripFrontmatter(style);
+		if (event.messageType !== "user") return;
 		const reminder = extractWritingReminder(style);
 		if (!reminder) return;
 		return { message: { customType: "acstack-writing-style-reminder", content: reminder, display: false } };
@@ -686,6 +710,44 @@ export default function acstack(pi: ExtensionAPI): void {
 		else pi.sendUserMessage(message, { deliverAs: "followUp" });
 	};
 
+	pi.registerCommand("acstack-writing-style", {
+		description: "Configure ACStack writing style injection: default | off | custom <path>",
+		handler: async (args, ctx) => {
+			const [choice = "", ...rest] = args.trim().split(/\s+/).filter(Boolean);
+			const settings = readSettings();
+			const current = writingStyleSettings(settings);
+			if (!choice || choice === "show") {
+				report(ctx, `acstack: writing style is ${current.mode}${current.path ? ` (${current.path})` : ""} (${settingsFile()}).`);
+				return;
+			}
+			if (choice === "default") {
+				settings.writingStyle = { mode: "default" };
+				writeSettings(settings);
+				report(ctx, `acstack: writing style is default (${settingsFile()}).`);
+				return;
+			}
+			if (choice === "off") {
+				settings.writingStyle = { mode: "off" };
+				writeSettings(settings);
+				report(ctx, `acstack: writing style is off (${settingsFile()}).`);
+				return;
+			}
+			if (choice === "custom") {
+				const customPath = rest.join(" ").trim();
+				if (!customPath) {
+					report(ctx, "acstack: usage is /acstack-writing-style custom <path>", "warning");
+					return;
+				}
+				const resolvedPath = expandUserPath(customPath, ctx.cwd);
+				settings.writingStyle = { mode: "custom", path: resolvedPath };
+				writeSettings(settings);
+				report(ctx, `acstack: writing style is custom (${resolvedPath}) (${settingsFile()}).`);
+				return;
+			}
+			report(ctx, "acstack: usage is /acstack-writing-style [show|default|off|custom <path>]", "warning");
+		},
+	});
+
 	pi.registerCommand("acstack", {
 		description: "Run an ACStack skill: /acstack <skill> [args], e.g. /acstack map",
 		handler: async (args, ctx) => {
@@ -704,20 +766,4 @@ export default function acstack(pi: ExtensionAPI): void {
 			handler: async (args, ctx) => runSkill(name, args, ctx),
 		});
 	}
-
-	pi.registerCommand("acstack-writing-style", {
-		description: "Turn the ACStack writing style on or off for every pi session (on | off)",
-		handler: async (args, ctx) => {
-			const choice = args.trim().toLowerCase();
-			const settings = readSettings();
-			if (choice === "on" || choice === "off") {
-				settings.writingStyle = choice === "on";
-				writeSettings(settings);
-			} else if (choice) {
-				report(ctx, "acstack: usage is /acstack-writing-style on|off", "warning");
-				return;
-			}
-			report(ctx, `acstack: writing style is ${settings.writingStyle ? "on" : "off"} (${settingsFile()}).`);
-		},
-	});
 }