acp-vscode 0.3.3 → 0.3.9

package/.github/copilot-instructions.md

@@ -0,0 +1,80 @@
+# Copilot Instructions for acp-vscode
+
+These instructions guide AI assistants (like GitHub Copilot) in maintaining code quality and best practices for the acp-vscode project.
+
+## Quality Checks
+
+After making any major changes to the codebase, **you must run the quality checks script and ensure all checks pass**:
+
+```bash
+./scripts/quality-checks.sh
+```
+
+This script runs:
+- **ESLint** - Validates code style and best practices
+- **Jest Tests** - Ensures all unit tests pass
+- **package.json Validation** - Verifies the package configuration is valid
+
+### When to Run Quality Checks
+
+Run quality checks after:
+- Implementing new features
+- Fixing bugs
+- Refactoring code
+- Adding or modifying tests
+- Updating dependencies
+- Making any changes to source files
+
+### Fixing Quality Check Failures
+
+If any quality check fails:
+
+1. **Read the error output carefully** - Identify the specific files and line numbers that failed
+2. **Fix the issues incrementally** - Make small, focused changes to address each failure
+3. **Re-run the quality checks** - After each fix, run the quality checks again to verify the change
+4. **Iterate until all checks pass** - Continue fixing and testing until `./scripts/quality-checks.sh` exits with code 0
+
+### ESLint Failures
+
+If ESLint fails:
+- Review the linting rules in the project configuration
+- Fix code style issues (indentation, spacing, naming conventions)
+- Follow the existing code style patterns in the codebase
+- Many ESLint errors can be automatically fixed with: `npm run lint -- --fix`
+
+### Jest Test Failures
+
+If tests fail:
+- Run the test suite with: `npm test`
+- Review the test output to understand what assertions failed
+- Update or add tests to cover the new code
+- Ensure backward compatibility with existing tests
+- Do not disable or skip tests to make them pass
+
+## Code Quality Standards
+
+### Guidelines
+
+- **Consistency** - Follow the existing code style and patterns in the codebase
+- **Testing** - All new features should have corresponding tests
+- **Documentation** - Update README.md and other documentation as needed
+- **Git Hygiene** - Make atomic, well-described commits
+
+### Before Submitting Changes
+
+1. Run `./scripts/quality-checks.sh` and ensure all checks pass
+2. Verify no new warnings or errors were introduced
+3. Test the changes manually if applicable
+4. Review the changes for clarity and correctness
+
+## References
+
+- CI/CD Pipeline: [.github/workflows/ci.yml](./workflows/ci.yml)
+- Release Process: [scripts/release.sh](../scripts/release.sh)
+- Quality Checks: [scripts/quality-checks.sh](../scripts/quality-checks.sh)
+
+## Related Configuration Files
+
+- [package.json](../../package.json) - Project metadata and scripts
+- [jest.config.cjs](../../jest.config.cjs) - Jest test configuration
+- [.eslintrc or similar]() - ESLint configuration (if present)

package/.github/workflows/ci.yml

@@ -17,5 +17,7 @@ jobs:
           node-version: '20'
       - name: Install dependencies
         run: npm ci
+      - name: Run linting
+        run: npm run lint
       - name: Run tests
         run: npm test

package/.github/workflows/release.yml

@@ -5,9 +5,9 @@ name: Release
 #   Then push the tag: `git push --follow-tags` (or `git push origin vX.Y.Z`).
 # - Alternatively, use a release manager like `semantic-release` to automate versioning and changelogs.
 # - This workflow runs when a tag matching `v*.*.*` is pushed. Ensure you create/tag using the v-prefixed semver format.
-# - Secrets required:
-#   - `NPM_TOKEN` (used for npm publish)
-#   - The default `GITHUB_TOKEN` is provided automatically by Actions for creating releases.
+# - This workflow uses Trusted Publishing (OIDC) for npm - no NPM_TOKEN secret needed!
+# - Provenance attestations are automatically generated when using trusted publishing.
+# - The default `GITHUB_TOKEN` is provided automatically by Actions for creating releases.
 
 on:
   push:
@@ -21,6 +21,8 @@ jobs:
     permissions:
       contents: write # needed to create a release
       packages: write # not strictly required for npm but useful if you use GitHub Packages
+      id-token: write  # Required for OIDC
+
     steps:
       # Fetch full history so tags and changelog generation work correctly
       - uses: actions/checkout@v4
@@ -29,15 +31,17 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
           registry-url: 'https://registry.npmjs.org'
+      - name: Upgrade npm for trusted publishing
+        run: npm install -g npm@latest
       - name: Install
         run: npm ci
+      - name: Run linting
+        run: npm run lint
       - name: Run tests
         run: npm test
       - name: Publish to npm
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: npm publish
       - name: Create GitHub Release
         # Create a GitHub Release for the pushed tag. Uses the git ref by default.

package/README.md

@@ -1,6 +1,6 @@
 # acp-vscode
 
-acp-vscode is a small CLI to fetch and install chatmodes, prompts and instructions from the GitHub "awesome-copilot" repository into your VS Code workspace or VS Code User profile.
+acp-vscode is a small CLI to fetch and install agents, prompts, instructions and skills from the GitHub "awesome-copilot" repository into your VS Code workspace or VS Code User profile.
 
 Install (when published):
 
@@ -14,9 +14,9 @@ Commands:
 - install <workspace|user> [names...]
   - target: `workspace` or `user`
   - names: optional list of ids or names to install (supports `repo:id` form)
-  - type: specify with the option `--type <type>` (prompts|chatmodes|instructions|all). For backwards compatibility you can still pass the type as the first positional name (e.g. `install workspace prompts p1 p2`). Note: the `install` command also accepts a deliberate typo alias `--referesh` (alias for `--refresh`) to preserve historical behavior.
+  - type: specify with the option `--type <type>` (prompts|agents|instructions|skills|chatmodes|all). Note: `chatmodes` is legacy/deprecated (use `agents` instead). For backwards compatibility you can still pass the type as the first positional name (e.g. `install workspace prompts p1 p2`). The `install` command also accepts a deliberate typo alias `--referesh` (alias for `--refresh`) to preserve historical behavior.
 - list [type]
-  - list items available. type can be `prompts`, `chatmodes`, `instructions`, or `all`
+  - list items available. type can be `prompts`, `agents`, `instructions`, `skills`, `chatmodes` (legacy), or `all`
 - search <query>
   - search across items
 - uninstall <workspace|user> <type> [names...]
@@ -102,6 +102,9 @@ acp-vscode list --refresh
 - Offline testing / injecting a local index
   - For tests or offline usage you can set `ACP_INDEX_JSON` to a JSON string representing the index. This bypasses network fetching entirely and the CLI will use the provided index verbatim.
 
+- Nested folder support
+  - The CLI automatically scans for prompts, agents, instructions, and skills at any folder depth. Items can be organized at the root level (`prompts/`, `agents/`, etc.) or in nested folders like `.github/prompts/`, `workflows/prompts/`, etc.
+
 - Multiple upstream repos
   - To index multiple repos set `ACP_REPOS_JSON` to a JSON array of repo descriptors. Example:
 
@@ -126,7 +129,9 @@ You can inject a full, pre-built index via the `ACP_INDEX_JSON` environment vari
 {
   "prompts": [{ "id": "p1", "name": "Prompt 1", "repo": "r1", "url": "https://..." }],
   "chatmodes": [],
-  "instructions": []
+  "agents": [],
+  "instructions": [],
+  "skills": []
 }
 ```
 
@@ -136,6 +141,8 @@ ACP_REPOS_JSON
 
 To support multiple upstream repos, set `ACP_REPOS_JSON` to a JSON array describing the repositories to index. Each repo object should contain at least an `id` and a `treeUrl`. Optionally include `rawBase` (the base URL to fetch raw file contents).
 
+**Important:** The default awesome-copilot repo is always included alongside your configured repos unless you explicitly set `ACP_EXCLUDE_DEFAULT_REPO=true` (environment variable). This means your custom repos are *additive* to the default, not replacements.
+
 Example:
 
 ```json
@@ -150,13 +157,28 @@ When multiple repos contain files with the same `id`, the fetcher adds an `_conf
 Local repo file (acp-repos.json)
 -------------------------------
 
-In addition to `ACP_REPOS_JSON` the CLI will look for a file named `acp-repos.json` in the `~/.acp` directory and use it to populate the upstream repo list if the environment variable is not set. This file should contain the same JSON array format as `ACP_REPOS_JSON` and is useful for per-user configuration without exporting environment variables. Precedence when building the repos list is:
+In addition to `ACP_REPOS_JSON` the CLI will look for a file named `acp-repos.json` in a local configuration directory and use it to populate the upstream repo list if the environment variable is not set. In normal usage (when `NODE_ENV` is not `development` or `test`), this file is expected at `~/.acp/acp-repos.json`. When `NODE_ENV` is set to `development` or `test`, the CLI instead looks for `./acp-repos.json` in the current working directory; this behavior exists primarily to support local development and automated tests. This file should contain the same JSON array format as `ACP_REPOS_JSON` and is useful for per-user configuration without exporting environment variables. **Like `ACP_REPOS_JSON`, the default awesome-copilot repo is always included alongside repos from this file unless you set `ACP_EXCLUDE_DEFAULT_REPO=true`.** Precedence when building the repos list is:
+
+1. `ACP_REPOS_JSON` environment variable (highest priority) — default repo is always added
+2. Local `acp-repos.json` file (if `ACP_REPOS_JSON` not set): in `~/.acp/acp-repos.json` by default, or `./acp-repos.json` when `NODE_ENV` is `development` or `test` — default repo is always added
+3. Built-in default repo (github/awesome-copilot) — used as fallback
+
+To exclude the default awesome-copilot repo entirely, set the `ACP_EXCLUDE_DEFAULT_REPO` environment variable to `true` or `1`.
+
+ACP_EXCLUDE_DEFAULT_REPO
 
-1. `ACP_REPOS_JSON` environment variable (highest priority)
-2. `~/.acp/acp-repos.json` file (if present)
-3. Built-in default repo (github/awesome-copilot)
+By default, the awesome-copilot repository is always included in the index regardless of whether you've configured custom repos via `ACP_REPOS_JSON` or `acp-repos.json`. This makes custom repos *additive* rather than replacements.
+
+If you want to exclude the default awesome-copilot repo, set `ACP_EXCLUDE_DEFAULT_REPO=true` or `ACP_EXCLUDE_DEFAULT_REPO=1`:
+
+```bash
+# Exclude default repo and use only custom repos
+export ACP_EXCLUDE_DEFAULT_REPO=true
+export ACP_REPOS_JSON='[{"id":"myrepo","treeUrl":"...","rawBase":"..."}]'
+acp-vscode list
+```
 
-Note: when running in development or tests the CLI will attempt to read `acp-repos.json` from the current working directory instead of `~/.acp` to keep test fixtures and local development predictable.
+When this is set to any value other than `true` or `1`, the default repo will be included (default behavior).
 
 Dry-run:
 
@@ -179,8 +201,8 @@ Commands reference
 Short reference for each command, key options, and quick examples.
 
 - install <workspace|user> [names...]
-  - Description: Install prompts/chatmodes/instructions into a workspace or VS Code user profile.
-  - Options: `-t, --type <type>` (prompts|chatmodes|instructions|all), `--dry-run`, `--referesh` (alias for refresh), `--verbose`
+  - Description: Install prompts/agents/instructions/skills into a workspace or VS Code user profile.
+  - Options: `-t, --type <type>` (prompts|agents|instructions|skills|chatmodes|all; `chatmodes` is legacy/deprecated), `--dry-run`, `--referesh` (alias for refresh), `--verbose`
   - Examples:
     - Install all prompts into the current workspace:
       - `acp-vscode install workspace prompts`
@@ -188,10 +210,10 @@ Short reference for each command, key options, and quick examples.
       - `acp-vscode install user --type instructions "Instruction Name"`
 
 - list [type]
-  - Description: List available items. Type can be `prompts`, `chatmodes`, `instructions`, or `all` (default).
+  - Description: List available items. Type can be `prompts`, `agents`, `instructions`, `skills`, `chatmodes` (legacy), or `all` (default).
   - Options: `-r, --refresh` (clear caches and refetch), `-j, --json`, `--verbose`
   - Examples:
-    - `acp-vscode list chatmodes`
+    - `acp-vscode list agents`
     - `acp-vscode list --json`
 
 - search <query>

package/__tests__/commands-actions.test.js

@@ -1,6 +1,4 @@
 const cache = require('../src/cache');
-const fs = require('fs-extra');
-const path = require('path');
 
 function makeCli() {
   const cli = {