acdev 1.0.12 → 1.0.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "acdev",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "Local CLI + web UI for running AI agents on GitHub issues via git worktrees",
   "type": "module",
   "bin": {

package/public/app.js

@@ -344,6 +344,7 @@ const els = {
   settingsOpenrouterKeyClear: document.getElementById('settings-openrouter-key-clear'),
   settingsOpenrouterKeyHint: document.getElementById('settings-openrouter-key-hint'),
   settingsLlmProvider: document.getElementById('settings-llm-provider'),
+  settingsLlmProviderHint: document.getElementById('settings-llm-provider-hint'),
   overviewLlmProvider: document.getElementById('overview-llm-provider'),
   sidebarAgentLabel: document.getElementById('sidebar-agent-label'),
   settingsTabs: document.getElementById('settings-tabs'),
@@ -3973,7 +3974,7 @@ function fillSettingsForm(cfg) {
   fillAuthSettings(cfg);
 
   updateTicketSourceUI(cfg.ticketSource === 'jira' ? 'jira' : 'github');
-  updateLlmProviderUI(cfg.llmProvider === 'openrouter' ? 'openrouter' : 'claude');
+  updateLlmProviderUI(cfg.llmProvider === 'openrouter' ? 'openrouter' : 'claude', cfg);
 
   if (els.settingsJiraBaseUrl) {
     els.settingsJiraBaseUrl.value = cfg.jiraBaseUrl || '';
@@ -4202,18 +4203,74 @@ function updateTicketSourceUI(source) {
 
 /**
  * @param {'claude' | 'openrouter'} provider
+ * @param {typeof appConfig} [cfg]
  */
-function updateLlmProviderUI(provider) {
+function llmProviderReady(provider, cfg = appConfig) {
+  if (cfg?.stubAgent) return true;
+  if (provider === 'openrouter') return cfg?.openrouterAuthOk === true;
+  return cfg?.claudeAuthOk === true;
+}
+
+/**
+ * @param {'claude' | 'openrouter'} provider
+ */
+function llmProviderUnavailableReason(provider) {
+  if (provider === 'openrouter') {
+    return 'OpenRouter is not configured. Add an API key in Settings → Authentication first.';
+  }
+  return 'Claude is not configured. Add an API key or OAuth token in Settings → Authentication, or run claude auth login.';
+}
+
+const LLM_PROVIDER_HINT_DEFAULT =
+  'Claude uses the Claude Agent SDK. OpenRouter uses <code>@openrouter/agent</code> with the same coding tools (any catalog model). A provider stays disabled until it is configured and authenticated.';
+
+/**
+ * @param {typeof appConfig} [cfg]
+ */
+function updateLlmProviderHint(cfg = appConfig) {
+  if (!els.settingsLlmProviderHint) return;
+  if (cfg?.stubAgent) {
+    els.settingsLlmProviderHint.innerHTML = LLM_PROVIDER_HINT_DEFAULT;
+    return;
+  }
+  const missing = [];
+  if (!llmProviderReady('claude', cfg)) {
+    missing.push('Claude (API key, OAuth token, or <code>claude auth login</code>)');
+  }
+  if (!llmProviderReady('openrouter', cfg)) {
+    missing.push('OpenRouter (API key in Authentication)');
+  }
+  if (!missing.length) {
+    els.settingsLlmProviderHint.innerHTML = LLM_PROVIDER_HINT_DEFAULT;
+    return;
+  }
+  els.settingsLlmProviderHint.innerHTML = `Cannot enable a provider until it is configured and authenticated. Missing: ${missing.join('; ')}.`;
+}
+
+/**
+ * @param {'claude' | 'openrouter'} provider
+ * @param {typeof appConfig} [cfg]
+ */
+function updateLlmProviderUI(provider, cfg = appConfig) {
   llmProvider = provider === 'openrouter' ? 'openrouter' : 'claude';
 
   for (const toggle of [els.settingsLlmProvider, els.overviewLlmProvider]) {
     if (!toggle) continue;
     toggle.querySelectorAll('.source-btn').forEach((btn) => {
-      const active = btn.dataset.provider === llmProvider;
+      const id = btn.dataset.provider === 'openrouter' ? 'openrouter' : 'claude';
+      const active = id === llmProvider;
+      const ready = llmProviderReady(id, cfg);
       btn.classList.toggle('active', active);
       btn.setAttribute('aria-pressed', active ? 'true' : 'false');
+      btn.disabled = !ready;
+      if (!ready) {
+        btn.title = llmProviderUnavailableReason(id);
+      } else {
+        btn.removeAttribute('title');
+      }
     });
   }
+  updateLlmProviderHint(cfg);
   updateModelLabel();
 }
 
@@ -4240,6 +4297,13 @@ async function saveTicketSource(next) {
 
 async function saveLlmProvider(next) {
   const provider = next === 'openrouter' ? 'openrouter' : 'claude';
+  if (!llmProviderReady(provider)) {
+    const msg = llmProviderUnavailableReason(provider);
+    setOverviewLlmFeedback(msg, 'error');
+    setSettingsFeedback(msg, 'error');
+    return;
+  }
+  const prev = llmProvider;
   updateLlmProviderUI(provider);
   clearAvailableModels();
   try {
@@ -4249,11 +4313,18 @@ async function saveLlmProvider(next) {
       body: JSON.stringify({ llmProvider: provider }),
     });
     const data = await readJson(res);
-    if (res.ok) {
-      applyConfigSnapshot({ ...appConfig, ...data });
+    if (!res.ok) {
+      updateLlmProviderUI(prev);
+      const msg = data.error || `Update failed (HTTP ${res.status})`;
+      setOverviewLlmFeedback(msg, 'error');
+      setSettingsFeedback(msg, 'error');
       await fetchModels({ refresh: true, reconcile: true });
+      return;
     }
+    applyConfigSnapshot({ ...appConfig, ...data });
+    await fetchModels({ refresh: true, reconcile: true });
   } catch {
+    updateLlmProviderUI(prev);
     void fetchModels({ refresh: true, reconcile: true });
   }
 }
@@ -4285,7 +4356,7 @@ function setOverviewLlmFeedback(message, kind = 'ok') {
  */
 function fillOverviewLlmControls(cfg) {
   if (!cfg) return;
-  updateLlmProviderUI(cfg.llmProvider === 'openrouter' ? 'openrouter' : 'claude');
+  updateLlmProviderUI(cfg.llmProvider === 'openrouter' ? 'openrouter' : 'claude', cfg);
   syncAllModelComboboxValues(currentModel);
 }
 
@@ -4333,7 +4404,10 @@ function applyConfigSnapshot(data) {
   updateModelLabel();
   fillOverviewLlmControls(data);
   updateTicketSourceUI(data?.ticketSource === 'jira' ? 'jira' : 'github');
-  updateLlmProviderUI(data?.llmProvider === 'openrouter' ? 'openrouter' : 'claude');
+  updateLlmProviderUI(
+    data?.llmProvider === 'openrouter' ? 'openrouter' : 'claude',
+    data || appConfig
+  );
   if (els.repoName) {
     els.repoName.textContent = data?.repoName || 'local repo';
   }
@@ -4730,6 +4804,12 @@ function handleLlmProviderToggleClick(e) {
   const next = btn.dataset.provider === 'openrouter' ? 'openrouter' : 'claude';
   if (next === llmProvider) return;
   e.stopPropagation();
+  if (btn.disabled || !llmProviderReady(next)) {
+    const msg = llmProviderUnavailableReason(next);
+    setOverviewLlmFeedback(msg, 'error');
+    setSettingsFeedback(msg, 'error');
+    return;
+  }
   void saveLlmProvider(next);
 }
 

package/public/index.html

@@ -669,7 +669,7 @@
                       <button type="button" class="source-btn active" data-provider="claude">Claude</button>
                       <button type="button" class="source-btn" data-provider="openrouter">OpenRouter</button>
                     </div>
-                    <p class="field-hint">Claude uses the Claude Agent SDK. OpenRouter uses <code>@openrouter/agent</code> with the same coding tools (any catalog model).</p>
+                    <p class="field-hint" id="settings-llm-provider-hint">Claude uses the Claude Agent SDK. OpenRouter uses <code>@openrouter/agent</code> with the same coding tools (any catalog model). A provider stays disabled until it is configured and authenticated.</p>
                   </div>
                   <div class="settings-grid">
                     <div class="settings-field">

package/public/styles.css

@@ -2475,7 +2475,7 @@ body.diff-fs-open {
   letter-spacing: 0.02em;
 }
 
-.source-btn:hover:not(.active) {
+.source-btn:hover:not(.active):not(:disabled) {
   color: var(--text);
   background: color-mix(in srgb, var(--text) 4%, transparent);
 }
@@ -2487,6 +2487,16 @@ body.diff-fs-open {
   box-shadow: var(--shadow-sm);
 }
 
+.source-btn:disabled {
+  opacity: 0.45;
+  cursor: not-allowed;
+}
+
+.source-btn.active:disabled {
+  opacity: 0.7;
+  cursor: default;
+}
+
 .enqueue-jira-hint {
   margin: 0;
   font-size: 12px;

package/src/config.js

@@ -91,6 +91,42 @@ export function normalizeLlmProvider(value) {
   return value === 'openrouter' ? 'openrouter' : 'claude';
 }
 
+/**
+ * Block enabling an LLM provider that is not authenticated.
+ * Stub-agent skips the check (UI-only testing without credentials).
+ * @param {unknown} nextProvider
+ * @param {{
+ *   stubAgent?: boolean,
+ *   claudeAuth?: import('./claude-auth.js').ClaudeAuthResult,
+ *   openrouterAuth?: import('./openrouter-auth.js').OpenRouterAuthResult,
+ * }} [opts]
+ * @returns {{ error: string, code: string } | null}
+ */
+export function llmProviderAuthGate(nextProvider, opts = {}) {
+  if (opts.stubAgent === true) return null;
+  const provider = normalizeLlmProvider(nextProvider);
+  if (provider === 'openrouter') {
+    const or = opts.openrouterAuth ?? checkOpenRouterAuth();
+    if (!or.ok) {
+      return {
+        error:
+          'OpenRouter is not authenticated. Add an API key in Settings → Authentication before enabling OpenRouter.',
+        code: 'openrouter_auth_required',
+      };
+    }
+    return null;
+  }
+  const claude = opts.claudeAuth ?? checkClaudeAuth();
+  if (!claude.ok) {
+    return {
+      error:
+        'Claude is not authenticated. Add an API key or OAuth token in Settings → Authentication, or run claude auth login, before enabling Claude.',
+      code: 'claude_auth_required',
+    };
+  }
+  return null;
+}
+
 /**
  * @param {unknown} raw
  * @returns {{ claude?: string, openrouter?: string }}

package/src/server.js

@@ -33,7 +33,12 @@ import {
   runAgentOnReviewFeedback,
   stripAiAttribution,
 } from './agent.js';
-import { publicConfig, updateConfig, normalizeLlmProvider } from './config.js';
+import {
+  publicConfig,
+  updateConfig,
+  normalizeLlmProvider,
+  llmProviderAuthGate,
+} from './config.js';
 import { upsertEnvVars } from './env.js';
 import { listModels } from './models.js';
 import { splitIssueUrls } from './urls.js';
@@ -682,6 +687,21 @@ export function createServer({ repoRoot, config, store, useStubAgent = false, de
         openrouterApiKey: _or,
         ...configPatch
       } = patch;
+
+      if (configPatch.llmProvider === 'claude' || configPatch.llmProvider === 'openrouter') {
+        const next = configPatch.llmProvider;
+        if (next !== normalizeLlmProvider(config.llmProvider)) {
+          const gate = llmProviderAuthGate(next, {
+            stubAgent: useStubAgent,
+            claudeAuth: doCheckClaudeAuth(),
+            openrouterAuth: checkOpenRouterAuth(),
+          });
+          if (gate) {
+            return res.status(400).json(gate);
+          }
+        }
+      }
+
       updateConfig(repoRoot, config, configPatch);
       res.json(publicConfigPayload());
     } catch (err) {