acdev 1.0.1 → 1.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "acdev",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Local CLI + web UI for running AI agents on GitHub issues via git worktrees",
   "type": "module",
   "bin": {

package/public/app.js

@@ -108,6 +108,10 @@ let reviewSearch = loadReviewSearch();
 let activeInlineCommentKey = null;
 /** @type {string | null} id of line comment currently being edited */
 let editingCommentId = null;
+/** @type {'inline' | 'pending' | null} where the edit form should render */
+let editingCommentSurface = null;
+/** Original body when edit started — restored on Cancel after live sync. */
+let editingCommentOriginalBody = null;
 /** @type {Record<string, {
  *   generalComment: string,
  *   lineComments: Array<{ id: string, path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>,
@@ -447,6 +451,8 @@ function clearReviewDraft(jobId) {
   delete reviewDrafts[jobId];
   activeInlineCommentKey = null;
   editingCommentId = null;
+  editingCommentSurface = null;
+  editingCommentOriginalBody = null;
   try {
     sessionStorage.removeItem(reviewDraftStorageKey(jobId));
   } catch {
@@ -454,6 +460,86 @@ function clearReviewDraft(jobId) {
   }
 }
 
+/** Clear in-progress line-comment edit state. */
+function clearCommentEditState() {
+  editingCommentId = null;
+  editingCommentSurface = null;
+  editingCommentOriginalBody = null;
+}
+
+/**
+ * @param {string} jobId
+ * @param {string} commentId
+ * @param {string} body
+ */
+function updateLineCommentBody(jobId, commentId, body) {
+  const d = loadReviewDraft(jobId);
+  const target = d.lineComments.find((x) => x.id === commentId);
+  if (!target) return;
+  target.body = body;
+  saveReviewDraft(jobId);
+}
+
+/**
+ * Refresh the non-active edit surface so both views stay in sync.
+ * @param {string} jobId
+ */
+function mirrorCommentEditToOtherSurface(jobId) {
+  if (editingCommentSurface === 'inline') {
+    renderPendingCommentList(jobId);
+    syncSubmitReviewButton(jobId);
+    return;
+  }
+  if (editingCommentSurface === 'pending') {
+    const job = jobsById[jobId];
+    if (job) {
+      const diff =
+        job.status === 'awaiting_review'
+          ? filterDiffForReviewJob(job)
+          : job.diff || '';
+      renderDiff(diff, {
+        interactive: job.status === 'awaiting_review',
+        jobId,
+      });
+    }
+    syncSubmitReviewButton(jobId);
+  }
+}
+
+/**
+ * Commit or discard an in-progress comment edit.
+ * @param {string} jobId
+ * @param {string} commentId
+ * @param {string | null} nextBody null = cancel / restore original
+ */
+function finishCommentEdit(jobId, commentId, nextBody) {
+  if (nextBody == null) {
+    if (editingCommentOriginalBody != null) {
+      updateLineCommentBody(jobId, commentId, editingCommentOriginalBody);
+    }
+  } else {
+    updateLineCommentBody(jobId, commentId, nextBody);
+  }
+  clearCommentEditState();
+  refreshReviewCommentUi(jobId);
+}
+
+/**
+ * Start editing a pending line comment on a specific surface.
+ * @param {string} commentId
+ * @param {'inline' | 'pending'} surface
+ * @param {string} jobId
+ */
+function startCommentEdit(commentId, surface, jobId) {
+  const draft = loadReviewDraft(jobId);
+  const target = draft.lineComments.find((x) => x.id === commentId);
+  editingCommentId = commentId;
+  editingCommentSurface = surface;
+  editingCommentOriginalBody = target ? target.body : '';
+  activeInlineCommentKey = null;
+  refreshReviewCommentUi(jobId);
+}
+
 /**
  * Re-render diff + pending list after draft mutation.
  * @param {string} jobId
@@ -480,6 +566,7 @@ function refreshReviewCommentUi(jobId) {
  *   saveLabel?: string,
  *   onSave: (body: string) => void,
  *   onCancel: () => void,
+ *   onInput?: (body: string) => void,
  * }} opts
  */
 function buildCommentEditForm(opts) {
@@ -490,6 +577,9 @@ function buildCommentEditForm(opts) {
   ta.rows = 3;
   ta.value = opts.initialBody;
   ta.placeholder = 'Edit comment…';
+  if (opts.onInput) {
+    ta.addEventListener('input', () => opts.onInput(ta.value));
+  }
   const actions = document.createElement('div');
   actions.className = 'diff-inline-actions';
   const save = document.createElement('button');
@@ -514,6 +604,7 @@ function buildCommentEditForm(opts) {
     ta.focus();
     const len = ta.value.length;
     ta.setSelectionRange(len, len);
+    ta.scrollIntoView({ block: 'nearest', inline: 'nearest' });
   });
   return form;
 }
@@ -1317,7 +1408,7 @@ function renderDiff(diff, opts = {}) {
     plus.addEventListener('click', (e) => {
       e.stopPropagation();
       activeInlineCommentKey = lineCommentKey(path, line, side);
-      editingCommentId = null;
+      clearCommentEditState();
       renderDiff(diff, opts);
       renderPendingCommentList(jobId);
       syncSubmitReviewButton(jobId);
@@ -1327,7 +1418,7 @@ function renderDiff(diff, opts = {}) {
     cell.addEventListener('click', (e) => {
       if (e.target.closest('button, textarea, a')) return;
       activeInlineCommentKey = lineCommentKey(path, line, side);
-      editingCommentId = null;
+      clearCommentEditState();
       renderDiff(diff, opts);
       renderPendingCommentList(jobId);
       syncSubmitReviewButton(jobId);
@@ -1382,22 +1473,16 @@ function renderDiff(diff, opts = {}) {
     thread.appendChild(meta);
 
     for (const c of existing) {
-      if (editingCommentId === c.id) {
+      if (editingCommentId === c.id && editingCommentSurface === 'inline') {
         thread.appendChild(
           buildCommentEditForm({
             initialBody: c.body,
-            onSave: (body) => {
-              const d = loadReviewDraft(jobId);
-              const target = d.lineComments.find((x) => x.id === c.id);
-              if (target) target.body = body;
-              saveReviewDraft(jobId);
-              editingCommentId = null;
-              refreshReviewCommentUi(jobId);
-            },
-            onCancel: () => {
-              editingCommentId = null;
-              refreshReviewCommentUi(jobId);
+            onInput: (body) => {
+              updateLineCommentBody(jobId, c.id, body);
+              mirrorCommentEditToOtherSurface(jobId);
             },
+            onSave: (body) => finishCommentEdit(jobId, c.id, body),
+            onCancel: () => finishCommentEdit(jobId, c.id, null),
           })
         );
         continue;
@@ -1415,9 +1500,7 @@ function renderDiff(diff, opts = {}) {
       edit.className = 'btn btn-muted-text btn-sm';
       edit.textContent = 'Edit';
       edit.addEventListener('click', () => {
-        editingCommentId = c.id;
-        activeInlineCommentKey = null;
-        refreshReviewCommentUi(jobId);
+        startCommentEdit(c.id, 'inline', jobId);
       });
       const remove = document.createElement('button');
       remove.type = 'button';
@@ -1427,7 +1510,7 @@ function renderDiff(diff, opts = {}) {
         const d = loadReviewDraft(jobId);
         d.lineComments = d.lineComments.filter((x) => x.id !== c.id);
         saveReviewDraft(jobId);
-        if (editingCommentId === c.id) editingCommentId = null;
+        if (editingCommentId === c.id) clearCommentEditState();
         refreshReviewCommentUi(jobId);
       });
       actions.appendChild(edit);
@@ -1684,22 +1767,16 @@ function renderPendingCommentList(jobId) {
     loc.textContent = `${c.path}:${c.line} (${c.side})`;
     main.appendChild(loc);
 
-    if (editingCommentId === c.id) {
+    if (editingCommentId === c.id && editingCommentSurface === 'pending') {
       main.appendChild(
         buildCommentEditForm({
           initialBody: c.body,
-          onSave: (body) => {
-            const d = loadReviewDraft(jobId);
-            const target = d.lineComments.find((x) => x.id === c.id);
-            if (target) target.body = body;
-            saveReviewDraft(jobId);
-            editingCommentId = null;
-            refreshReviewCommentUi(jobId);
-          },
-          onCancel: () => {
-            editingCommentId = null;
-            refreshReviewCommentUi(jobId);
+          onInput: (body) => {
+            updateLineCommentBody(jobId, c.id, body);
+            mirrorCommentEditToOtherSurface(jobId);
           },
+          onSave: (body) => finishCommentEdit(jobId, c.id, body),
+          onCancel: () => finishCommentEdit(jobId, c.id, null),
         })
       );
       item.appendChild(main);
@@ -1718,9 +1795,7 @@ function renderPendingCommentList(jobId) {
     edit.className = 'btn btn-muted-text btn-sm';
     edit.textContent = 'Edit';
     edit.addEventListener('click', () => {
-      editingCommentId = c.id;
-      activeInlineCommentKey = null;
-      refreshReviewCommentUi(jobId);
+      startCommentEdit(c.id, 'pending', jobId);
     });
     const remove = document.createElement('button');
     remove.type = 'button';
@@ -1730,7 +1805,7 @@ function renderPendingCommentList(jobId) {
       const d = loadReviewDraft(jobId);
       d.lineComments = d.lineComments.filter((x) => x.id !== c.id);
       saveReviewDraft(jobId);
-      if (editingCommentId === c.id) editingCommentId = null;
+      if (editingCommentId === c.id) clearCommentEditState();
       refreshReviewCommentUi(jobId);
     });
     actions.appendChild(edit);
@@ -2321,7 +2396,7 @@ function renderReview(jobs) {
     const focusInPending = Boolean(
       els.reviewPendingList?.contains(document.activeElement)
     );
-    if (!(editingCommentId && focusInPending)) {
+    if (!(editingCommentId && editingCommentSurface === 'pending' && focusInPending)) {
       renderPendingCommentList(job.id);
     }
     syncSubmitReviewButton(job.id);
@@ -2353,7 +2428,9 @@ function renderReview(jobs) {
 
   const focusInDiff = els.diffViewer?.contains(document.activeElement);
   const preservingDiffCompose =
-    (activeInlineCommentKey || editingCommentId) && focusInDiff;
+    (Boolean(activeInlineCommentKey) ||
+      (editingCommentId && editingCommentSurface === 'inline')) &&
+    focusInDiff;
   if (!preservingDiffCompose) {
     renderDiff(displayDiff, { interactive: editable, jobId: job.id });
   }