acdev 1.0.0

package/src/agent.js

@@ -0,0 +1,669 @@
+import { query } from '@anthropic-ai/claude-agent-sdk';
+import { execFile } from 'node:child_process';
+import { promisify } from 'node:util';
+import { ensureNoAiAttributionSettings, getIssueTitle } from './git.js';
+import { extractUsageFromResult } from './usage.js';
+
+const execFileAsync = promisify(execFile);
+
+/** Phrases that must not appear in PR title/body (case-insensitive). */
+const AI_ATTRIBUTION_RES = [
+  /co-authored-by:\s*[^\n]*/gi,
+  /claude-generated-by:\s*[^\n]*/gi,
+  /🤖\s*generated with\s*\[?claude code\]?[^\n]*/gi,
+  /generated with\s*\[?claude code\]?[^\n]*/gi,
+  /generated by\s+claude[^\n]*/gi,
+  /claude\s*code/gi,
+  /\banthropic\b/gi,
+  /\bclaude\b/gi,
+  /\bai\s*agents?\b/gi,
+  /\bai[- ]generated\b/gi,
+  /\bgenerated by (an? )?(ai|llm|assistant)\b/gi,
+  /\bllm\b/gi,
+];
+
+/**
+ * True when a single line is Claude/Anthropic/AI commit or PR attribution.
+ * @param {string} line
+ */
+export function isAiAttributionLine(line) {
+  const trimmed = String(line ?? '').trim();
+  if (!trimmed) return false;
+  if (/^co-authored-by:\s*/i.test(trimmed)) {
+    return /(claude|anthropic|noreply@anthropic\.com)/i.test(trimmed);
+  }
+  if (/^claude-generated-by:/i.test(trimmed)) return true;
+  if (/generated with\s*\[?claude code\]?/i.test(trimmed)) return true;
+  if (/generated by\s+claude/i.test(trimmed)) return true;
+  return (
+    /(claude|anthropic|ai agent|llm)/i.test(trimmed) &&
+    /(generated|created|authored|written|powered|via|using|by|assistant|automated|this (pr|change|fix|patch))/i.test(
+      trimmed
+    )
+  );
+}
+
+/**
+ * Strip Claude / Anthropic / AI-agent attribution from PR text.
+ * Keeps useful content (including `Closes #<n>`) while removing marketing lines.
+ * @param {string} text
+ * @returns {string}
+ */
+export function stripAiAttribution(text) {
+  if (!text || typeof text !== 'string') return text ?? '';
+
+  let result = text
+    .split('\n')
+    .filter((line) => {
+      if (/closes\s+#\d+/i.test(line)) return true;
+      return !isAiAttributionLine(line);
+    })
+    .join('\n');
+
+  for (const re of AI_ATTRIBUTION_RES) {
+    result = result.replace(re, '');
+  }
+
+  return result
+    .replace(/[ \t]{2,}/g, ' ')
+    .replace(/[ \t]+\n/g, '\n')
+    .replace(/\n{3,}/g, '\n\n')
+    .trim();
+}
+
+/**
+ * @param {string} issueUrl
+ * @param {import('./config.js').loadConfig extends (...args: any) => infer R ? R : never} config
+ * @param {{
+ *   branchName?: string,
+ *   issueNumber?: number,
+ *   ticketSource?: 'github' | 'jira',
+ *   jiraKey?: string,
+ *   jiraIssue?: {
+ *     key: string,
+ *     summary: string,
+ *     description: string,
+ *     issueType?: string,
+ *     labels?: string[],
+ *     comments?: Array<{ author: string, body: string }>,
+ *   },
+ *   jiraPrLinkPhrase?: string,
+ * }} [context]
+ */
+export function buildPrompt(issueUrl, config, context = {}) {
+  const issueNumber = context.issueNumber;
+  const branchName = context.branchName;
+  const isJira = context.ticketSource === 'jira' || Boolean(context.jiraKey);
+  const jiraKey = context.jiraKey || context.jiraIssue?.key;
+  const linkPhrase = context.jiraPrLinkPhrase || config.jiraPrLinkPhrase || 'Relates to';
+
+  /** @type {string[]} */
+  const parts = [];
+
+  if (isJira) {
+    parts.push(
+      `You are working on Jira issue: ${jiraKey || issueUrl}`,
+      issueUrl && issueUrl !== jiraKey ? `Browse URL: ${issueUrl}` : '',
+      '',
+      'Issue details are provided below. Use this context — do not invent a GitHub issue number,',
+      'and do not invent a fake `Closes #N` link. Prefer the provided content over fetching Jira yourself',
+      '(you may not have Jira credentials in this environment).',
+      ''
+    );
+
+    const issue = context.jiraIssue;
+    if (issue) {
+      parts.push(
+        `Key: ${issue.key}`,
+        `Summary: ${issue.summary || '(none)'}`,
+        `Type: ${issue.issueType || '(unknown)'}`,
+        `Labels: ${(issue.labels || []).join(', ') || '(none)'}`,
+        '',
+        'Description:',
+        issue.description || '(no description)',
+        ''
+      );
+      const comments = issue.comments || [];
+      if (comments.length > 0) {
+        parts.push('Comments:');
+        for (const c of comments.slice(-20)) {
+          parts.push(`- ${c.author}: ${c.body || '(empty)'}`);
+        }
+        parts.push('');
+      }
+    } else {
+      parts.push(
+        '1. The issue body was not pre-fetched. If you have network access, you may try to retrieve it;',
+        '   otherwise work from the key/summary available in the job title and explore the codebase.',
+        ''
+      );
+    }
+
+    parts.push(
+      '1. Determine whether this is a bug fix or a feature request from the issue type and description, and reason accordingly.',
+      '',
+      '2. Explore the codebase by reading relevant files before writing any code. Do not guess implementation details from the issue text alone.',
+      '',
+      '3. Implement the required change.'
+    );
+  } else {
+    parts.push(
+      `You are working on GitHub issue: ${issueUrl}`,
+      '',
+      '1. Fetch the issue details using this command via the Bash tool:',
+      `   gh issue view ${issueUrl} --json title,body,comments,labels`,
+      '   Do not guess issue content from the URL alone.',
+      '',
+      '2. Determine whether this is a bug fix or a feature request, and reason accordingly.',
+      '',
+      '3. Explore the codebase by reading relevant files before writing any code. Do not guess implementation details from the issue text alone.',
+      '',
+      '4. Implement the required change.'
+    );
+  }
+
+  // Drop empty strings from optional browse URL line
+  const cleaned = parts.filter((p) => p !== '');
+
+  if (config.testCommand) {
+    cleaned.push(
+      '',
+      `${isJira ? '4' : '5'}. Run the test command: ${config.testCommand}`,
+      '   Fix any failures introduced by your change. Ignore pre-existing failures unrelated to your change.'
+    );
+  }
+
+  const stepCommit = isJira
+    ? config.testCommand
+      ? '5'
+      : '4'
+    : config.testCommand
+      ? '6'
+      : '5';
+  const stepJson = isJira
+    ? config.testCommand
+      ? '6'
+      : '5'
+    : config.testCommand
+      ? '7'
+      : '6';
+
+  const refHint = isJira
+    ? jiraKey
+      ? ` (e.g. include ${jiraKey})`
+      : ''
+    : issueNumber != null
+      ? ` (e.g. include #${issueNumber})`
+      : '';
+
+  const prBodyHint = isJira
+    ? `... (include ${linkPhrase} ${jiraKey || 'KEY-123'})`
+    : '... (include Closes #<issue-number>)';
+
+  const prBodyRule = isJira
+    ? `- Include \`${linkPhrase} ${jiraKey || '<KEY>'}\` in prBody when appropriate. Do NOT invent a GitHub \`Closes #N\`.`
+    : '- Include `Closes #<issue-number>` in prBody when appropriate.';
+
+  cleaned.push(
+    '',
+    `${stepCommit}. Commit your changes locally with a message that references the issue` +
+      refHint +
+      '. Do NOT push, create a PR, rename the branch, or create a new branch.' +
+      (branchName
+        ? ` The branch \`${branchName}\` already exists — stay on it and commit there.`
+        : ' Work on the current branch only.'),
+    '',
+    '   Commit authorship rules (mandatory):',
+    '   - Use the repository\'s existing git `user.name` / `user.email`. Do NOT set `--author`, do NOT override `GIT_AUTHOR_*` / `GIT_COMMITTER_*`, and do NOT set the author to Claude or any AI identity.',
+    '   - Do NOT add `Co-Authored-By: Claude`, `Co-Authored-By: Claude Code`, `Generated by Claude`, `Generated with Claude Code`, `Claude-Generated-By`, Anthropic, or any other AI attribution trailer/line in the commit message.',
+    '   - Ignore any built-in examples that show Claude co-author trailers; omit those trailers entirely.',
+    '   - Do not commit `.claude/settings.local.json` if present.',
+    '',
+    `${stepJson}. End your final response with a fenced JSON block containing prTitle and prBody:`,
+    '```json',
+    `{"prTitle": "...", "prBody": "${prBodyHint}"}`,
+    '```',
+    '',
+    'Rules for prTitle and prBody:',
+    '- Do NOT mention Claude Code, Claude, Anthropic, AI agents, LLMs, or similar tooling/attribution.',
+    '- Do NOT include `Co-Authored-By`, `Generated with Claude Code`, or similar attribution lines.',
+    '- Write as a normal human engineer describing the change.',
+    prBodyRule
+  );
+
+  return cleaned.join('\n');
+}
+
+/**
+ * Prompt for applying human review feedback on an existing worktree/branch.
+ * @param {{
+ *   issueUrl: string,
+ *   generalComment?: string,
+ *   lineComments?: Array<{ path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>,
+ *   config: object,
+ *   branchName?: string,
+ *   issueNumber?: number,
+ *   ticketSource?: 'github' | 'jira',
+ *   jiraKey?: string,
+ *   jiraPrLinkPhrase?: string,
+ * }} params
+ */
+export function buildReviewFeedbackPrompt({
+  issueUrl,
+  generalComment = '',
+  lineComments = [],
+  config,
+  branchName,
+  issueNumber,
+  ticketSource,
+  jiraKey,
+  jiraPrLinkPhrase,
+}) {
+  const isJira = ticketSource === 'jira' || Boolean(jiraKey);
+  const linkPhrase = jiraPrLinkPhrase || config.jiraPrLinkPhrase || 'Relates to';
+  const parts = [
+    isJira
+      ? `You are continuing work on Jira issue: ${jiraKey || issueUrl}`
+      : `You are continuing work on GitHub issue: ${issueUrl}`,
+    '',
+    'A human reviewed your current local changes (diff vs the base branch) and left feedback.',
+    'Apply their requested changes on the existing branch. Do NOT start over from scratch.',
+    '',
+    'Review feedback:',
+  ];
+
+  const general = String(generalComment || '').trim();
+  if (general) {
+    parts.push('', 'General comment (whole change):', general);
+  }
+
+  const lines = Array.isArray(lineComments) ? lineComments : [];
+  if (lines.length > 0) {
+    parts.push('', 'Line comments:');
+    for (const c of lines) {
+      const side = c.side === 'LEFT' ? 'LEFT (old/removed)' : 'RIGHT (new/added or context)';
+      parts.push(`- ${c.path}:${c.line} [${side}]: ${c.body}`);
+    }
+  }
+
+  parts.push(
+    '',
+    'Instructions:',
+    '1. Read the relevant files around the cited paths/lines and understand the current diff.',
+    '2. Apply the requested changes. Prefer minimal, focused edits that address the feedback.',
+  );
+
+  if (config.testCommand) {
+    parts.push(
+      `3. Run the test command: ${config.testCommand}`,
+      '   Fix any failures introduced by your change. Ignore pre-existing failures unrelated to your change.'
+    );
+  }
+
+  const stepCommit = config.testCommand ? '4' : '3';
+  const stepJson = config.testCommand ? '5' : '4';
+
+  const refHint = isJira
+    ? jiraKey
+      ? ` (e.g. include ${jiraKey})`
+      : ''
+    : issueNumber != null
+      ? ` (e.g. include #${issueNumber})`
+      : '';
+
+  const prBodyHint = isJira
+    ? `... (include ${linkPhrase} ${jiraKey || 'KEY-123'})`
+    : '... (include Closes #<issue-number>)';
+
+  const prBodyRule = isJira
+    ? `- Include \`${linkPhrase} ${jiraKey || '<KEY>'}\` in prBody when appropriate. Do NOT invent a GitHub \`Closes #N\`.`
+    : '- Include `Closes #<issue-number>` in prBody when appropriate.';
+
+  parts.push(
+    `${stepCommit}. Commit your changes locally with a message that references the issue` +
+      refHint +
+      '. Do NOT push, create a PR, rename the branch, or create a new branch.' +
+      (branchName
+        ? ` The branch \`${branchName}\` already exists — stay on it and commit there.`
+        : ' Work on the current branch only.'),
+    '',
+    '   Commit authorship rules (mandatory):',
+    '   - Use the repository\'s existing git `user.name` / `user.email`. Do NOT set `--author`, do NOT override `GIT_AUTHOR_*` / `GIT_COMMITTER_*`, and do NOT set the author to Claude or any AI identity.',
+    '   - Do NOT add `Co-Authored-By: Claude`, `Co-Authored-By: Claude Code`, `Generated by Claude`, `Generated with Claude Code`, `Claude-Generated-By`, Anthropic, or any other AI attribution trailer/line in the commit message.',
+    '   - Ignore any built-in examples that show Claude co-author trailers; omit those trailers entirely.',
+    '   - Do not commit `.claude/settings.local.json` if present.',
+    '',
+    `${stepJson}. End your final response with a fenced JSON block containing updated prTitle and prBody:`,
+    '```json',
+    `{"prTitle": "...", "prBody": "${prBodyHint}"}`,
+    '```',
+    '',
+    'Rules for prTitle and prBody:',
+    '- Do NOT mention Claude Code, Claude, Anthropic, AI agents, LLMs, or similar tooling/attribution.',
+    '- Do NOT include `Co-Authored-By`, `Generated with Claude Code`, or similar attribution lines.',
+    '- Write as a normal human engineer describing the change.',
+    prBodyRule,
+    '- Refresh title/body to reflect the updated change after applying review feedback.'
+  );
+
+  return parts.join('\n');
+}
+
+/**
+ * @param {string} text
+ * @returns {{ prTitle?: string, prBody?: string } | null}
+ */
+export function extractPrMetadata(text) {
+  if (!text) return null;
+  const match = text.match(/```json\s*([\s\S]*?)\s*```/i);
+  if (!match) return null;
+  try {
+    const parsed = JSON.parse(match[1]);
+    if (parsed.prTitle && parsed.prBody) {
+      return {
+        prTitle: stripAiAttribution(String(parsed.prTitle)),
+        prBody: stripAiAttribution(String(parsed.prBody)),
+      };
+    }
+  } catch {
+    // fall through
+  }
+  return null;
+}
+
+/**
+ * @param {string} issueUrl
+ * @param {string} worktreePath
+ */
+async function fetchIssueTitle(issueUrl, worktreePath) {
+  try {
+    return await getIssueTitle(worktreePath, issueUrl);
+  } catch {
+    const { stdout } = await execFileAsync(
+      'gh',
+      ['issue', 'view', issueUrl, '--json', 'title'],
+      { cwd: worktreePath }
+    );
+    return JSON.parse(stdout).title;
+  }
+}
+
+/**
+ * Tools that must stay off for headless one-shot runs.
+ * Async Task / TaskOutput teardown in Claude Agent SDK streaming mode can emit a
+ * spurious `error_during_execution` ("only prompt commands are supported in
+ * streaming mode") after a successful result — see anthropics/claude-agent-sdk-typescript#130.
+ */
+export const DISALLOWED_AGENT_TOOLS = ['Task', 'TaskOutput', 'AskUserQuestion'];
+
+/**
+ * Prefer the first successful SDK result. A known SDK bug can emit a follow-up
+ * `error_during_execution` right after success when async subagents finish.
+ * @param {unknown} current
+ * @param {unknown} incoming
+ */
+export function mergeAgentResult(current, incoming) {
+  if (!incoming || typeof incoming !== 'object' || incoming.type !== 'result') {
+    return current ?? null;
+  }
+  if (current?.type === 'result' && current.subtype === 'success') {
+    return current;
+  }
+  return incoming;
+}
+
+/**
+ * @param {{
+ *   prompt: string,
+ *   worktreePath: string,
+ *   config: object,
+ *   onEvent: (message: unknown) => void,
+ *   queryFn?: typeof query,
+ * }} params
+ */
+async function runAgentQuery({ prompt, worktreePath, config, onEvent, queryFn = query }) {
+  const timeoutMs = config.agentTimeoutMs ?? 900_000;
+  let lastMessage = null;
+  let resultMessage = null;
+  const abortController = new AbortController();
+
+  // Claude Agent SDK defaults to injecting Co-Authored-By trailers into commit
+  // instructions unless attribution is cleared via Claude settings.
+  ensureNoAiAttributionSettings(worktreePath);
+
+  const runLoop = async () => {
+    try {
+      for await (const message of queryFn({
+        // String prompt = single-turn SDK input (still uses stream-json transport).
+        prompt,
+        options: {
+          cwd: worktreePath,
+          allowedTools: config.allowedTools,
+          disallowedTools: DISALLOWED_AGENT_TOOLS,
+          permissionMode: 'acceptEdits',
+          maxTurns: config.maxAgentTurns,
+          model: config.model || 'claude-sonnet-5',
+          // Load only local settings so our empty attribution wins without
+          // pulling in unrelated user settings.
+          settingSources: ['local'],
+          abortController,
+        },
+      })) {
+        onEvent(message);
+        lastMessage = message;
+        if (message?.type === 'result') {
+          resultMessage = mergeAgentResult(resultMessage, message);
+          // First success is authoritative — stop before SDK async-task teardown
+          // can overwrite it with a spurious streaming-mode error.
+          if (message.subtype === 'success') {
+            abortController.abort();
+            break;
+          }
+        }
+      }
+    } catch (err) {
+      // Aborting after success can surface as an iterator/abort error.
+      if (resultMessage?.subtype === 'success') return;
+      throw err;
+    }
+  };
+
+  let timeoutId;
+  try {
+    await Promise.race([
+      runLoop(),
+      new Promise((_, reject) => {
+        timeoutId = setTimeout(() => {
+          abortController.abort();
+          reject(new Error(`Agent timed out after ${timeoutMs}ms`));
+        }, timeoutMs);
+      }),
+    ]);
+  } finally {
+    if (timeoutId) clearTimeout(timeoutId);
+  }
+
+  if (!resultMessage || resultMessage.subtype !== 'success') {
+    const detail = lastMessage ? JSON.stringify(lastMessage) : 'no result received';
+    throw new Error(`Agent did not complete successfully: ${detail}`);
+  }
+
+  const resultText = resultMessage.result ?? '';
+  const meta = extractPrMetadata(resultText);
+  const usage = extractUsageFromResult(resultMessage);
+  return { resultText, meta, usage };
+}
+
+function stubAgentResult(onEvent, title, body) {
+  const fakeResult = {
+    type: 'result',
+    subtype: 'success',
+    result: `Stub agent completed.\n\n\`\`\`json\n${JSON.stringify({ prTitle: title, prBody: body })}\n\`\`\``,
+    total_cost_usd: 0.0123,
+    duration_ms: 2000,
+    num_turns: 1,
+    usage: {
+      input_tokens: 1200,
+      output_tokens: 400,
+      cache_read_input_tokens: 0,
+      cache_creation_input_tokens: 0,
+    },
+    modelUsage: {
+      'claude-sonnet-5': {
+        inputTokens: 1200,
+        outputTokens: 400,
+        cacheReadInputTokens: 0,
+        cacheCreationInputTokens: 0,
+        webSearchRequests: 0,
+        costUSD: 0.0123,
+        contextWindow: 200000,
+      },
+    },
+  };
+  onEvent(fakeResult);
+  const meta = extractPrMetadata(fakeResult.result);
+  return {
+    prTitle: meta?.prTitle ?? title,
+    prBody: meta?.prBody ?? stripAiAttribution(fakeResult.result),
+    resultText: fakeResult.result,
+    usage: extractUsageFromResult(fakeResult),
+  };
+}
+
+/**
+ * @param {{
+ *   issueUrl: string,
+ *   worktreePath: string,
+ *   config: object,
+ *   onEvent: (message: unknown) => void,
+ *   stub?: boolean,
+ *   branchName?: string,
+ *   issueNumber?: number,
+ *   ticketSource?: 'github' | 'jira',
+ *   jiraKey?: string,
+ *   jiraIssue?: object,
+ *   queryFn?: typeof query,
+ * }} params
+ */
+export async function runAgentOnIssue({
+  issueUrl,
+  worktreePath,
+  config,
+  onEvent,
+  stub = false,
+  branchName,
+  issueNumber,
+  ticketSource,
+  jiraKey,
+  jiraIssue,
+  queryFn = query,
+}) {
+  if (stub) {
+    await new Promise((resolve) => setTimeout(resolve, 2000));
+    const body =
+      ticketSource === 'jira' || jiraKey
+        ? `Automated fix from stub agent.\n\nRelates to ${jiraKey || 'KEY-1'}`
+        : 'Automated fix from stub agent.\n\nCloses #1';
+    return stubAgentResult(onEvent, 'Fix issue (stub)', body);
+  }
+
+  const { resultText, meta, usage } = await runAgentQuery({
+    prompt: buildPrompt(issueUrl, config, {
+      branchName,
+      issueNumber,
+      ticketSource,
+      jiraKey,
+      jiraIssue,
+      jiraPrLinkPhrase: config.jiraPrLinkPhrase,
+    }),
+    worktreePath,
+    config,
+    onEvent,
+    queryFn,
+  });
+
+  if (meta) {
+    return { prTitle: meta.prTitle, prBody: meta.prBody, resultText, usage };
+  }
+
+  const issueTitle =
+    jiraIssue?.summary ||
+    (await fetchIssueTitle(issueUrl, worktreePath).catch(() => issueUrl));
+  return {
+    prTitle: stripAiAttribution(issueTitle),
+    prBody: stripAiAttribution(resultText),
+    resultText,
+    usage,
+  };
+}
+
+/**
+ * Continue on an existing worktree using human review comments (no push/PR).
+ * @param {{
+ *   issueUrl: string,
+ *   worktreePath: string,
+ *   config: object,
+ *   generalComment?: string,
+ *   lineComments?: Array<{ path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>,
+ *   onEvent: (message: unknown) => void,
+ *   stub?: boolean,
+ *   branchName?: string,
+ *   issueNumber?: number,
+ *   ticketSource?: 'github' | 'jira',
+ *   jiraKey?: string,
+ *   queryFn?: typeof query,
+ * }} params
+ */
+export async function runAgentOnReviewFeedback({
+  issueUrl,
+  worktreePath,
+  config,
+  generalComment = '',
+  lineComments = [],
+  onEvent,
+  stub = false,
+  branchName,
+  issueNumber,
+  ticketSource,
+  jiraKey,
+  queryFn = query,
+}) {
+  if (stub) {
+    await new Promise((resolve) => setTimeout(resolve, 500));
+    const body =
+      ticketSource === 'jira' || jiraKey
+        ? `Applied review feedback.\n\nRelates to ${jiraKey || 'KEY-1'}`
+        : 'Applied review feedback.\n\nCloses #1';
+    return stubAgentResult(onEvent, 'Address review feedback (stub)', body);
+  }
+
+  const { resultText, meta, usage } = await runAgentQuery({
+    prompt: buildReviewFeedbackPrompt({
+      issueUrl,
+      generalComment,
+      lineComments,
+      config,
+      branchName,
+      issueNumber,
+      ticketSource,
+      jiraKey,
+      jiraPrLinkPhrase: config.jiraPrLinkPhrase,
+    }),
+    worktreePath,
+    config,
+    onEvent,
+    queryFn,
+  });
+
+  if (meta) {
+    return { prTitle: meta.prTitle, prBody: meta.prBody, resultText, usage };
+  }
+
+  const issueTitle = await fetchIssueTitle(issueUrl, worktreePath).catch(() => issueUrl);
+  return {
+    prTitle: stripAiAttribution(issueTitle),
+    prBody: stripAiAttribution(resultText),
+    resultText,
+    usage,
+  };
+}