acdev 1.0.0 → 1.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "acdev",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Local CLI + web UI for running AI agents on GitHub issues via git worktrees",
   "type": "module",
   "bin": {
@@ -22,6 +22,7 @@
   },
   "dependencies": {
     "@anthropic-ai/claude-agent-sdk": "0.1.77",
+    "acdev": "^1.0.0",
     "dotenv": "^17.4.2",
     "express": "^4.21.2",
     "open": "^10.1.0",
@@ -51,6 +52,5 @@
   "main": "index.js",
   "directories": {
     "test": "test"
-  },
-  "devDependencies": {}
+  }
 }

package/public/app.js

@@ -106,9 +106,14 @@ let reviewFilter = loadReviewFilter();
 let reviewSearch = loadReviewSearch();
 /** @type {string | null} */
 let activeInlineCommentKey = null;
+/** @type {string | null} id of line comment currently being edited */
+let editingCommentId = null;
 /** @type {Record<string, {
  *   generalComment: string,
- *   lineComments: Array<{ id: string, path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>
+ *   lineComments: Array<{ id: string, path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>,
+ *   prTitle: string | null,
+ *   prBody: string | null,
+ *   prMetaDirty: boolean,
  * }>} */
 let reviewDrafts = {};
 /** @type {Record<string, string[]>} changed file paths per job (from API or parsed diff) */
@@ -199,6 +204,8 @@ const els = {
   reviewFilesDeselectAll: document.getElementById('review-files-deselect-all'),
   diffHeader: document.getElementById('diff-header'),
   diffViewer: document.getElementById('diff-viewer'),
+  diffSection: document.getElementById('diff-section'),
+  diffFullscreenBtn: document.getElementById('diff-fullscreen-btn'),
   approveDraftBtn: document.getElementById('approve-draft-btn'),
   approveReadyBtn: document.getElementById('approve-ready-btn'),
   rejectBtn: document.getElementById('reject-btn'),
@@ -294,11 +301,20 @@ function reviewDraftStorageKey(jobId) {
  * @param {string} jobId
  * @returns {{
  *   generalComment: string,
- *   lineComments: Array<{ id: string, path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>
+ *   lineComments: Array<{ id: string, path: string, line: number, side: 'LEFT' | 'RIGHT', body: string }>,
+ *   prTitle: string | null,
+ *   prBody: string | null,
+ *   prMetaDirty: boolean,
  * }}
  */
 function emptyReviewDraft() {
-  return { generalComment: '', lineComments: [] };
+  return {
+    generalComment: '',
+    lineComments: [],
+    prTitle: null,
+    prBody: null,
+    prMetaDirty: false,
+  };
 }
 
 /** @param {string} jobId */
@@ -329,6 +345,9 @@ function loadReviewDraft(jobId) {
                 body: c.body,
               }))
           : [],
+        prTitle: typeof parsed?.prTitle === 'string' ? parsed.prTitle : null,
+        prBody: typeof parsed?.prBody === 'string' ? parsed.prBody : null,
+        prMetaDirty: Boolean(parsed?.prMetaDirty),
       };
       reviewDrafts[jobId] = draft;
       return draft;
@@ -352,10 +371,82 @@ function saveReviewDraft(jobId) {
   }
 }
 
+/**
+ * Resolve editable PR title/body for a job (local draft wins when dirty).
+ * @param {{ id: string, prTitle?: string, prBody?: string }} job
+ */
+function resolvePrMeta(job) {
+  const draft = loadReviewDraft(job.id);
+  if (!draft.prMetaDirty) {
+    return {
+      prTitle: job.prTitle || '',
+      prBody: job.prBody || '',
+    };
+  }
+  return {
+    prTitle: draft.prTitle != null ? draft.prTitle : job.prTitle || '',
+    prBody: draft.prBody != null ? draft.prBody : job.prBody || '',
+  };
+}
+
+/**
+ * Persist PR title/body edits from the form into the review draft.
+ * @param {string} jobId
+ */
+function persistPrMetaFromForm(jobId) {
+  if (!els.prTitle || !els.prBody) return;
+  const draft = loadReviewDraft(jobId);
+  draft.prTitle = els.prTitle.value;
+  draft.prBody = els.prBody.value;
+  draft.prMetaDirty = true;
+  saveReviewDraft(jobId);
+}
+
+/**
+ * Keep PR title/body across comment-only draft clears (submit review).
+ * @param {string} jobId
+ */
+function clearReviewCommentDraft(jobId) {
+  const prev = loadReviewDraft(jobId);
+  const kept = {
+    prTitle: prev.prTitle,
+    prBody: prev.prBody,
+    prMetaDirty: prev.prMetaDirty,
+  };
+  clearReviewDraft(jobId);
+  if (kept.prMetaDirty) {
+    const draft = loadReviewDraft(jobId);
+    draft.prTitle = kept.prTitle;
+    draft.prBody = kept.prBody;
+    draft.prMetaDirty = true;
+    saveReviewDraft(jobId);
+  }
+}
+
+function isDiffFullscreen() {
+  return Boolean(els.diffSection?.classList.contains('diff-fullscreen'));
+}
+
+/** @param {boolean} on */
+function setDiffFullscreen(on) {
+  if (!els.diffSection) return;
+  els.diffSection.classList.toggle('diff-fullscreen', on);
+  document.body.classList.toggle('diff-fs-open', on);
+  if (els.diffFullscreenBtn) {
+    els.diffFullscreenBtn.textContent = on ? 'Exit fullscreen' : 'Fullscreen';
+    els.diffFullscreenBtn.setAttribute('aria-pressed', on ? 'true' : 'false');
+  }
+}
+
+function toggleDiffFullscreen() {
+  setDiffFullscreen(!isDiffFullscreen());
+}
+
 /** @param {string} jobId */
 function clearReviewDraft(jobId) {
   delete reviewDrafts[jobId];
   activeInlineCommentKey = null;
+  editingCommentId = null;
   try {
     sessionStorage.removeItem(reviewDraftStorageKey(jobId));
   } catch {
@@ -363,6 +454,70 @@ function clearReviewDraft(jobId) {
   }
 }
 
+/**
+ * Re-render diff + pending list after draft mutation.
+ * @param {string} jobId
+ */
+function refreshReviewCommentUi(jobId) {
+  const job = jobsById[jobId];
+  if (job) {
+    const diff =
+      job.status === 'awaiting_review'
+        ? filterDiffForReviewJob(job)
+        : job.diff || '';
+    renderDiff(diff, {
+      interactive: job.status === 'awaiting_review',
+      jobId,
+    });
+  }
+  renderPendingCommentList(jobId);
+  syncSubmitReviewButton(jobId);
+}
+
+/**
+ * @param {{
+ *   initialBody: string,
+ *   saveLabel?: string,
+ *   onSave: (body: string) => void,
+ *   onCancel: () => void,
+ * }} opts
+ */
+function buildCommentEditForm(opts) {
+  const form = document.createElement('div');
+  form.className = 'diff-inline-form';
+  const ta = document.createElement('textarea');
+  ta.className = 'input textarea';
+  ta.rows = 3;
+  ta.value = opts.initialBody;
+  ta.placeholder = 'Edit comment…';
+  const actions = document.createElement('div');
+  actions.className = 'diff-inline-actions';
+  const save = document.createElement('button');
+  save.type = 'button';
+  save.className = 'btn btn-primary btn-sm';
+  save.textContent = opts.saveLabel || 'Save';
+  const cancel = document.createElement('button');
+  cancel.type = 'button';
+  cancel.className = 'btn btn-secondary btn-sm';
+  cancel.textContent = 'Cancel';
+  cancel.addEventListener('click', () => opts.onCancel());
+  save.addEventListener('click', () => {
+    const body = ta.value.trim();
+    if (!body) return;
+    opts.onSave(body);
+  });
+  actions.appendChild(save);
+  actions.appendChild(cancel);
+  form.appendChild(ta);
+  form.appendChild(actions);
+  requestAnimationFrame(() => {
+    ta.focus();
+    const len = ta.value.length;
+    ta.setSelectionRange(len, len);
+  });
+  return form;
+}
+
 /** @param {string} jobId */
 function reviewFilesStorageKey(jobId) {
   return `${REVIEW_FILES_PREFIX}${jobId}`;
@@ -1162,6 +1317,7 @@ function renderDiff(diff, opts = {}) {
     plus.addEventListener('click', (e) => {
       e.stopPropagation();
       activeInlineCommentKey = lineCommentKey(path, line, side);
+      editingCommentId = null;
       renderDiff(diff, opts);
       renderPendingCommentList(jobId);
       syncSubmitReviewButton(jobId);
@@ -1171,6 +1327,7 @@ function renderDiff(diff, opts = {}) {
     cell.addEventListener('click', (e) => {
       if (e.target.closest('button, textarea, a')) return;
       activeInlineCommentKey = lineCommentKey(path, line, side);
+      editingCommentId = null;
       renderDiff(diff, opts);
       renderPendingCommentList(jobId);
       syncSubmitReviewButton(jobId);
@@ -1225,6 +1382,27 @@ function renderDiff(diff, opts = {}) {
     thread.appendChild(meta);
 
     for (const c of existing) {
+      if (editingCommentId === c.id) {
+        thread.appendChild(
+          buildCommentEditForm({
+            initialBody: c.body,
+            onSave: (body) => {
+              const d = loadReviewDraft(jobId);
+              const target = d.lineComments.find((x) => x.id === c.id);
+              if (target) target.body = body;
+              saveReviewDraft(jobId);
+              editingCommentId = null;
+              refreshReviewCommentUi(jobId);
+            },
+            onCancel: () => {
+              editingCommentId = null;
+              refreshReviewCommentUi(jobId);
+            },
+          })
+        );
+        continue;
+      }
+
       const chip = document.createElement('div');
       chip.className = 'diff-pending-chip';
       const body = document.createElement('div');
@@ -1232,6 +1410,15 @@ function renderDiff(diff, opts = {}) {
       body.textContent = c.body;
       const actions = document.createElement('div');
       actions.className = 'diff-pending-chip-actions';
+      const edit = document.createElement('button');
+      edit.type = 'button';
+      edit.className = 'btn btn-muted-text btn-sm';
+      edit.textContent = 'Edit';
+      edit.addEventListener('click', () => {
+        editingCommentId = c.id;
+        activeInlineCommentKey = null;
+        refreshReviewCommentUi(jobId);
+      });
       const remove = document.createElement('button');
       remove.type = 'button';
       remove.className = 'btn btn-muted-text btn-sm';
@@ -1240,10 +1427,10 @@ function renderDiff(diff, opts = {}) {
         const d = loadReviewDraft(jobId);
         d.lineComments = d.lineComments.filter((x) => x.id !== c.id);
         saveReviewDraft(jobId);
-        renderDiff(diff, opts);
-        renderPendingCommentList(jobId);
-        syncSubmitReviewButton(jobId);
+        if (editingCommentId === c.id) editingCommentId = null;
+        refreshReviewCommentUi(jobId);
       });
+      actions.appendChild(edit);
       actions.appendChild(remove);
       chip.appendChild(body);
       chip.appendChild(actions);
@@ -1495,11 +1682,46 @@ function renderPendingCommentList(jobId) {
     const loc = document.createElement('div');
     loc.className = 'review-pending-item-loc';
     loc.textContent = `${c.path}:${c.line} (${c.side})`;
+    main.appendChild(loc);
+
+    if (editingCommentId === c.id) {
+      main.appendChild(
+        buildCommentEditForm({
+          initialBody: c.body,
+          onSave: (body) => {
+            const d = loadReviewDraft(jobId);
+            const target = d.lineComments.find((x) => x.id === c.id);
+            if (target) target.body = body;
+            saveReviewDraft(jobId);
+            editingCommentId = null;
+            refreshReviewCommentUi(jobId);
+          },
+          onCancel: () => {
+            editingCommentId = null;
+            refreshReviewCommentUi(jobId);
+          },
+        })
+      );
+      item.appendChild(main);
+      els.reviewPendingList.appendChild(item);
+      continue;
+    }
+
     const body = document.createElement('div');
     body.className = 'review-pending-item-body';
     body.textContent = c.body;
-    main.appendChild(loc);
     main.appendChild(body);
+    const actions = document.createElement('div');
+    actions.className = 'review-pending-item-actions';
+    const edit = document.createElement('button');
+    edit.type = 'button';
+    edit.className = 'btn btn-muted-text btn-sm';
+    edit.textContent = 'Edit';
+    edit.addEventListener('click', () => {
+      editingCommentId = c.id;
+      activeInlineCommentKey = null;
+      refreshReviewCommentUi(jobId);
+    });
     const remove = document.createElement('button');
     remove.type = 'button';
     remove.className = 'btn btn-muted-text btn-sm';
@@ -1508,19 +1730,13 @@ function renderPendingCommentList(jobId) {
       const d = loadReviewDraft(jobId);
       d.lineComments = d.lineComments.filter((x) => x.id !== c.id);
       saveReviewDraft(jobId);
-      const job = jobsById[jobId];
-      if (job) {
-        const diff =
-          job.status === 'awaiting_review'
-            ? filterDiffForReviewJob(job)
-            : job.diff || '';
-        renderDiff(diff, { interactive: job.status === 'awaiting_review', jobId });
-      }
-      renderPendingCommentList(jobId);
-      syncSubmitReviewButton(jobId);
+      if (editingCommentId === c.id) editingCommentId = null;
+      refreshReviewCommentUi(jobId);
     });
+    actions.appendChild(edit);
+    actions.appendChild(remove);
     item.appendChild(main);
-    item.appendChild(remove);
+    item.appendChild(actions);
     els.reviewPendingList.appendChild(item);
   }
 }
@@ -1533,6 +1749,9 @@ function syncSubmitReviewButton(jobId) {
 }
 
 function setView(view) {
+  if (view !== 'review' && isDiffFullscreen()) {
+    setDiffFullscreen(false);
+  }
   currentView = view;
   els.viewTitle.textContent = VIEW_TITLES[view] || view;
 
@@ -2021,6 +2240,7 @@ function renderReview(jobs) {
   if (!hasPool) {
     els.reviewNoMatches.classList.add('hidden');
     els.reviewLayout.classList.add('hidden');
+    if (isDiffFullscreen()) setDiffFullscreen(false);
     return;
   }
 
@@ -2084,9 +2304,10 @@ function renderReview(jobs) {
   els.reviewPrSection.classList.toggle('hidden', !isOpened);
   els.reviewTerminalSection.classList.toggle('hidden', !isTerminal);
 
+  const prMeta = resolvePrMeta(job);
   if (document.activeElement !== els.prTitle && document.activeElement !== els.prBody) {
-    els.prTitle.value = job.prTitle || '';
-    els.prBody.value = job.prBody || '';
+    els.prTitle.value = prMeta.prTitle;
+    els.prBody.value = prMeta.prBody;
   }
 
   if (editable) {
@@ -2097,7 +2318,12 @@ function renderReview(jobs) {
     ) {
       els.reviewGeneralComment.value = draft.generalComment;
     }
-    renderPendingCommentList(job.id);
+    const focusInPending = Boolean(
+      els.reviewPendingList?.contains(document.activeElement)
+    );
+    if (!(editingCommentId && focusInPending)) {
+      renderPendingCommentList(job.id);
+    }
     syncSubmitReviewButton(job.id);
     renderReviewFilesPanel(job);
   }
@@ -2126,7 +2352,9 @@ function renderReview(jobs) {
   }
 
   const focusInDiff = els.diffViewer?.contains(document.activeElement);
-  if (!(activeInlineCommentKey && focusInDiff)) {
+  const preservingDiffCompose =
+    (activeInlineCommentKey || editingCommentId) && focusInDiff;
+  if (!preservingDiffCompose) {
     renderDiff(displayDiff, { interactive: editable, jobId: job.id });
   }
 
@@ -3113,12 +3341,14 @@ async function approve(draft) {
     b.dataset.busy = '1';
   });
   try {
+    persistPrMetaFromForm(jobId);
+    const prMeta = resolvePrMeta(jobsById[jobId] || { id: jobId });
     const res = await fetch(`/api/jobs/${jobId}/approve`, {
       method: 'POST',
       headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({
-        prTitle: els.prTitle.value,
-        prBody: els.prBody.value,
+        prTitle: prMeta.prTitle,
+        prBody: prMeta.prBody,
         draft,
         excludedPaths,
       }),
@@ -3126,6 +3356,7 @@ async function approve(draft) {
     if (res.ok) {
       clearExcludedPaths(jobId);
       delete reviewFileLists[jobId];
+      clearReviewDraft(jobId);
     }
     await fetchJobs();
     if (!res.ok) {
@@ -3188,7 +3419,7 @@ async function submitReview() {
       return;
     }
 
-    clearReviewDraft(jobId);
+    clearReviewCommentDraft(jobId);
     if (els.reviewGeneralComment) els.reviewGeneralComment.value = '';
     selectedRunId = jobId;
     selectedReviewId = null;
@@ -3234,9 +3465,29 @@ els.reviewGeneralComment?.addEventListener('input', () => {
   syncSubmitReviewButton(selectedReviewId);
 });
 
+function onPrMetaInput() {
+  if (!selectedReviewId) return;
+  persistPrMetaFromForm(selectedReviewId);
+}
+
+els.prTitle?.addEventListener('input', onPrMetaInput);
+els.prBody?.addEventListener('input', onPrMetaInput);
+
+els.diffFullscreenBtn?.addEventListener('click', () => toggleDiffFullscreen());
+
+document.addEventListener('keydown', (e) => {
+  if (e.key === 'Escape' && isDiffFullscreen()) {
+    e.preventDefault();
+    setDiffFullscreen(false);
+  }
+});
+
 els.rejectBtn.addEventListener('click', async () => {
   if (!selectedReviewId) return;
-  await fetch(`/api/jobs/${selectedReviewId}/reject`, { method: 'POST' });
+  const jobId = selectedReviewId;
+  await fetch(`/api/jobs/${jobId}/reject`, { method: 'POST' });
+  clearReviewDraft(jobId);
+  if (isDiffFullscreen()) setDiffFullscreen(false);
   selectedReviewId = null;
   await fetchJobs();
 });

package/public/index.html

@@ -185,11 +185,23 @@
             <div class="review-detail" id="review-detail">
               <div class="empty-dashed" id="review-empty-detail">Select a job to review</div>
               <div class="stack hidden" id="review-detail-content">
-                <div class="card">
+                <div class="card" id="review-pr-meta-card">
                   <div class="field-label">PR title</div>
-                  <input id="pr-title" class="input input-title" type="text">
+                  <input
+                    id="pr-title"
+                    class="input input-title"
+                    type="text"
+                    placeholder="Pull request title"
+                    autocomplete="off"
+                  >
                   <div class="field-label field-label-spaced">Description</div>
-                  <textarea id="pr-body" class="input textarea" rows="4"></textarea>
+                  <textarea
+                    id="pr-body"
+                    class="input textarea"
+                    rows="4"
+                    placeholder="Pull request description…"
+                  ></textarea>
+                  <p class="field-hint" id="pr-meta-hint">Editable before approve. Edits stick across refreshes until you approve or reject.</p>
                 </div>
 
                 <div class="card" id="review-files-section">
@@ -204,8 +216,13 @@
                   <div id="review-files-list" class="review-files-list"></div>
                 </div>
 
-                <div>
-                  <div class="section-label" id="diff-header">Diff</div>
+                <div id="diff-section" class="diff-section">
+                  <div class="diff-section-bar">
+                    <div class="section-label" id="diff-header">Diff</div>
+                    <button type="button" class="btn btn-muted-text btn-sm" id="diff-fullscreen-btn" aria-pressed="false">
+                      Fullscreen
+                    </button>
+                  </div>
                   <div id="diff-viewer" class="diff-viewer amcp-scroll"></div>
                 </div>
 

package/public/styles.css

@@ -1233,6 +1233,24 @@ a { color: var(--primary); text-underline-offset: 3px; }
 }
 
 /* —— Diff (side-by-side, GitHub-style column panes) —— */
+.diff-section {
+  display: flex;
+  flex-direction: column;
+  gap: 8px;
+  min-width: 0;
+}
+
+.diff-section-bar {
+  display: flex;
+  align-items: center;
+  justify-content: space-between;
+  gap: 12px;
+}
+
+.diff-section-bar .section-label {
+  margin: 0;
+}
+
 .diff-viewer {
   border: 1px solid var(--border);
   border-radius: 10px;
@@ -1244,6 +1262,28 @@ a { color: var(--primary); text-underline-offset: 3px; }
   background: var(--surface);
 }
 
+.diff-section.diff-fullscreen {
+  position: fixed;
+  inset: 0;
+  z-index: 1200;
+  margin: 0;
+  padding: 14px 16px 16px;
+  background: var(--bg);
+  gap: 10px;
+  box-sizing: border-box;
+}
+
+.diff-section.diff-fullscreen .diff-viewer {
+  max-height: none;
+  flex: 1 1 auto;
+  min-height: 0;
+  border-radius: 12px;
+}
+
+body.diff-fs-open {
+  overflow: hidden;
+}
+
 .diff-file + .diff-file {
   border-top: 1px solid var(--border);
 }
@@ -1439,6 +1479,9 @@ a { color: var(--primary); text-underline-offset: 3px; }
 
 .diff-pending-chip-actions {
   margin-top: 6px;
+  display: flex;
+  gap: 4px;
+  flex-wrap: wrap;
 }
 
 .review-pending-list {
@@ -1469,6 +1512,13 @@ a { color: var(--primary); text-underline-offset: 3px; }
   flex: 1;
 }
 
+.review-pending-item-actions {
+  display: flex;
+  flex-direction: column;
+  gap: 2px;
+  flex-shrink: 0;
+}
+
 .review-pending-item-loc {
   font-size: 11px;
   font-weight: 600;