account-lookup-service 17.9.0-snapshot.1 → 17.9.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [17.9.0](https://github.com/mojaloop/account-lookup-service/compare/v17.8.1...v17.9.0) (2025-04-08)
+
+
+### Features
+
+* **csi-1350:** refactored oracleRequest ([#546](https://github.com/mojaloop/account-lookup-service/issues/546)) ([3f76ef7](https://github.com/mojaloop/account-lookup-service/commit/3f76ef7f712590e82bcb5bf7e49a643b2aae63f3))
+
 ### [17.8.1](https://github.com/mojaloop/account-lookup-service/compare/v17.8.0...v17.8.1) (2025-04-07)
 
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "17.9.0-snapshot.1",
+  "version": "17.9.0",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [

package/src/models/oracle/facade.js

@@ -408,6 +408,7 @@ const _getOracleEndpointByTypeCurrencyAndSubId = async (partyIdType, partyIdenti
  * @returns {object} - response from the oracle
  */
 const oracleBatchRequest = async (headers, method, requestPayload, type, payload) => {
+  let step = 'getOracleEndpoint'
   try {
     let oracleEndpointModel
     let url
@@ -416,33 +417,37 @@ const oracleBatchRequest = async (headers, method, requestPayload, type, payload
     } else {
       oracleEndpointModel = await oracleEndpointCached.getOracleEndpointByType(type)
     }
-    if (oracleEndpointModel.length > 0) {
-      if (oracleEndpointModel.length > 1) {
-        for (const record of oracleEndpointModel) {
-          if (record.isDefault) {
-            url = record.value + Enums.EndPoints.FspEndpointTemplates.ORACLE_PARTICIPANTS_BATCH
-            break
-          }
+
+    if (!Array.isArray(oracleEndpointModel) || oracleEndpointModel.length === 0) {
+      const errMessage = `Oracle type:${type} not found`
+      logger.warn(errMessage)
+      throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ADD_PARTY_INFO_ERROR, errMessage)
+    }
+
+    if (oracleEndpointModel.length > 1) {
+      for (const record of oracleEndpointModel) {
+        if (record.isDefault) {
+          url = record.value + Enums.EndPoints.FspEndpointTemplates.ORACLE_PARTICIPANTS_BATCH
+          break
         }
-      } else {
-        url = oracleEndpointModel[0].value + Enums.EndPoints.FspEndpointTemplates.ORACLE_PARTICIPANTS_BATCH
       }
-      logger.debug(`Oracle endpoints: ${url}`)
-      return await sendHttpRequest({
-        url,
-        headers,
-        source: headers[Headers.FSPIOP.SOURCE],
-        destination: headers[Headers.FSPIOP.DESTINATION] || Config.HUB_NAME,
-        method,
-        payload
-      })
     } else {
-      logger.error(`Oracle type:${type} not found`)
-      throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ADD_PARTY_INFO_ERROR, `Oracle type:${type} not found`)
+      url = oracleEndpointModel[0].value + Enums.EndPoints.FspEndpointTemplates.ORACLE_PARTICIPANTS_BATCH
     }
+    logger.verbose(`Oracle endpoint: ${url}`)
+
+    step = 'sendHttpRequest'
+    return await sendHttpRequest({
+      url,
+      headers,
+      source: headers[Headers.FSPIOP.SOURCE],
+      destination: headers[Headers.FSPIOP.DESTINATION] || Config.HUB_NAME,
+      method,
+      payload
+    })
   } catch (err) {
     logger.error('error in oracleBatchRequest: ', err)
-    throw ErrorHandler.Factory.reformatFSPIOPError(err)
+    throw countFspiopError(err, { operation: 'oracleBatchRequest', step })
   }
 }