account-lookup-service 17.8.0-snapshot.17 → 17.8.0-snapshot.18

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "17.8.0-snapshot.17",
+  "version": "17.8.0-snapshot.18",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [

package/src/constants.js

@@ -29,6 +29,7 @@ const { API_TYPES } = require('@mojaloop/central-services-shared').Util.Hapi
 
 const ERROR_MESSAGES = Object.freeze({
   emptyFilteredPartyList: 'Empty oracle partyList, filtered based on callbackEndpointType',
+  externalPartyError: 'External party error', // todo: think better message
   failedToCacheSendToProxiesList: 'Failed to cache sendToProxiesList',
   noDiscoveryRequestsForwarded: 'No discovery requests forwarded to participants',
   sourceFspNotFound: 'Requester FSP not found',

package/src/domain/parties/putParties.js

@@ -97,15 +97,7 @@ const putPartiesErrorByTypeAndID = async (headers, params, payload, dataUri, spa
   let fspiopError
 
   try {
-    const needDiscovery = await service.handleRequest()
-    if (needDiscovery) {
-      const getPartiesService = new services.GetPartiesService(deps, inputs)
-      await getPartiesService.triggerInterSchemeDiscoveryFlow(
-        services.GetPartiesService.headersWithoutDestination(headers)
-      )
-      // think, if we need to start the whole processing with getPartiesService.handleRequest() ?
-    }
-
+    await service.handleRequest()
     logger.info('putPartiesErrorByTypeAndID is done')
     histTimerEnd({ success: true })
   } catch (error) {

package/src/domain/parties/services/BasePartiesService.js

@@ -186,6 +186,11 @@ class BasePartiesService {
     return ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.PARTY_NOT_FOUND, errMessage)
   }
 
+  createFspiopServiceUnavailableError (errMessage, log = this.log) {
+    log.warn(errMessage)
+    return ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.SERVICE_CURRENTLY_UNAVAILABLE, errMessage)
+  }
+
   stepInProgress (stepName) {
     this.log.debug('step is in progress', { stepName })
     this.state.stepState?.inProgress(stepName)

package/src/domain/parties/services/PutPartiesErrorService.js

@@ -26,9 +26,9 @@
  ******/
 
 const BasePartiesService = require('./BasePartiesService')
+const { ERROR_MESSAGES } = require('../../../constants')
 
 class PutPartiesErrorService extends BasePartiesService {
-  /** @returns {Promise<true | undefined>} - If true, need to trigger inter-scheme discovery. */
   async handleRequest () {
     if (this.state.proxyEnabled && this.state.proxy) {
       const alsReq = this.deps.partiesUtils.alsRequestDto(this.state.destination, this.inputs.params) // or source?
@@ -37,23 +37,24 @@ class PutPartiesErrorService extends BasePartiesService {
       if (isInterSchemeDiscoveryCase) {
         const isLast = await this.checkLastProxyCallback(alsReq)
         if (!isLast) {
-          this.log.verbose('putPartiesErrorByTypeAndID proxy callback was processed')
+          this.log.verbose('proxy error callback was processed (not last)')
           return
         }
       } else {
         const schemeParticipant = await this.validateParticipant(this.state.destination)
         if (schemeParticipant) {
-          this.log.warn('Need to cleanup oracle and trigger new inter-scheme discovery flow')
+          const err = super.createFspiopServiceUnavailableError(ERROR_MESSAGES.externalPartyError)
+          this.log.info('Need to cleanup oracle and throw SERVICE_CURRENTLY_UNAVAILABLE error')
           await this.cleanupOracle()
           await this.removeProxyGetPartiesTimeoutCache(alsReq)
-          return true // need to trigger inter-scheme discovery
+          throw err
         }
       }
     }
 
     await this.identifyDestinationForCallback()
     await this.sendErrorCallbackToParticipant()
-    this.log.info('putPartiesByTypeAndID is done')
+    this.log.info('handleRequest is done')
   }
 
   async cleanupOracle () {

package/test/unit/domain/parties/parties.test.js

@@ -927,7 +927,7 @@ describe('Parties Tests', () => {
       expect(sendErrorCallArgs[1]).toBe(expectedCallbackEnpointType)
     })
 
-    it('should handle notValidPayeeIdentifier case, and delete partyId from oracle', async () => {
+    it('should handle external party error callback, and delete partyId from oracle', async () => {
       Config.PROXY_CACHE_CONFIG.enabled = true
       const errorCode = MojaloopApiErrorCodes.PAYEE_IDENTIFIER_NOT_VALID.code
       const payload = fixtures.errorCallbackResponseDto({ errorCode })
@@ -945,11 +945,14 @@ describe('Parties Tests', () => {
 
       await partiesDomain.putPartiesErrorByTypeAndID(headers, params, payload, '', null, null, proxyCache)
 
-      expect(participant.sendRequest.callCount).toBe(0)
       expect(oracle.oracleRequest.callCount).toBe(1)
-      const [, method] = oracle.oracleRequest.getCall(0).args
-      expect(method).toBe(RestMethods.DELETE)
-      expect(Util.proxies.getAllProxiesNames.callCount).toBe(1) // inter-scheme discovery flow was triggered
+      expect(oracle.oracleRequest.lastCall.args[1]).toBe(RestMethods.DELETE)
+      expect(participant.sendRequest.callCount).toBe(0)
+      expect(participant.sendErrorToParticipant.callCount).toBe(1)
+      // eslint-disable-next-line no-unused-vars
+      const [sentTo, _, data] = participant.sendErrorToParticipant.lastCall.args
+      expect(sentTo).toBe(source)
+      expect(data.errorInformation.errorCode).toBe('2003')
     })
   })
 })

package/test/unit/domain/parties/services/PutPartiesErrorService.test.js

@@ -29,6 +29,7 @@ const { createMockDeps, oracleMock, participantMock } = require('./deps')
 // ↑ should be first require to mock external deps ↑
 const { PutPartiesErrorService } = require('#src/domain/parties/services/index')
 const fixtures = require('#test/fixtures/index')
+const { ERROR_MESSAGES } = require('#src/constants')
 
 const { RestMethods } = PutPartiesErrorService.enums()
 
@@ -37,16 +38,21 @@ describe('PutPartiesErrorService Tests -->', () => {
     jest.clearAllMocks()
   })
 
-  test('should cleanup oracle and trigger discovery flow for party from external dfsp', async () => {
+  test('should cleanup oracle and throw SERVICE_CURRENTLY_UNAVAILABLE error for party from external dfsp', async () => {
+    expect.hasAssertions()
     participantMock.validateParticipant = jest.fn().mockResolvedValue({})
     const headers = fixtures.partiesCallHeadersDto({ proxy: 'proxyA' })
     const params = fixtures.partiesParamsDto()
-    const service = new PutPartiesErrorService(createMockDeps(), { headers, params })
+    const dataUri = fixtures.dataUriDto()
+    const service = new PutPartiesErrorService(createMockDeps(), { headers, params, dataUri })
 
-    const needDiscovery = await service.handleRequest()
-    expect(needDiscovery).toBe(true)
-    expect(oracleMock.oracleRequest).toHaveBeenCalledTimes(1)
-    expect(oracleMock.oracleRequest.mock.lastCall[1]).toBe(RestMethods.DELETE)
+    await service.handleRequest()
+      .catch(err => {
+        expect(err).toEqual(service.createFspiopServiceUnavailableError(ERROR_MESSAGES.externalPartyError))
+        expect(oracleMock.oracleRequest).toHaveBeenCalledTimes(1)
+        expect(oracleMock.oracleRequest.mock.lastCall[1]).toBe(RestMethods.DELETE)
+        expect(participantMock.sendErrorToParticipant).not.toHaveBeenCalled()
+      })
   })
 
   test('should NOT cleanup oracle if destination is external', async () => {
@@ -63,8 +69,7 @@ describe('PutPartiesErrorService Tests -->', () => {
     const dataUri = fixtures.dataUriDto()
     const service = new PutPartiesErrorService(deps, { headers, params, dataUri })
 
-    const needDiscovery = await service.handleRequest()
-    expect(needDiscovery).toBeUndefined()
+    await service.handleRequest()
     expect(oracleMock.oracleRequest).not.toHaveBeenCalled()
     expect(participantMock.sendErrorToParticipant).toHaveBeenCalledTimes(1)
     expect(participantMock.sendErrorToParticipant.mock.lastCall[0]).toBe(proxyDest)