account-lookup-service 17.14.0-snapshot.3 → 17.14.0-snapshot.5

package/config/default.json

@@ -52,14 +52,14 @@
     "getDecoratedValue": true
   },
   "CENTRAL_SHARED_PARTICIPANT_CACHE_CONFIG": {
-    "expiresIn": 61000,
+    "expiresIn": 3000,
     "generateTimeout": 30000,
     "getDecoratedValue": true
   },
   "GENERAL_CACHE_CONFIG": {
     "CACHE_ENABLED": false,
     "MAX_BYTE_SIZE": 10000000,
-    "EXPIRES_IN_MS": 61000
+    "EXPIRES_IN_MS": 3000
   },
   "PROXY_CACHE": {
     "enabled": true,

package/docker/account-lookup-service/default.json

@@ -51,14 +51,14 @@
     "getDecoratedValue": true
   },
   "CENTRAL_SHARED_PARTICIPANT_CACHE_CONFIG": {
-    "expiresIn": 61000,
+    "expiresIn": 3000,
     "generateTimeout": 30000,
     "getDecoratedValue": true
   },
   "GENERAL_CACHE_CONFIG": {
     "CACHE_ENABLED": false,
     "MAX_BYTE_SIZE": 10000000,
-    "EXPIRES_IN_MS": 61000
+    "EXPIRES_IN_MS": 3000
   },
   "PROXY_CACHE": {
     "enabled": true,

package/docker/config-modifier/account-lookup-service.js

@@ -7,7 +7,7 @@ module.exports = {
   GENERAL_CACHE_CONFIG: {
     CACHE_ENABLED: true,
     MAX_BYTE_SIZE: 10000000,
-    EXPIRES_IN_MS: 61000
+    EXPIRES_IN_MS: 3000
   },
   CENTRAL_SHARED_PARTICIPANT_CACHE_CONFIG: {
     expiresIn: 1,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "17.14.0-snapshot.3",
+  "version": "17.14.0-snapshot.5",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [
@@ -95,8 +95,8 @@
     "@mojaloop/central-services-health": "15.1.0",
     "@mojaloop/central-services-logger": "11.10.1",
     "@mojaloop/central-services-metrics": "12.7.1",
-    "@mojaloop/central-services-shared": "18.33.3",
-    "@mojaloop/central-services-stream": "11.8.7",
+    "@mojaloop/central-services-shared": "18.33.4",
+    "@mojaloop/central-services-stream": "11.8.8",
     "@mojaloop/database-lib": "^11.3.2",
     "@mojaloop/event-sdk": "14.7.0",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.7.0-snapshot.2",

package/src/domain/parties/services/PutPartiesErrorService.js

@@ -35,17 +35,17 @@ class PutPartiesErrorService extends BasePartiesService {
       this.log.verbose(`isInterSchemeDiscoveryCase: ${isInterSchemeDiscoveryCase}`, this.state)
 
       if (isInterSchemeDiscoveryCase) {
-        const isLast = await this.checkLastProxyCallback(alsReq)
-        if (!isLast) {
-          this.log.verbose('proxy error callback was processed (not last)')
+        const isLastAndNoSuccess = await this.checkLastProxyCallback(alsReq)
+        if (!isLastAndNoSuccess) {
+          this.log.verbose('proxy error callback was processed - not last OR has success, skip forwarding')
           return
         }
       } else {
-        const isExternal = await this.#isPartyFromExternalDfsp() // !!! DO not clear oracle for the error callback for the same inter-scheme discovery flow
+        const isExternal = await this.#isPartyFromExternalDfsp()
         if (isExternal) {
           this.log.info('need to cleanup oracle coz party is from external DFSP')
           await this.cleanupOracle()
-          await this.removeProxyGetPartiesTimeoutCache(alsReq) // todo: think if we need this
+          await this.removeProxyGetPartiesTimeoutCache(alsReq)
         }
       }
     }

package/src/domain/parties/services/TimeoutPartiesService.js

@@ -58,6 +58,8 @@ class TimeoutPartiesService extends PutPartiesErrorService {
 
   async prepareErrorInformation () {
     const { headers, params } = this.inputs
+    headers.date = new Date().toUTCString()
+
     const error = TimeoutPartiesService.createFSPIOPExpiredError()
     const errorInfo = await this.deps.partiesUtils.makePutPartiesErrorPayload(
       this.deps.config, error, headers, params

package/src/models/oracle/facade.js

@@ -126,7 +126,7 @@ const determineOracleEndpoint = async ({
     url = await _getOracleEndpointByType(partyIdType, partyIdentifier, assertPendingAcquire)
   }
 
-  logger.verbose(`Oracle endpoint: ${url}`, { currency, params, partySubIdOrType, url })
+  logger.debug(`Oracle endpoint: ${url}`, { currency, params, partySubIdOrType, url })
   return url
 }
 

package/test/integration/api/parties.test.js

@@ -43,10 +43,6 @@ describe('Parties Endpoints Tests -->', () => {
     await proxyCache.connect()
   })
 
-  // beforeEach(async () => {
-  //   await proxyCache.redisClient.flushdb()
-  // })
-
   afterAll(async () => {
     await proxyCache.disconnect()
   })

package/test/unit/domain/parties/services/TimeoutPartiesService.test.js

@@ -50,7 +50,9 @@ describe('TimeoutPartiesService Tests -->', () => {
 
     await service.handleExpiredKey()
     expect(participantMock.sendErrorToParticipant).toHaveBeenCalledTimes(1)
-    expect(participantMock.sendErrorToParticipant.mock.lastCall[0]).toBe(proxy)
+    const [sendTo, , , cbHeaders] = participantMock.sendErrorToParticipant.mock.lastCall
+    expect(sendTo).toBe(proxy)
+    expect(cbHeaders.date).toBeDefined()
   })
 
   test('should send error callback in ISO20022 format', async () => {