account-lookup-service 17.13.0-snapshot.8 → 17.13.0

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [17.13.0](https://github.com/mojaloop/account-lookup-service/compare/v17.12.10...v17.13.0) (2025-09-16)
+
+
+### Features
+
+* **oss-4203:** added validation of local destination for external source ([#574](https://github.com/mojaloop/account-lookup-service/issues/574)) ([8ca46d6](https://github.com/mojaloop/account-lookup-service/commit/8ca46d6bbacbf30bb4b6dcc739df970e1b46d268))
+
+
+### Chore
+
+* **sbom:** update sbom [skip ci] ([f68b088](https://github.com/mojaloop/account-lookup-service/commit/f68b088b9fa01b96682761bfb946048ea24de54f))
+
 ### [17.12.10](https://github.com/mojaloop/account-lookup-service/compare/v17.12.9...v17.12.10) (2025-09-10)
 
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "17.13.0-snapshot.8",
+  "version": "17.13.0",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [
@@ -91,7 +91,7 @@
     "@hapi/hapi": "21.4.3",
     "@hapi/inert": "7.1.0",
     "@hapi/vision": "7.0.3",
-    "@mojaloop/central-services-error-handling": "13.1.2-snapshot.0",
+    "@mojaloop/central-services-error-handling": "13.1.2",
     "@mojaloop/central-services-health": "15.1.0",
     "@mojaloop/central-services-logger": "11.9.3",
     "@mojaloop/central-services-metrics": "12.7.1",
@@ -101,7 +101,7 @@
     "@mojaloop/event-sdk": "14.7.0",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.6.0",
     "@mojaloop/ml-schema-transformer-lib": "2.7.8",
-    "@mojaloop/sdk-standard-components": "19.16.9",
+    "@mojaloop/sdk-standard-components": "19.17.0",
     "@now-ims/hapi-now-auth": "2.1.0",
     "ajv": "8.17.1",
     "ajv-keywords": "5.1.0",
@@ -124,7 +124,6 @@
     "postcss": {
       "nanoid": "^3.3.8"
     },
-    "@mojaloop/central-services-error-handling": "13.1.2-snapshot.0",
     "@mojaloop/central-services-health": {
       "@mojaloop/central-services-logger": ">=11.4.0"
     },

package/src/domain/parties/putParties.js

@@ -47,7 +47,7 @@ const services = require('./services')
  * @param {IProxyCache} [proxyCache] - IProxyCache instance
  */
 const putPartiesByTypeAndID = async (headers, params, method, payload, dataUri, cache, proxyCache = undefined) => {
-  // todo: think, if we need to pass span here
+  // think, if we need to pass span here
   const component = putPartiesByTypeAndID.name
   const histTimerEnd = Metrics.getHistogram(
     component,

package/src/domain/parties/services/BasePartiesService.js

@@ -172,7 +172,7 @@ class BasePartiesService {
    * @returns {Promise<{ fspId: string, partySubIdOrType?: string }[]>} List of parties from oracle response
    */
   async sendOracleDiscoveryRequest () {
-    this.stepInProgress('#sendOracleDiscoveryRequest')
+    this.stepInProgress('sendOracleDiscoveryRequest')
     const { headers, params, query } = this.inputs
 
     const response = await this.deps.oracle.oracleRequest(headers, RestMethods.GET, params, query, undefined, this.deps.cache)

package/src/domain/parties/services/PutPartiesErrorService.js

@@ -30,8 +30,9 @@ const BasePartiesService = require('./BasePartiesService')
 class PutPartiesErrorService extends BasePartiesService {
   async handleRequest () {
     if (this.state.proxyEnabled && this.state.proxy) {
-      const alsReq = this.deps.partiesUtils.alsRequestDto(this.state.destination, this.inputs.params) // or source?
+      const alsReq = this.deps.partiesUtils.alsRequestDto(this.state.destination, this.inputs.params)
       const isInterSchemeDiscoveryCase = await this.deps.proxyCache.isPendingCallback(alsReq)
+      this.log.verbose(`isInterSchemeDiscoveryCase: ${isInterSchemeDiscoveryCase}`, this.state)
 
       if (isInterSchemeDiscoveryCase) {
         const isLast = await this.checkLastProxyCallback(alsReq)
@@ -42,11 +43,9 @@ class PutPartiesErrorService extends BasePartiesService {
       } else {
         const isExternal = await this.#isPartyFromExternalDfsp()
         if (isExternal) {
-          this.log.info('Need to cleanup oracle and forward PARTY_RESOLUTION_FAILURE error')
+          this.log.info('need to cleanup oracle coz party is from external DFSP')
           await this.cleanupOracle()
-          await this.removeProxyGetPartiesTimeoutCache(alsReq)
-          await this.sendPartyResolutionErrorCallback() // todo: think, if we need this?
-          return
+          await this.removeProxyGetPartiesTimeoutCache(alsReq) // think if we need this
         }
       }
     }

package/test/unit/domain/parties/parties.test.js

@@ -947,10 +947,10 @@ describe('Parties Tests', () => {
       Config.PROXY_CACHE_CONFIG.enabled = true
       const errorCode = MojaloopApiErrorCodes.PAYEE_IDENTIFIER_NOT_VALID.code
       const payload = fixtures.errorCallbackResponseDto({ errorCode })
-      const source = 'payerFsp'
+      const dataUri = encodePayload(JSON.stringify(payload), 'application/json')
       const destination = `dest-${Date.now()}`
       const proxy = `proxy-${Date.now()}`
-      const headers = fixtures.partiesCallHeadersDto({ source, destination, proxy })
+      const headers = fixtures.partiesCallHeadersDto({ destination, proxy })
       const { params } = Helper.putByTypeIdRequest
       participant.validateParticipant = sandbox.stub().resolves(null) // external participant
       participant.sendRequest = sandbox.stub().resolves()
@@ -963,7 +963,7 @@ describe('Parties Tests', () => {
         data: { partyList: [{ fspId: 'fspId' }] }
       })
 
-      await partiesDomain.putPartiesErrorByTypeAndID(headers, params, payload, '', null, null, proxyCache)
+      await partiesDomain.putPartiesErrorByTypeAndID(headers, params, payload, dataUri, null, null, proxyCache)
 
       expect(oracle.oracleRequest.callCount).toBe(2)
       expect(oracle.oracleRequest.lastCall.args[1]).toBe(RestMethods.DELETE)
@@ -972,9 +972,8 @@ describe('Parties Tests', () => {
       // eslint-disable-next-line no-unused-vars
       const [sentTo, _, data, cbHeaders] = participant.sendErrorToParticipant.lastCall.args
       expect(sentTo).toBe(proxy)
-      expect(cbHeaders[Headers.FSPIOP.DESTINATION]).toBe(source)
-      expect(cbHeaders[Headers.FSPIOP.PROXY]).toBeUndefined()
-      expect(data.errorInformation.errorCode).toBe('2006')
+      expect(cbHeaders[Headers.FSPIOP.DESTINATION]).toBe(destination)
+      expect(JSON.parse(data).errorInformation.errorCode).toBe(errorCode)
     })
   })
 })

package/test/unit/domain/parties/services/PutPartiesErrorService.test.js

@@ -46,15 +46,15 @@ describe('PutPartiesErrorService Tests -->', () => {
     oracle.oracleRequest = jest.fn().mockResolvedValue({
       data: { partyList: [{ fspId: 'fspId' }] }
     })
-    const source = 'externalSource'
     const destination = 'externalDestination'
     const proxyDest = 'proxyDest'
     const deps = createMockDeps({ oracle, participant })
     deps.proxyCache.lookupProxyByDfspId = jest.fn().mockResolvedValue(proxyDest)
 
-    const headers = fixtures.partiesCallHeadersDto({ source, destination, proxy: 'proxyA' })
+    const headers = fixtures.partiesCallHeadersDto({ destination, proxy: 'proxyA' })
     const params = fixtures.partiesParamsDto()
-    const dataUri = fixtures.dataUriDto()
+    const data = { test: true }
+    const dataUri = fixtures.dataUriDto(data)
 
     const service = new PutPartiesErrorService(deps, { headers, params, dataUri })
     await service.handleRequest()
@@ -65,8 +65,8 @@ describe('PutPartiesErrorService Tests -->', () => {
 
     const [sentTo, , payload, cbHeaders] = participant.sendErrorToParticipant.mock.lastCall
     expect(sentTo).toBe(proxyDest)
-    expect(cbHeaders[Headers.FSPIOP.DESTINATION]).toBe(source)
-    expect(payload.errorInformation.errorCode).toBe('2006')
+    expect(cbHeaders[Headers.FSPIOP.DESTINATION]).toBe(destination)
+    expect(payload).toBe(JSON.stringify(data))
   })
 
   test('should NOT cleanup oracle if destination is local', async () => {