account-lookup-service 17.12.6 → 17.12.8

package/src/api/participants/{ID}.js

@@ -25,7 +25,8 @@
 /* istanbul ignore file */
 'use strict'
 
-const ErrorHandler = require('@mojaloop/central-services-error-handling')
+const { Factory, Enums } = require('@mojaloop/central-services-error-handling')
+const { errorInfoDto } = require('../../lib/dto')
 
 /**
  * Operations on /participants/{ID}
@@ -39,6 +40,8 @@ module.exports = {
    * responses: 200, 400, 401, 403, 404, 405, 406, 501, 503
    */
   put: function (context, request, h) {
-    return h.response(ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.NOT_IMPLEMENTED))
+    const { code, message, httpStatusCode } = Factory.createFSPIOPError(Enums.FSPIOPErrorCodes.NOT_IMPLEMENTED).apiErrorCode
+    return h.response(errorInfoDto(code, message))
+      .code(httpStatusCode)
   }
 }

package/src/api/participants/{Type}/{ID}.js

@@ -71,8 +71,8 @@ module.exports = {
       payload
     }, EventSdk.AuditEventAction.start)
 
-    const metadata = `${request.method} ${request.path}`
-    participants.getParticipantsByTypeAndID(request.headers, request.params, request.method, request.query, span, request.server.app.cache).catch(err => {
+    const metadata = `${method} ${path}`
+    participants.getParticipantsByTypeAndID(headers, params, method, request.query, span, request.server.app.cache).catch(err => {
       request.server.log(['error'], `ERROR - getParticipantsByTypeAndID:${metadata}: ${LibUtil.getStackOrInspect(err)}`)
     })
     histTimerEnd({ success: true })
@@ -115,7 +115,7 @@ module.exports = {
       payload
     }, EventSdk.AuditEventAction.start)
 
-    participants.putParticipantsByTypeAndID(request.headers, request.params, request.method, request.payload, request.server.app.cache).catch(err => {
+    participants.putParticipantsByTypeAndID(headers, params, method, payload, request.server.app.cache).catch(err => {
       request.server.log(['error'], `ERROR - putParticipantsByTypeAndID:${metadata}: ${LibUtil.getStackOrInspect(err)}`)
     })
     histTimerEnd({ success: true })
@@ -134,7 +134,7 @@ module.exports = {
       'Ingress: Post participant by Type and Id',
       ['success']
     ).startTimer()
-    const { method, path, params, span } = request
+    const { headers, payload, method, path, params, span } = request
     const spanTags = LibUtil.getSpanTags(request, Enum.Events.Event.Type.PARTICIPANT, Enum.Events.Event.Action.POST)
     span.setTags(spanTags)
     const queryTags = EventFrameworkUtil.Tags.getQueryTags(
@@ -151,11 +151,12 @@ module.exports = {
     )
     span.setTags(queryTags)
     await span.audit({
-      headers: request.headers,
-      payload: request.payload
+      headers,
+      payload
     }, EventSdk.AuditEventAction.start)
-    const metadata = `${request.method} ${request.path}`
-    participants.postParticipants(request.headers, request.method, request.params, request.payload, span, request.server.app.cache).catch(err => {
+
+    const metadata = `${method} ${path}`
+    participants.postParticipants(headers, method, params, payload, span, request.server.app.cache).catch(err => {
       request.server.log(['error'], `ERROR - postParticipants:${metadata}: ${LibUtil.getStackOrInspect(err)}`)
     })
     histTimerEnd({ success: true })
@@ -196,8 +197,8 @@ module.exports = {
       payload: undefined
     }, EventSdk.AuditEventAction.start)
 
-    const metadata = `${request.method} ${request.path}`
-    participants.deleteParticipants(request.headers, request.params, request.method, request.query, request.server.app.cache).catch(err => {
+    const metadata = `${method} ${path}`
+    participants.deleteParticipants(headers, params, method, request.query, request.server.app.cache).catch(err => {
       request.server.log(['error'], `ERROR - deleteParticipants:${metadata}: ${LibUtil.getStackOrInspect(err)}`)
     })
     histTimerEnd({ success: true })

package/src/lib/dto.js

@@ -0,0 +1,38 @@
+/*****
+ License
+ --------------
+ Copyright © 2020-2025 Mojaloop Foundation
+ The Mojaloop files are made available by the Mojaloop Foundation under the Apache License, Version 2.0 (the "License") and you may not use these files except in compliance with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, the Mojaloop files are distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+
+ Contributors
+ --------------
+ This is the official list of the Mojaloop project contributors for this file.
+ Names of the original copyright holders (individuals or organizations)
+ should be listed with a '*' in the first column. People who have
+ contributed from an organization can be listed under the organization
+ that actually holds the copyright for their contributions (see the
+ Mojaloop Foundation for an example). Those individuals should have
+ their names indented and be marked with a '-'. Email address can be added
+ optionally within square brackets <email>.
+
+ * Mojaloop Foundation
+ * Eugen Klymniuk <eugen.klymniuk@infitx.com>
+
+ --------------
+ ******/
+
+const errorInfoDto = (errorCode, errorDescription, extensionList = null) => ({
+  errorInformation: {
+    errorCode,
+    errorDescription,
+    ...(extensionList && { extensionList })
+  }
+})
+
+module.exports = {
+  errorInfoDto
+}

package/test/integration/api/parties.test.js

@@ -68,7 +68,7 @@ describe('Parties Endpoints Tests -->', () => {
 
       await sleep(1000)
       history = await proxyClient.getHistory()
-      expect(history.length).toBe(2)
+      expect(history.length).toBeGreaterThanOrEqual(2)
       expect(history[0].path).toBe(`/oracle/participants/${PARTY_ID_TYPE}/${partyId}`)
       expect(history[1].path).toBe(`/parties/${PARTY_ID_TYPE}/${partyId}`)
 

package/test/unit/api/participants/participants.test.js

@@ -112,4 +112,25 @@ describe('/participants', () => {
     expect(response.statusCode).toBe(500)
     participants.postParticipantsBatch.restore()
   })
+
+  it('should return 501 error on PUT /participants/{ID} call [CSI-1694]', async () => {
+    // Arrange
+    const options = {
+      method: 'put',
+      url: '/participants/123',
+      headers: Helper.defaultSwitchHeaders,
+      payload: {
+        partyList: [
+          { partyId: mock.partyList[0] }
+        ]
+      }
+    }
+
+    // Act
+    const response = await server.inject(options)
+
+    // Assert
+    expect(response.statusCode).toBe(501)
+    expect(response.result.errorInformation).toBeDefined()
+  })
 })