account-lookup-service 17.12.10 → 17.13.0-snapshot.10

package/test/unit/domain/parties/services/PutPartiesErrorService.test.js

@@ -25,45 +25,54 @@
  --------------
  ******/
 
-const { createMockDeps, oracleMock, participantMock } = require('./deps')
-// ↑ should be first require to mock external deps ↑
 const { PutPartiesErrorService } = require('#src/domain/parties/services/index')
+const { createMockDeps, createOracleFacadeMock, createParticipantFacadeMock } = require('./deps')
 const fixtures = require('#test/fixtures/index')
 
 const { RestMethods, Headers } = PutPartiesErrorService.enums()
 
 describe('PutPartiesErrorService Tests -->', () => {
+  let oracle
+  let participant
+
   beforeEach(() => {
     jest.clearAllMocks()
+    oracle = createOracleFacadeMock()
+    participant = createParticipantFacadeMock()
   })
 
-  test('should cleanup oracle and forward SERVICE_CURRENTLY_UNAVAILABLE error for party from external dfsp', async () => {
-    participantMock.validateParticipant = jest.fn().mockRejectedValue(new Error('No participant found')) // external participant
-    const destination = 'externalDfsp'
+  test('should cleanup oracle and forward PARTY_RESOLUTION_FAILURE error for party from external dfsp', async () => {
+    participant.validateParticipant = jest.fn().mockRejectedValue(new Error('No participant found')) // external participant
+    oracle.oracleRequest = jest.fn().mockResolvedValue({
+      data: { partyList: [{ fspId: 'fspId' }] }
+    })
+    const destination = 'externalDestination'
     const proxyDest = 'proxyDest'
-    const deps = createMockDeps()
+    const deps = createMockDeps({ oracle, participant })
     deps.proxyCache.lookupProxyByDfspId = jest.fn().mockResolvedValue(proxyDest)
 
     const headers = fixtures.partiesCallHeadersDto({ destination, proxy: 'proxyA' })
     const params = fixtures.partiesParamsDto()
-    const dataUri = fixtures.dataUriDto()
-    const service = new PutPartiesErrorService(deps, { headers, params, dataUri })
+    const data = { test: true }
+    const dataUri = fixtures.dataUriDto(data)
 
+    const service = new PutPartiesErrorService(deps, { headers, params, dataUri })
     await service.handleRequest()
-    expect(oracleMock.oracleRequest).toHaveBeenCalledTimes(1)
-    expect(oracleMock.oracleRequest.mock.lastCall[1]).toBe(RestMethods.DELETE)
-    expect(participantMock.sendErrorToParticipant).toHaveBeenCalledTimes(1)
-    // eslint-disable-next-line no-unused-vars
-    const [sentTo, _, payload, cbHeaders] = participantMock.sendErrorToParticipant.mock.lastCall
+
+    expect(oracle.oracleRequest).toHaveBeenCalledTimes(2)
+    expect(oracle.oracleRequest.mock.lastCall[1]).toBe(RestMethods.DELETE)
+    expect(participant.sendErrorToParticipant).toHaveBeenCalledTimes(1)
+
+    const [sentTo, , payload, cbHeaders] = participant.sendErrorToParticipant.mock.lastCall
     expect(sentTo).toBe(proxyDest)
     expect(cbHeaders[Headers.FSPIOP.DESTINATION]).toBe(destination)
-    expect(payload.errorInformation.errorCode).toBe('2003')
+    expect(payload).toBe(JSON.stringify(data))
   })
 
   test('should NOT cleanup oracle if destination is local', async () => {
     const destination = 'localDfsp'
-    const deps = createMockDeps()
-    deps.participant.validateParticipant = jest.fn().mockResolvedValue({})
+    participant.validateParticipant = jest.fn().mockResolvedValue({})
+    const deps = createMockDeps({ participant })
 
     const headers = fixtures.partiesCallHeadersDto({ destination })
     const params = fixtures.partiesParamsDto()
@@ -71,8 +80,8 @@ describe('PutPartiesErrorService Tests -->', () => {
     const service = new PutPartiesErrorService(deps, { headers, params, dataUri })
 
     await service.handleRequest()
-    expect(oracleMock.oracleRequest).not.toHaveBeenCalled()
-    expect(participantMock.sendErrorToParticipant).toHaveBeenCalledTimes(1)
-    expect(participantMock.sendErrorToParticipant.mock.lastCall[0]).toBe(destination)
+    expect(oracle.oracleRequest).not.toHaveBeenCalled()
+    expect(participant.sendErrorToParticipant).toHaveBeenCalledTimes(1)
+    expect(participant.sendErrorToParticipant.mock.lastCall[0]).toBe(destination)
   })
 })

package/test/unit/domain/parties/services/deps.js

@@ -32,18 +32,34 @@ const oracleMock = require('#src/models/oracle/facade')
 const participantMock = require('#src/models/participantEndpoint/facade')
 const { createDeps } = require('#src/domain/parties/deps')
 const { logger } = require('#src/lib/index')
-const { createProxyCacheMock, createProxiesUtilMock } = require('#test/util/mockDeps')
+const {
+  createOracleFacadeMock,
+  createParticipantFacadeMock,
+  createProxyCacheMock,
+  createProxiesUtilMock
+} = require('#test/util/mockDeps')
 
 /** @returns {PartiesDeps} */
 const createMockDeps = ({
+  cache,
+  oracle,
+  participant,
   proxyCache = createProxyCacheMock(),
   proxies = createProxiesUtilMock(),
-  log = logger.child({ test: true }),
-  cache
-} = {}) => createDeps({ cache, proxyCache, proxies, log })
+  log = logger.child({ test: true })
+} = {}) => createDeps({
+  cache,
+  oracle,
+  participant,
+  proxyCache,
+  proxies,
+  log
+})
 
 module.exports = {
   createMockDeps,
+  createOracleFacadeMock,
+  createParticipantFacadeMock,
   createProxyCacheMock,
   createProxiesUtilMock,
   oracleMock,

package/test/util/mockDeps.js

@@ -66,7 +66,27 @@ const createProxiesUtilMock = ({
   invalidateProxiesCache
 })
 
+const createParticipantFacadeMock = ({
+  validateParticipant = jest.fn(),
+  sendRequest = jest.fn(),
+  sendErrorToParticipant = jest.fn()
+} = {}) => ({
+  validateParticipant,
+  sendRequest,
+  sendErrorToParticipant
+})
+
+const createOracleFacadeMock = ({
+  oracleRequest = jest.fn(),
+  oracleBatchRequest = jest.fn()
+} = {}) => ({
+  oracleRequest,
+  oracleBatchRequest
+})
+
 module.exports = {
+  createOracleFacadeMock,
+  createParticipantFacadeMock,
   createProxyCacheMock,
   createProxiesUtilMock
 }