account-lookup-service 17.11.1-snapshot.0 → 17.11.2

package/src/api/health.js

@@ -27,7 +27,7 @@
 'use strict'
 
 const HealthCheck = require('@mojaloop/central-services-shared').HealthCheck.HealthCheck
-const { getSubServiceHealthDatastore, getProxyCacheHealth, getSubServiceHealthBroker } = require('../lib/healthCheck/subServiceHealth')
+const { getSubServiceHealthDatastore, getProxyCacheHealth } = require('../lib/healthCheck/subServiceHealth')
 const packageJson = require('../../package.json')
 const Config = require('../lib/config')
 
@@ -36,8 +36,7 @@ const getSubServices = (appConfig, isAdmin) => {
     return [getSubServiceHealthDatastore]
   }
 
-  const subServices = [getSubServiceHealthDatastore, getSubServiceHealthBroker]
-
+  const subServices = [getSubServiceHealthDatastore]
   if (appConfig.PROXY_CACHE_CONFIG.enabled) {
     subServices.push(getProxyCacheHealth)
   }

package/src/handlers/monitoring/plugins/health.js

@@ -20,14 +20,14 @@
 
 const { HealthCheck } = require('@mojaloop/central-services-shared').HealthCheck
 const { defaultHealthHandler } = require('@mojaloop/central-services-health')
-const { getProxyCacheHealth, getSubServiceHealthBroker } = require('../../../lib/healthCheck/subServiceHealth')
+const { getProxyCacheHealth } = require('../../../lib/healthCheck/subServiceHealth')
 const packageJson = require('../../../../package.json')
 
 let healthCheck
 
 const createHealthCheck = ({ proxyCache }) => {
   return new HealthCheck(packageJson, [
-    () => getProxyCacheHealth(proxyCache), () => getSubServiceHealthBroker()
+    () => getProxyCacheHealth(proxyCache)
   ])
 }
 

package/src/lib/healthCheck/subServiceHealth.js

@@ -26,7 +26,6 @@
 const { statusEnum, serviceName } = require('@mojaloop/central-services-shared').HealthCheck.HealthCheckEnums
 const { logger } = require('../../lib')
 const MigrationLockModel = require('../../models/misc/migrationLock')
-const Producer = require('@mojaloop/central-services-stream').Util.Producer
 
 /**
  * @function getSubServiceHealthDatastore
@@ -55,28 +54,6 @@ const getSubServiceHealthDatastore = async () => {
   }
 }
 
-/**
- * @function getSubServiceHealthBroker
- *
- * @description Gets the health for the Notification broker
- * @returns Promise<object> The SubService health object for the broker
- */
-const getSubServiceHealthBroker = async () => {
-  let status = statusEnum.OK
-  try {
-    await Producer.allConnected()
-    status = statusEnum.OK
-  } catch (err) {
-    logger.isDebugEnabled && logger.debug(`getSubServiceHealthBroker failed with error: ${err.message}.`)
-    status = statusEnum.DOWN
-  }
-
-  return {
-    name: serviceName.broker,
-    status
-  }
-}
-
 /**
  * @function getProxyCacheHealth
  *
@@ -102,6 +79,5 @@ const getProxyCacheHealth = async (proxyCache) => {
 
 module.exports = {
   getSubServiceHealthDatastore,
-  getProxyCacheHealth,
-  getSubServiceHealthBroker
+  getProxyCacheHealth
 }

package/test/unit/api/health.test.js

@@ -86,7 +86,7 @@ describe('/health', () => {
     expect(response.statusCode).toBe(200)
     const payload = JSON.parse(response.payload)
     expect(payload.status).toBe('OK')
-    expect(payload.services.length).toBe(2)
+    expect(payload.services.length).toBe(1)
     expect(payload.services[0].name).toBe('datastore')
   })
 
@@ -108,7 +108,7 @@ describe('/health', () => {
     expect(response.statusCode).toBe(503)
     const payload = JSON.parse(response.payload)
     expect(payload.status).toBe('DOWN')
-    expect(payload.services.length).toBe(2)
+    expect(payload.services.length).toBe(1)
     expect(payload.services[0].name).toBe('datastore')
   })
 
@@ -135,8 +135,8 @@ describe('/health', () => {
       // Assert
       const payload = JSON.parse(response.payload)
       expect(response.statusCode).toBe(200)
-      expect(payload.services.length).toBe(3)
-      expect(payload.services[2].name).toBe('proxyCache')
+      expect(payload.services.length).toBe(2)
+      expect(payload.services[1].name).toBe('proxyCache')
     } finally {
       serverWithProxy && await serverWithProxy.stop()
     }