account-lookup-service 16.1.0-iso.0 → 16.1.0-iso.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "16.1.0-iso.0",
+  "version": "16.1.0-iso.1",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [

package/src/constants.js

@@ -1,6 +1,5 @@
 const ERROR_MESSAGES = Object.freeze({
   sourceFspNotFound: 'Requester FSP not found',
-  partySourceFspNotFound: 'Requester FSP not found', // todo: use sourceFspNotFound
   partyDestinationFspNotFound: 'Destination FSP not found',
   partyProxyNotFound: 'Proxy not found',
   proxyConnectionError: 'Proxy connection error',

package/src/domain/parties/getPartiesByTypeAndID.js

@@ -52,7 +52,7 @@ const validateRequester = async ({ source, proxy, proxyCache }) => {
   }
 
   if (!proxy) {
-    const errMessage = ERROR_MESSAGES.partySourceFspNotFound
+    const errMessage = ERROR_MESSAGES.sourceFspNotFound
     throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
   }
 

package/src/domain/parties/parties.js

@@ -81,7 +81,7 @@ const putPartiesByTypeAndID = async (headers, params, method, payload, dataUri,
     const requesterParticipant = await participant.validateParticipant(source)
     if (!requesterParticipant) {
       if (!proxyEnabled || !proxy) {
-        const errMessage = ERROR_MESSAGES.partySourceFspNotFound
+        const errMessage = ERROR_MESSAGES.sourceFspNotFound
         throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
       }
       step = 'addDfspIdToProxyMapping-1'

package/test/fixtures/index.js

@@ -61,7 +61,6 @@ const participantsCallHeadersDto = ({
   contentType: interopHeader('participants', contentTypeVersion)
 })
 
-// todo: add ISO mode support
 const interopHeader = (resource, version = '1') => `application/vnd.interoperability.${resource}+json;version=${version}`
 
 const oracleRequestResponseDto = ({

package/test/unit/domain/parties/parties.test.js

@@ -251,7 +251,7 @@ describe('Parties Tests', () => {
 
       const { errorInformation } = participant.sendErrorToParticipant.getCall(0).args[2]
       expect(errorInformation.errorCode).toBe('3200')
-      expect(errorInformation.errorDescription).toContain(ERROR_MESSAGES.partySourceFspNotFound)
+      expect(errorInformation.errorDescription).toContain(ERROR_MESSAGES.sourceFspNotFound)
     })
 
     it('should send error callback, if proxy-header is present, but no proxy in the scheme', async () => {
@@ -634,7 +634,7 @@ describe('Parties Tests', () => {
       // Assert
       expect(participant.sendErrorToParticipant.callCount).toBe(1)
       const firstLoggerCallArgs = loggerStub.getCall(0).args
-      expect(firstLoggerCallArgs[1].message).toBe(ERROR_MESSAGES.partySourceFspNotFound)
+      expect(firstLoggerCallArgs[1].message).toBe(ERROR_MESSAGES.sourceFspNotFound)
       loggerStub.reset()
       participant.sendErrorToParticipant.reset()
     })

package/test/unit/models/participantEndpoint/facade.test.js

@@ -50,16 +50,18 @@ jest.mock('@mojaloop/central-services-shared', () => ({
     Participants: { getParticipant: mockGetParticipant },
     Request: { sendRequest: mockSendRequest },
     Http: { SwitchDefaultHeaders: jest.fn() },
-    HeaderValidation: { getHubNameRegex: jest.fn().mockReturnValue(new RegExp(mockHubName)) }
+    HeaderValidation: { getHubNameRegex: jest.fn().mockReturnValue(new RegExp(mockHubName)) },
+    Hapi: jest.requireActual('@mojaloop/central-services-shared').Util.Hapi
   },
   Enum: mockEnums
 }))
 
 const Logger = require('@mojaloop/central-services-logger')
 const fixtures = require('../../../fixtures')
+const { API_TYPES } = require('@mojaloop/central-services-shared').Util.Hapi
 
 const mockConfigDto = ({
-  apiType = 'fspiop', // todo: use API_TYPES
+  apiType = API_TYPES.fspiop,
   jwsSign = false
 } = {}) => ({
   API_TYPE: apiType,