account-lookup-service 15.6.0-iso.21 → 15.6.0-iso.23

package/audit-ci.jsonc

@@ -29,6 +29,7 @@
     "GHSA-rv95-896h-c2vc", // https://github.com/advisories/GHSA-rv95-896h-c2vc
     "GHSA-952p-6rrq-rcjv", // https://github.com/advisories/GHSA-952p-6rrq-rcjv
     "GHSA-3xgq-45jj-v275", // https://github.com/advisories/GHSA-3xgq-45jj-v275
-    "GHSA-rhx6-c78j-4q9w" // https://github.com/advisories/GHSA-rhx6-c78j-4q9w
+    "GHSA-rhx6-c78j-4q9w", // https://github.com/advisories/GHSA-rhx6-c78j-4q9w
+    "GHSA-mwcw-c2x4-8c55" // https://github.com/advisories/GHSA-mwcw-c2x4-8c55
   ]
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "15.6.0-iso.21",
+  "version": "15.6.0-iso.23",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [
@@ -94,12 +94,12 @@
     "@mojaloop/central-services-health": "15.0.0",
     "@mojaloop/central-services-logger": "11.5.1",
     "@mojaloop/central-services-metrics": "12.4.2",
-    "@mojaloop/central-services-shared": "18.14.1",
-    "@mojaloop/central-services-stream": "11.3.1",
-    "@mojaloop/database-lib": "11.0.6",
+    "@mojaloop/central-services-shared": "18.14.2",
+    "@mojaloop/central-services-stream": "11.4.1",
+    "@mojaloop/database-lib": "11.1.0",
     "@mojaloop/event-sdk": "14.1.1",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1",
-    "@mojaloop/ml-schema-transformer-lib": "2.4.1",
+    "@mojaloop/ml-schema-transformer-lib": "2.5.0",
     "@mojaloop/sdk-standard-components": "19.6.2",
     "@now-ims/hapi-now-auth": "2.1.0",
     "ajv": "8.17.1",
@@ -157,7 +157,7 @@
     "jest": "29.7.0",
     "jest-junit": "16.0.0",
     "jsdoc": "4.0.4",
-    "nodemon": "3.1.7",
+    "nodemon": "3.1.9",
     "npm-check-updates": "17.1.11",
     "nyc": "17.1.0",
     "pre-commit": "1.2.2",

package/src/domain/oracle/oracle.js

@@ -94,7 +94,7 @@ exports.createOracle = async (payload) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'createOracle',
       step
@@ -163,7 +163,7 @@ exports.getOracle = async (query) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'getOracle',
       step
@@ -250,7 +250,7 @@ exports.updateOracle = async (params, payload) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'updateOracle',
       step
@@ -284,7 +284,7 @@ exports.deleteOracle = async (params) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'deleteOracle'
     })

package/src/domain/participants/participants.js

@@ -131,7 +131,7 @@ const getParticipantsByTypeAndID = async (headers, params, method, query, span,
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'getParticipantsByTypeAndID',
       step
@@ -252,7 +252,7 @@ const putParticipantsByTypeAndID = async (headers, params, method, payload, cach
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'putParticipantsByTypeAndID',
       step
@@ -328,7 +328,7 @@ const putParticipantsErrorByTypeAndID = async (headers, params, payload, dataUri
       const extensions = err.extensions || []
       const system = extensions.find((element) => element.key === 'system')?.value || ''
       errorCounter.inc({
-        code: fspiopError?.apiErrorCode,
+        code: fspiopError?.apiErrorCode?.code,
         system,
         operation: 'putParticipantsErrorByTypeAndID',
         step
@@ -434,7 +434,7 @@ const postParticipants = async (headers, method, params, payload, span, cache) =
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'postParticipants',
       step
@@ -566,7 +566,7 @@ const postParticipantsBatch = async (headers, method, requestPayload, span) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'postParticipantsBatch',
       step
@@ -662,7 +662,7 @@ const deleteParticipants = async (headers, params, method, query, cache) => {
       const extensions = err.extensions || []
       const system = extensions.find((element) => element.key === 'system')?.value || ''
       errorCounter.inc({
-        code: fspiopError?.apiErrorCode,
+        code: fspiopError?.apiErrorCode?.code,
         system,
         operation: 'deleteParticipants',
         step

package/src/domain/parties/getPartiesByTypeAndID.js

@@ -91,12 +91,16 @@ const getPartiesByTypeAndID = async (headers, params, method, query, span, cache
   const proxyEnabled = !!(Config.PROXY_CACHE_CONFIG.enabled && proxyCache)
   const type = params.Type
   const partySubId = params.SubId
+  const callbackEndpointType = utils.getPartyCbType(partySubId)
   const source = headers[Headers.FSPIOP.SOURCE]
   const proxy = proxyEnabled && headers[Headers.FSPIOP.PROXY]
-  const callbackEndpointType = utils.getPartyCbType(partySubId)
+  let destination = headers[Headers.FSPIOP.DESTINATION]
+  // see https://github.com/mojaloop/design-authority/issues/79
+  // the requester has specified a destination routing header. We should respect that and forward the request directly to the destination
+  // without consulting any oracles.
 
   const childSpan = span ? span.getChild('getPartiesByTypeAndID') : undefined
-  log.info('parties::getPartiesByTypeAndID::begin', { source, proxy, params })
+  log.info('parties::getPartiesByTypeAndID::begin', { source, destination, proxy, params })
 
   let requester
   let fspiopError
@@ -110,10 +114,6 @@ const getPartiesByTypeAndID = async (headers, params, method, query, span, cache
       ...(partySubId && { partySubIdOrType: partySubId })
     }
 
-    let destination = headers[Headers.FSPIOP.DESTINATION]
-    // see https://github.com/mojaloop/design-authority/issues/79
-    // the requester has specified a destination routing header. We should respect that and forward the request directly to the destination
-    // without consulting any oracles.
     if (destination) {
       step = 'validateParticipant-1'
       const destParticipantModel = await participant.validateParticipant(destination)
@@ -122,6 +122,7 @@ const getPartiesByTypeAndID = async (headers, params, method, query, span, cache
         const proxyId = proxyEnabled && await proxyCache.lookupProxyByDfspId(destination)
 
         if (!proxyId) {
+          log.warn('no destination participant, and no dfsp-to-proxy mapping', { destination })
           const errMessage = ERROR_MESSAGES.partyDestinationFspNotFound
           throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
         }
@@ -247,7 +248,7 @@ const getPartiesByTypeAndID = async (headers, params, method, query, span, cache
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'getPartiesByTypeAndID',
       step

package/src/domain/parties/parties.js

@@ -137,7 +137,7 @@ const putPartiesByTypeAndID = async (headers, params, method, payload, dataUri,
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'putPartiesByTypeAndID',
       step
@@ -223,7 +223,7 @@ const putPartiesErrorByTypeAndID = async (headers, params, payload, dataUri, spa
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'putPartiesErrorByTypeAndID',
       step

package/src/domain/timeout/index.js

@@ -77,7 +77,7 @@ const sendTimeoutCallback = async (cacheKey) => {
     const extensions = err.extensions || []
     const system = extensions.find((element) => element.key === 'system')?.value || ''
     errorCounter.inc({
-      code: fspiopError?.apiErrorCode,
+      code: fspiopError?.apiErrorCode?.code,
       system,
       operation: 'sendTimeoutCallback',
       step