ac-support-connector 1.0.13 → 1.0.14

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [1.0.14](https://github.com/admiralcloud/ac-support-connector/compare/v1.0.13..v1.0.14) (2026-04-09 11:27:07)
+
+
+### Bug Fix
+
+
+* **Connector:** Improvements after CoPilot review | MP | [e09a77aa4871c89a05383f0f03b076a6ef2f63c3](https://github.com/admiralcloud/ac-support-connector/commit/e09a77aa4871c89a05383f0f03b076a6ef2f63c3)    
+Improvements after CoPilot review  
+Related issues:
+* **Connector:** Add 2 new parameters - throwError, logger | MP | [982c057541f6e3cef22a661c0eb51403a899b2ef](https://github.com/admiralcloud/ac-support-connector/commit/982c057541f6e3cef22a661c0eb51403a899b2ef)    
+Set throwError as true per default, so errors are propagated. Allow custom loggers, default to console (as before)  
+Related issues:
 ## [1.0.13](https://github.com/admiralcloud/ac-support-connector/compare/v1.0.12..v1.0.13) (2026-04-04 10:19:59)
 
 

package/index.js

@@ -9,7 +9,7 @@ module.exports = {
 
   aws: {},
 
-  init: async function({ serviceName, instanceId, sqsQueue = 'AC-SupportQueue', bucket, redisInstance, region = 'eu-central-1', profile = process.env['profile'], debug } = {}) {
+  init: async function({ serviceName, instanceId, sqsQueue = 'AC-SupportQueue', bucket, redisInstance, region = 'eu-central-1', profile = process.env['profile'], debug, logger = console, throwError = true } = {}) {
     
     this.sqsQueue = sqsQueue
     this.serviceName = serviceName || 'SupportConnector'
@@ -17,6 +17,12 @@ module.exports = {
     this.redisInstance = redisInstance
     this.cache = new NodeCache()
     this.debugMode = debug
+    this.logger = {
+      info:  logger?.info?.bind(logger)  ?? console.info.bind(console),
+      warn:  logger?.warn?.bind(logger)  ?? console.warn.bind(console),
+      error: logger?.error?.bind(logger) ?? console.error.bind(console),
+    }
+    this.throwError = throwError
 
     if (!debug) {
       const client = new STSClient({
@@ -31,7 +37,8 @@ module.exports = {
         availableLists: [{
           name: sqsQueue,
           fifo: true
-        }]
+        }],
+        throwError
       }
       if (profile) { sqsParams.profile = profile } // Optional AWS profile, see below
       if (bucket) {
@@ -61,7 +68,7 @@ module.exports = {
           })
         }
         await this.createMessage(ticket)
-        console.warn(`Test Message ${identifier} sent`)
+        this.logger.warn(`Test Message ${identifier} sent`)
         process.exit(0)
       }
     }
@@ -111,11 +118,14 @@ module.exports = {
     }
     try {
       const response = await this.acsqs.sendSQSMessage({ name: this.sqsQueue, message: JSON.stringify(messagePayload), messageGroupId: (messageGroupId || this.serviceName) })
-      if (this.debugMode) { console.warn(response) }
+      if (this.debugMode) { this.logger.info(response) }
       return response
     }
     catch(e) {
-      console.error('%s | Subject %s | Failed %j', functionName, subject, e?.message)
+      this.logger.error('%s | Subject %s | Failed %j', functionName, subject, e?.message)
+      if (this.throwError) { 
+        throw e
+      }
     }
   }
 }

package/package.json

@@ -3,7 +3,7 @@
   "author": "Mark Poepping (https://www.admiralcloud.com)",
   "license": "MIT",
   "repository": "admiralcloud/ac-support-connector",
-  "version": "1.0.13",
+  "version": "1.0.14",
   "dependencies": {
     "@aws-sdk/client-sts": "^3.1024.0",
     "ac-sqs": "^4.0.6",

package/test/test.js

@@ -7,7 +7,7 @@ function createFakeRedis() {
   const store = new Map()
   return {
     async set(key, _value, exFlag, seconds, nxFlag) {
-      if (nxFlag === 'nx' && store.has(key)) return null
+      if (nxFlag === 'nx' && store.has(key)) { return null }
       store.set(key, true)
       setTimeout(() => store.delete(key), seconds * 1000)
       return 'OK'
@@ -18,7 +18,7 @@ function createFakeRedis() {
 
 const redisInstance = createFakeRedis()
 
-const string1001 = new Array(512000).join('b')
+const string1001 = new Array(1100000).join('b')
 
 function timeout(ms) {
   return new Promise(resolve => setTimeout(resolve, ms));
@@ -38,7 +38,7 @@ describe('Basic tests', () => {
     expect(response.message[0]).to.have.property('content', params.text)
   })
 
-  it('Check truncated payload > 256KB - should not throw an error', async() => {
+  it('Check truncated payload > 1MB - should not throw an error', async() => {
     const params = {
       subject: 'Failed',
       message: [{
@@ -153,6 +153,116 @@ describe('Block with Memory', () => {
 })
 
 
+describe('throwError behavior', () => {
+  const originalEnv = process.env.NODE_ENV
+  let fakeLogger
+
+  before(async() => {
+    fakeLogger = { errors: [], warns: [], error(...args) { this.errors.push(args) }, warn(...args) { this.warns.push(args) } }
+    await supCon.init({ debug: true, logger: fakeLogger })
+    process.env.NODE_ENV = 'production' // bypass early return in createMessage
+    supCon.acsqs = {
+      async sendSQSMessage() {
+        throw new Error('SQS failed')
+      }
+    }
+  })
+
+  after(() => {
+    process.env.NODE_ENV = originalEnv
+    delete supCon.acsqs
+  })
+
+  it('throwError: true - should throw on SQS failure', async() => {
+    supCon.throwError = true
+    fakeLogger.errors = []
+    let threw = false
+    try {
+      await supCon.createMessage({ subject: 'Test', text: 'Error' })
+    }
+ catch(e) {
+      threw = true
+      expect(e.message).to.equal('SQS failed')
+    }
+    expect(threw).to.be.true
+    expect(fakeLogger.errors).to.have.lengthOf(1)
+  })
+
+  it('throwError: false - should not throw on SQS failure', async() => {
+    supCon.throwError = false
+    fakeLogger.errors = []
+    const response = await supCon.createMessage({ subject: 'Test', text: 'Error' })
+    expect(response).to.be.undefined
+    expect(fakeLogger.errors).to.have.lengthOf(1)
+  })
+})
+
+describe('custom logger', () => {
+  const originalEnv = process.env.NODE_ENV
+  let fakeLogger
+
+  before(async() => {
+    fakeLogger = { infos: [], info(...args) { this.infos.push(args) } }
+    await supCon.init({ debug: true, logger: fakeLogger })
+    process.env.NODE_ENV = 'production'
+    supCon.acsqs = {
+      async sendSQSMessage() { return { MessageId: 'abc123' } }
+    }
+  })
+
+  after(() => {
+    process.env.NODE_ENV = originalEnv
+    delete supCon.acsqs
+  })
+
+  it('logger.info is called on successful send in debug mode', async() => {
+    const response = await supCon.createMessage({ subject: 'Test', text: 'Hello' })
+    expect(response).to.deep.equal({ MessageId: 'abc123' })
+    expect(fakeLogger.infos).to.have.lengthOf(1)
+  })
+})
+
+
+describe('logger normalization', () => {
+  const originalEnv = process.env.NODE_ENV
+
+  before(() => {
+    process.env.NODE_ENV = 'production'
+  })
+
+  after(() => {
+    process.env.NODE_ENV = originalEnv
+    delete supCon.acsqs
+  })
+
+  it('null logger - falls back to console without throwing', async() => {
+    await supCon.init({ debug: true, logger: null })
+    supCon.acsqs = { async sendSQSMessage() { throw new Error('boom') } }
+    supCon.throwError = false
+    // must not throw a TypeError about this.logger.error
+    await supCon.createMessage({ subject: 'Test', text: 'Hello' })
+  })
+
+  it('partial logger (missing warn/error) - fills gaps without throwing', async() => {
+    const partial = { infos: [], info(...args) { this.infos.push(args) } }
+    await supCon.init({ debug: true, logger: partial })
+    supCon.acsqs = { async sendSQSMessage() { throw new Error('boom') } }
+    supCon.throwError = false
+    // error method is missing on partial — must not throw a TypeError
+    await supCon.createMessage({ subject: 'Test', text: 'Hello' })
+  })
+
+  it('partial logger (missing info) - successful send does not throw', async() => {
+    const partial = { errors: [], error(...args) { this.errors.push(args) } }
+    await supCon.init({ debug: true, logger: partial })
+    supCon.acsqs = { async sendSQSMessage() { return { MessageId: 'xyz' } } }
+    // info method is missing — must not throw a TypeError on success path
+    const response = await supCon.createMessage({ subject: 'Test', text: 'Hello' })
+    expect(response).to.deep.equal({ MessageId: 'xyz' })
+  })
+})
+
+
 describe('Cleanup', () => {
   it('Close Redis', async() => {
     redisInstance.quit()