ac-custom-error 2.0.2 → 2.0.3

package/.github/workflows/node.js.yml

@@ -1,3 +1,4 @@
+
 # This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
@@ -5,28 +6,28 @@ name: Node.js CI
 
 on:
   push:
-    branches: [ master, develop ]
+    branches: [ develop, master ]
   pull_request:
-    branches: [ master, develop ]
+    branches: [ develop, master ]
 
 jobs:
   build:
 
     permissions:
-      contents: read    
+      contents: read
 
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node-version: [20.x, 22.x]
+        node-version: [22.x, 24.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v5
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v5
       with:
         node-version: ${{ matrix.node-version }}
-    
     - run: yarn install
     - run: yarn run test

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## [2.0.3](https://github.com/admiralcloud/ac-custom-error/compare/v2.0.2..v2.0.3) (2026-04-03 17:01:30)
+
+
+### Bug Fix
+
+
+* **App:** Fixed chaining issue for global.errorCodes | MP | [53006bdee67ca3322f33d62fa36aee850e177a78](https://github.com/admiralcloud/ac-custom-error/commit/53006bdee67ca3322f33d62fa36aee850e177a78)    
+Optional chaining on errorCodes to prevent a TypeError when global.errorCodes is undefined.  
+Related issues:
+* **App:** Package updates | MP | [be06bb2eb36de0f3acd4b64e48caa01f1a92ba4a](https://github.com/admiralcloud/ac-custom-error/commit/be06bb2eb36de0f3acd4b64e48caa01f1a92ba4a)    
+Package updates  
+Related issues:
+### Chores
+
+
+* **App:** Updated Github actions | MP | [f87a97de35e910301f5d407ba794c15596088a1a](https://github.com/admiralcloud/ac-custom-error/commit/f87a97de35e910301f5d407ba794c15596088a1a)    
+Updated Github actions  
+Related issues:
 
 ## [2.0.2](https://github.com/admiralcloud/ac-custom-error/compare/v2.0.1..v2.0.2) (2026-02-28 12:02:22)
 

package/README.md

@@ -1,7 +1,7 @@
 # AC-Custom-Error
 Extend the NodeJS error with an error code and additional information.
 
-[![Node.js CI](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/node.js.yml/badge.svg)](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/node.js.yml)
+[![Node.js CI](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/node.js.yml/badge.svg)](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/node.js.yml) [![CodeQL](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/github-code-scanning/codeql/badge.svg)](https://github.com/AdmiralCloud/ac-custom-error/actions/workflows/github-code-scanning/codeql)
 
 # ACErrorFromCode
 This is the preferred way to use this class. You define a central library of error codes and export them to global. You can then throw the error based on that code.

package/index.js

@@ -27,7 +27,7 @@ class ACErrorFromCode extends Error {
     super(code)
 
     // fetch the error message for errorCodes object (if available)
-    const error = global?.errorCodes[code]
+    const error = global?.errorCodes?.[code]
     
     if (Error.captureStackTrace) {
       Error.captureStackTrace(this, ACErrorFromCode)

package/package.json

@@ -1,16 +1,16 @@
 {
   "name": "ac-custom-error",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Custom NodeJS error with error code and additional info",
   "main": "index.js",
   "repository": "https://github.com/AdmiralCloud/ac-custom-error",
   "author": "Mark Poepping (www.admiralcloud.com)",
   "license": "MIT",
   "devDependencies": {
-    "ac-semantic-release": "^0.4.10",
+    "ac-semantic-release": "^1.0.1",
     "chai": "^4.5.0",
-    "eslint": "^10.0.2",
-    "globals": "^17.3.0",
+    "eslint": "^10.1.0",
+    "globals": "^17.4.0",
     "mocha": "^11.7.5",
     "nyc": "^18.0.0"
   },

package/test.js

@@ -23,7 +23,9 @@ describe('Run tests with ACError', () => {
       error = err
     }
     expect(error).to.be.an('Error')
+    expect(error).to.be.instanceOf(ACError)
     expect(error.message).to.equal(errorParams.message)
+    expect(error.errorMessage).to.equal(errorParams.message)
     expect(error.code).to.equal(errorParams.code)
   })
 
@@ -57,11 +59,36 @@ describe('Run tests with ACError', () => {
     expect(error.options).to.have.property('stack', errorParams.options.stack)
   })
 
+  it('Check default code -1 when no code is provided', () => {
+    let errorParams = { message: 'myError' }
+    let error
+    try {
+      errorFunction(errorParams)
+    }
+    catch (err) {
+      error = err
+    }
+    expect(error).to.be.an('Error')
+    expect(error.code).to.equal(-1)
+  })
+
+  it('Check that additionalInfo is not set when empty', () => {
+    let errorParams = { message: 'myError', code: 123 }
+    let error
+    try {
+      errorFunction(errorParams)
+    }
+    catch (err) {
+      error = err
+    }
+    expect(error.additionalInfo).to.be.undefined
+  })
+
 })
 
-describe('Run tests with ACError', () => {
+describe('Run tests with ACErrorFromCode', () => {
 
-  it('Define error codes', () => {
+  before(() => {
     global.errorCodes = {
       123: {
         message: 'thisIsAnError',
@@ -70,6 +97,9 @@ describe('Run tests with ACError', () => {
     }
   })
 
+  after(() => {
+    delete global.errorCodes
+  })
 
   it('Check error', () => {
     let error
@@ -79,13 +109,68 @@ describe('Run tests with ACError', () => {
     catch (err) {
       error = err
     }
-    
+
     expect(error).to.be.an('Error')
+    expect(error).to.be.instanceOf(ACErrorFromCode)
     expect(error.message).to.equal(global.errorCodes[123].message)
+    expect(error.errorMessage).to.equal(global.errorCodes[123].message)
     expect(error.code).to.equal(123)
     expect(error.solution).to.equal(global.errorCodes[123].solution)
   })
 
+  it('Check error with additionalInfo', () => {
+    let error
+    try {
+      errorFunctionFromCode({ code: 123, additionalInfo: { field: 'userId' } })
+    }
+    catch (err) {
+      error = err
+    }
+
+    expect(error).to.be.an('Error')
+    expect(error.additionalInfo).to.deep.equal({ field: 'userId' })
+  })
+
+  it('Check default code -1 when no code is provided', () => {
+    let error
+    try {
+      errorFunctionFromCode({})
+    }
+    catch (err) {
+      error = err
+    }
+
+    expect(error).to.be.an('Error')
+    expect(error.code).to.equal(-1)
+  })
+
+  it('Check fallback errorMessage for unknown code', () => {
+    let error
+    try {
+      errorFunctionFromCode({ code: 999 })
+    }
+    catch (err) {
+      error = err
+    }
+
+    expect(error).to.be.an('Error')
+    expect(error.errorMessage).to.equal('undefinedError')
+    expect(error.solution).to.be.undefined
+  })
+
+  it('Check that ACErrorFromCode works when global.errorCodes is not defined', () => {
+    delete global.errorCodes
+    let error
+    try {
+      errorFunctionFromCode({ code: 123 })
+    }
+    catch (err) {
+      error = err
+    }
+
+    expect(error).to.be.an('Error')
+    expect(error.errorMessage).to.equal('undefinedError')
+  })
 
 })