abmp-npm 2.0.80 → 2.0.81

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abmp-npm",
-  "version": "2.0.80",
+  "version": "2.0.81",
   "main": "index.js",
   "files": [
     "index.js",

package/pages/Home.js

@@ -7,11 +7,10 @@ const { DEFAULT_FILTER, DROPDOWN_OPTIONS } = require('../public/consts.js');
 const { createHomepageUtils } = require('../public/Utils/homePage.js');
 const {
   getMainAddress,
-  findMainAddress,
   formatPracticeAreasForDisplay,
   isWixHostedImage,
   normalizeExternalUrl,
-  buildMapLink,
+  buildDirectionsLink,
 } = require('../public/Utils/sharedUtils.js');
 
 let filter = JSON.parse(JSON.stringify(DEFAULT_FILTER));
@@ -226,24 +225,13 @@ const homePageOnReady = async ({
         $item('#milesAwayText').text = '';
       }
 
-      // 7) "Show maps" button - directions to whatever address the member displays.
+      // 7) "Show maps" button - only for members who selected "Show Full Address".
       //
-      // Uses the same address as the location text above, so the button always
-      // matches what the member is showing. Members displaying city/state/ZIP get
-      // directions to that, rather than no button at all: their NetForum
-      // coordinates can be miles off (see Monday 12596102059), and the text they
-      // publish is the reliable value.
-      //
-      // Privacy is enforced in buildMapLink, not here - it delegates to
-      // formatAddress, which prints the street line only for full_address, and
-      // returns '' outright for dont_show. findMainAddress also excludes
-      // dont_show. A hidden street address can never reach a maps URL.
-      //
-      // Gate on the link rather than the address: buildMapLink returns '' when it
-      // can build neither an address nor a coordinate link, and handles being
-      // passed '' or undefined, so the button is never shown linking nowhere.
-      const mapAddress = findMainAddress(itemData.addressDisplayOption, addresses);
-      const mapLink = buildMapLink(mapAddress);
+      // buildDirectionsLink owns the rule and returns '' when the button should be
+      // hidden: city/state/ZIP and hidden members get nothing, and a full-address
+      // member gets a link built from their address text rather than their NetForum
+      // coordinates, which are unreliable (Monday 12596102059).
+      const mapLink = buildDirectionsLink(itemData.addressDisplayOption, addresses);
 
       if (mapLink) {
         $item('#showMaps').enable();

package/public/Utils/sharedUtils.js

@@ -155,6 +155,40 @@ function buildMapLink(address) {
   return '';
 }
 
+/**
+ * Builds the directions-button link for a member, or '' when no button should show.
+ *
+ * PAC's rule (Monday 12596102059, confirmed by Richard Visser): directions appear
+ * only for members who selected "Show Full Address". Members displaying
+ * city/state/ZIP, and members who hid their address, get no button at all. An
+ * earlier pass relaxed this to city-level members and had to be reverted, so the
+ * rule lives here with tests around it rather than inline in the page code.
+ *
+ * The address is resolved with findMainAddress, so the button is always tied to
+ * the same address as the location text rendered beside it. A member whose
+ * displayed address is city-level gets no button even when a fuller address exists
+ * elsewhere on their record - the button must not point somewhere other than what
+ * is on screen.
+ *
+ * Coordinates are deliberately not required: buildMapLink navigates from the
+ * address text, so a member with missing or wrong NetForum coordinates still gets
+ * a working button where previously they got none. Distance ranking and the
+ * "XX miles away" figure keep using the coordinates and are unaffected.
+ *
+ * @param {Array} addressDisplayOption
+ * @param {Array} addresses
+ * @returns {string} map URL, or '' when the button should be hidden
+ */
+function buildDirectionsLink(addressDisplayOption = [], addresses = []) {
+  const address = findMainAddress(addressDisplayOption, addresses);
+
+  if (address?.addressStatus !== ADDRESS_STATUS_TYPES.FULL_ADDRESS) {
+    return '';
+  }
+
+  return buildMapLink(address);
+}
+
 /**
  * @param {Array} addressDisplayOption
  * @param {Array} addresses
@@ -266,6 +300,7 @@ module.exports = {
   generateId,
   formatAddress,
   buildMapLink,
+  buildDirectionsLink,
   isWixHostedImage,
   normalizeExternalUrl,
   normalizeEmail,