abmp-npm 2.0.76 → 2.0.78

package/package.json

@@ -1,7 +1,14 @@
 {
   "name": "abmp-npm",
-  "version": "2.0.76",
+  "version": "2.0.78",
   "main": "index.js",
+  "files": [
+    "index.js",
+    "backend",
+    "pages",
+    "public",
+    "!backend/__tests__"
+  ],
   "scripts": {
     "check-cycles": "madge --circular .",
     "test": "jest backend/__tests__",

package/pages/Home.js

@@ -3,20 +3,15 @@ const { location: wixLocation } = require('@wix/site-location');
 const { window: wixWindow, rendering } = require('@wix/site-window');
 const { withWarmUpData } = require('psdev-utils/frontend');
 
-const {
-  ADDRESS_STATUS_TYPES,
-  DEFAULT_FILTER,
-  DROPDOWN_OPTIONS,
-  LIGHTBOX_NAMES,
-} = require('../public/consts.js');
+const { ADDRESS_STATUS_TYPES, DEFAULT_FILTER, DROPDOWN_OPTIONS } = require('../public/consts.js');
 const { createHomepageUtils } = require('../public/Utils/homePage.js');
 const {
   getMainAddress,
-  findMainAddress,
-  checkAddressIsVisible,
   formatPracticeAreasForDisplay,
+  checkAddressIsVisible,
   isWixHostedImage,
   normalizeExternalUrl,
+  buildMapLink,
 } = require('../public/Utils/sharedUtils.js');
 
 let filter = JSON.parse(JSON.stringify(DEFAULT_FILTER));
@@ -36,28 +31,6 @@ const pagination = {
 let searchResults = [];
 let isMobile = false;
 
-const isMappable = addr =>
-  addr?.addressStatus === ADDRESS_STATUS_TYPES.FULL_ADDRESS && addr.latitude && addr.longitude;
-
-// The button is only offered when the member has at least one mappable address, which is
-// the same condition as before the lightbox was introduced. When that address is not the
-// primary one we still show the button but withhold the link, so the click opens the
-// lightbox instead of sending the visitor to a secondary address in another city.
-const getDirectionsTarget = itemData => {
-  const addresses = Array.isArray(itemData?.addresses) ? itemData.addresses : [];
-  const showButton = checkAddressIsVisible(addresses).some(isMappable);
-  if (!showButton) {
-    return { showButton: false, mapsLink: null };
-  }
-  const mainAddr = findMainAddress(itemData?.addressDisplayOption, addresses);
-  return {
-    showButton: true,
-    mapsLink: isMappable(mainAddr)
-      ? `https://maps.google.com/?q=${mainAddr.latitude},${mainAddr.longitude}`
-      : null,
-  };
-};
-
 const homePageOnReady = async ({
   _$w,
   getCompiledFiltersOptions,
@@ -209,16 +182,6 @@ const homePageOnReady = async ({
       await updateResults('zeroTimeout');
     });
     const baseUrl = await wixLocation.baseUrl();
-    _$w('#showMaps').onClick(event => {
-      const member = searchResults.find(result => result._id === event.context.itemId);
-      if (!member) {
-        return;
-      }
-      const { showButton, mapsLink } = getDirectionsTarget(member);
-      if (showButton && !mapsLink) {
-        wixWindow.openLightbox(LIGHTBOX_NAMES.CONTACT_FOR_LOCATION, member);
-      }
-    });
     _$w('#profileRepeater').onItemReady(($item, itemData) => {
       // 1) safely default to arrays
       const addresses = Array.isArray(itemData.addresses) ? itemData.addresses : [];
@@ -263,24 +226,33 @@ const homePageOnReady = async ({
         $item('#milesAwayText').text = '';
       }
 
-      // 7) "Show maps" button. Links to the primary address when it is a full address;
-      // otherwise it stays visible and the page-level onClick opens a lightbox.
-      const { showButton, mapsLink } = getDirectionsTarget(itemData);
+      // 7) "Show maps" button shown only when we can actually build a link for it
+      const visible = checkAddressIsVisible(addresses);
+      const fullAddressWithValidCoords = visible.find(
+        addr =>
+          addr.addressStatus === ADDRESS_STATUS_TYPES.FULL_ADDRESS &&
+          addr.latitude &&
+          addr.longitude
+      );
 
-      if (!showButton) {
-        $item('#showMaps').hide();
-      } else {
+      // Links to the street address rather than the stored coordinates, which are
+      // unreliable for some members. The full-address filter above is what keeps
+      // this safe: members set to state_city_zip or dont_show never reach here, so
+      // a hidden street address is never put in a maps URL.
+      //
+      // Gate on the link rather than on the address. buildMapLink returns '' when
+      // it can build neither an address nor a coordinate link, and it also handles
+      // being passed undefined - so this cannot leave a visible button linking
+      // nowhere, even if the filter above is later relaxed.
+      const mapLink = buildMapLink(fullAddressWithValidCoords);
+
+      if (mapLink) {
         $item('#showMaps').enable();
         $item('#showMaps').show();
-
-        if (mapsLink) {
-          $item('#showMaps').link = mapsLink;
-          $item('#showMaps').target = '_blank';
-        } else {
-          // Clear any link left over from a recycled repeater item, otherwise the
-          // button would still navigate to the previous member's address.
-          $item('#showMaps').link = undefined;
-        }
+        $item('#showMaps').link = mapLink;
+        $item('#showMaps').target = '_blank';
+      } else {
+        $item('#showMaps').hide();
       }
 
       // 8) Phone / contact form

package/pages/index.js

@@ -9,5 +9,4 @@ module.exports = {
   ...require('./deleteConfirm.js'),
   ...require('./SaveAlerts.js'),
   ...require('./LearnMore.js'),
-  ...require('./contactForLocation.js'),
 };

package/public/Utils/personalDetailsUtils.js

@@ -13,8 +13,12 @@ function isNotValidUrl(url) {
   if (!url) return false;
 
   // URL must start with protocol OR www - handles all TLDs including multi-level and query params
+  // NOTE: the host class is `[\da-z.-]` (digit, letter, dot, hyphen). It previously read
+  // `[da-z.-]`, which - missing the backslash - matched only a literal "d" plus a-z, so any
+  // domain containing a digit was rejected (e.g. https://patty-10439.square.site).
+  // The `i` flag keeps mixed-case hosts valid; domains are case-insensitive.
   const urlRegex =
-    /^(https?:\/\/|www\.)([da-z.-]+)\.([a-z.]{2,})([/\w .-]*)*(\?[&\w=.-]*)?(#[&\w=.-]*)?\/?$/;
+    /^(https?:\/\/|www\.)([\da-z.-]+)\.([a-z.]{2,})([/\w .-]*)*(\?[&\w=.-]*)?(#[&\w=.-]*)?\/?$/i;
 
   return !urlRegex.test(url);
 }

package/public/Utils/sharedUtils.js

@@ -118,6 +118,37 @@ function formatAddress(item) {
   return addressParts.filter(Boolean).join(', ');
 }
 
+/**
+ * Builds the outbound map link for an address.
+ *
+ * Prefers the street address over the stored coordinates. NetForum's address
+ * verifier (Cdyne) sometimes returns coordinates that are miles away from the
+ * real address, and some coordinates were edited by hand in the past to change
+ * directory ranking, so the address text is the more reliable of the two.
+ * Distance ranking and the "XX miles away" figure keep using the coordinates -
+ * that is a separate calculation (see calculateDistance) and is unaffected.
+ *
+ * Falls back to coordinates only when the address cannot be formatted, so the
+ * button never links nowhere.
+ *
+ * @param {Object} address - a single address entry
+ * @returns {string} map URL, or '' when neither an address nor coordinates exist
+ */
+function buildMapLink(address) {
+  if (!address) return '';
+
+  const query = formatAddress(address);
+  if (query) {
+    return `https://maps.google.com/?q=${encodeURIComponent(query)}`;
+  }
+
+  if (isValidLocation(address)) {
+    return `https://maps.google.com/?q=${address.latitude},${address.longitude}`;
+  }
+
+  return '';
+}
+
 /**
  * @param {Array} addressDisplayOption
  * @param {Array} addresses
@@ -228,6 +259,7 @@ module.exports = {
   toRadians,
   generateId,
   formatAddress,
+  buildMapLink,
   isWixHostedImage,
   normalizeExternalUrl,
   normalizeEmail,

package/public/consts.js

@@ -85,7 +85,6 @@ const LIGHTBOX_NAMES = {
   SELECT_BANNER_IMAGES: 'Select Banner Images',
   CONTACT_US: 'Contact Us',
   MAIN_ADDRESS_ERROR: 'mainAddressError',
-  CONTACT_FOR_LOCATION: 'contactForLocation',
 };
 
 const FREE_WEBSITE_TEXT_STATES = {

package/.claude/worktrees/fix-save-button-disable/.husky/pre-commit

@@ -1,19 +0,0 @@
-echo "Running ESLint check..."
-npm run lint
-
-if [ $? -ne 0 ]; then
-  echo "❌ ESLint check failed. Please fix the linting errors before committing."
-  exit 1
-fi
-
-echo "Running Prettier check..."
-npm run format:check
-
-if [ $? -ne 0 ]; then
-  echo "❌ Prettier check failed. Please format your code before committing."
-  echo "Run 'npm run format' to automatically format your files."
-  exit 1
-fi
-
-echo "✅ All checks passed!"
-

package/.claude/worktrees/fix-save-button-disable/.prettierignore

@@ -1,7 +0,0 @@
-node_modules
-dist
-build
-coverage
-*.min.js
-package-lock.json
-

package/.claude/worktrees/fix-save-button-disable/.prettierrc.json

@@ -1,16 +0,0 @@
-{
-  "singleQuote": true,
-  "trailingComma": "es5",
-  "printWidth": 100,
-  "tabWidth": 2,
-  "semi": true,
-  "bracketSpacing": true,
-  "bracketSameLine": false,
-  "arrowParens": "avoid",
-  "endOfLine": "lf",
-  "quoteProps": "as-needed",
-  "jsxSingleQuote": false,
-  "requirePragma": false,
-  "insertPragma": false,
-  "proseWrap": "preserve"
-}

package/.claude/worktrees/fix-save-button-disable/README.md

@@ -1 +0,0 @@
-# abmp-npm

package/.claude/worktrees/fix-save-button-disable/backend/README-member-contact-flows.md

@@ -1,136 +0,0 @@
-# Member–Contact Flows
-
-How Wix **Members** (login identity) and **CRM Contacts** (form/submission identity) stay in sync in ABMP.
-
-## Concepts
-
-| Concept                | Meaning                                                                                                    |
-| ---------------------- | ---------------------------------------------------------------------------------------------------------- |
-| **Single entity**      | Member and contact use the same Wix ID (`wixContactId === wixMemberId`). One person, one record.           |
-| **Separate contact**   | Member has a login email; contact has a different “form” email. Two Wix entities: one Member, one Contact. |
-| **Login email**        | `memberData.email` — used to sign in (Wix Member).                                                         |
-| **Contact form email** | `memberData.contactFormEmail` — email used on forms; can differ from login.                                |
-
----
-
-## 1. Login / first-time flow: `createContactAndMemberIfNew`
-
-**Used when:** A user logs in or is created and we need to ensure they have both a Wix Member and (if needed) a CRM Contact.
-
-**File:** `members-data-methods.js` → `createContactAndMemberIfNew(memberData)`
-
-### Logic in short
-
-- If no **Wix Member** → create one (login identity).
-- If no **Wix Contact** and contact form email **differs** from login email → create a separate Contact.
-- If contact form email **equals** login email → no separate contact; we use the member ID as the contact ID (single entity).
-- Persist `wixMemberId` and `wixContactId` on the member record.
-
-### Flow diagram
-
-```mermaid
-flowchart TD
-    A[createContactAndMemberIfNew] --> B{Has wixMemberId?}
-    B -->|No| C[Create Wix Member]
-    B -->|Yes| D{Has wixContactId?}
-    C --> D
-    D -->|No| E{contactFormEmail !== email?}
-    D -->|Yes| K[Keep existing IDs]
-    E -->|Yes| F[Create Wix Contact]
-    E -->|No| G[Use member ID as contact ID]
-    F --> H[Resolve IDs]
-    G --> H
-    K --> H
-    H[newWixContactId = createdContact OR memberId] --> I[Set wixMemberId, wixContactId on member]
-    I --> J[updateMember + return]
-```
-
-### Parallel work
-
-```
-                    ┌─────────────────────────────────────┐
-                    │  createContactAndMemberIfNew         │
-                    └─────────────────────────────────────┘
-                                        │
-                    ┌───────────────────┴───────────────────┐
-                    │           Promise.all([              │
-                    │  runIf(needsWixMember, createMember),  │
-                    │  runIf(needsContact && differentEmail, │
-                    │        createContact)                 │
-                    │           ])                          │
-                    └───────────────────┬───────────────────┘
-                                        │
-          newWixContactId = createdWixContactId || newWixMemberId
-          (if no separate contact, member ID is the contact ID)
-                                        │
-                    ┌───────────────────┴───────────────────┐
-                    │  updateMember({ ...memberData,        │
-                    │    wixMemberId, wixContactId })      │
-                    └───────────────────────────────────────┘
-```
-
-### Outcome
-
-| Scenario                                | wixMemberId   | wixContactId                        |
-| --------------------------------------- | ------------- | ----------------------------------- |
-| New user, same email for login and form | New member ID | Same as wixMemberId (single entity) |
-| New user, form email ≠ login email      | New member ID | New contact ID (separate contact)   |
-| Existing user (already has both IDs)    | Unchanged     | Unchanged                           |
-
----
-
-## 2. Update contact email flow: `updateContactEmail`
-
-**Used when:** User changes their contact/form email in the app and we need to update CRM and optionally the member record.
-
-**File:** `member-contact-orchestration.js` → `updateContactEmail(newContactEmail, existingMemberData)` (used by `updateMemberContactInfo`).
-
-### Logic in short
-
-- **Single entity** (`wixContactId === wixMemberId`):
-  - If new email **equals** login → no change.
-  - If new email **differs** → create a new Contact with the new email and point the member to it (we now have a separate contact).
-- **Separate contact** (different IDs):
-  - If new email **equals** login → delete the extra contact and set `wixContactId = wixMemberId` (collapse to single entity).
-  - If new email **differs** → update the existing contact’s email in CRM.
-
-### Flow diagram
-
-```mermaid
-flowchart TD
-    A[updateContactEmail] --> B{contactEmail === loginEmail?}
-    B -->|Yes| C{Single entity?}
-    B -->|No| D{Single entity?}
-    C -->|Yes| E[No-op: already in sync]
-    C -->|No| F[Delete contact\nSet wixContactId = wixMemberId]
-    D -->|Yes| G[Create new Contact with new email\nUpdate member wixContactId]
-    D -->|No| H[Update existing contact email in CRM]
-```
-
-### Decision table
-
-| Single entity? | New email vs login | Action                                                            |
-| -------------- | ------------------ | ----------------------------------------------------------------- |
-| Yes            | Same               | No-op                                                             |
-| Yes            | Different          | Create new Contact; set member’s `wixContactId` to new contact ID |
-| No             | Same               | Delete Contact; set member’s `wixContactId = wixMemberId`         |
-| No             | Different          | Update existing Contact’s email in CRM (no member change)         |
-
-### Where it’s used
-
-`updateContactEmail` is called from `updateMemberContactInfo` when the **contactFormEmail** field changes (e.g. profile or form update). So:
-
-- **Login flow** → `createContactAndMemberIfNew` (ensure member + contact exist and IDs stored).
-- **Profile/form email change** → `updateMemberContactInfo` → `updateContactEmail` (keep contact and member in sync).
-
----
-
-## File roles
-
-| File                              | Role                                                                                                                                |
-| --------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- |
-| `contacts-methods.js`             | Contact CRUD only: create/update/delete contact in Wix CRM.                                                                         |
-| `member-contact-orchestration.js` | Orchestration: when to create/update/delete contact and when to update member’s `wixContactId`. Uses injected `updateMember`.       |
-| `members-data-methods.js`         | Member CRUD, `createContactAndMemberIfNew`; requires `updateMemberContactInfo` and calls `updateMember` once with its return value. |
-
-Dependency direction: **members-data** → **member-contact-orchestration** → **contacts** (no cycle).

package/.claude/worktrees/fix-save-button-disable/backend/__tests__/daily-pull-execution-check.test.js

@@ -1,124 +0,0 @@
-jest.mock('../elevated-modules', () => ({
-  wixData: { query: jest.fn() },
-}));
-jest.mock('psdev-task-manager', () => ({ taskManager: jest.fn() }));
-
-const { taskManager } = require('psdev-task-manager');
-
-const { buildDailyPullTasks } = require('../daily-pull/schedule-methods');
-const { wixData } = require('../elevated-modules');
-const { TASKS_NAMES } = require('../tasks/consts');
-const { dailyPullExecutionCheck } = require('../tasks/daily-pull-check-methods');
-
-const makeQueryResult = items => ({ items, hasNext: () => false });
-
-const mockTasksQuery = items => {
-  const query = {
-    hasSome: jest.fn().mockReturnThis(),
-    ge: jest.fn().mockReturnThis(),
-    find: jest.fn().mockResolvedValue(makeQueryResult(items)),
-  };
-  wixData.query.mockReturnValue(query);
-  return query;
-};
-
-describe('buildDailyPullTasks', () => {
-  test('schedules one ScheduleMembersDataPerAction task per action, excluding none by default', () => {
-    const tasks = buildDailyPullTasks();
-
-    expect(tasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'update']);
-    tasks.forEach(task => {
-      expect(task.name).toBe(TASKS_NAMES.ScheduleMembersDataPerAction);
-      expect(task.type).toBe('scheduled');
-      expect(task.data).toEqual({ action: task.data.action });
-    });
-  });
-
-  test('includes the none action and flag when includeNone is set', () => {
-    const tasks = buildDailyPullTasks({ includeNone: true });
-
-    expect(tasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'none', 'update']);
-    tasks.forEach(task => expect(task.data.includeNone).toBe(true));
-  });
-
-  test('propagates isTestEnvironment and backupDate to every task', () => {
-    const tasks = buildDailyPullTasks({ isTestEnvironment: true, backupDate: '2026-06-01' });
-
-    tasks.forEach(task => {
-      expect(task.data.isTestEnvironment).toBe(true);
-      expect(task.data.backupDate).toBe('2026-06-01');
-    });
-  });
-});
-
-describe('dailyPullExecutionCheck', () => {
-  let scheduleInBulk;
-
-  beforeEach(() => {
-    wixData.query.mockReset();
-    scheduleInBulk = jest.fn().mockResolvedValue(undefined);
-    taskManager.mockReturnValue({ scheduleInBulk });
-  });
-
-  test('counts the per-action tasks the cron creates as evidence the pull ran', async () => {
-    const query = mockTasksQuery([{ name: TASKS_NAMES.ScheduleMembersDataPerAction }]);
-
-    const result = await dailyPullExecutionCheck({});
-
-    expect(query.hasSome).toHaveBeenCalledWith('name', [
-      TASKS_NAMES.ScheduleMembersDataPerAction,
-      TASKS_NAMES.ScheduleDailyMembersDataSync,
-    ]);
-    expect(result.success).toBe(true);
-    expect(result.fallbackScheduled).toBeUndefined();
-    expect(scheduleInBulk).not.toHaveBeenCalled();
-  });
-
-  test('schedules the per-action fallback with environment flags when no pull is found', async () => {
-    mockTasksQuery([]);
-
-    const result = await dailyPullExecutionCheck({ isTestEnvironment: true, includeNone: true });
-
-    expect(result.success).toBe(false);
-    expect(result.fallbackScheduled).toBe(true);
-    expect(scheduleInBulk).toHaveBeenCalledTimes(1);
-    const scheduledTasks = scheduleInBulk.mock.calls[0][0];
-    expect(scheduledTasks.map(task => task.data.action).sort()).toEqual([
-      'drop',
-      'new',
-      'none',
-      'update',
-    ]);
-    scheduledTasks.forEach(task => {
-      expect(task.name).toBe(TASKS_NAMES.ScheduleMembersDataPerAction);
-      expect(task.data.isTestEnvironment).toBe(true);
-      expect(task.data.includeNone).toBe(true);
-    });
-  });
-
-  test('fallback defaults to production flags when no task data is provided', async () => {
-    mockTasksQuery([]);
-
-    await dailyPullExecutionCheck(undefined);
-
-    const scheduledTasks = scheduleInBulk.mock.calls[0][0];
-    expect(scheduledTasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'update']);
-    scheduledTasks.forEach(task => {
-      expect(task.data.isTestEnvironment).toBeUndefined();
-      expect(task.data.includeNone).toBeUndefined();
-    });
-  });
-
-  test('uses the provided lookback window', async () => {
-    const query = mockTasksQuery([{ name: TASKS_NAMES.ScheduleDailyMembersDataSync }]);
-    const before = Date.now();
-
-    const result = await dailyPullExecutionCheck({ hoursBack: 12 });
-
-    const sinceDate = query.ge.mock.calls[0][1];
-    expect(query.ge).toHaveBeenCalledWith('_createdDate', expect.any(Date));
-    const expectedSince = before - 12 * 60 * 60 * 1000;
-    expect(Math.abs(sinceDate.getTime() - expectedSince)).toBeLessThan(5000);
-    expect(result.success).toBe(true);
-  });
-});

package/.claude/worktrees/fix-save-button-disable/backend/__tests__/ensure-unique-urls-in-batch.test.js

@@ -1,129 +0,0 @@
-const { ensureUniqueUrlsInBatch } = require('../daily-pull/bulk-process-methods');
-const membersDataMethods = require('../members-data-methods');
-jest.mock('../members-data-methods');
-
-describe('ensureUniqueUrlsInBatch', () => {
-  beforeEach(() => {
-    membersDataMethods.getMemberBySlug.mockReset();
-  });
-
-  describe('case-insensitivity (regression: avoid creating John-12 AND john-12)', () => {
-    test('merges John-11 and john-11 into one group and assigns unique sequential URLs', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue({ url: 'John-11', memberId: 1 });
-
-      const members = [
-        { memberId: 101, url: 'John-11', fullName: 'John Doe' },
-        { memberId: 102, url: 'john-11', fullName: 'John Doe' },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-
-      const urls = result.map(m => m.url);
-
-      expect(urls).toHaveLength(2);
-      expect(new Set(urls).size).toBe(2);
-      expect(urls.some(u => u.endsWith('-12'))).toBe(true);
-      expect(urls.some(u => u.endsWith('-13'))).toBe(true);
-    });
-
-    test('does NOT create both John-12 and john-12 (case duplicate)', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue({ url: 'John-11', memberId: 1 });
-
-      const members = [
-        { memberId: 101, url: 'John-11' },
-        { memberId: 102, url: 'john-11' },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-      const urls = result.map(m => m.url);
-
-      const hasJohn12 = urls.some(u => u === 'John-12');
-      const hasjohn12 = urls.some(u => u === 'john-12');
-      expect(hasJohn12 && hasjohn12).toBe(false);
-    });
-
-    test('handles JOHN, John, john variants - all merge into single group', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue(null);
-
-      const members = [
-        { memberId: 101, url: 'JOHN-5' },
-        { memberId: 102, url: 'John-5' },
-        { memberId: 103, url: 'john-5' },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-      const urls = result.map(m => m.url);
-
-      expect(urls).toHaveLength(3);
-      expect(new Set(urls).size).toBe(3);
-      const bases = urls.map(u => u.replace(/-\d+$/, '').toLowerCase());
-      expect(new Set(bases).size).toBe(1);
-    });
-  });
-
-  describe('multiple members with same base URL', () => {
-    test('assigns sequential counters starting after batch max and DB max', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue({
-        url: 'firstNameLastName-11',
-        memberId: 1,
-      });
-
-      const members = [
-        { memberId: 201, url: 'firstNameLastName-11' },
-        { memberId: 202, url: 'firstNameLastName-11' },
-        { memberId: 203, url: 'firstNameLastName-11' },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-      const urls = result.map(m => m.url).sort();
-
-      expect(urls).toEqual([
-        'firstNameLastName-12',
-        'firstNameLastName-13',
-        'firstNameLastName-14',
-      ]);
-    });
-
-    test('uses batch max when DB has no matches', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue(null);
-
-      const members = [
-        { memberId: 301, url: 'testUser-5' },
-        { memberId: 302, url: 'testUser-5' },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-      const urls = result.map(m => m.url).sort();
-
-      expect(urls).toEqual(['testUser-6', 'testUser-7']);
-    });
-  });
-
-  describe('edge cases', () => {
-    test('returns empty array unchanged', async () => {
-      const result = await ensureUniqueUrlsInBatch([]);
-      expect(result).toEqual([]);
-    });
-
-    test('returns non-array unchanged', async () => {
-      const input = { not: 'array' };
-      const result = await ensureUniqueUrlsInBatch(input);
-      expect(result).toBe(input);
-    });
-
-    test('skips members without url', async () => {
-      membersDataMethods.getMemberBySlug.mockResolvedValue(null);
-
-      const members = [
-        { memberId: 401, url: 'validUrl' },
-        { memberId: 402, url: null },
-        { memberId: 403 },
-      ];
-
-      const result = await ensureUniqueUrlsInBatch(members);
-      expect(result).toHaveLength(3);
-      expect(result[0].url).toBe('validUrl');
-      expect(result[1].url).toBeNull();
-    });
-  });
-});