abmp-npm 10.3.8 → 10.3.10

package/backend/__tests__/daily-pull-execution-check.test.js

@@ -0,0 +1,124 @@
+jest.mock('../elevated-modules', () => ({
+  wixData: { query: jest.fn() },
+}));
+jest.mock('psdev-task-manager', () => ({ taskManager: jest.fn() }));
+
+const { taskManager } = require('psdev-task-manager');
+
+const { buildDailyPullTasks } = require('../daily-pull/schedule-methods');
+const { wixData } = require('../elevated-modules');
+const { TASKS_NAMES } = require('../tasks/consts');
+const { dailyPullExecutionCheck } = require('../tasks/daily-pull-check-methods');
+
+const makeQueryResult = items => ({ items, hasNext: () => false });
+
+const mockTasksQuery = items => {
+  const query = {
+    hasSome: jest.fn().mockReturnThis(),
+    ge: jest.fn().mockReturnThis(),
+    find: jest.fn().mockResolvedValue(makeQueryResult(items)),
+  };
+  wixData.query.mockReturnValue(query);
+  return query;
+};
+
+describe('buildDailyPullTasks', () => {
+  test('schedules one ScheduleMembersDataPerAction task per action, excluding none by default', () => {
+    const tasks = buildDailyPullTasks();
+
+    expect(tasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'update']);
+    tasks.forEach(task => {
+      expect(task.name).toBe(TASKS_NAMES.ScheduleMembersDataPerAction);
+      expect(task.type).toBe('scheduled');
+      expect(task.data).toEqual({ action: task.data.action });
+    });
+  });
+
+  test('includes the none action and flag when includeNone is set', () => {
+    const tasks = buildDailyPullTasks({ includeNone: true });
+
+    expect(tasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'none', 'update']);
+    tasks.forEach(task => expect(task.data.includeNone).toBe(true));
+  });
+
+  test('propagates isTestEnvironment and backupDate to every task', () => {
+    const tasks = buildDailyPullTasks({ isTestEnvironment: true, backupDate: '2026-06-01' });
+
+    tasks.forEach(task => {
+      expect(task.data.isTestEnvironment).toBe(true);
+      expect(task.data.backupDate).toBe('2026-06-01');
+    });
+  });
+});
+
+describe('dailyPullExecutionCheck', () => {
+  let scheduleInBulk;
+
+  beforeEach(() => {
+    wixData.query.mockReset();
+    scheduleInBulk = jest.fn().mockResolvedValue(undefined);
+    taskManager.mockReturnValue({ scheduleInBulk });
+  });
+
+  test('counts the per-action tasks the cron creates as evidence the pull ran', async () => {
+    const query = mockTasksQuery([{ name: TASKS_NAMES.ScheduleMembersDataPerAction }]);
+
+    const result = await dailyPullExecutionCheck({});
+
+    expect(query.hasSome).toHaveBeenCalledWith('name', [
+      TASKS_NAMES.ScheduleMembersDataPerAction,
+      TASKS_NAMES.ScheduleDailyMembersDataSync,
+    ]);
+    expect(result.success).toBe(true);
+    expect(result.fallbackScheduled).toBeUndefined();
+    expect(scheduleInBulk).not.toHaveBeenCalled();
+  });
+
+  test('schedules the per-action fallback with environment flags when no pull is found', async () => {
+    mockTasksQuery([]);
+
+    const result = await dailyPullExecutionCheck({ isTestEnvironment: true, includeNone: true });
+
+    expect(result.success).toBe(false);
+    expect(result.fallbackScheduled).toBe(true);
+    expect(scheduleInBulk).toHaveBeenCalledTimes(1);
+    const scheduledTasks = scheduleInBulk.mock.calls[0][0];
+    expect(scheduledTasks.map(task => task.data.action).sort()).toEqual([
+      'drop',
+      'new',
+      'none',
+      'update',
+    ]);
+    scheduledTasks.forEach(task => {
+      expect(task.name).toBe(TASKS_NAMES.ScheduleMembersDataPerAction);
+      expect(task.data.isTestEnvironment).toBe(true);
+      expect(task.data.includeNone).toBe(true);
+    });
+  });
+
+  test('fallback defaults to production flags when no task data is provided', async () => {
+    mockTasksQuery([]);
+
+    await dailyPullExecutionCheck(undefined);
+
+    const scheduledTasks = scheduleInBulk.mock.calls[0][0];
+    expect(scheduledTasks.map(task => task.data.action).sort()).toEqual(['drop', 'new', 'update']);
+    scheduledTasks.forEach(task => {
+      expect(task.data.isTestEnvironment).toBeUndefined();
+      expect(task.data.includeNone).toBeUndefined();
+    });
+  });
+
+  test('uses the provided lookback window', async () => {
+    const query = mockTasksQuery([{ name: TASKS_NAMES.ScheduleDailyMembersDataSync }]);
+    const before = Date.now();
+
+    const result = await dailyPullExecutionCheck({ hoursBack: 12 });
+
+    const sinceDate = query.ge.mock.calls[0][1];
+    expect(query.ge).toHaveBeenCalledWith('_createdDate', expect.any(Date));
+    const expectedSince = before - 12 * 60 * 60 * 1000;
+    expect(Math.abs(sinceDate.getTime() - expectedSince)).toBeLessThan(5000);
+    expect(result.success).toBe(true);
+  });
+});

package/backend/__tests__/login-email-sync.test.js

@@ -0,0 +1,49 @@
+const { LOGIN_EMAIL_SYNC_STATUS } = require('../consts');
+const { summarizeLoginEmailOutcomes } = require('../daily-pull/utils');
+
+const { UPDATED, FAILED, SKIPPED } = LOGIN_EMAIL_SYNC_STATUS;
+
+describe('summarizeLoginEmailOutcomes', () => {
+  test('collects only FAILED outcomes as failures and failed ids', () => {
+    const outcomes = [
+      { memberId: 1, wixMemberId: 'w1', desiredEmail: 'a@x.com', status: UPDATED },
+      {
+        memberId: 2,
+        wixMemberId: 'w2',
+        desiredEmail: 'b@x.com',
+        status: FAILED,
+        error: 'duplicate',
+      },
+      { memberId: 3, status: SKIPPED, desiredEmail: 'c@x.com' },
+    ];
+
+    const { failedMemberIds, failures } = summarizeLoginEmailOutcomes(outcomes);
+
+    expect([...failedMemberIds]).toEqual([2]);
+    expect(failures).toEqual([
+      { memberId: 2, wixMemberId: 'w2', desiredEmail: 'b@x.com', error: 'duplicate' },
+    ]);
+  });
+
+  test('UPDATED and SKIPPED never produce failures (CMS email is left to advance/no-op)', () => {
+    const outcomes = [
+      { memberId: 1, status: UPDATED, desiredEmail: 'a@x.com' },
+      { memberId: 2, status: SKIPPED, desiredEmail: 'b@x.com' },
+    ];
+    const { failedMemberIds, failures } = summarizeLoginEmailOutcomes(outcomes);
+    expect(failedMemberIds.size).toBe(0);
+    expect(failures).toEqual([]);
+  });
+
+  test('defaults a missing error message', () => {
+    const { failures } = summarizeLoginEmailOutcomes([
+      { memberId: 9, wixMemberId: 'w9', desiredEmail: 'z@x.com', status: FAILED },
+    ]);
+    expect(failures[0].error).toBe('unknown error');
+  });
+
+  test('handles empty / missing input', () => {
+    expect(summarizeLoginEmailOutcomes([]).failures).toEqual([]);
+    expect(summarizeLoginEmailOutcomes().failures).toEqual([]);
+  });
+});

package/backend/__tests__/transient-retry-and-bulk-lookup.test.js

@@ -0,0 +1,129 @@
+jest.mock('../elevated-modules', () => ({
+  wixData: { query: jest.fn() },
+}));
+
+const { wixData } = require('../elevated-modules');
+const { findMembersByIds } = require('../members-data-methods');
+const { withTransientErrorRetry, isTransientNetworkError } = require('../utils');
+
+const makeQueryResult = items => ({ items, hasNext: () => false });
+
+const mockQueryReturning = find => {
+  const query = {
+    hasSome: jest.fn().mockReturnThis(),
+    limit: jest.fn().mockReturnThis(),
+    find,
+  };
+  wixData.query.mockReturnValue(query);
+  return query;
+};
+
+describe('isTransientNetworkError', () => {
+  test('matches undici "fetch failed" and common network error codes', () => {
+    expect(isTransientNetworkError(new Error('fetch failed'))).toBe(true);
+    expect(isTransientNetworkError({ message: 'request failed', code: 'ECONNRESET' })).toBe(true);
+    expect(
+      isTransientNetworkError({ message: 'fetch failed', cause: { code: 'UND_ERR_SOCKET' } })
+    ).toBe(true);
+  });
+
+  test('does not match application errors', () => {
+    expect(isTransientNetworkError(new Error('Multiple members found with memberId 1'))).toBe(
+      false
+    );
+    expect(isTransientNetworkError(new Error('WDE0025: validation failed'))).toBe(false);
+  });
+});
+
+describe('withTransientErrorRetry', () => {
+  test('retries transient failures and resolves with the eventual result', async () => {
+    const operation = jest
+      .fn()
+      .mockRejectedValueOnce(new Error('fetch failed'))
+      .mockResolvedValueOnce('ok');
+
+    await expect(withTransientErrorRetry(operation, { baseDelayMs: 1 })).resolves.toBe('ok');
+    expect(operation).toHaveBeenCalledTimes(2);
+  });
+
+  test('rethrows immediately on non-transient errors', async () => {
+    const operation = jest.fn().mockRejectedValue(new Error('validation failed'));
+
+    await expect(withTransientErrorRetry(operation, { baseDelayMs: 1 })).rejects.toThrow(
+      'validation failed'
+    );
+    expect(operation).toHaveBeenCalledTimes(1);
+  });
+
+  test('gives up after the configured number of retries', async () => {
+    const operation = jest.fn().mockRejectedValue(new Error('fetch failed'));
+
+    await expect(
+      withTransientErrorRetry(operation, { retries: 2, baseDelayMs: 1 })
+    ).rejects.toThrow('fetch failed');
+    expect(operation).toHaveBeenCalledTimes(3);
+  });
+});
+
+describe('findMembersByIds', () => {
+  beforeEach(() => {
+    wixData.query.mockReset();
+  });
+
+  test('returns a map of String(memberId) to member record', async () => {
+    mockQueryReturning(
+      jest.fn().mockResolvedValue(
+        makeQueryResult([
+          { _id: 'a', memberId: 1 },
+          { _id: 'b', memberId: 2 },
+        ])
+      )
+    );
+
+    const membersById = await findMembersByIds([1, 2, 3]);
+
+    expect(membersById.get('1')).toEqual({ _id: 'a', memberId: 1 });
+    expect(membersById.get('2')).toEqual({ _id: 'b', memberId: 2 });
+    expect(membersById.has('3')).toBe(false);
+  });
+
+  test('deduplicates input IDs and skips null/undefined before querying', async () => {
+    const query = mockQueryReturning(jest.fn().mockResolvedValue(makeQueryResult([])));
+
+    await findMembersByIds([1, 1, null, undefined, 2]);
+
+    expect(query.hasSome).toHaveBeenCalledWith('memberId', [1, 2]);
+  });
+
+  test('returns an empty map without querying when there are no IDs', async () => {
+    const membersById = await findMembersByIds([]);
+
+    expect(membersById.size).toBe(0);
+    expect(wixData.query).not.toHaveBeenCalled();
+  });
+
+  test('chunks large ID lists into multiple queries', async () => {
+    const query = mockQueryReturning(jest.fn().mockResolvedValue(makeQueryResult([])));
+    const ids = Array.from({ length: 250 }, (_, i) => i + 1);
+
+    await findMembersByIds(ids);
+
+    expect(query.hasSome).toHaveBeenCalledTimes(3);
+    expect(query.hasSome.mock.calls.map(call => call[1].length)).toEqual([100, 100, 50]);
+  });
+
+  test('throws when multiple records share the same memberId', async () => {
+    mockQueryReturning(
+      jest.fn().mockResolvedValue(
+        makeQueryResult([
+          { _id: 'a', memberId: 1 },
+          { _id: 'b', memberId: 1 },
+        ])
+      )
+    );
+
+    await expect(findMembersByIds([1])).rejects.toThrow(
+      'Multiple members found with memberId(s): [1]'
+    );
+  });
+});

package/backend/consts.js

@@ -34,6 +34,15 @@ const MEMBERSHIPS_TYPES = {
   PAC_STAFF: 'PAC STAFF',
 };
 
+/**
+ * Possible outcomes of attempting to change a Wix member's login email during the sync.
+ */
+const LOGIN_EMAIL_SYNC_STATUS = {
+  UPDATED: 'updated', // Wix login email successfully changed to the desired email
+  FAILED: 'failed', // change failed -> keep the CMS login email unchanged and report for manual handling
+  SKIPPED: 'skipped', // member has no wixMemberId, nothing to change
+};
+
 module.exports = {
   CONFIG_KEYS,
   MAX__MEMBERS_SEARCH_RESULTS,
@@ -45,4 +54,5 @@ module.exports = {
   MEMBERSHIPS_TYPES,
   SSO_TOKEN_AUTH_API_URL,
   BACKUP_API_URL,
+  LOGIN_EMAIL_SYNC_STATUS,
 };

package/backend/contacts-methods.js

@@ -28,6 +28,9 @@ async function createSiteContact(contactData) {
     },
   };
   console.log('[createSiteContact]contactInfo', JSON.stringify(contactInfo, null, 2));
+  // Intentionally NOT passing allowDuplicates: Wix CRM enforces email uniqueness
+  // case-insensitively, which is the guard we want against two different members sharing an
+  // email. Same-member cases never reach here — they collapse to a single entity upstream.
   const createContactResponse = await elevatedCreateContact(contactInfo);
   console.log(
     '[createSiteContact]createContactResponse',

package/backend/daily-pull/bulk-process-methods.js

@@ -1,8 +1,13 @@
-const { bulkSaveMembers, getMemberBySlug } = require('../members-data-methods');
+const { bulkSaveMembers, getMemberBySlug, findMembersByIds } = require('../members-data-methods');
 const { extractUrlCounter } = require('../utils');
 
 const { generateUpdatedMemberData } = require('./process-member-methods');
-const { changeWixMembersEmails, incrementUrlCounter, extractBaseUrl } = require('./utils');
+const {
+  changeWixMembersEmails,
+  summarizeLoginEmailOutcomes,
+  incrementUrlCounter,
+  extractBaseUrl,
+} = require('./utils');
 
 /**
  * Ensures unique URLs within a batch of members by deduplicating URLs
@@ -127,10 +132,18 @@ const bulkProcessAndSaveMemberData = async ({ memberDataList, currentPageNumber
   const startTime = Date.now();
 
   try {
+    // Prefetch all existing members for this page in a few chunked queries instead of
+    // one query per member — thousands of parallel lookups made the whole page fail
+    // whenever a single one hit a transient network error.
+    const existingMembersById = await findMembersByIds(
+      memberDataList.map(memberData => memberData?.memberid)
+    );
+
     const processedMemberDataPromises = memberDataList.map(memberData =>
       generateUpdatedMemberData({
         inputMemberData: memberData,
         currentPageNumber,
+        existingDbMember: existingMembersById.get(String(memberData?.memberid)) ?? null,
       })
     );
 
@@ -151,28 +164,55 @@ const bulkProcessAndSaveMemberData = async ({ memberDataList, currentPageNumber
     // Ensure unique URLs within the batch to prevent duplicates (also checks DB for cross-page conflicts)
     const uniqueUrlsNewToDBMembersList = await ensureUniqueUrlsInBatch(newMembers);
     const uniqueUrlsMembersData = [...uniqueUrlsNewToDBMembersList, ...existingMembers];
-    const toChangeWixMembersEmails = [];
+
+    // Change Wix login emails FIRST so we know which succeeded before saving the CMS records.
+    const toChangeWixMembersEmails = uniqueUrlsMembersData.filter(
+      member => member.wixMemberId && member.isLoginEmailChanged
+    );
+    let failedLoginEmailIds = new Set();
+    let loginEmailFailures = [];
+    if (toChangeWixMembersEmails.length > 0) {
+      const outcomes = await changeWixMembersEmails(toChangeWixMembersEmails);
+      ({ failedMemberIds: failedLoginEmailIds, failures: loginEmailFailures } =
+        summarizeLoginEmailOutcomes(outcomes));
+    }
+
     const toSaveMembersData = uniqueUrlsMembersData.map(member => {
-      const { isLoginEmailChanged, isNewToDb: _isNewToDb, ...restMemberData } = member;
-      if (member.wixMemberId && isLoginEmailChanged) {
-        toChangeWixMembersEmails.push(member);
+      // Transient flags only drive the sync above; never persist them.
+      const {
+        isLoginEmailChanged: _isLoginEmailChanged,
+        isNewToDb: _isNewToDb,
+        previousLoginEmail,
+        ...restMemberData
+      } = member;
+      // If the Wix login-email change failed, keep the CMS login email unchanged (revert to the
+      // previous value) so the CMS stays consistent with Wix; the failure is reported below for
+      // manual handling.
+      if (failedLoginEmailIds.has(member.memberId) && previousLoginEmail !== undefined) {
+        return { ...restMemberData, email: previousLoginEmail };
       }
-      return restMemberData; //we don't want to store the isLoginEmailChanged in the database, it's just a flag to know if we need to change the login email in Members area
+      return restMemberData;
     });
     const saveResult = await bulkSaveMembers(toSaveMembersData);
-    // Change login emails for users who was dropped but now are back to system as new members and have different loginEmail for users with action DROP
-    if (toChangeWixMembersEmails.length > 0) {
-      await changeWixMembersEmails(toChangeWixMembersEmails);
-    }
     const totalFailed = memberDataList.length - validMemberData.length;
     const processingTime = Date.now() - startTime;
 
+    if (loginEmailFailures.length > 0) {
+      console.error(
+        `[loginEmailSync] ${loginEmailFailures.length} login-email change(s) failed on page ${currentPageNumber}; CMS login email left unchanged for memberIds: [${loginEmailFailures
+          .map(failure => failure.memberId)
+          .join(', ')}]`
+      );
+    }
+
     return {
       ...saveResult,
       totalProcessed: memberDataList.length,
       totalSaved: validMemberData.length,
       totalFailed: totalFailed,
       processingTime: processingTime,
+      loginEmailFailedCount: loginEmailFailures.length,
+      loginEmailFailures,
     };
   } catch (error) {
     throw new Error(`Bulk operation failed: ${error.message}`);

package/backend/daily-pull/process-member-methods.js

@@ -58,16 +58,26 @@ const ensureUniqueUrl = async ({ url, memberId, fullName }) => {
  * @param {Object} options - The options object
  * @param {Object} options.inputMemberData - Raw member data from API
  * @param {number} options.currentPageNumber - Current page number being processed
+ * @param {Object|null} [options.existingDbMember] - Prefetched DB member (null if none exists).
+ *   Pass it when processing members in bulk to avoid one DB query per member; when omitted,
+ *   the member is looked up individually.
  * @returns {Promise<Object|null>} - Complete updated member data or null if validation fails
  */
-async function generateUpdatedMemberData({ inputMemberData, currentPageNumber }) {
+async function generateUpdatedMemberData({
+  inputMemberData,
+  currentPageNumber,
+  existingDbMember: prefetchedDbMember,
+}) {
   if (!validateCoreMemberData(inputMemberData)) {
     throw new Error(
       'Invalid member data: memberid, email (valid string), and memberships (array) are required'
     );
   }
 
-  const existingDbMember = await findMemberById(inputMemberData.memberid);
+  const existingDbMember =
+    prefetchedDbMember === undefined
+      ? await findMemberById(inputMemberData.memberid)
+      : prefetchedDbMember;
 
   const updatedMemberData = await createCoreMemberData(
     inputMemberData,
@@ -165,10 +175,12 @@ async function createCoreMemberData(inputMemberData, existingDbMember, currentPa
       newEmail &&
       existingDbMember.email !== newEmail;
     if (isMemberReinstatedWithNewEmail) {
-      // If exists in DB, and email was changed means this user was dropped before that's why it exists in DB, then only update loginEmail not contactFormEmail
+      // If exists in DB, and email was changed means this user was dropped before that's why it exists in DB, then only update loginEmail not contactFormEmail.
+      // previousLoginEmail lets the caller keep the old email if the Wix login-email change fails.
       return {
         email: newEmail,
         isLoginEmailChanged: true,
+        previousLoginEmail: existingDbMember.email,
       };
     }
     //If exists in DB but not reinstated with new email, then don't update emails

package/backend/daily-pull/schedule-methods.js

@@ -0,0 +1,41 @@
+const { taskManager } = require('psdev-task-manager');
+
+const { TASKS_NAMES } = require('../tasks/consts');
+
+const { MEMBER_ACTIONS } = require('./consts');
+
+/**
+ * Builds the per-action daily pull tasks. Single source of truth for what a
+ * "daily pull" schedules, shared by the cron job and the execution-check
+ * fallback so both produce identical tasks (same names, same environment flags).
+ * @param {Object} [options]
+ * @param {string} [options.backupDate] - Optional backup date (YYYY-MM-DD) to pull from the backup endpoint
+ * @param {boolean} [options.isTestEnvironment=false] - Whether to pull from the test PAC API
+ * @param {boolean} [options.includeNone=false] - Whether to also sync the NONE action
+ * @returns {Array<Object>} - Task definitions for taskManager().scheduleInBulk
+ */
+const buildDailyPullTasks = ({ backupDate, isTestEnvironment, includeNone } = {}) => {
+  const actionsToSync = includeNone
+    ? Object.values(MEMBER_ACTIONS)
+    : Object.values(MEMBER_ACTIONS).filter(action => action !== MEMBER_ACTIONS.NONE);
+  return actionsToSync.map(action => ({
+    name: TASKS_NAMES.ScheduleMembersDataPerAction,
+    data: {
+      action,
+      ...(backupDate ? { backupDate } : {}),
+      ...(isTestEnvironment ? { isTestEnvironment } : {}),
+      ...(includeNone ? { includeNone } : {}),
+    },
+    type: 'scheduled',
+  }));
+};
+
+/**
+ * Schedules the daily pull (one ScheduleMembersDataPerAction task per action).
+ * @param {Object} [options] - Same options as buildDailyPullTasks
+ * @returns {Promise<any>}
+ */
+const scheduleDailyPullTasks = options =>
+  taskManager().scheduleInBulk(buildDailyPullTasks(options));
+
+module.exports = { buildDailyPullTasks, scheduleDailyPullTasks };

package/backend/daily-pull/utils.js

@@ -1,3 +1,4 @@
+const { LOGIN_EMAIL_SYNC_STATUS } = require('../consts');
 const { updateWixMemberLoginEmail } = require('../members-area-methods');
 const { extractUrlCounter } = require('../utils');
 
@@ -7,13 +8,49 @@ const isUpdatedMember = member => member.action !== MEMBER_ACTIONS.NONE;
 const isSiteAssociatedMember = (member, siteAssociation) =>
   member.memberships.some(membership => membership.association === siteAssociation);
 
+/**
+ * Attempts to change Wix login emails for the given members and returns one structured
+ * outcome per member (see updateWixMemberLoginEmail). Never throws for an individual member.
+ * @param {Array} toChangeWixMembersEmails
+ * @returns {Promise<Array>} outcomes
+ */
 const changeWixMembersEmails = async toChangeWixMembersEmails => {
   console.log(
-    `Changing login emails for ${toChangeWixMembersEmails.length} members with ids: [${toChangeWixMembersEmails.map(member => member.memberId).join(', ')}]`
+    `[loginEmailSync] changing login emails for ${toChangeWixMembersEmails.length} members with ids: [${toChangeWixMembersEmails.map(member => member.memberId).join(', ')}]`
   );
-  return await Promise.all(
-    toChangeWixMembersEmails.map(member => updateWixMemberLoginEmail(member, {}))
+  const outcomes = await Promise.all(
+    toChangeWixMembersEmails.map(member => updateWixMemberLoginEmail(member))
   );
+  const summary = outcomes.reduce((acc, outcome) => {
+    acc[outcome.status] = (acc[outcome.status] || 0) + 1;
+    return acc;
+  }, {});
+  console.log(`[loginEmailSync] results summary: ${JSON.stringify(summary)}`);
+  return outcomes;
+};
+
+/**
+ * Summarizes login-email sync outcomes for manual handling via the task result.
+ * Pure function so it can be unit-tested without Wix.
+ * @param {Array} outcomes - from updateWixMemberLoginEmail / changeWixMembersEmails
+ * @returns {{ failedMemberIds: Set, failures: Array }} set of failed memberIds (whose CMS login
+ *   email must be left unchanged) and the failure records to surface in the task result
+ */
+const summarizeLoginEmailOutcomes = (outcomes = []) => {
+  const failedMemberIds = new Set();
+  const failures = [];
+  outcomes.forEach(outcome => {
+    if (outcome.status === LOGIN_EMAIL_SYNC_STATUS.FAILED) {
+      failedMemberIds.add(outcome.memberId);
+      failures.push({
+        memberId: outcome.memberId,
+        wixMemberId: outcome.wixMemberId,
+        desiredEmail: outcome.desiredEmail,
+        error: outcome.error || 'unknown error',
+      });
+    }
+  });
+  return { failedMemberIds, failures };
 };
 
 const extractBaseUrl = url => {
@@ -105,6 +142,7 @@ module.exports = {
   isUpdatedMember,
   isSiteAssociatedMember,
   changeWixMembersEmails,
+  summarizeLoginEmailOutcomes,
   validateCoreMemberData,
   containsNonEnglish,
   createFullName,

package/backend/jobs.js

@@ -1,6 +1,6 @@
 const { taskManager } = require('psdev-task-manager');
 
-const { MEMBER_ACTIONS } = require('./daily-pull/consts');
+const { scheduleDailyPullTasks } = require('./daily-pull/schedule-methods');
 const { TASKS_NAMES } = require('./tasks/consts');
 const { dailyPullExecutionCheck } = require('./tasks/daily-pull-check-methods');
 const { TASKS } = require('./tasks/tasks-configs');
@@ -34,21 +34,7 @@ async function scheduleDailyPullTask(options = null) {
     console.log(`isTestEnvironment: ${isTestEnvironment}`);
     console.log(`includeNone: ${includeNone}`);
 
-    const actionsToSync = includeNone
-      ? Object.values(MEMBER_ACTIONS)
-      : Object.values(MEMBER_ACTIONS).filter(action => action !== MEMBER_ACTIONS.NONE);
-    const toScheduleTasks = actionsToSync.map(action => ({
-      name: TASKS_NAMES.ScheduleMembersDataPerAction,
-      data: {
-        action,
-        ...(backupDate ? { backupDate } : {}),
-        ...(isTestEnvironment ? { isTestEnvironment } : {}),
-        ...(includeNone ? { includeNone } : {}),
-      },
-      type: 'scheduled',
-    }));
-
-    return await taskManager().scheduleInBulk(toScheduleTasks);
+    return await scheduleDailyPullTasks({ backupDate, isTestEnvironment, includeNone });
   } catch (error) {
     console.error(`Failed to scheduleDailyPullTask: ${error.message}`);
     throw new Error(`Failed to scheduleDailyPullTask: ${error.message}`);
@@ -97,10 +83,50 @@ async function scheduleFixUrlsWithSpacesTask() {
   }
 }
 
-async function runDailyPullExecutionCheck() {
+async function scheduleNormalizeMemberEmailsTask() {
+  try {
+    console.log('scheduleNormalizeMemberEmails started!');
+    return await taskManager().schedule({
+      name: TASKS_NAMES.scheduleNormalizeMemberEmails,
+      data: {},
+      type: 'scheduled',
+    });
+  } catch (error) {
+    console.error(`Failed to scheduleNormalizeMemberEmails: ${error.message}`);
+    throw new Error(`Failed to scheduleNormalizeMemberEmails: ${error.message}`);
+  }
+}
+
+/**
+ * Schedules hiding ALL addresses for ALL members that have any address (sets each address's
+ * addressStatus to DONT_SHOW). Manually triggered one-off maintenance task.
+ */
+async function scheduleHideAllMemberAddressesTask() {
+  try {
+    console.log('scheduleHideAllMemberAddresses started!');
+    return await taskManager().schedule({
+      name: TASKS_NAMES.scheduleHideAllMemberAddresses,
+      data: {},
+      type: 'scheduled',
+    });
+  } catch (error) {
+    console.error(`Failed to scheduleHideAllMemberAddresses: ${error.message}`);
+    throw new Error(`Failed to scheduleHideAllMemberAddresses: ${error.message}`);
+  }
+}
+
+/**
+ * Runs the daily pull execution check (watchdog).
+ * @param {Object} [options]
+ * @param {number} [options.hoursBack=4] - Lookback window in hours
+ * @param {boolean} [options.isTestEnvironment=false] - Pull from the test PAC API if the fallback fires
+ * @param {boolean} [options.includeNone=false] - Include the NONE action if the fallback fires
+ * @returns {Promise<Object>} - Check result
+ */
+async function runDailyPullExecutionCheck(options = {}) {
   try {
     console.log('runDailyPullExecutionCheck started!');
-    return await dailyPullExecutionCheck({});
+    return await dailyPullExecutionCheck(options || {});
   } catch (error) {
     console.error(`Failed to runDailyPullExecutionCheck: ${error.message}`);
     throw new Error(`Failed to runDailyPullExecutionCheck: ${error.message}`);
@@ -126,5 +152,7 @@ module.exports = {
   scheduleCreateContactsFromMembersTask,
   scheduleFixPrimaryAddressForMembersTask,
   scheduleFixUrlsWithSpacesTask,
+  scheduleNormalizeMemberEmailsTask,
+  scheduleHideAllMemberAddressesTask,
   runDailyPullExecutionCheck,
 };