abmp-npm 1.9.7 → 1.9.9

package/backend/contacts-methods.js

@@ -17,15 +17,10 @@ async function updateContactInfo(contactId, updateInfoCallback, operationName) {
 
   try {
     const contact = await elevatedGetContact(contactId);
-    console.log('debug contact', contact);
     const currentInfo = contact.info;
-    console.log('debug currentInfo', currentInfo);
     const updatedInfo = updateInfoCallback(currentInfo);
-    console.log('debug updatedInfo', updatedInfo);
 
-    const result = await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
-    console.log('debug result', result);
-    return result;
+    await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
   } catch (error) {
     console.error(`Error in ${operationName}:`, error);
     throw new Error(`Failed to ${operationName}: ${error.message}`);

package/backend/daily-pull/bulk-process-methods.js

@@ -5,11 +5,18 @@ const { changeWixMembersEmails } = require('./utils');
 
 /**
  * Processes and saves multiple member records in bulk
+ * @param {Object} options - The options object
+ * @param {Array} options.memberDataList - Array of member data from API
+ * @param {number} options.currentPageNumber - Current page number being processed
+ * @param {boolean} [options.addInterests=true] - Whether to add interests to the member data
  * @param {Array} memberDataList - Array of member data from API
- * @param {number} currentPageNumber - Current page number being processed
  * @returns {Promise<Object>} - Bulk save operation result with statistics
  */
-const bulkProcessAndSaveMemberData = async (memberDataList, currentPageNumber) => {
+const bulkProcessAndSaveMemberData = async ({
+  memberDataList,
+  currentPageNumber,
+  addInterests = true,
+}) => {
   if (!Array.isArray(memberDataList) || memberDataList.length === 0) {
     throw new Error('Invalid member data list provided');
   }
@@ -18,7 +25,11 @@ const bulkProcessAndSaveMemberData = async (memberDataList, currentPageNumber) =
 
   try {
     const processedMemberDataPromises = memberDataList.map(memberData =>
-      generateUpdatedMemberData(memberData, currentPageNumber)
+      generateUpdatedMemberData({
+        inputMemberData: memberData,
+        currentPageNumber,
+        addInterests,
+      })
     );
 
     const processedMemberDataList = await Promise.all(processedMemberDataPromises);

package/backend/daily-pull/consts.js

@@ -24,8 +24,19 @@ const DEFAULT_MEMBER_DISPLAY_SETTINGS = {
   showWixUrl: true,
 };
 
+const PAC_ASSOCIATIONS = {
+  ABMP: 'ABMP',
+  ASCP: 'ASCP',
+  ANP: 'ANP',
+  AHP: 'AHP',
+};
+
+const SITES_WITH_INTERESTS_TO_MIGRATE = [PAC_ASSOCIATIONS.ABMP];
+
 module.exports = {
   MEMBER_ACTIONS,
   ADDRESS_VISIBILITY_OPTIONS,
   DEFAULT_MEMBER_DISPLAY_SETTINGS,
+  PAC_ASSOCIATIONS,
+  SITES_WITH_INTERESTS_TO_MIGRATE,
 };

package/backend/daily-pull/process-member-methods.js

@@ -60,11 +60,17 @@ const ensureUniqueUrl = async ({ url, memberId, fullName }) => {
 
 /**
  * Generates complete updated member data by combining existing and migration data
- * @param {Object} inputMemberData - Raw member data from API
- * @param {number} currentPageNumber - Current page number being processed
+ * @param {Object} options - The options object
+ * @param {Object} options.inputMemberData - Raw member data from API
+ * @param {string} options.addInterests - Site association of the member
+ * @param {number} options.currentPageNumber - Current page number being processed
  * @returns {Promise<Object|null>} - Complete updated member data or null if validation fails
  */
-async function generateUpdatedMemberData(inputMemberData, currentPageNumber) {
+async function generateUpdatedMemberData({
+  inputMemberData,
+  addInterests = true,
+  currentPageNumber,
+}) {
   if (!validateCoreMemberData(inputMemberData)) {
     throw new Error(
       'Invalid member data: memberid, email (valid string), and memberships (array) are required'
@@ -86,7 +92,11 @@ async function generateUpdatedMemberData(inputMemberData, currentPageNumber) {
 
   // Only enrich with migration and address data for new members
   if (!existingDbMember) {
-    enrichWithMigrationData(updatedMemberData, inputMemberData.migrationData);
+    enrichWithMigrationData({
+      memberDataToUpdate: updatedMemberData,
+      migrationData: inputMemberData.migrationData,
+      addInterests,
+    });
 
     enrichWithAddressData(
       updatedMemberData,
@@ -196,10 +206,13 @@ async function getNewMemberOnlyFields(inputMemberData, existingDbMember) {
 }
 /**
  * Enriches member data with optional migration properties
- * @param {Object} memberDataToUpdate - Member data object to enhance
+ * @param {Object} options - The options object
+ * @param {Object} options.memberDataToUpdate - Member data object to enhance
+ * @param {Object} options.migrationData - Migration data containing optional properties
+ * @param {boolean} [options.addInterests=true] - Whether to add interests to the member data
  * @param {Object} migrationData - Migration data containing optional properties
  */
-function enrichWithMigrationData(memberDataToUpdate, migrationData) {
+function enrichWithMigrationData({ memberDataToUpdate, migrationData, addInterests = true }) {
   if (!migrationData) return;
 
   memberDataToUpdate.addressInfo = migrationData.addressinfo;
@@ -209,7 +222,7 @@ function enrichWithMigrationData(memberDataToUpdate, migrationData) {
     memberDataToUpdate.showWebsite = true;
   }
 
-  if (migrationData.interests) {
+  if (addInterests && migrationData.interests) {
     memberDataToUpdate.areasOfPractices = processInterests(migrationData.interests);
   }
 }

package/backend/daily-pull/sync-to-cms-methods.js

@@ -6,6 +6,7 @@ const { TASKS_NAMES } = require('../tasks/consts');
 const { getSiteConfigs } = require('../utils');
 
 const { bulkProcessAndSaveMemberData } = require('./bulk-process-methods');
+const { SITES_WITH_INTERESTS_TO_MIGRATE } = require('./consts');
 const { isUpdatedMember, isSiteAssociatedMember } = require('./utils');
 
 async function syncMembersDataPerAction(action) {
@@ -79,6 +80,7 @@ async function synchronizeSinglePage(taskObject) {
       getSiteConfigs(CONFIG_KEYS.SITE_ASSOCIATION),
       fetchPACMembers(pageNumber, action),
     ]);
+    const addInterests = SITES_WITH_INTERESTS_TO_MIGRATE.includes(siteAssociation);
     if (
       !memberDataResponse ||
       !memberDataResponse.results ||
@@ -98,7 +100,11 @@ async function synchronizeSinglePage(taskObject) {
         message: `No to be updated, or members of association: '${siteAssociation}' found`,
       };
     }
-    const result = await bulkProcessAndSaveMemberData(toSyncMembers, pageNumber);
+    const result = await bulkProcessAndSaveMemberData({
+      memberDataList: toSyncMembers,
+      currentPageNumber: pageNumber,
+      addInterests,
+    });
 
     return {
       success: true,

package/backend/elevated-modules.js

@@ -12,7 +12,7 @@ const wixData = {
   get: auth.elevate(items.get),
   truncate: auth.elevate(items.truncate),
   bulkSave: auth.elevate(items.bulkSave),
+  search: auth.elevate(items.search),
   //TODO: add other methods here as needed
 };
-
 module.exports = { wixData };

package/backend/index.js

@@ -13,5 +13,4 @@ module.exports = {
   ...require('./login'),
   ...require('./data-hooks'),
   ...require('./http-functions'),
-  ...require('./test-methods'), // Debug/test methods for contact email update investigation
 };

package/backend/members-data-methods.js

@@ -10,6 +10,7 @@ const {
   normalizeUrlForComparison,
   queryAllItems,
   generateGeoHash,
+  searchAllItems,
 } = require('./utils');
 
 /**
@@ -121,7 +122,7 @@ async function getMemberBySlug({
   if (!slug) return null;
 
   try {
-    let query = wixData.query(COLLECTIONS.MEMBERS_DATA).contains('url', slug);
+    let query = wixData.search(COLLECTIONS.MEMBERS_DATA).expression(slug);
 
     if (excludeDropped) {
       query = query.ne('action', 'drop');
@@ -131,11 +132,23 @@ async function getMemberBySlug({
       query = query.ne('memberId', memberId);
     }
     query = query.limit(1000);
-    const membersList = await queryAllItems(query);
+    const searchResult = await searchAllItems(query);
+    console.log('searchResult type:', Array.isArray(searchResult) ? 'array' : typeof searchResult);
+    console.log('searchResult length:', searchResult?.length);
+    const membersList = searchResult.filter(item => item.url && item.url.includes(slug)); //replacement for contains
+    console.log('membersList type:', Array.isArray(membersList) ? 'array' : typeof membersList);
+    console.log('membersList length:', membersList?.length);
     let matchingMembers = membersList.filter(
       item => item.url && item.url.toLowerCase() === slug.toLowerCase()
     );
+    console.log(
+      'matchingMembers type:',
+      Array.isArray(matchingMembers) ? 'array' : typeof matchingMembers
+    );
+    console.log('matchingMembers length:', matchingMembers?.length);
     if (normalizeSlugForComparison) {
+      console.log('normalizeSlugForComparison is true, about to filter membersList');
+      console.log('membersList before normalize filter:', membersList);
       matchingMembers = membersList
         .filter(
           //remove trailing "-1", "-2", etc.

package/backend/utils.js

@@ -107,18 +107,28 @@ function getAddressesByStatus(addresses = [], addressDisplayOption = []) {
     })
     .filter(Boolean);
 }
-const queryAllItems = async query => {
-  console.log('start query');
-  let oldResults = await query.find();
+const getAllItems = async querySearchResult => {
+  let oldResults = querySearchResult;
   console.log(`found items: ${oldResults.items.length}`);
   const allItems = oldResults.items;
   while (oldResults.hasNext()) {
     oldResults = await oldResults.next();
     allItems.push(...oldResults.items);
   }
-  console.log(`all items: ${allItems.length}`);
+  console.log(`all items count : ${allItems.length}`);
   return allItems;
 };
+const searchAllItems = async searchQuery => {
+  console.log('start search');
+  const searchResults = await searchQuery.run();
+  return getAllItems(searchResults);
+};
+
+const queryAllItems = async query => {
+  console.log('start query');
+  const queryResults = await query.find();
+  return getAllItems(queryResults);
+};
 /**
  * Chunks large arrays into smaller chunks for processing
  * @param {Array} array - Array to chunk
@@ -206,4 +216,5 @@ module.exports = {
   formatDateOnly,
   getAddressesByStatus,
   isPAC_STAFF,
+  searchAllItems,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abmp-npm",
-  "version": "1.9.7",
+  "version": "1.9.9",
   "main": "index.js",
   "scripts": {
     "check-cycles": "madge --circular .",

package/public/Utils/homePage.js

@@ -127,6 +127,8 @@ const createHomepageUtils = (_$w, filterProfiles) => {
 
     paginateSearchResults(searchResults, pagination);
     await updateUrlParams(filter, pagination);
+
+    _$w('#resultsStateBox').scrollTo();
   }
 
   async function onChangeMultiCheckbox({

package/CONTACT_EMAIL_UPDATE_DEBUG.md

@@ -1,313 +0,0 @@
-# Contact Email Update Investigation Guide
-
-## Problem Description
-
-Contact email updates in Wix CRM are not working after migration to npm package:
-
-- ✅ Members data in Wix DB updates correctly
-- ❌ Contact email in Wix CRM does not update
-- ❌ No errors appear in logs
-- ✅ Old implementation (before npm) works fine
-
-## Key Differences Found
-
-### OLD Implementation (Working)
-
-```javascript
-// From: src/backend/api.web.js (before npm migration)
-import { contacts } from 'wix-crm.v2'; // ← Old package
-import { elevate } from 'wix-auth'; // ← Old import style
-
-// Elevated functions created INSIDE the function
-async function updateContactInfo(contactId, updateInfoCallback, operationName) {
-  const elevatedGetContact = elevate(contacts.getContact);
-  const elevatedUpdateContact = elevate(contacts.updateContact);
-
-  const currentContact = await elevatedGetContact(contactId);
-  const updatedInfo = updateInfoCallback(currentContact.info);
-
-  // Passes updatedInfo DIRECTLY (not wrapped)
-  const result = await elevatedUpdateContact(
-    contactId,
-    updatedInfo, // ← Direct info object
-    currentContact.revision
-  );
-  return result;
-}
-```
-
-### NEW Implementation (Not Working)
-
-```javascript
-// From: abmp-npm/backend/contacts-methods.js
-const { contacts } = require('@wix/crm'); // ← New package
-const { auth } = require('@wix/essentials'); // ← New import style
-
-// Elevated functions created at MODULE LEVEL
-const elevatedGetContact = auth.elevate(contacts.getContact);
-const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-async function updateContactInfo(contactId, updateInfoCallback, operationName) {
-  const contact = await elevatedGetContact(contactId);
-  const updatedInfo = updateInfoCallback(contact.info);
-
-  // Wraps updatedInfo in { info: }
-  await elevatedUpdateContact(
-    contactId,
-    { info: updatedInfo }, // ← Wrapped in { info: }
-    contact.revision
-  );
-}
-```
-
-## Potential Issues
-
-### 1. Package Change: `wix-crm.v2` → `@wix/crm`
-
-The API signature might have changed between these packages:
-
-- **Old**: `updateContact(contactId, infoObject, revision)`
-- **New**: `updateContact(contactId, { info: infoObject }, revision)` or `updateContact(contactId, contactObject, { revision })`
-
-### 2. Elevation Scope
-
-- **Old**: Functions elevated inside the function (per-call elevation)
-- **New**: Functions elevated at module level (shared elevation)
-
-This could cause issues with permissions or context.
-
-### 3. Silent Failures
-
-If the CRM update throws an error but it's being caught and not logged, it would appear to work but not actually update.
-
-## Investigation Steps
-
-I've created three debugging files for you:
-
-### File 1: `contacts-methods-DEBUG.js`
-
-This is your current implementation with extensive logging. It will show:
-
-- Every step of the update process
-- All data being passed
-- Any errors (even if they're being caught)
-- Success confirmations
-
-### File 2: `contacts-methods-TEST.js`
-
-This contains 4 different implementations to test:
-
-- **V1**: Current style (wrapped in `{ info: }`)
-- **V2**: Old style (direct info object)
-- **V3**: Minimal payload (only changed fields)
-- **V4**: Revision in options object
-- **Elevation Test**: Checks if elevation is working at all
-
-### File 3: `test-methods.js`
-
-Web method wrappers you can call from the frontend to run the tests.
-
-## How to Use
-
-### Step 1: Update Backend Index
-
-Add the test methods to your npm package exports:
-
-```javascript
-// In abmp-npm/backend/index.js
-module.exports = {
-  ...require('./forms-methods'),
-  ...require('./search-filters-methods'),
-  ...require('./jobs'),
-  ...require('./utils'),
-  ...require('./daily-pull'),
-  ...require('./pac-api-methods'),
-  ...require('./members-area-methods'),
-  ...require('./members-data-methods'),
-  ...require('./cms-data-methods'),
-  ...require('./routers-methods'),
-  ...require('./test-methods'), // ← Add this
-};
-```
-
-### Step 2: Expose in Host Site
-
-Add these web methods to your host site:
-
-```javascript
-// In abmp/src/backend/web-methods.web.js
-import { Permissions, webMethod } from 'wix-web-module';
-import {
-  // ... existing imports
-  runContactUpdateTests as _runContactUpdateTests,
-  testContactElevation as _testContactElevation,
-  testUpdateMemberContactInfo as _testUpdateMemberContactInfo,
-} from 'abmp-npm/backend';
-
-// ... existing exports
-
-export const runContactUpdateTests = webMethod(Permissions.SiteMember, _runContactUpdateTests);
-
-export const testContactElevation = webMethod(Permissions.SiteMember, _testContactElevation);
-
-export const testUpdateMemberContactInfo = webMethod(
-  Permissions.SiteMember,
-  _testUpdateMemberContactInfo
-);
-```
-
-### Step 3: Run Tests from Frontend
-
-Option A - Test all variations:
-
-```javascript
-import { runContactUpdateTests } from 'backend/web-methods.web';
-import wixData from 'wix-data';
-
-// Get your member data (you need the contactId)
-const memberData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
-const contactId = memberData.contactId;
-
-// Run all test variations
-const results = await runContactUpdateTests(contactId, 'newemail@test.com');
-console.log('Test results:', results);
-
-// Check Wix Site Monitoring logs for detailed output
-```
-
-Option B - Test elevation only:
-
-```javascript
-import { testContactElevation } from 'backend/web-methods.web';
-
-const results = await testContactElevation(contactId);
-console.log('Elevation test results:', results);
-```
-
-Option C - Test with DEBUG logging (using your actual saveRegistrationData flow):
-
-```javascript
-import { testUpdateMemberContactInfo } from 'backend/web-methods.web';
-import wixData from 'wix-data';
-
-// Get existing member data
-const existingData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
-
-// Create update data (as it would come from your form)
-const updateData = {
-  ...existingData,
-  contactFormEmail: 'newemail@test.com', // Change the email
-  firstName: existingData.firstName,
-  lastName: existingData.lastName,
-};
-
-// Test with DEBUG logging
-const results = await testUpdateMemberContactInfo(updateData, existingData);
-console.log('Debug test results:', results);
-
-// Check Wix Site Monitoring logs for extensive output
-```
-
-### Step 4: Check Logs
-
-Go to your Wix Site Monitoring (Logs) and look for entries starting with:
-
-- `[DEBUG]` - From the debug version
-- `[TEST V1]`, `[TEST V2]`, etc. - From different test implementations
-- `[TEST ELEVATION]` - From elevation tests
-- `[TEST RUNNER]` - From the test runner
-
-## What to Look For
-
-### 1. Elevation Issues
-
-If you see errors like:
-
-- "Insufficient permissions"
-- "Unauthorized"
-- "Forbidden"
-
-Then elevation is not working correctly.
-
-### 2. API Signature Issues
-
-If you see errors like:
-
-- "Invalid parameter"
-- "Expected object of type Contact"
-- "Unexpected argument"
-
-Then the API signature has changed between packages.
-
-### 3. Silent Success
-
-If all tests show "success" but the email still doesn't update in CRM:
-
-- Check if the contact actually exists in CRM
-- Check if there are any CRM automation rules blocking updates
-- Check if the email field is locked/read-only
-
-### 4. Which Version Works
-
-If one of the test versions (V1, V2, V3, V4) works:
-
-- That tells us the correct API signature to use
-- Update the actual `contacts-methods.js` to match the working version
-
-## Quick Fix Hypothesis
-
-Based on the code comparison, my best guess is that the issue is with the API call signature. Try this fix first:
-
-### Option 1: Use Old Style (Direct Info Object)
-
-```javascript
-// In contacts-methods.js, line 23
-// CHANGE FROM:
-await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
-
-// CHANGE TO:
-await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
-```
-
-### Option 2: Move Elevation Inside Function
-
-```javascript
-// In contacts-methods.js
-// CHANGE FROM:
-const elevatedGetContact = auth.elevate(contacts.getContact);
-const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-async function updateContactInfo(contactId, updateInfoCallback, operationName) {
-  // ...
-}
-
-// CHANGE TO:
-async function updateContactInfo(contactId, updateInfoCallback, operationName) {
-  const elevatedGetContact = auth.elevate(contacts.getContact);
-  const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-  // ...
-}
-```
-
-## Next Steps
-
-1. ✅ Add test files to npm package (already created)
-2. ⬜ Release new npm version with test methods
-3. ⬜ Install new version in host site
-4. ⬜ Expose test web methods in host site
-5. ⬜ Run tests from frontend
-6. ⬜ Check logs to see which version works
-7. ⬜ Apply the working solution to the actual code
-8. ⬜ Remove test files and release final version
-
-## Need More Help?
-
-If the tests don't reveal the issue, we can:
-
-1. Add even more detailed logging
-2. Test with the actual Wix CRM dashboard to verify the contact exists
-3. Check if there are any CRM automation rules or webhooks interfering
-4. Test with a different contact to rule out data-specific issues
-5. Compare the exact bytes being sent in the old vs new implementation
-
-Let me know what the test results show!

package/DEBUG_QUICKSTART.md

@@ -1,133 +0,0 @@
-# Contact Email Update Investigation - Quick Start
-
-## 🔍 Problem Summary
-
-After migrating to npm package, contact email updates fail silently:
-
-- ✅ Wix DB updates work
-- ❌ CRM contact email doesn't update
-- ❌ No errors in logs
-
-## 🎯 Key Finding
-
-The old code used `wix-crm.v2` while the new code uses `@wix/crm`. These have **different API signatures**!
-
-**Old (Working)**:
-
-```javascript
-elevatedUpdateContact(contactId, infoObject, revision);
-```
-
-**New (Not Working?)**:
-
-```javascript
-elevatedUpdateContact(contactId, { info: infoObject }, revision);
-```
-
-## 🚀 Quick Steps to Investigate
-
-### 1. I've created 4 files for you:
-
-- ✅ `contacts-methods-DEBUG.js` - Your code with extensive logging
-- ✅ `contacts-methods-TEST.js` - 4 different API call variations
-- ✅ `test-methods.js` - Web methods to run tests
-- ✅ `CONTACT_EMAIL_UPDATE_DEBUG.md` - Full documentation
-
-### 2. Release this version to test:
-
-The test methods are already exported in `backend/index.js`.
-You just need to:
-
-1. Release new npm version
-2. Expose test methods in host site `web-methods.web.js`
-3. Run tests from frontend
-4. Check logs to see which variation works
-
-### 3. Expose test methods in host site:
-
-Add to `abmp/src/backend/web-methods.web.js`:
-
-```javascript
-import {
-  // ... your existing imports
-  runContactUpdateTests as _runContactUpdateTests,
-  testContactElevation as _testContactElevation,
-  testUpdateMemberContactInfo as _testUpdateMemberContactInfo,
-} from 'abmp-npm/backend';
-
-// ... existing exports
-
-export const runContactUpdateTests = webMethod(Permissions.SiteMember, _runContactUpdateTests);
-
-export const testContactElevation = webMethod(Permissions.SiteMember, _testContactElevation);
-
-export const testUpdateMemberContactInfo = webMethod(
-  Permissions.SiteMember,
-  _testUpdateMemberContactInfo
-);
-```
-
-### 4. Run tests from frontend:
-
-```javascript
-import { runContactUpdateTests } from 'backend/web-methods.web';
-import wixData from 'wix-data';
-
-// Get your contact ID from member data
-const memberData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
-
-// Run all test variations
-const results = await runContactUpdateTests(memberData.contactId, 'test@newemail.com');
-
-console.log('Results:', results);
-// Then check Wix Site Monitoring logs for detailed output
-```
-
-### 5. Check which test works:
-
-In Wix Site Monitoring, look for:
-
-- ✅ `[TEST V1]` - Current implementation
-- ✅ `[TEST V2]` - Old style (direct info object) ← **Most likely to work**
-- ✅ `[TEST V3]` - Minimal payload
-- ✅ `[TEST V4]` - Revision in options
-
-### 6. Apply the fix:
-
-Once you know which version works, update `contacts-methods.js` to match that signature.
-
-## 🔧 Most Likely Fix
-
-Based on the code comparison, try this first:
-
-### Change line 23 in `contacts-methods.js`:
-
-**FROM:**
-
-```javascript
-await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
-```
-
-**TO:**
-
-```javascript
-await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
-```
-
-This matches the old working implementation and might be the correct signature for the new package.
-
-## 📖 Full Documentation
-
-See `CONTACT_EMAIL_UPDATE_DEBUG.md` for complete details, analysis, and troubleshooting steps.
-
-## ✅ What's Already Done
-
-- ✅ Debugging files created
-- ✅ Test variations created
-- ✅ Test methods exported
-- ⬜ Release new npm version
-- ⬜ Expose in host site
-- ⬜ Run tests
-- ⬜ Apply fix
-
-Let me know what the tests reveal!

package/backend/contacts-methods-DEBUG.js

@@ -1,237 +0,0 @@
-const { contacts } = require('@wix/crm');
-const { auth } = require('@wix/essentials');
-
-/**
- * DEBUG VERSION with extensive logging
- * This file helps investigate why contact email updates aren't working
- */
-
-const elevatedGetContact = auth.elevate(contacts.getContact);
-const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-/**
- * Generic contact update helper function - DEBUG VERSION
- * @param {string} contactId - The contact ID in Wix CRM
- * @param {function} updateInfoCallback - Function that returns the updated info object
- * @param {string} operationName - Name of the operation for logging
- */
-async function updateContactInfo(contactId, updateInfoCallback, operationName) {
-  console.log(`[DEBUG] Starting ${operationName}`);
-  console.log(`[DEBUG] contactId:`, contactId);
-
-  if (!contactId) {
-    console.error(`[DEBUG] ERROR: Contact ID is missing`);
-    throw new Error('Contact ID is required');
-  }
-
-  try {
-    console.log(`[DEBUG] Attempting to fetch contact...`);
-    const contact = await elevatedGetContact(contactId);
-    console.log(`[DEBUG] Contact fetched successfully:`, JSON.stringify(contact, null, 2));
-
-    const currentInfo = contact.info;
-    console.log(`[DEBUG] Current contact info:`, JSON.stringify(currentInfo, null, 2));
-
-    const updatedInfo = updateInfoCallback(currentInfo);
-    console.log(`[DEBUG] Updated info to send:`, JSON.stringify(updatedInfo, null, 2));
-
-    console.log(`[DEBUG] Contact revision:`, contact.revision);
-    console.log(`[DEBUG] Attempting to update contact...`);
-
-    // Try the new way (wrapping in { info: })
-    const result = await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
-    console.log(`[DEBUG] Update result:`, JSON.stringify(result, null, 2));
-
-    console.log(`[DEBUG] ✅ ${operationName} completed successfully`);
-    return result;
-  } catch (error) {
-    console.error(`[DEBUG] ❌ Error in ${operationName}:`, error);
-    console.error(`[DEBUG] Error name:`, error.name);
-    console.error(`[DEBUG] Error message:`, error.message);
-    console.error(`[DEBUG] Error stack:`, error.stack);
-    console.error(`[DEBUG] Full error object:`, JSON.stringify(error, null, 2));
-    throw new Error(`Failed to ${operationName}: ${error.message}`);
-  }
-}
-
-/**
- * Updates contact email in Wix CRM - DEBUG VERSION
- * @param {string} contactId - The contact ID in Wix CRM
- * @param {string} newEmail - The new email address
- */
-async function updateContactEmail(contactId, newEmail) {
-  console.log(`[DEBUG] updateContactEmail called`);
-  console.log(`[DEBUG] contactId:`, contactId);
-  console.log(`[DEBUG] newEmail:`, newEmail);
-
-  if (!newEmail) {
-    console.error(`[DEBUG] ERROR: New email is missing`);
-    throw new Error('New email is required');
-  }
-
-  return await updateContactInfo(
-    contactId,
-    currentInfo => {
-      console.log(`[DEBUG] Building email update object...`);
-      const result = {
-        ...currentInfo,
-        emails: {
-          items: [
-            {
-              email: newEmail,
-              primary: true,
-            },
-          ],
-        },
-      };
-      console.log(`[DEBUG] Email update object built:`, JSON.stringify(result, null, 2));
-      return result;
-    },
-    'update contact email'
-  );
-}
-
-/**
- * Updates contact names in Wix CRM - DEBUG VERSION
- * @param {string} contactId - The contact ID in Wix CRM
- * @param {string} firstName - The new first name
- * @param {string} lastName - The new last name
- */
-async function updateContactNames(contactId, firstName, lastName) {
-  console.log(`[DEBUG] updateContactNames called`);
-  console.log(`[DEBUG] contactId:`, contactId);
-  console.log(`[DEBUG] firstName:`, firstName);
-  console.log(`[DEBUG] lastName:`, lastName);
-
-  if (!firstName && !lastName) {
-    console.error(`[DEBUG] ERROR: Both names are missing`);
-    throw new Error('At least one name field is required');
-  }
-
-  return await updateContactInfo(
-    contactId,
-    currentInfo => {
-      console.log(`[DEBUG] Building names update object...`);
-      const result = {
-        ...currentInfo,
-        name: {
-          first: firstName || currentInfo?.name?.first || '',
-          last: lastName || currentInfo?.name?.last || '',
-        },
-      };
-      console.log(`[DEBUG] Names update object built:`, JSON.stringify(result, null, 2));
-      return result;
-    },
-    'update contact names'
-  );
-}
-
-/**
- * Update fields if they have changed - DEBUG VERSION
- * @param {Array} existingValues - Current values for comparison
- * @param {Array} newValues - New values to compare against
- * @param {Function} updater - Function to call if values changed
- * @param {Function} argsBuilder - Function to build arguments for updater
- */
-const updateIfChanged = (existingValues, newValues, updater, argsBuilder) => {
-  console.log(`[DEBUG] updateIfChanged called`);
-  console.log(`[DEBUG] existingValues:`, JSON.stringify(existingValues));
-  console.log(`[DEBUG] newValues:`, JSON.stringify(newValues));
-
-  const hasChanged = existingValues.some((val, idx) => {
-    const changed = val !== newValues[idx];
-    if (changed) {
-      console.log(`[DEBUG] Value changed at index ${idx}: "${val}" -> "${newValues[idx]}"`);
-    }
-    return changed;
-  });
-
-  console.log(`[DEBUG] hasChanged:`, hasChanged);
-
-  if (!hasChanged) {
-    console.log(`[DEBUG] No changes detected, skipping update`);
-    return null;
-  }
-
-  console.log(`[DEBUG] Changes detected, calling updater with args:`, argsBuilder(newValues));
-  return updater(...argsBuilder(newValues));
-};
-
-/**
- * Updates member contact information in CRM if fields have changed - DEBUG VERSION
- * @param {Object} data - New member data
- * @param {Object} existingMemberData - Existing member data
- */
-const updateMemberContactInfo = async (data, existingMemberData) => {
-  console.log(`[DEBUG] ========================================`);
-  console.log(`[DEBUG] updateMemberContactInfo called`);
-  console.log(`[DEBUG] data:`, JSON.stringify(data, null, 2));
-  console.log(`[DEBUG] existingMemberData:`, JSON.stringify(existingMemberData, null, 2));
-  console.log(`[DEBUG] ========================================`);
-
-  const { contactId } = existingMemberData;
-  console.log(`[DEBUG] Extracted contactId:`, contactId);
-
-  if (!contactId) {
-    console.error(`[DEBUG] ERROR: contactId is missing from existingMemberData`);
-    throw new Error('contactId is required in existingMemberData');
-  }
-
-  const updateConfig = [
-    {
-      fields: ['contactFormEmail'],
-      updater: updateContactEmail,
-      args: ([email]) => [contactId, email],
-    },
-    {
-      fields: ['firstName', 'lastName'],
-      updater: updateContactNames,
-      args: ([firstName, lastName]) => [contactId, firstName, lastName],
-    },
-  ];
-
-  console.log(`[DEBUG] Processing update config...`);
-
-  const updatePromises = updateConfig
-    .map(({ fields, updater, args }, index) => {
-      console.log(`[DEBUG] Config ${index}: fields=${JSON.stringify(fields)}`);
-      const existingValues = fields.map(field => {
-        const value = existingMemberData[field];
-        console.log(`[DEBUG]   Existing ${field}:`, value);
-        return value;
-      });
-      const newValues = fields.map(field => {
-        const value = data[field];
-        console.log(`[DEBUG]   New ${field}:`, value);
-        return value;
-      });
-      return updateIfChanged(existingValues, newValues, updater, args);
-    })
-    .filter(Boolean);
-
-  console.log(`[DEBUG] Number of updates to perform:`, updatePromises.length);
-
-  if (updatePromises.length === 0) {
-    console.log(`[DEBUG] No updates needed, returning early`);
-    return;
-  }
-
-  console.log(`[DEBUG] Executing ${updatePromises.length} update(s) in parallel...`);
-
-  try {
-    const results = await Promise.all(updatePromises);
-    console.log(`[DEBUG] All updates completed successfully`);
-    console.log(`[DEBUG] Results:`, JSON.stringify(results, null, 2));
-    console.log(`[DEBUG] ========================================`);
-  } catch (error) {
-    console.error(`[DEBUG] ❌ Error in Promise.all:`, error);
-    console.error(`[DEBUG] Error details:`, JSON.stringify(error, null, 2));
-    throw error;
-  }
-};
-
-module.exports = {
-  updateMemberContactInfo,
-  updateContactEmail, // Export for individual testing
-  updateContactNames, // Export for individual testing
-};

package/backend/contacts-methods-TEST.js

@@ -1,271 +0,0 @@
-const { contacts } = require('@wix/crm');
-const { auth } = require('@wix/essentials');
-
-/**
- * TEST FILE - Multiple approaches to debug contact email updates
- *
- * This file contains different implementations to test and compare
- */
-
-// ============================================================================
-// APPROACH 1: Current implementation (from npm package)
-// ============================================================================
-const elevatedGetContact_v1 = auth.elevate(contacts.getContact);
-const elevatedUpdateContact_v1 = auth.elevate(contacts.updateContact);
-
-async function updateContactEmail_v1(contactId, newEmail) {
-  console.log(`[TEST V1] Starting - contactId: ${contactId}, email: ${newEmail}`);
-
-  const contact = await elevatedGetContact_v1(contactId);
-  console.log(`[TEST V1] Fetched contact:`, contact);
-
-  const updatedInfo = {
-    ...contact.info,
-    emails: {
-      items: [{ email: newEmail, primary: true }],
-    },
-  };
-  console.log(`[TEST V1] Calling updateContact with:`, {
-    contactId,
-    payload: { info: updatedInfo },
-    revision: contact.revision,
-  });
-
-  const result = await elevatedUpdateContact_v1(contactId, { info: updatedInfo }, contact.revision);
-  console.log(`[TEST V1] Result:`, result);
-  return result;
-}
-
-// ============================================================================
-// APPROACH 2: Old working implementation style
-// ============================================================================
-async function updateContactEmail_v2(contactId, newEmail) {
-  console.log(`[TEST V2] Starting - contactId: ${contactId}, email: ${newEmail}`);
-
-  // Create elevated functions inside the function (like old code)
-  const elevatedGetContact = auth.elevate(contacts.getContact);
-  const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-  const contact = await elevatedGetContact(contactId);
-  console.log(`[TEST V2] Fetched contact:`, contact);
-
-  const updatedInfo = {
-    ...contact.info,
-    emails: {
-      items: [{ email: newEmail, primary: true }],
-    },
-  };
-  console.log(`[TEST V2] Calling updateContact with updatedInfo directly (old style):`, {
-    contactId,
-    payload: updatedInfo,
-    revision: contact.revision,
-  });
-
-  // Try passing updatedInfo directly (old style)
-  const result = await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
-  console.log(`[TEST V2] Result:`, result);
-  return result;
-}
-
-// ============================================================================
-// APPROACH 3: Minimal update (only changed fields)
-// ============================================================================
-async function updateContactEmail_v3(contactId, newEmail) {
-  console.log(`[TEST V3] Starting - contactId: ${contactId}, email: ${newEmail}`);
-
-  const elevatedGetContact = auth.elevate(contacts.getContact);
-  const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-  const contact = await elevatedGetContact(contactId);
-  console.log(`[TEST V3] Fetched contact:`, contact);
-
-  // Only send the fields being updated (minimal approach)
-  const updatePayload = {
-    info: {
-      emails: {
-        items: [{ email: newEmail, primary: true }],
-      },
-    },
-  };
-  console.log(`[TEST V3] Calling updateContact with minimal payload:`, {
-    contactId,
-    payload: updatePayload,
-    revision: contact.revision,
-  });
-
-  const result = await elevatedUpdateContact(contactId, updatePayload, contact.revision);
-  console.log(`[TEST V3] Result:`, result);
-  return result;
-}
-
-// ============================================================================
-// APPROACH 4: Using revision in options object
-// ============================================================================
-async function updateContactEmail_v4(contactId, newEmail) {
-  console.log(`[TEST V4] Starting - contactId: ${contactId}, email: ${newEmail}`);
-
-  const elevatedGetContact = auth.elevate(contacts.getContact);
-  const elevatedUpdateContact = auth.elevate(contacts.updateContact);
-
-  const contact = await elevatedGetContact(contactId);
-  console.log(`[TEST V4] Fetched contact:`, contact);
-
-  const updatedInfo = {
-    ...contact.info,
-    emails: {
-      items: [{ email: newEmail, primary: true }],
-    },
-  };
-  console.log(`[TEST V4] Calling updateContact with revision in options:`, {
-    contactId,
-    payload: { info: updatedInfo },
-    options: { revision: contact.revision },
-  });
-
-  // Try passing revision as part of an options object
-  const result = await elevatedUpdateContact(
-    contactId,
-    { info: updatedInfo },
-    { revision: contact.revision }
-  );
-  console.log(`[TEST V4] Result:`, result);
-  return result;
-}
-
-// ============================================================================
-// APPROACH 5: Check if elevation is working at all
-// ============================================================================
-async function testElevation(contactId) {
-  console.log(`[TEST ELEVATION] Testing if elevation works at all...`);
-  console.log(`[TEST ELEVATION] contactId:`, contactId);
-
-  try {
-    // Test 1: Non-elevated getContact (should fail if user doesn't have permission)
-    console.log(`[TEST ELEVATION] Test 1: Non-elevated getContact`);
-    try {
-      const nonElevatedResult = await contacts.getContact(contactId);
-      console.log(
-        `[TEST ELEVATION] ❓ Non-elevated getContact succeeded (unexpected?):`,
-        nonElevatedResult
-      );
-    } catch (error) {
-      console.log(`[TEST ELEVATION] ✓ Non-elevated getContact failed as expected:`, error.message);
-    }
-
-    // Test 2: Elevated getContact (should succeed)
-    console.log(`[TEST ELEVATION] Test 2: Elevated getContact (module-level)`);
-    const elevatedResult = await elevatedGetContact_v1(contactId);
-    console.log(`[TEST ELEVATION] ✓ Elevated getContact succeeded:`, elevatedResult);
-
-    // Test 3: Elevated getContact (function-level)
-    console.log(`[TEST ELEVATION] Test 3: Elevated getContact (function-level)`);
-    const elevatedGetContactLocal = auth.elevate(contacts.getContact);
-    const elevatedResultLocal = await elevatedGetContactLocal(contactId);
-    console.log(`[TEST ELEVATION] ✓ Elevated getContact (local) succeeded:`, elevatedResultLocal);
-
-    return { success: true };
-  } catch (error) {
-    console.error(`[TEST ELEVATION] ❌ Error during elevation test:`, error);
-    return { success: false, error };
-  }
-}
-
-// ============================================================================
-// Test runner
-// ============================================================================
-async function runAllTests(contactId, newEmail) {
-  console.log(`\n${'='.repeat(80)}`);
-  console.log(`STARTING CONTACT EMAIL UPDATE TESTS`);
-  console.log(`Contact ID: ${contactId}`);
-  console.log(`New Email: ${newEmail}`);
-  console.log(`${'='.repeat(80)}\n`);
-
-  const results = {
-    elevation: null,
-    v1: null,
-    v2: null,
-    v3: null,
-    v4: null,
-  };
-
-  // Test elevation first
-  console.log(`\n${'='.repeat(80)}`);
-  console.log(`TEST: Elevation Check`);
-  console.log(`${'='.repeat(80)}`);
-  try {
-    results.elevation = await testElevation(contactId);
-    console.log(`✓ Elevation test completed`);
-  } catch (error) {
-    console.error(`✗ Elevation test failed:`, error);
-    results.elevation = { success: false, error: error.message };
-  }
-
-  // Only run update tests if elevation works
-  if (results.elevation?.success) {
-    // Test V1: Current implementation
-    console.log(`\n${'='.repeat(80)}`);
-    console.log(`TEST V1: Current Implementation (wrapped in { info: })`);
-    console.log(`${'='.repeat(80)}`);
-    try {
-      results.v1 = await updateContactEmail_v1(contactId, newEmail);
-      console.log(`✓ V1 completed successfully`);
-    } catch (error) {
-      console.error(`✗ V1 failed:`, error);
-      results.v1 = { error: error.message };
-    }
-
-    // Test V2: Old style
-    console.log(`\n${'='.repeat(80)}`);
-    console.log(`TEST V2: Old Style (direct info object)`);
-    console.log(`${'='.repeat(80)}`);
-    try {
-      results.v2 = await updateContactEmail_v2(contactId, newEmail);
-      console.log(`✓ V2 completed successfully`);
-    } catch (error) {
-      console.error(`✗ V2 failed:`, error);
-      results.v2 = { error: error.message };
-    }
-
-    // Test V3: Minimal payload
-    console.log(`\n${'='.repeat(80)}`);
-    console.log(`TEST V3: Minimal Payload`);
-    console.log(`${'='.repeat(80)}`);
-    try {
-      results.v3 = await updateContactEmail_v3(contactId, newEmail);
-      console.log(`✓ V3 completed successfully`);
-    } catch (error) {
-      console.error(`✗ V3 failed:`, error);
-      results.v3 = { error: error.message };
-    }
-
-    // Test V4: Revision in options
-    console.log(`\n${'='.repeat(80)}`);
-    console.log(`TEST V4: Revision in Options Object`);
-    console.log(`${'='.repeat(80)}`);
-    try {
-      results.v4 = await updateContactEmail_v4(contactId, newEmail);
-      console.log(`✓ V4 completed successfully`);
-    } catch (error) {
-      console.error(`✗ V4 failed:`, error);
-      results.v4 = { error: error.message };
-    }
-  }
-
-  // Summary
-  console.log(`\n${'='.repeat(80)}`);
-  console.log(`TEST RESULTS SUMMARY`);
-  console.log(`${'='.repeat(80)}`);
-  console.log(JSON.stringify(results, null, 2));
-  console.log(`${'='.repeat(80)}\n`);
-
-  return results;
-}
-
-module.exports = {
-  updateContactEmail_v1,
-  updateContactEmail_v2,
-  updateContactEmail_v3,
-  updateContactEmail_v4,
-  testElevation,
-  runAllTests,
-};

package/backend/test-methods.js

@@ -1,118 +0,0 @@
-/**
- * DEBUG WEB METHOD
- *
- * Instructions for use:
- *
- * 1. Import this in your host site's web-methods.web.js:
- *    import { runContactUpdateTests, testContactElevation } from 'abmp-npm/backend/test-methods';
- *    import { Permissions, webMethod } from 'wix-web-module';
- *
- *    export const runContactUpdateTests = webMethod(Permissions.SiteMember, _runContactUpdateTests);
- *    export const testContactElevation = webMethod(Permissions.SiteMember, _testContactElevation);
- *
- * 2. Call from frontend console or page code:
- *    import { runContactUpdateTests } from 'backend/web-methods.web';
- *
- *    // Get your contactId from your member data
- *    const results = await runContactUpdateTests('YOUR_CONTACT_ID', 'newemail@test.com');
- *    console.log('Test results:', results);
- *
- * 3. Check the Wix logs (Site Monitoring) for detailed output
- */
-
-const { updateMemberContactInfo } = require('./contacts-methods-DEBUG');
-const { runAllTests, testElevation } = require('./contacts-methods-TEST');
-
-/**
- * Run all contact update test variations
- */
-async function runContactUpdateTests(contactId, newEmail) {
-  console.log(`[TEST RUNNER] Starting tests for contactId: ${contactId}, email: ${newEmail}`);
-
-  if (!contactId) {
-    throw new Error('contactId is required');
-  }
-
-  if (!newEmail) {
-    throw new Error('newEmail is required');
-  }
-
-  try {
-    const results = await runAllTests(contactId, newEmail);
-    return {
-      success: true,
-      message: 'Tests completed - check logs for details',
-      results,
-    };
-  } catch (error) {
-    console.error(`[TEST RUNNER] Error:`, error);
-    return {
-      success: false,
-      error: error.message,
-      stack: error.stack,
-    };
-  }
-}
-
-/**
- * Test if elevation is working correctly
- */
-async function testContactElevation(contactId) {
-  console.log(`[TEST RUNNER] Testing elevation for contactId: ${contactId}`);
-
-  if (!contactId) {
-    throw new Error('contactId is required');
-  }
-
-  try {
-    const results = await testElevation(contactId);
-    return {
-      success: true,
-      message: 'Elevation test completed - check logs for details',
-      results,
-    };
-  } catch (error) {
-    console.error(`[TEST RUNNER] Error:`, error);
-    return {
-      success: false,
-      error: error.message,
-      stack: error.stack,
-    };
-  }
-}
-
-/**
- * Test the debug version of updateMemberContactInfo
- */
-async function testUpdateMemberContactInfo(data, existingMemberData) {
-  console.log(`[TEST RUNNER] Testing updateMemberContactInfo with DEBUG logging`);
-
-  if (!data) {
-    throw new Error('data is required');
-  }
-
-  if (!existingMemberData) {
-    throw new Error('existingMemberData is required');
-  }
-
-  try {
-    await updateMemberContactInfo(data, existingMemberData);
-    return {
-      success: true,
-      message: 'updateMemberContactInfo completed - check logs for details',
-    };
-  } catch (error) {
-    console.error(`[TEST RUNNER] Error:`, error);
-    return {
-      success: false,
-      error: error.message,
-      stack: error.stack,
-    };
-  }
-}
-
-module.exports = {
-  runContactUpdateTests,
-  testContactElevation,
-  testUpdateMemberContactInfo,
-};