abmp-npm 1.9.6 → 1.9.7

package/CONTACT_EMAIL_UPDATE_DEBUG.md

@@ -0,0 +1,313 @@
+# Contact Email Update Investigation Guide
+
+## Problem Description
+
+Contact email updates in Wix CRM are not working after migration to npm package:
+
+- ✅ Members data in Wix DB updates correctly
+- ❌ Contact email in Wix CRM does not update
+- ❌ No errors appear in logs
+- ✅ Old implementation (before npm) works fine
+
+## Key Differences Found
+
+### OLD Implementation (Working)
+
+```javascript
+// From: src/backend/api.web.js (before npm migration)
+import { contacts } from 'wix-crm.v2'; // ← Old package
+import { elevate } from 'wix-auth'; // ← Old import style
+
+// Elevated functions created INSIDE the function
+async function updateContactInfo(contactId, updateInfoCallback, operationName) {
+  const elevatedGetContact = elevate(contacts.getContact);
+  const elevatedUpdateContact = elevate(contacts.updateContact);
+
+  const currentContact = await elevatedGetContact(contactId);
+  const updatedInfo = updateInfoCallback(currentContact.info);
+
+  // Passes updatedInfo DIRECTLY (not wrapped)
+  const result = await elevatedUpdateContact(
+    contactId,
+    updatedInfo, // ← Direct info object
+    currentContact.revision
+  );
+  return result;
+}
+```
+
+### NEW Implementation (Not Working)
+
+```javascript
+// From: abmp-npm/backend/contacts-methods.js
+const { contacts } = require('@wix/crm'); // ← New package
+const { auth } = require('@wix/essentials'); // ← New import style
+
+// Elevated functions created at MODULE LEVEL
+const elevatedGetContact = auth.elevate(contacts.getContact);
+const elevatedUpdateContact = auth.elevate(contacts.updateContact);
+
+async function updateContactInfo(contactId, updateInfoCallback, operationName) {
+  const contact = await elevatedGetContact(contactId);
+  const updatedInfo = updateInfoCallback(contact.info);
+
+  // Wraps updatedInfo in { info: }
+  await elevatedUpdateContact(
+    contactId,
+    { info: updatedInfo }, // ← Wrapped in { info: }
+    contact.revision
+  );
+}
+```
+
+## Potential Issues
+
+### 1. Package Change: `wix-crm.v2` → `@wix/crm`
+
+The API signature might have changed between these packages:
+
+- **Old**: `updateContact(contactId, infoObject, revision)`
+- **New**: `updateContact(contactId, { info: infoObject }, revision)` or `updateContact(contactId, contactObject, { revision })`
+
+### 2. Elevation Scope
+
+- **Old**: Functions elevated inside the function (per-call elevation)
+- **New**: Functions elevated at module level (shared elevation)
+
+This could cause issues with permissions or context.
+
+### 3. Silent Failures
+
+If the CRM update throws an error but it's being caught and not logged, it would appear to work but not actually update.
+
+## Investigation Steps
+
+I've created three debugging files for you:
+
+### File 1: `contacts-methods-DEBUG.js`
+
+This is your current implementation with extensive logging. It will show:
+
+- Every step of the update process
+- All data being passed
+- Any errors (even if they're being caught)
+- Success confirmations
+
+### File 2: `contacts-methods-TEST.js`
+
+This contains 4 different implementations to test:
+
+- **V1**: Current style (wrapped in `{ info: }`)
+- **V2**: Old style (direct info object)
+- **V3**: Minimal payload (only changed fields)
+- **V4**: Revision in options object
+- **Elevation Test**: Checks if elevation is working at all
+
+### File 3: `test-methods.js`
+
+Web method wrappers you can call from the frontend to run the tests.
+
+## How to Use
+
+### Step 1: Update Backend Index
+
+Add the test methods to your npm package exports:
+
+```javascript
+// In abmp-npm/backend/index.js
+module.exports = {
+  ...require('./forms-methods'),
+  ...require('./search-filters-methods'),
+  ...require('./jobs'),
+  ...require('./utils'),
+  ...require('./daily-pull'),
+  ...require('./pac-api-methods'),
+  ...require('./members-area-methods'),
+  ...require('./members-data-methods'),
+  ...require('./cms-data-methods'),
+  ...require('./routers-methods'),
+  ...require('./test-methods'), // ← Add this
+};
+```
+
+### Step 2: Expose in Host Site
+
+Add these web methods to your host site:
+
+```javascript
+// In abmp/src/backend/web-methods.web.js
+import { Permissions, webMethod } from 'wix-web-module';
+import {
+  // ... existing imports
+  runContactUpdateTests as _runContactUpdateTests,
+  testContactElevation as _testContactElevation,
+  testUpdateMemberContactInfo as _testUpdateMemberContactInfo,
+} from 'abmp-npm/backend';
+
+// ... existing exports
+
+export const runContactUpdateTests = webMethod(Permissions.SiteMember, _runContactUpdateTests);
+
+export const testContactElevation = webMethod(Permissions.SiteMember, _testContactElevation);
+
+export const testUpdateMemberContactInfo = webMethod(
+  Permissions.SiteMember,
+  _testUpdateMemberContactInfo
+);
+```
+
+### Step 3: Run Tests from Frontend
+
+Option A - Test all variations:
+
+```javascript
+import { runContactUpdateTests } from 'backend/web-methods.web';
+import wixData from 'wix-data';
+
+// Get your member data (you need the contactId)
+const memberData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
+const contactId = memberData.contactId;
+
+// Run all test variations
+const results = await runContactUpdateTests(contactId, 'newemail@test.com');
+console.log('Test results:', results);
+
+// Check Wix Site Monitoring logs for detailed output
+```
+
+Option B - Test elevation only:
+
+```javascript
+import { testContactElevation } from 'backend/web-methods.web';
+
+const results = await testContactElevation(contactId);
+console.log('Elevation test results:', results);
+```
+
+Option C - Test with DEBUG logging (using your actual saveRegistrationData flow):
+
+```javascript
+import { testUpdateMemberContactInfo } from 'backend/web-methods.web';
+import wixData from 'wix-data';
+
+// Get existing member data
+const existingData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
+
+// Create update data (as it would come from your form)
+const updateData = {
+  ...existingData,
+  contactFormEmail: 'newemail@test.com', // Change the email
+  firstName: existingData.firstName,
+  lastName: existingData.lastName,
+};
+
+// Test with DEBUG logging
+const results = await testUpdateMemberContactInfo(updateData, existingData);
+console.log('Debug test results:', results);
+
+// Check Wix Site Monitoring logs for extensive output
+```
+
+### Step 4: Check Logs
+
+Go to your Wix Site Monitoring (Logs) and look for entries starting with:
+
+- `[DEBUG]` - From the debug version
+- `[TEST V1]`, `[TEST V2]`, etc. - From different test implementations
+- `[TEST ELEVATION]` - From elevation tests
+- `[TEST RUNNER]` - From the test runner
+
+## What to Look For
+
+### 1. Elevation Issues
+
+If you see errors like:
+
+- "Insufficient permissions"
+- "Unauthorized"
+- "Forbidden"
+
+Then elevation is not working correctly.
+
+### 2. API Signature Issues
+
+If you see errors like:
+
+- "Invalid parameter"
+- "Expected object of type Contact"
+- "Unexpected argument"
+
+Then the API signature has changed between packages.
+
+### 3. Silent Success
+
+If all tests show "success" but the email still doesn't update in CRM:
+
+- Check if the contact actually exists in CRM
+- Check if there are any CRM automation rules blocking updates
+- Check if the email field is locked/read-only
+
+### 4. Which Version Works
+
+If one of the test versions (V1, V2, V3, V4) works:
+
+- That tells us the correct API signature to use
+- Update the actual `contacts-methods.js` to match the working version
+
+## Quick Fix Hypothesis
+
+Based on the code comparison, my best guess is that the issue is with the API call signature. Try this fix first:
+
+### Option 1: Use Old Style (Direct Info Object)
+
+```javascript
+// In contacts-methods.js, line 23
+// CHANGE FROM:
+await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
+
+// CHANGE TO:
+await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
+```
+
+### Option 2: Move Elevation Inside Function
+
+```javascript
+// In contacts-methods.js
+// CHANGE FROM:
+const elevatedGetContact = auth.elevate(contacts.getContact);
+const elevatedUpdateContact = auth.elevate(contacts.updateContact);
+
+async function updateContactInfo(contactId, updateInfoCallback, operationName) {
+  // ...
+}
+
+// CHANGE TO:
+async function updateContactInfo(contactId, updateInfoCallback, operationName) {
+  const elevatedGetContact = auth.elevate(contacts.getContact);
+  const elevatedUpdateContact = auth.elevate(contacts.updateContact);
+  // ...
+}
+```
+
+## Next Steps
+
+1. ✅ Add test files to npm package (already created)
+2. ⬜ Release new npm version with test methods
+3. ⬜ Install new version in host site
+4. ⬜ Expose test web methods in host site
+5. ⬜ Run tests from frontend
+6. ⬜ Check logs to see which version works
+7. ⬜ Apply the working solution to the actual code
+8. ⬜ Remove test files and release final version
+
+## Need More Help?
+
+If the tests don't reveal the issue, we can:
+
+1. Add even more detailed logging
+2. Test with the actual Wix CRM dashboard to verify the contact exists
+3. Check if there are any CRM automation rules or webhooks interfering
+4. Test with a different contact to rule out data-specific issues
+5. Compare the exact bytes being sent in the old vs new implementation
+
+Let me know what the test results show!

package/DEBUG_QUICKSTART.md

@@ -0,0 +1,133 @@
+# Contact Email Update Investigation - Quick Start
+
+## 🔍 Problem Summary
+
+After migrating to npm package, contact email updates fail silently:
+
+- ✅ Wix DB updates work
+- ❌ CRM contact email doesn't update
+- ❌ No errors in logs
+
+## 🎯 Key Finding
+
+The old code used `wix-crm.v2` while the new code uses `@wix/crm`. These have **different API signatures**!
+
+**Old (Working)**:
+
+```javascript
+elevatedUpdateContact(contactId, infoObject, revision);
+```
+
+**New (Not Working?)**:
+
+```javascript
+elevatedUpdateContact(contactId, { info: infoObject }, revision);
+```
+
+## 🚀 Quick Steps to Investigate
+
+### 1. I've created 4 files for you:
+
+- ✅ `contacts-methods-DEBUG.js` - Your code with extensive logging
+- ✅ `contacts-methods-TEST.js` - 4 different API call variations
+- ✅ `test-methods.js` - Web methods to run tests
+- ✅ `CONTACT_EMAIL_UPDATE_DEBUG.md` - Full documentation
+
+### 2. Release this version to test:
+
+The test methods are already exported in `backend/index.js`.
+You just need to:
+
+1. Release new npm version
+2. Expose test methods in host site `web-methods.web.js`
+3. Run tests from frontend
+4. Check logs to see which variation works
+
+### 3. Expose test methods in host site:
+
+Add to `abmp/src/backend/web-methods.web.js`:
+
+```javascript
+import {
+  // ... your existing imports
+  runContactUpdateTests as _runContactUpdateTests,
+  testContactElevation as _testContactElevation,
+  testUpdateMemberContactInfo as _testUpdateMemberContactInfo,
+} from 'abmp-npm/backend';
+
+// ... existing exports
+
+export const runContactUpdateTests = webMethod(Permissions.SiteMember, _runContactUpdateTests);
+
+export const testContactElevation = webMethod(Permissions.SiteMember, _testContactElevation);
+
+export const testUpdateMemberContactInfo = webMethod(
+  Permissions.SiteMember,
+  _testUpdateMemberContactInfo
+);
+```
+
+### 4. Run tests from frontend:
+
+```javascript
+import { runContactUpdateTests } from 'backend/web-methods.web';
+import wixData from 'wix-data';
+
+// Get your contact ID from member data
+const memberData = await wixData.get('Members/PrivateMembersData', 'YOUR_MEMBER_ID');
+
+// Run all test variations
+const results = await runContactUpdateTests(memberData.contactId, 'test@newemail.com');
+
+console.log('Results:', results);
+// Then check Wix Site Monitoring logs for detailed output
+```
+
+### 5. Check which test works:
+
+In Wix Site Monitoring, look for:
+
+- ✅ `[TEST V1]` - Current implementation
+- ✅ `[TEST V2]` - Old style (direct info object) ← **Most likely to work**
+- ✅ `[TEST V3]` - Minimal payload
+- ✅ `[TEST V4]` - Revision in options
+
+### 6. Apply the fix:
+
+Once you know which version works, update `contacts-methods.js` to match that signature.
+
+## 🔧 Most Likely Fix
+
+Based on the code comparison, try this first:
+
+### Change line 23 in `contacts-methods.js`:
+
+**FROM:**
+
+```javascript
+await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
+```
+
+**TO:**
+
+```javascript
+await elevatedUpdateContact(contactId, updatedInfo, contact.revision);
+```
+
+This matches the old working implementation and might be the correct signature for the new package.
+
+## 📖 Full Documentation
+
+See `CONTACT_EMAIL_UPDATE_DEBUG.md` for complete details, analysis, and troubleshooting steps.
+
+## ✅ What's Already Done
+
+- ✅ Debugging files created
+- ✅ Test variations created
+- ✅ Test methods exported
+- ⬜ Release new npm version
+- ⬜ Expose in host site
+- ⬜ Run tests
+- ⬜ Apply fix
+
+Let me know what the tests reveal!

package/backend/consts.js

@@ -1,6 +1,5 @@
 const PAC_API_URL = 'https://members.abmp.com/eweb/api/Wix';
 const SSO_TOKEN_AUTH_API_URL = 'https://members.professionalassistcorp.com/';
-const SSO_TOKEN_AUTH_API_KEY = 'testkey';
 
 /**
  * Valid configuration keys for getSiteConfigs function
@@ -41,5 +40,4 @@ module.exports = {
   COMPILED_FILTERS_FIELDS,
   MEMBERSHIPS_TYPES,
   SSO_TOKEN_AUTH_API_URL,
-  SSO_TOKEN_AUTH_API_KEY,
 };

package/backend/contacts-methods-DEBUG.js

@@ -0,0 +1,237 @@
+const { contacts } = require('@wix/crm');
+const { auth } = require('@wix/essentials');
+
+/**
+ * DEBUG VERSION with extensive logging
+ * This file helps investigate why contact email updates aren't working
+ */
+
+const elevatedGetContact = auth.elevate(contacts.getContact);
+const elevatedUpdateContact = auth.elevate(contacts.updateContact);
+
+/**
+ * Generic contact update helper function - DEBUG VERSION
+ * @param {string} contactId - The contact ID in Wix CRM
+ * @param {function} updateInfoCallback - Function that returns the updated info object
+ * @param {string} operationName - Name of the operation for logging
+ */
+async function updateContactInfo(contactId, updateInfoCallback, operationName) {
+  console.log(`[DEBUG] Starting ${operationName}`);
+  console.log(`[DEBUG] contactId:`, contactId);
+
+  if (!contactId) {
+    console.error(`[DEBUG] ERROR: Contact ID is missing`);
+    throw new Error('Contact ID is required');
+  }
+
+  try {
+    console.log(`[DEBUG] Attempting to fetch contact...`);
+    const contact = await elevatedGetContact(contactId);
+    console.log(`[DEBUG] Contact fetched successfully:`, JSON.stringify(contact, null, 2));
+
+    const currentInfo = contact.info;
+    console.log(`[DEBUG] Current contact info:`, JSON.stringify(currentInfo, null, 2));
+
+    const updatedInfo = updateInfoCallback(currentInfo);
+    console.log(`[DEBUG] Updated info to send:`, JSON.stringify(updatedInfo, null, 2));
+
+    console.log(`[DEBUG] Contact revision:`, contact.revision);
+    console.log(`[DEBUG] Attempting to update contact...`);
+
+    // Try the new way (wrapping in { info: })
+    const result = await elevatedUpdateContact(contactId, { info: updatedInfo }, contact.revision);
+    console.log(`[DEBUG] Update result:`, JSON.stringify(result, null, 2));
+
+    console.log(`[DEBUG] ✅ ${operationName} completed successfully`);
+    return result;
+  } catch (error) {
+    console.error(`[DEBUG] ❌ Error in ${operationName}:`, error);
+    console.error(`[DEBUG] Error name:`, error.name);
+    console.error(`[DEBUG] Error message:`, error.message);
+    console.error(`[DEBUG] Error stack:`, error.stack);
+    console.error(`[DEBUG] Full error object:`, JSON.stringify(error, null, 2));
+    throw new Error(`Failed to ${operationName}: ${error.message}`);
+  }
+}
+
+/**
+ * Updates contact email in Wix CRM - DEBUG VERSION
+ * @param {string} contactId - The contact ID in Wix CRM
+ * @param {string} newEmail - The new email address
+ */
+async function updateContactEmail(contactId, newEmail) {
+  console.log(`[DEBUG] updateContactEmail called`);
+  console.log(`[DEBUG] contactId:`, contactId);
+  console.log(`[DEBUG] newEmail:`, newEmail);
+
+  if (!newEmail) {
+    console.error(`[DEBUG] ERROR: New email is missing`);
+    throw new Error('New email is required');
+  }
+
+  return await updateContactInfo(
+    contactId,
+    currentInfo => {
+      console.log(`[DEBUG] Building email update object...`);
+      const result = {
+        ...currentInfo,
+        emails: {
+          items: [
+            {
+              email: newEmail,
+              primary: true,
+            },
+          ],
+        },
+      };
+      console.log(`[DEBUG] Email update object built:`, JSON.stringify(result, null, 2));
+      return result;
+    },
+    'update contact email'
+  );
+}
+
+/**
+ * Updates contact names in Wix CRM - DEBUG VERSION
+ * @param {string} contactId - The contact ID in Wix CRM
+ * @param {string} firstName - The new first name
+ * @param {string} lastName - The new last name
+ */
+async function updateContactNames(contactId, firstName, lastName) {
+  console.log(`[DEBUG] updateContactNames called`);
+  console.log(`[DEBUG] contactId:`, contactId);
+  console.log(`[DEBUG] firstName:`, firstName);
+  console.log(`[DEBUG] lastName:`, lastName);
+
+  if (!firstName && !lastName) {
+    console.error(`[DEBUG] ERROR: Both names are missing`);
+    throw new Error('At least one name field is required');
+  }
+
+  return await updateContactInfo(
+    contactId,
+    currentInfo => {
+      console.log(`[DEBUG] Building names update object...`);
+      const result = {
+        ...currentInfo,
+        name: {
+          first: firstName || currentInfo?.name?.first || '',
+          last: lastName || currentInfo?.name?.last || '',
+        },
+      };
+      console.log(`[DEBUG] Names update object built:`, JSON.stringify(result, null, 2));
+      return result;
+    },
+    'update contact names'
+  );
+}
+
+/**
+ * Update fields if they have changed - DEBUG VERSION
+ * @param {Array} existingValues - Current values for comparison
+ * @param {Array} newValues - New values to compare against
+ * @param {Function} updater - Function to call if values changed
+ * @param {Function} argsBuilder - Function to build arguments for updater
+ */
+const updateIfChanged = (existingValues, newValues, updater, argsBuilder) => {
+  console.log(`[DEBUG] updateIfChanged called`);
+  console.log(`[DEBUG] existingValues:`, JSON.stringify(existingValues));
+  console.log(`[DEBUG] newValues:`, JSON.stringify(newValues));
+
+  const hasChanged = existingValues.some((val, idx) => {
+    const changed = val !== newValues[idx];
+    if (changed) {
+      console.log(`[DEBUG] Value changed at index ${idx}: "${val}" -> "${newValues[idx]}"`);
+    }
+    return changed;
+  });
+
+  console.log(`[DEBUG] hasChanged:`, hasChanged);
+
+  if (!hasChanged) {
+    console.log(`[DEBUG] No changes detected, skipping update`);
+    return null;
+  }
+
+  console.log(`[DEBUG] Changes detected, calling updater with args:`, argsBuilder(newValues));
+  return updater(...argsBuilder(newValues));
+};
+
+/**
+ * Updates member contact information in CRM if fields have changed - DEBUG VERSION
+ * @param {Object} data - New member data
+ * @param {Object} existingMemberData - Existing member data
+ */
+const updateMemberContactInfo = async (data, existingMemberData) => {
+  console.log(`[DEBUG] ========================================`);
+  console.log(`[DEBUG] updateMemberContactInfo called`);
+  console.log(`[DEBUG] data:`, JSON.stringify(data, null, 2));
+  console.log(`[DEBUG] existingMemberData:`, JSON.stringify(existingMemberData, null, 2));
+  console.log(`[DEBUG] ========================================`);
+
+  const { contactId } = existingMemberData;
+  console.log(`[DEBUG] Extracted contactId:`, contactId);
+
+  if (!contactId) {
+    console.error(`[DEBUG] ERROR: contactId is missing from existingMemberData`);
+    throw new Error('contactId is required in existingMemberData');
+  }
+
+  const updateConfig = [
+    {
+      fields: ['contactFormEmail'],
+      updater: updateContactEmail,
+      args: ([email]) => [contactId, email],
+    },
+    {
+      fields: ['firstName', 'lastName'],
+      updater: updateContactNames,
+      args: ([firstName, lastName]) => [contactId, firstName, lastName],
+    },
+  ];
+
+  console.log(`[DEBUG] Processing update config...`);
+
+  const updatePromises = updateConfig
+    .map(({ fields, updater, args }, index) => {
+      console.log(`[DEBUG] Config ${index}: fields=${JSON.stringify(fields)}`);
+      const existingValues = fields.map(field => {
+        const value = existingMemberData[field];
+        console.log(`[DEBUG]   Existing ${field}:`, value);
+        return value;
+      });
+      const newValues = fields.map(field => {
+        const value = data[field];
+        console.log(`[DEBUG]   New ${field}:`, value);
+        return value;
+      });
+      return updateIfChanged(existingValues, newValues, updater, args);
+    })
+    .filter(Boolean);
+
+  console.log(`[DEBUG] Number of updates to perform:`, updatePromises.length);
+
+  if (updatePromises.length === 0) {
+    console.log(`[DEBUG] No updates needed, returning early`);
+    return;
+  }
+
+  console.log(`[DEBUG] Executing ${updatePromises.length} update(s) in parallel...`);
+
+  try {
+    const results = await Promise.all(updatePromises);
+    console.log(`[DEBUG] All updates completed successfully`);
+    console.log(`[DEBUG] Results:`, JSON.stringify(results, null, 2));
+    console.log(`[DEBUG] ========================================`);
+  } catch (error) {
+    console.error(`[DEBUG] ❌ Error in Promise.all:`, error);
+    console.error(`[DEBUG] Error details:`, JSON.stringify(error, null, 2));
+    throw error;
+  }
+};
+
+module.exports = {
+  updateMemberContactInfo,
+  updateContactEmail, // Export for individual testing
+  updateContactNames, // Export for individual testing
+};