abmp-npm 1.1.97 → 1.1.98

package/backend/members-data-methods.js

@@ -1,4 +1,5 @@
 const { COLLECTIONS } = require('../public/consts');
+const { isWixHostedImage } = require('../public/Utils/sharedUtils');
 
 const { MEMBERSHIPS_TYPES } = require('./consts');
 const { updateMemberContactInfo, createContact } = require('./contacts-methods');
@@ -328,9 +329,9 @@ async function getAllMembersWithExternalImages() {
 
     const allItems = await queryAllItems(membersQuery);
 
-    // Filter for external images (not starting with 'wix:')
+    // Filter for external images (not 'wix hosted images')
     const membersWithExternalImages = allItems.filter(
-      member => member.profileImage && !member.profileImage.startsWith('wix:')
+      member => member.profileImage && !isWixHostedImage(member.profileImage)
     );
 
     return membersWithExternalImages;

package/backend/routers/methods.js

@@ -1,4 +1,5 @@
 const { PAGES_PATHS } = require('../../public/consts');
+const { isWixHostedImage } = require('../../public/Utils/sharedUtils');
 //const { fetchAllItemsInParallel } = require('../cms-data-methods'); unused at host site
 const { CONFIG_KEYS } = require('../consts');
 const { getSiteConfigs } = require('../utils');
@@ -27,7 +28,11 @@ const createRoutersHandlers = wixRouterMethods => {
       const defaultProfileImage = siteConfigs[CONFIG_KEYS.DEFAULT_PROFILE_IMAGE];
       const profileData = await getMemberProfileData(slug, siteAssociation);
       if (profileData && profileData.showWixUrl) {
-        const ogImage = profileData.profileImage || profileData.logoImage || siteLogoUrl;
+        const profileImage =
+          profileData.profileImage?.trim() && isWixHostedImage(profileData.profileImage)
+            ? profileData.profileImage
+            : defaultProfileImage;
+        const ogImage = profileImage || profileData.logoImage || siteLogoUrl;
         const seoTitle = generateSEOTitle({
           fullName: profileData.fullName,
           areasOfPractices: profileData.areasOfPractices,

package/backend/tasks/tasks-helpers-methods.js

@@ -5,6 +5,7 @@ const aws4 = require('aws4');
 const axios = require('axios');
 
 const { PAGES_PATHS } = require('../../public/consts');
+const { isWixHostedImage } = require('../../public/Utils/sharedUtils');
 const { findMemberByWixDataId, updateMember } = require('../members-data-methods');
 const { getSecret, getSiteBaseUrl, encodeXml, formatDateOnly } = require('../utils');
 
@@ -140,11 +141,7 @@ async function updateMemberProfileImage(memberId) {
     const member = await findMemberByWixDataId(memberId);
     const trimmedProfileImage = member.profileImage.trim();
     // Check if member has an external profile image URL
-    if (
-      !trimmedProfileImage ||
-      trimmedProfileImage.startsWith('wix:') ||
-      trimmedProfileImage.startsWith('https://static.wixstatic.com')
-    ) {
+    if (!trimmedProfileImage || isWixHostedImage(trimmedProfileImage)) {
       console.log(`Member ${memberId} already has Wix-hosted image or no image`);
       return { success: true, message: 'No update needed' };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abmp-npm",
-  "version": "1.1.97",
+  "version": "1.1.98",
   "main": "index.js",
   "scripts": {
     "check-cycles": "madge --circular .",

package/pages/Home.js

@@ -9,6 +9,7 @@ const {
   getMainAddress,
   formatPracticeAreasForDisplay,
   checkAddressIsVisible,
+  isWixHostedImage,
 } = require('../public/Utils/sharedUtils.js');
 
 let filter = JSON.parse(JSON.stringify(DEFAULT_FILTER));
@@ -187,7 +188,7 @@ const homePageOnReady = async ({
         : [];
 
       // 2) Profile image
-      if (itemData.profileImage) {
+      if (itemData.profileImage?.trim() && isWixHostedImage(itemData.profileImage)) {
         $item('#profileImage').src = itemData.profileImage;
       }
 

package/pages/Profile.js

@@ -2,7 +2,11 @@ const { location: wixLocation } = require('@wix/site-location');
 const { window: wixWindow } = require('@wix/site-window');
 
 const { LIGHTBOX_NAMES } = require('../public/consts');
-const { generateId, formatPracticeAreasForDisplay } = require('../public/Utils/sharedUtils');
+const {
+  generateId,
+  formatPracticeAreasForDisplay,
+  isWixHostedImage,
+} = require('../public/Utils/sharedUtils');
 
 const TESTIMONIALS_PER_PAGE_CONFIG = {
   DESKTOP: 4,
@@ -117,7 +121,7 @@ async function profileOnReady({ $w: _$w }) {
       _$w('#logoImage').delete();
     }
 
-    if (profileData.profileImage) {
+    if (profileData.profileImage && isWixHostedImage(profileData.profileImage)) {
       _$w('#profileImage').src = profileData.profileImage;
     } else {
       _$w('#profileImage').src = profileData.defaultProfileImage;

package/pages/personalDetails.js

@@ -9,7 +9,7 @@ const {
   LIGHTBOX_NAMES,
 } = require('../public/consts');
 const { handleOnCustomValidation, isNotValidUrl } = require('../public/Utils/personalDetailsUtils');
-const { generateId } = require('../public/Utils/sharedUtils');
+const { generateId, isWixHostedImage } = require('../public/Utils/sharedUtils');
 
 const MAX_PHONES_COUNT = 10;
 const MAX_ADDRESSES_COUNT = 10;
@@ -793,8 +793,14 @@ async function personalDetailsOnReady({
           : null
         : itemMemberObj[key];
 
-      if (imageValue) {
-        _$w(imageSelector).src = imageValue;
+      if (imageValue && imageValue?.trim()) {
+        // Only set profile image if it's Wix-hosted; other images will always be wix url
+        const isProfileImage = imageSelector === '#profileImage';
+        const shouldSetImage = !isProfileImage || isWixHostedImage(imageValue);
+
+        if (shouldSetImage) {
+          _$w(imageSelector).src = imageValue;
+        }
         _$w(nameSelector).text = formatFileName(extractFileName(imageValue));
         _$w(containerSelector).expand();
         uploadedImages[key === 'bannerImages' ? 'bannerImage' : key] = imageValue;

package/public/Utils/sharedUtils.js

@@ -158,6 +158,13 @@ function generateId() {
   return `${Date.now()}-${Math.random().toString(36).substr(2, 9)}`;
 }
 
+function isWixHostedImage(imageUrl) {
+  return (
+    imageUrl?.trim() &&
+    (imageUrl?.startsWith('wix:') || imageUrl?.startsWith('https://static.wixstatic.com'))
+  );
+}
+
 module.exports = {
   checkAddressIsVisible,
   formatPracticeAreasForDisplay,
@@ -169,4 +176,5 @@ module.exports = {
   toRadians,
   generateId,
   formatAddress,
+  isWixHostedImage,
 };