ableton-js 3.2.8 → 3.2.10

package/CHANGELOG.md

@@ -4,8 +4,21 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v3.2.10](https://github.com/leolabs/ableton.js/compare/v3.2.9...v3.2.10)
+
+- :sparkles: Remove the socket after closing it to avoid dangling event listeners trying to send messages after the plugin has been shut down [`54278f2`](https://github.com/leolabs/ableton.js/commit/54278f2b4ccb6efe34592fc108cd10c35e404e58)
+
+#### [v3.2.9](https://github.com/leolabs/ableton.js/compare/v3.2.8...v3.2.9)
+
+> 14 July 2023
+
+- :sparkles: Only send the client port to Live once [`29e9443`](https://github.com/leolabs/ableton.js/commit/29e9443194294f5b55805df909d234b67e52eca2)
+- :sparkles: Send the current client port to Live every time the server port changes [`eb42ce3`](https://github.com/leolabs/ableton.js/commit/eb42ce32f4fa91bd57e4c026a7d29d961afa0a04)
+
 #### [v3.2.8](https://github.com/leolabs/ableton.js/compare/v3.2.7...v3.2.8)
 
+> 14 July 2023
+
 - :wrench: Make fast polling optional, in an attempt to fix flaky behavior in Live 11.3 [`17f1634`](https://github.com/leolabs/ableton.js/commit/17f16342896f5f1989ef7f5147a7b3fce1e924fa)
 
 #### [v3.2.7](https://github.com/leolabs/ableton.js/compare/v3.2.6...v3.2.7)

package/index.js

@@ -120,12 +120,12 @@ class Ableton extends events_1.EventEmitter {
         });
         this.client.bind(undefined, "127.0.0.1");
         // Wait for the server port file to exist
-        await new Promise(async (res) => {
+        const sentPort = await new Promise(async (res) => {
             try {
                 const serverPort = await (0, promises_1.readFile)(this.serverPortFile);
                 this.serverPort = Number(serverPort.toString());
                 this.logger?.info("Server port:", { port: this.serverPort });
-                res();
+                res(false);
             }
             catch (e) {
                 this.logger?.info("Server doesn't seem to be online yet, waiting for it to go online...");
@@ -138,19 +138,33 @@ class Ableton extends events_1.EventEmitter {
                     if (!isNaN(newPort) && newPort !== this.serverPort) {
                         this.logger?.info("Server port changed:", { port: newPort });
                         this.serverPort = Number(serverPort.toString());
+                        if (this.client) {
+                            try {
+                                const port = this.client.address().port;
+                                this.logger?.info("Sending port to Live:", { port });
+                                await this.setProp("internal", "", "client_port", port);
+                                res(true);
+                                return;
+                            }
+                            catch (e) {
+                                this.logger?.info("Sending port to Live failed", { e });
+                            }
+                        }
                     }
-                    res();
+                    res(false);
                 }
             });
         });
         // Send used port to Live in case the plugin is already started
-        try {
-            const port = this.client.address().port;
-            this.logger?.info("Sending port to Live:", { port });
-            await this.setProp("internal", "", "client_port", port);
-        }
-        catch (e) {
-            this.logger?.info("Live doesn't seem to be loaded yet, waiting...");
+        if (!sentPort) {
+            try {
+                const port = this.client.address().port;
+                this.logger?.info("Sending port to Live:", { port });
+                await this.setProp("internal", "", "client_port", port);
+            }
+            catch (e) {
+                this.logger?.info("Live doesn't seem to be loaded yet, waiting...");
+            }
         }
         this.logger?.info("Checking connection...");
         const connection = this.waitForConnection();

package/midi-script/Socket.py

@@ -93,6 +93,7 @@ class Socket(object):
     def shutdown(self):
         self.log_message("Shutting down...")
         self._socket.close()
+        self._socket = None
 
     def init_socket(self, try_stored=False):
         self.log_message(
@@ -150,6 +151,9 @@ class Socket(object):
         # https://stackoverflow.com/questions/22819214/udp-message-too-long
         limit = 7500
 
+        if self._socket == None:
+            return
+
         if len(compressed) < limit:
             self._socket.sendto(b'\xFF' + compressed, self._client_addr)
         else:

package/midi-script/version.py

@@ -1 +1 @@
-version = "3.2.8"
+version = "3.2.10"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ableton-js",
-  "version": "3.2.8",
+  "version": "3.2.10",
   "description": "Control Ableton Live from Node",
   "main": "index.js",
   "author": "Leo Bernard <admin@leolabs.org>",