abcjs 6.2.2 → 6.2.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abcjs",
-  "version": "6.2.2",
+  "version": "6.2.3",
   "description": "Renderer for abc music notation",
   "main": "index.js",
   "types": "types/index.d.ts",

package/src/api/abc_tablatures.js

@@ -84,6 +84,9 @@ var abcTablatures = {
           // plugin.init(tune, tuneNumber, args, ii);
           returned.push(pluginInstance);
           nbPlugins++;
+        } else if (instrument === '') {
+          // create a placeholder - there is no tab for this staff
+          returned.push(null)
         } else {
           // unknown tab plugin 
           //this.emit_error('Undefined tablature plugin: ' + tabName)

package/src/api/abc_tunebook_svg.js

@@ -117,12 +117,12 @@ var renderAbc = function(output, abc, parserParams, engraverParams, renderParams
             div.setAttribute("style", "visibility: hidden;");
             document.body.appendChild(div);
         }
-    	if (params.afterParsing)
-    		params.afterParsing(tune, tuneNumber, abcString);
         if (!removeDiv && params.wrap && params.staffwidth) {
-	        tune = doLineWrapping(div, tune, tuneNumber, abcString, params);
+            tune = doLineWrapping(div, tune, tuneNumber, abcString, params);
 	        return tune;
         }
+        if (params.afterParsing)
+            params.afterParsing(tune, tuneNumber, abcString);
         renderOne(div, tune, params, tuneNumber, 0);
         if (removeDiv)
             div.parentNode.removeChild(div);
@@ -145,6 +145,8 @@ function doLineWrapping(div, tune, tuneNumber, abcString, params) {
         if (warnings)
             tune.warnings = warnings;
     }
+    if (params.afterParsing)
+        params.afterParsing(tune, tuneNumber, abcString);
     renderOne(div, tune, ret.revisedParams, tuneNumber, 0);
 	tune.explanation = ret.explanation;
 	return tune;

package/src/parse/abc_parse_music.js

@@ -9,6 +9,20 @@ var tune;
 var tuneBuilder;
 var header;
 
+var {
+  legalAccents,
+  volumeDecorations,
+  dynamicDecorations,
+  accentPseudonyms,
+  accentDynamicPseudonyms,
+  nonDecorations,
+  durations,
+  pitches,
+  rests,
+  accMap,
+  tripletQ
+} = require('./abc_parse_settings')
+
 var MusicParser = function(_tokenizer, _warn, _multilineVars, _tune, _tuneBuilder, _header) {
 	tokenizer = _tokenizer;
 	warn = _warn;
@@ -76,7 +90,6 @@ var MusicParser = function(_tokenizer, _warn, _multilineVars, _tune, _tuneBuilde
 // double-quote: chord symbol
 // less-than, greater-than, slash: duration
 // back-tick, space, tab: space
-var nonDecorations = "ABCDEFGabcdefgxyzZ[]|^_{";	// use this to prescreen so we don't have to look for a decoration at every note.
 
 var isInTie = function(multilineVars, overlayLevel, el) {
 	if (multilineVars.inTie[overlayLevel] === undefined)
@@ -540,15 +553,8 @@ MusicParser.prototype.parseMusic = function(line) {
 						// Create a warning if this is not a displayable duration.
 						// The first item on a line is a regular note value, each item after that represents a dot placed after the previous note.
 						// Only durations less than a whole note are tested because whole note durations have some tricky rules.
-						var durations = [
-							0.5, 0.75, 0.875, 0.9375, 0.96875, 0.984375,
-							0.25, 0.375, 0.4375, 0.46875, 0.484375, 0.4921875,
-							0.125, 0.1875, 0.21875, 0.234375, 0.2421875, 0.24609375,
-							0.0625, 0.09375, 0.109375, 0.1171875, 0.12109375, 0.123046875,
-							0.03125, 0.046875, 0.0546875, 0.05859375, 0.060546875, 0.0615234375,
-							0.015625, 0.0234375, 0.02734375, 0.029296875, 0.0302734375, 0.03076171875,
-						];
-						if (el.duration < 1 && durations.indexOf(el.duration) === -1 && el.duration !== 0) {
+
+            if (el.duration < 1 && durations.indexOf(el.duration) === -1 && el.duration !== 0) {
 							if (!el.rest || el.rest.type !== 'spacer')
 								warn("Duration not representable: " + line.substring(startI, i), line, i);
 						}
@@ -717,35 +723,8 @@ function durationOfMeasure(multilineVars) {
 	return parseInt(meter.value[0].num, 10) / parseInt(meter.value[0].den, 10);
 }
 
-var legalAccents = [
-	"trill", "lowermordent", "uppermordent", "mordent", "pralltriller", "accent",
-	"fermata", "invertedfermata", "tenuto", "0", "1", "2", "3", "4", "5", "+", "wedge",
-	"open", "thumb", "snap", "turn", "roll", "breath", "shortphrase", "mediumphrase", "longphrase",
-	"segno", "coda", "D.S.", "D.C.", "fine", "beambr1", "beambr2",
-	"slide", "marcato",
-	"upbow", "downbow", "/", "//", "///", "////", "trem1", "trem2", "trem3", "trem4",
-	"turnx", "invertedturn", "invertedturnx", "trill(", "trill)", "arpeggio", "xstem", "mark", "umarcato",
-	"style=normal", "style=harmonic", "style=rhythm", "style=x", "style=triangle", "D.C.alcoda", "D.C.alfine", "D.S.alcoda", "D.S.alfine", "editorial", "courtesy"
-];
-
-var volumeDecorations = [
-	"p", "pp", "f", "ff", "mf", "mp", "ppp", "pppp",  "fff", "ffff", "sfz"
-];
-
-var dynamicDecorations = [
-	"crescendo(", "crescendo)", "diminuendo(", "diminuendo)", "glissando(", "glissando)"
-];
-
-var accentPseudonyms = [
-	["<", "accent"], [">", "accent"], ["tr", "trill"],
-	["plus", "+"], [ "emphasis", "accent"],
-	[ "^", "umarcato" ], [ "marcato", "umarcato" ]
-];
-
-var accentDynamicPseudonyms = [
-	["<(", "crescendo("], ["<)", "crescendo)"],
-	[">(", "diminuendo("], [">)", "diminuendo)"]
-];
+
+
 
 var letter_to_accent = function(line, i) {
 	var macro = multilineVars.macros[line[i]];
@@ -877,17 +856,6 @@ var letter_to_bar = function(line, curr_pos) {
 	return [ret.len+retRep.len, ret.token, retRep.token];
 };
 
-var tripletQ = {
-	2: 3,
-	3: 2,
-	4: 3,
-	5: 2, // TODO-PER: not handling 6/8 rhythm yet
-	6: 2,
-	7: 2, // TODO-PER: not handling 6/8 rhythm yet
-	8: 3,
-	9: 2 // TODO-PER: not handling 6/8 rhythm yet
-};
-
 var letter_to_open_slurs_and_triplets =  function(line, i) {
 	// consume spaces, and look for all the open parens. If there is a number after the open paren,
 	// that is a triplet. Otherwise that is a slur. Collect all the slurs and the first triplet.
@@ -1050,9 +1018,6 @@ var addEndBeam = function(el) {
 	return el;
 };
 
-var pitches = {A: 5, B: 6, C: 0, D: 1, E: 2, F: 3, G: 4, a: 12, b: 13, c: 7, d: 8, e: 9, f: 10, g: 11};
-var rests = {x: 'invisible', X: 'invisible-multimeasure', y: 'spacer', z: 'rest', Z: 'multimeasure' };
-var accMap = { 'dblflat': '__', 'flat': '_', 'natural': '=', 'sharp': '^', 'dblsharp': '^^', 'quarterflat': '_/', 'quartersharp': '^/'};
 var getCoreNote = function(line, index, el, canHaveBrokenRhythm) {
 	//var el = { startChar: index };
 	var isComplete = function(state) {

package/src/parse/abc_parse_settings.js

@@ -0,0 +1,165 @@
+module.exports.legalAccents = [
+  'trill',
+  'lowermordent',
+  'uppermordent',
+  'mordent',
+  'pralltriller',
+  'accent',
+  'fermata',
+  'invertedfermata',
+  'tenuto',
+  '0',
+  '1',
+  '2',
+  '3',
+  '4',
+  '5',
+  '+',
+  'wedge',
+  'open',
+  'thumb',
+  'snap',
+  'turn',
+  'roll',
+  'breath',
+  'shortphrase',
+  'mediumphrase',
+  'longphrase',
+  'segno',
+  'coda',
+  'D.S.',
+  'D.C.',
+  'fine',
+  'beambr1',
+  'beambr2',
+  'slide',
+  'marcato',
+  'upbow',
+  'downbow',
+  '/',
+  '//',
+  '///',
+  '////',
+  'trem1',
+  'trem2',
+  'trem3',
+  'trem4',
+  'turnx',
+  'invertedturn',
+  'invertedturnx',
+  'trill(',
+  'trill)',
+  'arpeggio',
+  'xstem',
+  'mark',
+  'umarcato',
+  'style=normal',
+  'style=harmonic',
+  'style=rhythm',
+  'style=x',
+  'style=triangle',
+  'D.C.alcoda',
+  'D.C.alfine',
+  'D.S.alcoda',
+  'D.S.alfine',
+  'editorial',
+  'courtesy'
+];
+
+module.exports.volumeDecorations = [
+  'p',
+  'pp',
+  'f',
+  'ff',
+  'mf',
+  'mp',
+  'ppp',
+  'pppp',
+  'fff',
+  'ffff',
+  'sfz'
+];
+
+module.exports.dynamicDecorations = [
+  'crescendo(',
+  'crescendo)',
+  'diminuendo(',
+  'diminuendo)',
+  'glissando(',
+  'glissando)',
+  '~(',
+  '~)'
+];
+
+module.exports.accentPseudonyms = [
+  ['<', 'accent'],
+  ['>', 'accent'],
+  ['tr', 'trill'],
+  ['plus', '+'],
+  ['emphasis', 'accent'],
+  ['^', 'umarcato'],
+  ['marcato', 'umarcato']
+];
+
+module.exports.accentDynamicPseudonyms = [
+  ['<(', 'crescendo('],
+  ['<)', 'crescendo)'],
+  ['>(', 'diminuendo('],
+  ['>)', 'diminuendo)']
+];
+
+module.exports.nonDecorations = 'ABCDEFGabcdefgxyzZ[]|^_{'; // use this to prescreen so we don't have to look for a decoration at every note.
+
+module.exports.durations = [
+  0.5, 0.75, 0.875, 0.9375, 0.96875, 0.984375, 0.25, 0.375, 0.4375, 0.46875,
+  0.484375, 0.4921875, 0.125, 0.1875, 0.21875, 0.234375, 0.2421875, 0.24609375,
+  0.0625, 0.09375, 0.109375, 0.1171875, 0.12109375, 0.123046875, 0.03125,
+  0.046875, 0.0546875, 0.05859375, 0.060546875, 0.0615234375, 0.015625,
+  0.0234375, 0.02734375, 0.029296875, 0.0302734375, 0.03076171875
+];
+
+module.exports.pitches = {
+  A: 5,
+  B: 6,
+  C: 0,
+  D: 1,
+  E: 2,
+  F: 3,
+  G: 4,
+  a: 12,
+  b: 13,
+  c: 7,
+  d: 8,
+  e: 9,
+  f: 10,
+  g: 11
+};
+
+module.exports.rests = {
+  x: 'invisible',
+  X: 'invisible-multimeasure',
+  y: 'spacer',
+  z: 'rest',
+  Z: 'multimeasure'
+};
+
+module.exports.accMap = {
+  dblflat: '__',
+  flat: '_',
+  natural: '=',
+  sharp: '^',
+  dblsharp: '^^',
+  quarterflat: '_/',
+  quartersharp: '^/'
+};
+
+module.exports.tripletQ = {
+  2: 3,
+  3: 2,
+  4: 3,
+  5: 2, // TODO-PER: not handling 6/8 rhythm yet
+  6: 2,
+  7: 2, // TODO-PER: not handling 6/8 rhythm yet
+  8: 3,
+  9: 2 // TODO-PER: not handling 6/8 rhythm yet
+};

package/src/synth/create-synth.js

@@ -511,6 +511,10 @@ function CreateSynth() {
 		return self.audioBuffers[0];
 	};
 
+	self.getIsRunning = function() {
+		return self.isRunning;
+	}
+
 	/////////////// Private functions //////////////
 
 	self._deviceCapable = function() {

package/src/synth/place-note.js

@@ -17,6 +17,12 @@ function placeNote(outputAudioBuffer, sampleRate, sound, startArray, volumeMulti
 		len = 0.005; // Have some small audible length no matter how short the note is.
 	var offlineCtx = new OfflineAC(2,Math.floor((len+fadeTimeSec)*sampleRate),sampleRate);
 	var noteName = pitchToNoteName[sound.pitch];
+	if (!soundsCache[sound.instrument]) {
+		// It shouldn't happen that the entire instrument cache wasn't created, but this has been seen in practice, so guard against it.
+		if (debugCallback)
+			debugCallback('placeNote skipped (instrument empty): '+sound.instrument+':'+noteName)
+		return Promise.resolve();
+	}
 	var noteBufferPromise = soundsCache[sound.instrument][noteName];
 
 	if (!noteBufferPromise) {

package/src/synth/play-event.js

@@ -2,7 +2,7 @@ var SynthSequence = require('./synth-sequence');
 var CreateSynth = require('./create-synth');
 var activeAudioContext = require("./active-audio-context");
 
-function playEvent(midiPitches, midiGracePitches, millisecondsPerMeasure) {
+function playEvent(midiPitches, midiGracePitches, millisecondsPerMeasure, soundFontUrl, debugCallback) {
 	var sequence = new SynthSequence();
 
 	for (var i = 0; i < midiPitches.length; i++) {
@@ -21,18 +21,20 @@ function playEvent(midiPitches, midiGracePitches, millisecondsPerMeasure) {
 	var ac = activeAudioContext();
 	if (ac.state === "suspended") {
 		return ac.resume().then(function () {
-			return doPlay(sequence, millisecondsPerMeasure);
+			return doPlay(sequence, millisecondsPerMeasure, soundFontUrl, debugCallback);
 		});
 	} else {
-		return doPlay(sequence, millisecondsPerMeasure);
+		return doPlay(sequence, millisecondsPerMeasure, soundFontUrl, debugCallback);
 	}
 }
 
-function doPlay(sequence, millisecondsPerMeasure) {
+function doPlay(sequence, millisecondsPerMeasure, soundFontUrl, debugCallback) {
 	var buffer = new CreateSynth();
 	return buffer.init({
 		sequence: sequence,
-		millisecondsPerMeasure: millisecondsPerMeasure
+		millisecondsPerMeasure: millisecondsPerMeasure,
+		options: { soundFontUrl: soundFontUrl },
+		debugCallback: debugCallback,
 	}).then(function () {
 		return buffer.prime();
 	}).then(function () {

package/src/tablatures/tab-absolute-elements.js

@@ -177,10 +177,11 @@ TabAbsoluteElements.prototype.build = function (plugin,
   tabVoice,
   voiceIndex,
   staffIndex,
-  keySig ) {
+  keySig,
+  tabVoiceIndex ) {
   var staffSize = getInitialStaffSize(staffAbsolute);
   var source = staffAbsolute[staffIndex+voiceIndex];
-  var dest = staffAbsolute[staffSize+staffIndex+voiceIndex];
+  var dest = staffAbsolute[tabVoiceIndex];
   var tabPos = null;
   var defNote = null;
   if (source.children[0].abcelem.el_type != 'clef') {

package/src/tablatures/tab-renderer.js

@@ -233,10 +233,11 @@ TabRenderer.prototype.doLayout = function () {
     staffGroup.staffs[this.staffIndex].top += nameHeight;
     staffGroup.height += nameHeight * spacing.STEP;
     tabVoice.staff = staffGroupInfos;
+    var tabVoiceIndex = voices.length
     voices.splice(voices.length, 0, tabVoice);
     var keySig = checkVoiceKeySig(voices, ii + this.staffIndex);
     this.tabStaff.voices[ii] = [];
-    this.absolutes.build(this.plugin, voices, this.tabStaff.voices[ii], ii , this.staffIndex ,keySig);
+    this.absolutes.build(this.plugin, voices, this.tabStaff.voices[ii], ii , this.staffIndex ,keySig, tabVoiceIndex);
   }
   linkStaffAndTabs(staffGroup.staffs); // crossreference tabs and staff
 };

package/src/test/abc_parser_lint.js

@@ -51,18 +51,18 @@
 var parseCommon = require('../parse/abc_common');
 var JSONSchema = require('./jsonschema-b4');
 
-var ParserLint = function() {
-	"use strict";
-	var decorationList = { type: 'array', optional: true, items: { type: 'string', Enum: [
-		"trill", "lowermordent", "uppermordent", "mordent", "pralltriller", "accent",
-		"fermata", "invertedfermata", "tenuto", "0", "1", "2", "3", "4", "5", "+", "wedge",
-		"open", "thumb", "snap", "turn", "roll", "irishroll", "breath", "shortphrase", "mediumphrase", "longphrase",
-		"segno", "coda", "D.S.", "D.C.", "fine", "crescendo(", "crescendo)", "diminuendo(", "diminuendo)", "glissando(", "glissando)",
-		"p", "pp", "f", "ff", "mf", "mp", "ppp", "pppp",  "fff", "ffff", "sfz", "repeatbar", "repeatbar2", "slide",
-		"upbow", "downbow", "staccato", "trem1", "trem2", "trem3", "trem4",
-		"/", "//", "///", "////", "turnx", "invertedturn", "invertedturnx", "arpeggio", "trill(", "trill)", "xstem",
-		"mark", "marcato", "umarcato", "D.C.alcoda", "D.C.alfine", "D.S.alcoda", "D.S.alfine", "editorial", "courtesy"
-	] } };
+var { legalAccents } = require('../parse/abc_parse_settings');
+
+var ParserLint = function () {
+  'use strict';
+  var decorationList = {
+    type: 'array',
+    optional: true,
+    items: {
+      type: 'string',
+      Enum: legalAccents
+    }
+  };
 
 	var tempoProperties =  {
 		duration: { type: "array", optional: true, output: "join", requires: [ 'bpm'], items: { type: "number"} },

package/src/write/creation/abstract-engraver.js

@@ -747,6 +747,12 @@ AbstractEngraver.prototype.addNoteToAbcElement = function (abselem, elem, dot, s
 			else
 				p1 += 1;
 		}
+		if (noteHead && noteHead.c === 'noteheads.triangle.quarter') {
+			if (dir === 'down')
+				p2 -= 0.7;
+			else
+				p1 -= 1.2;
+		}
 		abselem.addRight(new RelativeElement(null, dx, 0, p1, { "type": "stem", "pitch2": p2, linewidth: width, bottom: p1 - 1 }));
 		//var RelativeElement = function RelativeElement(c, dx, w, pitch, opt) {
 		min = Math.min(p1, p2);

package/src/write/creation/decoration.js

@@ -313,10 +313,12 @@ Decoration.prototype.dynamicDecoration = function (voice, decoration, abselem, p
 				crescendo = { start: this.startCrescendoX, stop: abselem };
 				this.startCrescendoX = undefined;
 				break;
+			case '~(':
 			case "glissando(":
 				this.startGlissandoX = abselem;
 				glissando = undefined;
 				break;
+			case '~)':
 			case "glissando)":
 				glissando = { start: this.startGlissandoX, stop: abselem };
 				this.startGlissandoX = undefined;

package/src/write/creation/glyphs.js

@@ -105,7 +105,7 @@ glyphs['noteheads.slash.quarter'] = { d: [['M', 9, -6], ['l', 0, 4], ['l', -9, 9
 
 glyphs['noteheads.harmonic.quarter'] = { d: [['M', 3.63, -4.02], ['c', 0.09, -0.06, 0.18, -0.09, 0.24, -0.03], ['c', 0.03, 0.03, 0.87, 0.93, 1.83, 2.01], ['c', 1.50, 1.65, 1.80, 1.98, 1.80, 2.04], ['c', 0.00, 0.06, -0.30, 0.39, -1.80, 2.04], ['c', -0.96, 1.08, -1.80, 1.98, -1.83, 2.01], ['c', -0.06, 0.06, -0.15, 0.03, -0.24, -0.03], ['c', -0.12, -0.09, -3.54, -3.84, -3.60, -3.93], ['c', -0.03, -0.03, -0.03, -0.09, -0.03, -0.15], ['c', 0.03, -0.06, 3.45, -3.84, 3.63, -3.96], ['z']], w: 7.5, h: 8.165 };
 
-glyphs['noteheads.triangle.quarter'] = { d: [['M', 0, 0], ['l', 9, 0], ['l', -4.5, -9], ['z']], w: 9, h: 9 };
+glyphs['noteheads.triangle.quarter'] = { d: [['M', 0, 4], ['l', 9, 0], ['l', -4.5, -9], ['z']], w: 9, h: 9 };
 
 var pathClone = function (pathArray) {
 	var res = [];

package/src/write/draw/glissando.js

@@ -11,6 +11,7 @@ function drawGlissando(renderer, params, selectables) {
 	var rightY = renderer.calcY(params.anchor2.heads[0].pitch)
 	var leftX = params.anchor1.x + params.anchor1.w / 2
 	var rightX = params.anchor2.x + params.anchor2.w / 2
+	
 	var len = lineLength(leftX, leftY, rightX, rightY)
 	var marginLeft = params.anchor1.w / 2 + margin
 	var marginRight = params.anchor2.w / 2 + margin

package/src/write/draw/set-paper-size.js

@@ -1,5 +1,5 @@
 function setPaperSize(renderer, maxwidth, scale, responsive) {
-	var w = (maxwidth + renderer.padding.right) * scale;
+	var w = (maxwidth + renderer.padding.left + renderer.padding.right) * scale;
 	var h = (renderer.y + renderer.padding.bottom) * scale;
 	if (renderer.isPrint)
 		h = Math.max(h, 1056); // 11in x 72pt/in x 1.33px/pt

package/src/write/draw/tie.js

@@ -17,7 +17,15 @@ function drawTie(renderer, params, linestartx, lineendx, selectables) {
 		klass = "abcjs-hint";
 	var fudgeY = params.fixedY ? 1.5 : 0; // TODO-PER: This just compensates for drawArc, which contains too much knowledge of ties and slurs.
 	var el = drawArc(renderer, params.startX, params.endX, params.startY + fudgeY, params.endY + fudgeY, params.above, klass, params.isTie, params.dotted);
-	selectables.wrapSvgEl({ el_type: "slur", startChar: -1, endChar: -1 }, el);
+	var startChar = -1
+	// This gets the start and end points of the contents of the slur. We assume that the parenthesis are just to the outside of that.
+	if (params.anchor1 && !params.isTie)
+		startChar = params.anchor1.parent.abcelem.startChar - 1
+	var endChar = -1
+	if (params.anchor2 && !params.isTie)
+		endChar = params.anchor2.parent.abcelem.endChar + 1
+
+	selectables.wrapSvgEl({ el_type: "slur", startChar: startChar, endChar: endChar }, el);
 	return [el];
 }
 

package/src/write/engraver-controller.js

@@ -40,6 +40,7 @@ var EngraverController = function (paper, params) {
 	this.responsive = params.responsive;
 	this.space = 3 * spacing.SPACE;
 	this.initialClef = params.initialClef;
+	this.expandToWidest = !!params.expandToWidest;
 	this.scale = params.scale ? parseFloat(params.scale) : 0;
 	this.classes = new Classes({ shouldAddClasses: params.add_classes });
 	if (!(this.scale > 0.1))
@@ -242,7 +243,12 @@ EngraverController.prototype.engraveTune = function (abcTune, tuneNumber, lineOf
 	this.constructTuneElements(abcTune);
 
 	// Do all the positioning, both horizontally and vertically
-	var maxWidth = layout(this.renderer, abcTune, this.width, this.space);
+	var maxWidth = layout(this.renderer, abcTune, this.width, this.space, this.expandToWidest);
+
+	//Set the top text now that we know the width
+	if (this.expandToWidest && maxWidth > this.width+1) {
+		abcTune.topText = new TopText(abcTune.metaText, abcTune.metaTextInfo, abcTune.formatting, abcTune.lines, maxWidth, this.renderer.isPrint, this.renderer.padding.left, this.renderer.spacing, this.getTextSize);
+	}
 
 	// Deal with tablature for staff
 	if (abcTune.tablatures) {

package/src/write/interactive/selection.js

@@ -127,6 +127,8 @@ function keyboardSelection(ev) {
 }
 
 function findElementInHistory(selectables, el) {
+	if (!el)
+		return -1;
 	for (var i = 0; i < selectables.length; i++) {
 		if (el.dataset.index === selectables[i].svgEl.dataset.index)
 			return i;
@@ -195,9 +197,13 @@ function getBestMatchCoordinates(dim, ev, scale) {
 
 function getTarget(target) {
 	// This searches up the dom for the first item containing the attribute "selectable", or stopping at the SVG.
+	if (!target)
+		return null;
 	if (target.tagName === "svg")
 		return target;
 
+	if (!target.getAttribute)
+		return null;	
 	var found = target.getAttribute("selectable");
 	while (!found) {
 		if (!target.parentElement)

package/src/write/layout/layout.js

@@ -3,7 +3,7 @@ var setUpperAndLowerElements = require('./set-upper-and-lower-elements');
 var layoutStaffGroup = require('./staff-group');
 var getLeftEdgeOfStaff = require('./get-left-edge-of-staff');
 
-var layout = function (renderer, abctune, width, space) {
+var layout = function (renderer, abctune, width, space, expandToWidest) {
 	var i;
 	var abcLine;
 	// Adjust the x-coordinates to their absolute positions
@@ -11,8 +11,14 @@ var layout = function (renderer, abctune, width, space) {
 	for (i = 0; i < abctune.lines.length; i++) {
 		abcLine = abctune.lines[i];
 		if (abcLine.staff) {
-			setXSpacing(renderer, width, space, abcLine.staffGroup, abctune.formatting, i === abctune.lines.length - 1, false);
-			if (abcLine.staffGroup.w > maxWidth) maxWidth = abcLine.staffGroup.w;
+			// console.log("=== line", i)
+			var thisWidth = setXSpacing(renderer, maxWidth, space, abcLine.staffGroup, abctune.formatting, i === abctune.lines.length - 1, false);
+			// console.log(thisWidth, maxWidth)
+			if (Math.round(thisWidth) > Math.round(maxWidth)) { // to take care of floating point weirdness
+				maxWidth = thisWidth
+				if (expandToWidest)
+					i = -1 // do the calculations over with the new width
+			}
 		}
 	}
 
@@ -41,15 +47,39 @@ var setXSpacing = function (renderer, width, space, staffGroup, formatting, isLa
 	var leftEdge = getLeftEdgeOfStaff(renderer, staffGroup.getTextSize, staffGroup.voices, staffGroup.brace, staffGroup.bracket);
 	var newspace = space;
 	for (var it = 0; it < 8; it++) { // TODO-PER: shouldn't need multiple passes, but each pass gets it closer to the right spacing. (Only affects long lines: normal lines break out of this loop quickly.)
+		// console.log("iteration", it)
+		// dumpGroup("before", staffGroup)
 		var ret = layoutStaffGroup(newspace, renderer, debug, staffGroup, leftEdge);
+		// dumpGroup("after",staffGroup)
 		newspace = calcHorizontalSpacing(isLastLine, formatting.stretchlast, width + renderer.padding.left, staffGroup.w, newspace, ret.spacingUnits, ret.minSpace, renderer.padding.left + renderer.padding.right);
 		if (debug)
 			console.log("setXSpace", it, staffGroup.w, newspace, staffGroup.minspace);
 		if (newspace === null) break;
 	}
 	centerWholeRests(staffGroup.voices);
+	return staffGroup.w - leftEdge
 };
 
+// function dumpGroup(label, staffGroup) {
+// 	var output = {
+// 		line: staffGroup.line,
+// 		w: staffGroup.w,
+// 		voice: {
+// 			i: staffGroup.voices[0].i,
+// 			minx: staffGroup.voices[0].minx,
+// 			nextx: staffGroup.voices[0].nextx,
+// 			spacingduration: staffGroup.voices[0].spacingduration,
+// 			w: staffGroup.voices[0].w,
+// 			children: [],
+// 		}
+// 	}
+// 	for (var i = 0; i < staffGroup.voices[0].children.length; i++) {
+// 		var child = staffGroup.voices[0].children[i]
+// 		output.voice.children.push({ fixedW: child.fixed.w, w: child.w, x: child.x, type: child.type })
+// 	}
+// 	console.log(label,output)
+// }
+
 function calcHorizontalSpacing(isLastLine, stretchLast, targetWidth, lineWidth, spacing, spacingUnits, minSpace, padding) {
 	if (isLastLine) {
 		if (stretchLast === undefined) {