abapgit-agent 1.8.0 → 1.8.1

package/README.md

@@ -1,3 +1,9 @@
+---
+title: abapGit Agent
+nav_order: 1
+permalink: /
+---
+
 # abapGit Agent
 
 A local agent that enables AI coding tools (Claude, Copilot, etc.) to automatically pull and activate ABAP code from git repositories using REST API.
@@ -87,7 +93,18 @@ abapgit-agent import --message "feat: add new feature"
 ### Validation Commands
 
 ```bash
-# Inspect source file for issues
+# Check syntax of local source files BEFORE commit (fast, no activation)
+# Supported: CLAS, INTF, PROG, DDLS (CDS Views)
+abapgit-agent syntax --files src/zcl_my_class.clas.abap
+abapgit-agent syntax --files src/zc_my_view.ddls.asddls
+
+# Syntax check with ABAP Cloud mode
+abapgit-agent syntax --files src/zcl_my_class.clas.abap --cloud
+
+# Syntax check multiple files
+abapgit-agent syntax --files src/zcl_class.clas.abap,src/zc_view.ddls.asddls
+
+# Inspect source file for issues (after activation)
 abapgit-agent inspect --files src/zcl_my_class.clas.abap
 
 # Run AUnit tests for test classes
@@ -158,6 +175,7 @@ npm run pull -- --url <git-url> --branch main
 | delete Command | [docs/delete-command.md](docs/delete-command.md) |
 | import Command | [docs/import-command.md](docs/import-command.md) |
 | pull Command | [docs/pull-command.md](docs/pull-command.md) |
+| syntax Command | [docs/syntax-command.md](docs/syntax-command.md) |
 | inspect Command | [docs/inspect-command.md](docs/inspect-command.md) |
 | unit Command | [docs/unit-command.md](docs/unit-command.md) |
 | tree Command | [docs/tree-command.md](docs/tree-command.md) |

package/abap/CLAUDE.md

@@ -294,15 +294,16 @@ abapgit-agent unit --files src/zcl_test1.clas.testclasses.abap,src/zcl_test2.cla
 | CLAS (test classes: .testclasses.abap) | ✅ Supported | Run `syntax` before commit |
 | INTF (interfaces) | ✅ Supported | Run `syntax` before commit |
 | PROG (programs) | ✅ Supported | Run `syntax` before commit |
-| DDLS (CDS views) | ❌ Not supported | Skip syntax, use `pull` then `inspect` |
+| DDLS (CDS views) | ✅ Supported | Run `syntax` before commit (requires annotations) |
 | FUGR (function groups) | ❌ Not supported | Skip syntax, use `pull` then `inspect` |
 | TABL/DTEL/DOMA/MSAG/SHLP | ❌ Not supported | Skip syntax, just `pull` |
 | All other types | ❌ Not supported | Skip syntax, just `pull` |
 
 **IMPORTANT**:
-- **Use `syntax` BEFORE commit** for CLAS/INTF/PROG (including test classes) - catches errors early, no git pollution
+- **Use `syntax` BEFORE commit** for CLAS/INTF/PROG/DDLS - catches errors early, no git pollution
 - **Syntax checks files INDEPENDENTLY** - no cross-file dependency support (e.g., interface definition not available when checking implementing class)
 - **For dependent files** (interface + class, class + using class): Skip `syntax`, use `pull` directly
+- **DDLS requires proper annotations** - CDS views need `@AbapCatalog.sqlViewName`, view entities don't
 - **ALWAYS push to git BEFORE running pull** - abapGit reads from git
 - **Use `inspect` AFTER pull** for unsupported types or if pull fails
 
@@ -340,7 +341,7 @@ abapgit-agent pull --files src/zcl_my_class.clas.abap,src/zif_my_intf.intf.abap,
    ├─ .clas.abap or .clas.testclasses.abap → CLAS ✅ syntax supported (if independent)
    ├─ .intf.abap → INTF ✅ syntax supported (if independent)
    ├─ .prog.abap → PROG ✅ syntax supported
-   ├─ .ddls.asddls → DDLS ❌ syntax not supported
+   ├─ .ddls.asddls → DDLS ✅ syntax supported (requires proper annotations)
    └─ All other extensions → ❌ syntax not supported
 
 2. Check for dependencies:
@@ -349,11 +350,11 @@ abapgit-agent pull --files src/zcl_my_class.clas.abap,src/zif_my_intf.intf.abap,
    ├─ New objects that don't exist in ABAP system? → Check if they depend on each other
    └─ Unrelated bug fixes across files? → No dependencies
 
-3. For SUPPORTED types (CLAS/INTF/PROG):
+3. For SUPPORTED types (CLAS/INTF/PROG/DDLS):
    ├─ Independent files → Run syntax → Fix errors → Commit → Push → Pull
    └─ Dependent files → Skip syntax → Commit → Push → Pull
 
-4. For UNSUPPORTED types (DDLS, FUGR, TABL, etc.):
+4. For UNSUPPORTED types (FUGR, TABL, etc.):
    Write code → Skip syntax → Commit → Push → Pull → (if errors: inspect)
 
 5. For MIXED types (some supported + some unsupported):

package/abap/guidelines/01_sql.md

@@ -90,6 +90,26 @@ SELECT object obj_name FROM tadir ...
 
 ---
 
+## 6. Modern ABAP SQL (with FIXPT)
+
+When `<FIXPT>X</FIXPT>` is in class XML (default for modern ABAP):
+
+```abap
+" ✅ Required syntax
+SELECT carrid, connid, fldate      " Commas required
+  FROM sflight
+  INTO TABLE @lt_result             " @ for host variables
+  WHERE carrid = @lv_carrier.       " @ for parameters
+```
+
+**Common errors**:
+- Missing commas → Add between all SELECT fields
+- Missing @ → Add to all ABAP variables (not DB columns)
+
+**Why FIXPT**: Without it, decimals treated as integers in calculations.
+
+---
+
 ## See Also
 - **Constructor Expressions** (05_classes.md) - for VALUE #(), FILTER, FOR loops
 - **Internal Tables** - for filtering and iteration patterns

package/abap/guidelines/04_cds.md

@@ -21,6 +21,77 @@ grand_parent: ABAP Development
 
 CDS views (Data Definition Language Source) require specific file naming and structure for abapGit.
 
+### CDS View vs View Entity: When to Use Which
+
+**IMPORTANT**: When creating CDS views, use **View Entity** by default unless explicitly requested otherwise.
+
+| User Request | Create Type | Why |
+|--------------|-------------|-----|
+| "Create CDS view" | CDS View Entity (modern) | Default for new development |
+| "Create CDS view for..." | CDS View Entity (modern) | Recommended approach |
+| "Create legacy CDS view" | CDS View (legacy) | Only if explicitly requested |
+| "Create CDS view with sqlViewName" | CDS View (legacy) | Explicit legacy request |
+
+### Key Differences
+
+| Aspect | CDS View (Legacy) | CDS View Entity (Modern) |
+|--------|-------------------|-------------------------|
+| **Syntax** | `define view` | `define view entity` |
+| **@AbapCatalog.sqlViewName** | ✅ Required | ❌ Not allowed (will fail) |
+| **Creates SQL View** | Yes (DDLS + SQL view) | No (DDLS only) |
+| **XML SOURCE_TYPE** | `V` | `W` |
+| **ABAP Version** | 7.40+ | 7.55+ / S/4HANA Cloud |
+| **Parameter Syntax** | `:param` or `$parameters.param` | `$parameters.param` only |
+| **Use For** | Legacy systems, existing code | New development, S/4HANA |
+
+### XML Metadata: The Key Difference
+
+The XML metadata differs only in the `SOURCE_TYPE` field:
+
+**CDS View Entity XML (RECOMMENDED - use by default):**
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DDLS>
+    <DDLNAME>ZC_MY_ENTITY</DDLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>My CDS View Entity</DDTEXT>
+    <SOURCE_TYPE>W</SOURCE_TYPE>
+   </DDLS>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+**CDS View XML (Legacy - only if explicitly requested):**
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DDLS>
+    <DDLNAME>ZC_MY_VIEW</DDLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>My CDS View</DDTEXT>
+    <SOURCE_TYPE>V</SOURCE_TYPE>
+   </DDLS>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+**SOURCE_TYPE values:**
+- `W` = View Entity (modern, no SQL view created)
+- `V` = View (legacy, creates SQL view)
+
+---
+
+## Creating CDS Views (DDLS)
+
+CDS views (Data Definition Language Source) require specific file naming and structure for abapGit.
+
 ### File Naming
 
 CDS views require **two files**:
@@ -34,6 +105,20 @@ CDS views require **two files**:
 
 ### DDL Source File (`.ddls.asddls`)
 
+**CDS View Entity (RECOMMENDED - use by default):**
+```abap
+@AccessControl.authorizationCheck: #NOT_REQUIRED
+@EndUserText.label: 'My CDS View Entity'
+define view entity ZC_My_Entity as select from tdevc
+{
+  key devclass as Devclass,
+      parentcl as ParentPackage,
+      ctext    as Description
+}
+where devclass not like '$%'
+```
+
+**CDS View (Legacy - only if explicitly requested):**
 ```abap
 @AbapCatalog.sqlViewName: 'ZCMYVIEW'
 @AbapCatalog.compiler.compareFilter: true
@@ -48,55 +133,34 @@ define view ZC_My_View as select from tdevc
 where devclass not like '$%'
 ```
 
-### XML Metadata File (`.ddls.xml`)
-
-```xml
-<?xml version="1.0" encoding="utf-8"?>
-<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
- <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-  <asx:values>
-   <DDLS>
-    <DDLNAME>ZC_MY_VIEW</DDLNAME>
-    <DDLANGUAGE>E</DDLANGUAGE>
-    <DDTEXT>My CDS View</DDTEXT>
-   </DDLS>
-  </asx:values>
- </asx:abap>
-</abapGit>
-```
+**Note the key differences:**
+- View Entity: No `@AbapCatalog.sqlViewName`, uses `define view entity`
+- View (legacy): Has `@AbapCatalog.sqlViewName`, uses `define view`
 
 ### Key Points
 
 1. **Avoid reserved words** - Field names like `PACKAGE`, `CLASS`, `INTERFACE` are reserved in CDS. Use alternatives like `PackageName`, `ClassName`.
 
-2. **Pull all files to activate** - When activating CDS views, use `abapgit-agent pull` (not single file) to ensure proper activation:
-   ```bash
-   abapgit-agent pull  # Pull all files
-   ```
+2. **Workflow for creating CDS views** - See `../CLAUDE.md` for complete workflow guidance:
+   - Independent CDS views: `syntax → commit → pull --files`
+   - Dependent CDS views (with associations to NEW views): Create underlying view first, then dependent view
+   - See CLAUDE.md section on "Working with dependent objects"
 
 3. **System support** - CDS views require SAP systems with CDS capability (S/4HANA, SAP BW/4HANA, or ABAP 7.51+). Older systems will show error: "Object type DDLS is not supported by this system"
 
-### Debugging Activation Errors
-
-When pull shows generic errors like "Activation cancelled. Check the inactive objects":
+### Activating CDS Views
 
-1. **Check in ADT/Eclipse** - Open the DDL source in ADT and run syntax check for detailed errors
-2. **Pull all files** - Sometimes `abapgit-agent pull` (all files) works better than single file for CDS views
+**For standard workflow, see `../CLAUDE.md`**
 
-## Creating CDS View Entities
+**CDS-specific notes:**
+- Single independent DDLS file: `abapgit-agent pull --files src/zc_view.ddls.asddls`
+- CDS views with associations to OTHER NEW views: Create target view first (see `../CLAUDE.md` for workflow)
 
-CDS View Entities (`define view entity`) are the modern replacement for CDS Views with additional features like **associations for OData navigation**.
+## CDS View Entity Features
 
-### Differences from CDS Views
+CDS View Entities are the modern replacement for CDS Views with enhanced features like **associations for OData navigation**.
 
-| Aspect | CDS View | View Entity |
-|--------|----------|-------------|
-| Syntax | `define view` | `define view entity` |
-| Associations | No | Yes (exposed for navigation) |
-| OData/Navigation | Requires separate service | Auto-exposes associations |
-| ABAP Version | 7.40+ | 7.55+ / S/4HANA Cloud |
-
-### DDL Source File with Association
+### Associations in View Entities
 
 ```abap
 @EndUserText.label: 'Package Hierarchy'
@@ -138,6 +202,49 @@ When working with CDS view syntax (arithmetic, built-in functions, aggregations,
 
 ---
 
+## Selecting from CDS Views in Classes
+
+### Best Practice: Use CDS View Entity as Type
+
+```abap
+" ✅ RECOMMENDED - Use view entity directly
+TYPES ty_results TYPE STANDARD TABLE OF zc_my_view WITH DEFAULT KEY.
+
+METHOD get_data.
+  SELECT * FROM zc_my_view INTO TABLE @rt_results.
+ENDMETHOD.
+```
+
+**Benefits**: No field mismatches, 33% less code, auto-sync with CDS changes.
+
+---
+
+### Alternative: Manual Structure Definition
+
+Only when you need to hide/transform fields:
+
+```abap
+" Use data elements from underlying tables
+TYPES: BEGIN OF ty_custom,
+         carrierid TYPE s_carr_id,     " ✅ Data element
+         connid    TYPE s_conn_id,     " ✅ NOT: TYPE c LENGTH 3
+       END OF ty_custom.
+```
+
+**Find data elements**:
+```bash
+abapgit-agent view --objects SFLIGHT --type TABL
+```
+
+**Match field names**:
+```bash
+abapgit-agent preview --objects ZC_MY_VIEW --limit 1
+```
+
+**Calculated fields**: Use `TYPE decfloat34` for division/complex math.
+
+---
+
 ## See Also
 - **Unit Testing** (03_testing.md) - for CDS Test Double Framework
 - **abapGit** (08_abapgit.md) - for CDS XML metadata templates

package/abap/guidelines/08_abapgit.md

@@ -65,6 +65,7 @@ abapGit needs XML files to:
     <EXPOSURE>2</EXPOSURE>
     <STATE>1</STATE>
     <UNICODE>X</UNICODE>
+    <FIXPT>X</FIXPT>
    </VSEOCLASS>
   </asx:values>
  </asx:abap>
@@ -77,6 +78,9 @@ abapGit needs XML files to:
 - `EXPOSURE`: Exposure (2 = Public, 3 = Protected, 4 = Private)
 - `STATE`: State (1 = Active)
 - `UNICODE`: Unicode encoding (X = Yes)
+- `FIXPT`: Fixed-point arithmetic (X = Yes) - **Always include for correct decimal arithmetic**
+
+**Note**: `<FIXPT>X</FIXPT>` is default for modern ABAP. Without it, decimals treated as integers.
 
 **Local Classes**: If the class has local classes (e.g., test doubles), add:
 - `<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>` - for test classes
@@ -171,7 +175,41 @@ abapGit needs XML files to:
 
 ---
 
-### CDS View (DDLS)
+### CDS View Entity (DDLS) - RECOMMENDED
+
+**Use by default when user says "create CDS view"**
+
+**Filename**: `src/zc_my_entity.ddls.xml`
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DDLS>
+    <DDLNAME>ZC_MY_ENTITY</DDLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>My CDS View Entity</DDTEXT>
+    <SOURCE_TYPE>W</SOURCE_TYPE>
+   </DDLS>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+**Key Points for CDS View Entities**:
+1. **ABAP file extension**: Use `.ddls.asddls` (NOT `.ddls.abap`)
+2. **XML file**: Use `.ddls.xml`
+3. **DDLNAME**: Must match the CDS view entity name in the source
+4. **SOURCE_TYPE**: `W` = View Entity (modern, recommended)
+5. **Serializer**: Use `LCL_OBJECT_DDLS`
+6. **Source file**: Use `define view entity` (no `@AbapCatalog.sqlViewName`)
+
+---
+
+### CDS View (DDLS) - Legacy Only
+
+**Only use when explicitly requested (e.g., "create legacy CDS view")**
 
 **Filename**: `src/zc_my_view.ddls.xml`
 
@@ -191,12 +229,15 @@ abapGit needs XML files to:
 </abapGit>
 ```
 
-**Key Points for CDS Views**:
+**Key Points for CDS Views (Legacy)**:
 1. **ABAP file extension**: Use `.ddls.asddls` (NOT `.ddls.abap`)
 2. **XML file**: Use `.ddls.xml`
 3. **DDLNAME**: Must match the CDS view name in the source
-4. **SOURCE_TYPE**: V = View, C = Consumption
+4. **SOURCE_TYPE**: `V` = View (legacy)
 5. **Serializer**: Use `LCL_OBJECT_DDLS`
+6. **Source file**: Must include `@AbapCatalog.sqlViewName` annotation
+
+**For detailed comparison and usage guidance, see `guidelines/04_cds.md`**
 
 ---
 

package/abap/guidelines/10_common_errors.md

@@ -0,0 +1,95 @@
+---
+layout: default
+title: Common ABAP Errors
+nav_order: 11
+parent: ABAP Coding Guidelines
+grand_parent: ABAP Development
+---
+
+# Common ABAP Errors - Quick Fixes
+
+**Searchable keywords**: error, syntax error, field mismatch, fixed point, comma, host variable, @ prefix, type incompatible
+
+## Fixed Point Arithmetic Error
+
+```
+This ABAP SQL statement uses additions that can only be used when
+the fixed point arithmetic flag is activated
+```
+
+**Fix**: Add `<FIXPT>X</FIXPT>` to class XML.
+
+```xml
+<VSEOCLASS>
+  ...
+  <FIXPT>X</FIXPT>
+</VSEOCLASS>
+```
+
+---
+
+## Field Name Mismatch
+
+```
+The field 'CARRIERID' does not have a corresponding field in the work area
+```
+
+**Fix**: Match structure field names with CDS view.
+
+Check actual names: `abapgit-agent preview --objects <VIEW> --limit 1`
+
+**Better fix**: Use CDS as type: `TYPE STANDARD TABLE OF zc_view WITH DEFAULT KEY`
+
+---
+
+## Missing Commas in SELECT
+
+```
+The elements in the 'SELECT LIST' list must be separated using commas
+```
+
+**Fix**: `SELECT carrid, connid, fldate` (add commas between fields)
+
+---
+
+## Missing @ Escape
+
+```
+Either 'LT_RESULT' has to be escaped using '@' or qualified by a table name
+```
+
+**Fix**: `INTO TABLE @lt_result WHERE field = @lv_param` (add @ prefix)
+
+---
+
+## Type Incompatible
+
+```
+The data type of the component 'OCCUPANCYPERCENT' is not compatible
+```
+
+**Fix for calculated CDS fields**: Use `TYPE decfloat34`
+
+**Fix for other fields**: Use correct data element.
+
+Find: `abapgit-agent view --objects <TABLE> --type TABL`
+
+---
+
+## Using Raw Types
+
+```abap
+❌ carrierid TYPE c LENGTH 3,
+✅ carrierid TYPE s_carr_id,
+```
+
+**Rule**: Always use data elements, never raw types (c, n, p without reference).
+
+Find data elements: `abapgit-agent view --objects <TABLE> --type TABL`
+
+---
+
+## See Also
+- **ABAP SQL** (01_sql.md) - for SQL syntax rules
+- **CDS Views** (04_cds.md) - for CDS selection patterns
+- **abapGit** (08_abapgit.md) - for XML metadata templates

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abapgit-agent",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
   "main": "src/index.js",
   "files": [

package/src/commands/syntax.js

@@ -79,6 +79,10 @@ module.exports = {
       } else if (baseName.includes('.prog.')) {
         objType = 'PROG';
         objName = baseName.split('.')[0].toUpperCase();
+      } else if (baseName.includes('.ddls.asddls')) {
+        objType = 'DDLS';
+        objName = baseName.split('.')[0].toUpperCase();
+        fileKind = 'main';
       }
 
       // Read source from file
@@ -103,11 +107,35 @@ module.exports = {
           classFiles[fileKind] = source;
         }
       } else {
-        objects.push({
+        const obj = {
           type: objType,
           name: objName,
           source: source
-        });
+        };
+
+        // Read FIXPT from XML metadata for INTF and PROG
+        if (objType === 'INTF' || objType === 'PROG') {
+          const dir = pathModule.dirname(filePath);
+          let xmlFile;
+          if (objType === 'INTF') {
+            xmlFile = pathModule.join(dir, `${objName.toLowerCase()}.intf.xml`);
+          } else if (objType === 'PROG') {
+            xmlFile = pathModule.join(dir, `${objName.toLowerCase()}.prog.xml`);
+          }
+          if (xmlFile && fs.existsSync(xmlFile)) {
+            const xmlContent = fs.readFileSync(xmlFile, 'utf8');
+            // Simple regex to extract FIXPT value
+            const fixptMatch = xmlContent.match(/<FIXPT>([^<]+)<\/FIXPT>/);
+            if (fixptMatch && fixptMatch[1] === 'X') {
+              obj.fixpt = 'X';
+            } else {
+              // No FIXPT tag means FIXPT=false (blank)
+              obj.fixpt = '';
+            }
+          }
+        }
+
+        objects.push(obj);
       }
     }
 
@@ -180,6 +208,28 @@ module.exports = {
         if (files.locals_def) obj.locals_def = files.locals_def;
         if (files.locals_imp) obj.locals_imp = files.locals_imp;
         if (files.testclasses) obj.testclasses = files.testclasses;
+
+        // Read FIXPT from XML metadata
+        const mainFile = syntaxFiles.find(f => {
+          const bn = pathModule.basename(f).toUpperCase();
+          return bn.startsWith(className) && bn.includes('.CLAS.ABAP') && !bn.includes('LOCALS') && !bn.includes('TESTCLASSES');
+        });
+        if (mainFile) {
+          const dir = pathModule.dirname(mainFile);
+          const xmlFile = pathModule.join(dir, `${className.toLowerCase()}.clas.xml`);
+          if (fs.existsSync(xmlFile)) {
+            const xmlContent = fs.readFileSync(xmlFile, 'utf8');
+            // Simple regex to extract FIXPT value
+            const fixptMatch = xmlContent.match(/<FIXPT>([^<]+)<\/FIXPT>/);
+            if (fixptMatch && fixptMatch[1] === 'X') {
+              obj.fixpt = 'X';
+            } else {
+              // No FIXPT tag means FIXPT=false (blank)
+              obj.fixpt = '';
+            }
+          }
+        }
+
         objects.push(obj);
       } else {
         console.error(`  Warning: No main class file for ${className}, skipping local files`);