abapgit-agent 1.4.0 → 1.5.0

package/.github/workflows/release.yml

@@ -14,6 +14,8 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - name: Setup Node.js
         uses: actions/setup-node@v4
@@ -39,6 +41,7 @@ jobs:
       - name: Prepare release notes
         id: release_notes
         run: |
+          # Read release notes from file (generated by npm run release)
           if [ -f "RELEASE_NOTES.md" ]; then
             # Extract only the current release (first section until --- separator)
             content=$(awk '/^---$/{exit}1' RELEASE_NOTES.md)
@@ -46,7 +49,7 @@ jobs:
             echo "$content" >> $GITHUB_OUTPUT
             echo "EOF" >> $GITHUB_OUTPUT
           else
-            echo "CONTENT=No release notes" >> $GITHUB_OUTPUT
+            echo "CONTENT=Release ${{ steps.get_tag.outputs.VERSION }}" >> $GITHUB_OUTPUT
           fi
 
       - name: Create GitHub Release

package/CLAUDE.md

@@ -127,6 +127,7 @@ abapgit-agent health
 # Check configuration
 abapgit-agent status
 ```
+Note: All ABAP commands automatically check CLI/ABAP API version compatibility.
 
 ## Pull Command
 
@@ -237,8 +238,21 @@ abapgit-agent inspect --files abap/zc_my_view.ddls.asddls
 
 # Inspect mixed file types (DDLS + CLAS)
 abapgit-agent inspect --files abap/zc_my_view.ddls.asddls,abap/zcl_my_class.clas.abap
+
+# Inspect with specific Code Inspector variant
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant ALL_CHECKS
+
+# Inspect with no variant (uses default SAP standard checks)
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant EMPTY
 ```
 
+### Parameters
+
+| Parameter | Required | Description |
+|-----------|----------|-------------|
+| `--files` | Yes | Comma-separated list of ABAP files to inspect |
+| `--variant` | No | Code Inspector variant name (e.g., `ALL_CHECKS`, `EMPTY`) |
+
 ### Supported Object Types
 
 | Type | Description | Validation Method |
@@ -809,6 +823,7 @@ Create `.abapGitAgent` in repository root:
 | `language` | SAP language | EN |
 | `gitUsername` | Git username/token | Optional |
 | `gitPassword` | Git password/token | Optional |
+| `transport` | Default transport request for pull | Optional |
 
 ### Environment Variables
 ```bash
@@ -820,8 +835,20 @@ export ABAP_PASSWORD="your-password"
 export ABAP_LANGUAGE="EN"
 export GIT_USERNAME="git-username"
 export GIT_PASSWORD="git-token"
+export ABAP_TRANSPORT="DEVK900001"
 ```
 
+### Transport Request Precedence
+
+When running `pull` command, the transport request is determined in this order:
+
+| Priority | Source | Example |
+|----------|--------|---------|
+| 1 | CLI `--transport` argument | `--transport DEVK900001` |
+| 2 | Config file `transport` | `"transport": "DEVK900001"` |
+| 3 | Environment variable `ABAP_TRANSPORT` | `export ABAP_TRANSPORT="DEVK900001"` |
+| 4 (default) | Not set | abapGit creates/uses default |
+
 ## Troubleshooting
 
 **Pull fails with "Error updating where-used list":**

package/README.md

@@ -124,6 +124,7 @@ abapgit-agent health
 # Check integration status
 abapgit-agent status
 ```
+Note: All ABAP commands automatically check CLI/ABAP API version compatibility.
 
 ## Local Development
 

package/abap/CLAUDE.md

@@ -788,6 +788,118 @@ ENDCLASS.
 - Syntax errors in one command don't affect others
 - Add new commands by updating the mapping table
 
+## Exception Handling in ABAP
+
+ABAP has two different ways to handle exceptions. Understanding the difference is critical.
+
+### Classical ABAP Exceptions (EXCEPTIONS)
+
+Used in older function modules and some OO classes. Defined in method signature using `EXCEPTIONS` keyword.
+
+**Method Definition:**
+```abap
+METHODS method_name
+  IMPORTING iv_param TYPE string
+  EXCEPTIONS
+    exc1 = 1
+    exc2 = 2
+    OTHERS = 3.
+```
+
+**Method Call:**
+```abap
+method_name(
+  EXPORTING iv_param = lv_value
+  EXCEPTIONS
+    exc1 = 1
+    exc2 = 2
+    OTHERS = 3 ).
+
+IF sy-subrc <> 0.
+  " Handle error - check sy-subrc for exception number
+ENDIF.
+```
+
+**Characteristics:**
+- Return code in `sy-subrc`
+- No exception objects
+- Legacy approach
+
+### Modern ABAP Exceptions (TRY-CATCH)
+
+Used in modern OO ABAP (7.40+). Uses exception classes and RAISING clause.
+
+**Exception Class:**
+```abap
+CLASS cx_my_exception DEFINITION INHERITING FROM cx_dynamic_check.
+  PUBLIC SECTION.
+    METHODS constructor IMPORTING textid LIKE textid OPTIONAL.
+ENDCLASS.
+```
+
+**Method Definition:**
+```abap
+METHODS method_name
+  IMPORTING iv_param TYPE string
+  RAISING cx_my_exception.
+```
+
+**Method Call:**
+```abap
+TRY.
+    method_name( iv_param = lv_value ).
+  CATCH cx_my_exception INTO lx_error.
+    lv_message = lx_error->get_text( ).
+ENDTRY.
+```
+
+### How to Identify Which to Use
+
+Look at the method signature:
+
+| Syntax | Type |
+|--------|------|
+| `EXCEPTIONS exc1 = 1` | Classical |
+| `RAISING cx_exception` | Modern (TRY-CATCH) |
+
+### Real Example: cl_ci_checkvariant=>get_ref
+
+This method uses **classical exceptions**:
+
+```abap
+" WRONG - using TRY-CATCH
+TRY.
+    lo_variant = cl_ci_checkvariant=>get_ref(
+      p_user = ''
+      p_name = lv_variant ).
+  CATCH cx_root.
+    " This won't work!
+ENDTRY.
+
+" CORRECT - using EXCEPTIONS with EXPORTING and RECEIVING
+cl_ci_checkvariant=>get_ref(
+  EXPORTING
+    p_user = ''
+    p_name = lv_variant
+  RECEIVING
+    p_ref = lo_variant
+  EXCEPTIONS
+    chkv_not_exists = 1
+    missing_parameter = 2
+    broken_variant = 3
+    OTHERS = 4 ).
+
+IF sy-subrc <> 0.
+  " Handle error
+ENDIF.
+```
+
+**Key Points:**
+1. Use `EXPORTING` before importing parameters when using `EXCEPTIONS`
+2. Use `RECEIVING` for RETURNING parameters (not direct assignment)
+3. Check `sy-subrc` for exception codes
+4. Not all OO methods use TRY-CATCH - some still use classical exceptions
+
 ## Best Practices
 
 ### Always Return Interface Types, Not Class Types

package/abap/zcl_abgagt_command_inspect.clas.abap

@@ -44,6 +44,7 @@ CLASS zcl_abgagt_command_inspect DEFINITION PUBLIC FINAL CREATE PUBLIC.
 
     TYPES: BEGIN OF ty_inspect_params,
              files TYPE string_table,
+             variant TYPE string,
            END OF ty_inspect_params.
 
     TYPES ty_object_keys TYPE TABLE OF scir_objs WITH NON-UNIQUE DEFAULT KEY.
@@ -53,6 +54,7 @@ CLASS zcl_abgagt_command_inspect DEFINITION PUBLIC FINAL CREATE PUBLIC.
 
     METHODS run_syntax_check
       IMPORTING it_objects TYPE ty_object_keys
+                iv_variant TYPE string DEFAULT 'SYNTAX_CHECK'
       RETURNING VALUE(rt_results) TYPE ty_inspect_results.
 
     " Validate DDLS (CDS views)
@@ -120,7 +122,9 @@ CLASS zcl_abgagt_command_inspect IMPLEMENTATION.
 
     " Run syntax check for non-DDLS objects
     IF lt_objects IS NOT INITIAL.
-      DATA(lt_sci_results) = run_syntax_check( lt_objects ).
+      DATA(lt_sci_results) = run_syntax_check(
+        it_objects = lt_objects
+        iv_variant = ls_params-variant ).
       INSERT LINES OF lt_sci_results INTO TABLE lt_results.
     ENDIF.
 
@@ -300,6 +304,7 @@ CLASS zcl_abgagt_command_inspect IMPLEMENTATION.
           lo_inspection TYPE REF TO cl_ci_inspection,
           lt_list TYPE scit_alvlist,
           ls_error TYPE ty_error,
+          ls_warning TYPE ty_warning,
           ls_list TYPE scir_alvlist,
           lx_error TYPE REF TO cx_root,
           ls_result TYPE ty_inspect_result.
@@ -315,10 +320,36 @@ CLASS zcl_abgagt_command_inspect IMPLEMENTATION.
           p_name    = lv_name
           p_objects = it_objects ).
 
-        " Get check variant for syntax check
-        lo_variant = cl_ci_checkvariant=>get_ref(
-          p_user = ''
-          p_name = 'SYNTAX_CHECK' ).
+        " Get check variant (default: SYNTAX_CHECK)
+        DATA lv_variant TYPE sci_chkv.
+        lv_variant = iv_variant.
+        IF lv_variant IS INITIAL.
+          lv_variant = 'SYNTAX_CHECK'.
+        ENDIF.
+
+        " Try to get the variant using EXCEPTIONS
+        cl_ci_checkvariant=>get_ref(
+          EXPORTING
+            p_user = ''
+            p_name = lv_variant
+          RECEIVING
+            p_ref = lo_variant
+          EXCEPTIONS
+            chkv_not_exists = 1
+            missing_parameter = 2
+            broken_variant = 3
+            OTHERS = 4 ).
+
+        IF sy-subrc <> 0.
+          " Variant not found, return error
+          ls_result-object_type = 'VARIANT'.
+          ls_result-object_name = lv_variant.
+          ls_result-success = abap_false.
+          ls_result-error_count = 1.
+          APPEND VALUE #( line = '0' column = '0' text = |Check variant "{ lv_variant }" not found (rc={ sy-subrc })| word = '' ) TO ls_result-errors.
+          APPEND ls_result TO rt_results.
+          RETURN.
+        ENDIF.
 
         " Create inspection
         cl_ci_inspection=>create(
@@ -355,14 +386,28 @@ CLASS zcl_abgagt_command_inspect IMPLEMENTATION.
           ls_result-object_name = ls_obj-objname.
           ls_result-success = abap_true.
 
-          " Get errors for this object
+          " Get errors and warnings for this object
           LOOP AT lt_list INTO ls_list WHERE objname = ls_obj-objname.
-            CLEAR ls_error.
-            ls_error-line = ls_list-line.
-            ls_error-column = ls_list-col.
-            ls_error-text = ls_list-text.
-            ls_error-word = ls_list-code.
-            APPEND ls_error TO ls_result-errors.
+            " Check severity - 'E' = Error, 'W' = Warning, 'I' = Info
+            IF ls_list-kind = 'E'.
+              " Error
+              CLEAR ls_error.
+              ls_error-line = ls_list-line.
+              ls_error-column = ls_list-col.
+              ls_error-text = ls_list-text.
+              ls_error-word = ls_list-code.
+              APPEND ls_error TO ls_result-errors.
+            ELSEIF ls_list-kind = 'W' OR ls_list-kind = 'I'.
+              " Warning or Info
+              CLEAR ls_warning.
+              ls_warning-line = ls_list-line.
+              ls_warning-column = ls_list-col.
+              ls_warning-severity = ls_list-kind.
+              ls_warning-message = ls_list-text.
+              ls_warning-object_type = ls_obj-objtype.
+              ls_warning-object_name = ls_obj-objname.
+              APPEND ls_warning TO ls_result-warnings.
+            ENDIF.
           ENDLOOP.
 
           ls_result-error_count = lines( ls_result-errors ).

package/abap/zcl_abgagt_resource_health.clas.abap

@@ -14,7 +14,7 @@ CLASS zcl_abgagt_resource_health IMPLEMENTATION.
 
   METHOD if_rest_resource~get.
     DATA lv_json TYPE string.
-    lv_json = '{"status":"OK","version":"1.0.0"}'.
+    lv_json = '{"status":"OK","version":"1.4.0"}'.
 
     DATA(lo_entity) = mo_response->create_entity( ).
     lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).

package/abap/zcl_abgagt_resource_inspect.clas.abap

@@ -19,6 +19,7 @@ CLASS zcl_abgagt_resource_inspect IMPLEMENTATION.
     " Parse JSON using /ui2/cl_json
     DATA: BEGIN OF ls_request,
             files TYPE string_table,
+            variant TYPE string,
           END OF ls_request.
 
     /ui2/cl_json=>deserialize(

package/bin/abapgit-agent

@@ -23,6 +23,74 @@ const TERM_WIDTH = getTermWidth();
 
 const COOKIE_FILE = '.abapgit_agent_cookies.txt';
 
+/**
+ * Get CLI version from package.json
+ */
+function getCliVersion() {
+  const packageJsonPath = pathModule.join(__dirname, '..', 'package.json');
+  if (fs.existsSync(packageJsonPath)) {
+    const pkg = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+    return pkg.version || '1.0.0';
+  }
+  return '1.0.0';
+}
+
+/**
+ * Check version compatibility between CLI and ABAP API
+ */
+async function checkVersionCompatibility() {
+  const cliVersion = getCliVersion();
+
+  try {
+    const config = loadConfig();
+    const https = require('https');
+    const url = new URL(`/sap/bc/z_abapgit_agent/health`, `https://${config.host}:${config.sapport}`);
+
+    return new Promise((resolve) => {
+      const options = {
+        hostname: url.hostname,
+        port: url.port,
+        path: url.pathname,
+        method: 'GET',
+        headers: {
+          'Authorization': `Basic ${Buffer.from(`${config.user}:${config.password}`).toString('base64')}`,
+          'sap-client': config.client,
+          'sap-language': config.language || 'EN',
+          'Content-Type': 'application/json'
+        },
+        agent: new https.Agent({ rejectUnauthorized: false })
+      };
+
+      const req = https.request(options, (res) => {
+        let body = '';
+        res.on('data', chunk => body += chunk);
+        res.on('end', () => {
+          try {
+            const result = JSON.parse(body);
+            const apiVersion = result.version || '1.0.0';
+
+            if (cliVersion !== apiVersion) {
+              console.log(`\n⚠️  Version mismatch: CLI ${cliVersion}, ABAP API ${apiVersion}`);
+              console.log('   Some commands may not work correctly.');
+              console.log('   Update ABAP code: abapgit-agent pull\n');
+            }
+            resolve({ cliVersion, apiVersion, compatible: cliVersion === apiVersion });
+          } catch (e) {
+            resolve({ cliVersion, apiVersion: null, compatible: false, error: e.message });
+          }
+        });
+      });
+
+      req.on('error', (e) => {
+        resolve({ cliVersion, apiVersion: null, compatible: false, error: e.message });
+      });
+      req.end();
+    });
+  } catch (error) {
+    return { cliVersion, apiVersion: null, compatible: false, error: error.message };
+  }
+}
+
 /**
  * Load configuration from .abapGitAgent in current working directory
  */
@@ -42,10 +110,19 @@ function loadConfig() {
     password: process.env.ABAP_PASSWORD,
     language: process.env.ABAP_LANGUAGE || 'EN',
     gitUsername: process.env.GIT_USERNAME,
-    gitPassword: process.env.GIT_PASSWORD
+    gitPassword: process.env.GIT_PASSWORD,
+    transport: process.env.ABAP_TRANSPORT
   };
 }
 
+/**
+ * Get transport request from config or environment
+ */
+function getTransport() {
+  const config = loadConfig();
+  return config.transport;
+}
+
 /**
  * Check if ABAP integration is configured for this repo
  */
@@ -385,7 +462,7 @@ async function syntaxCheckSource(sourceFile, csrfToken, config) {
 /**
  * Inspect all files in one request
  */
-async function inspectAllFiles(files, csrfToken, config) {
+async function inspectAllFiles(files, csrfToken, config, variant = null) {
   // Convert files to uppercase names (same as syntaxCheckSource does)
   const fileNames = files.map(f => {
     const baseName = pathModule.basename(f).toUpperCase();
@@ -398,6 +475,11 @@ async function inspectAllFiles(files, csrfToken, config) {
       files: fileNames
     };
 
+    // Add variant if specified
+    if (variant) {
+      data.variant = variant;
+    }
+
     const result = await request('POST', '/sap/bc/z_abapgit_agent/inspect', data, { csrfToken: csrfToken });
 
     // Handle both table result and old single result
@@ -1195,6 +1277,12 @@ To enable integration:
     }
   }
 
+  // Version compatibility check for commands that interact with ABAP
+  const abapCommands = ['create', 'import', 'pull', 'inspect', 'unit', 'tree', 'view', 'preview'];
+  if (command && abapCommands.includes(command)) {
+    await checkVersionCompatibility();
+  }
+
   try {
     switch (command) {
       case 'init':
@@ -1390,16 +1478,21 @@ Examples:
         let gitUrl = urlArgIndex !== -1 ? args[urlArgIndex + 1] : null;
         let branch = branchArgIndex !== -1 ? args[branchArgIndex + 1] : getGitBranch();
         let files = null;
+
+        // Transport: CLI arg takes priority, then config/environment, then null
         let transportRequest = null;
+        if (transportArgIndex !== -1 && transportArgIndex + 1 < args.length) {
+          // Explicit --transport argument
+          transportRequest = args[transportArgIndex + 1];
+        } else {
+          // Fall back to config or environment variable
+          transportRequest = getTransport();
+        }
 
         if (filesArgIndex !== -1 && filesArgIndex + 1 < args.length) {
           files = args[filesArgIndex + 1].split(',').map(f => f.trim());
         }
 
-        if (transportArgIndex !== -1 && transportArgIndex + 1 < args.length) {
-          transportRequest = args[transportArgIndex + 1];
-        }
-
         if (!gitUrl) {
           gitUrl = getGitRemoteUrl();
           if (!gitUrl) {
@@ -1427,31 +1520,32 @@ Examples:
         break;
 
       case 'inspect': {
-        // TODO: Implement full inspect feature with:
-        // - Syntax check (currently implemented via /inspect)
-        // - Code Inspector checks (SE51, SCI)
-        // - ATC checks (SATC)
-        // - Custom rule checks
-        // Add --check-type parameter to specify which check to run
-
         const filesArgIndex = args.indexOf('--files');
         if (filesArgIndex === -1 || filesArgIndex + 1 >= args.length) {
           console.error('Error: --files parameter required');
-          console.error('Usage: abapgit-agent inspect --files <file1>,<file2>,...');
+          console.error('Usage: abapgit-agent inspect --files <file1>,<file2>,... [--variant <check-variant>]');
           console.error('Example: abapgit-agent inspect --files zcl_my_class.clas.abap');
+          console.error('Example: abapgit-agent inspect --files zcl_my_class.clas.abap --variant ALL_CHECKS');
           process.exit(1);
         }
 
         const filesSyntaxCheck = args[filesArgIndex + 1].split(',').map(f => f.trim());
 
+        // Parse optional --variant parameter
+        const variantArgIndex = args.indexOf('--variant');
+        const variant = variantArgIndex !== -1 ? args[variantArgIndex + 1] : null;
+
         console.log(`\n  Inspect for ${filesSyntaxCheck.length} file(s)`);
+        if (variant) {
+          console.log(`  Using variant: ${variant}`);
+        }
         console.log('');
 
         const config = loadConfig();
         const csrfToken = await fetchCsrfToken(config);
 
         // Send all files in one request
-        const results = await inspectAllFiles(filesSyntaxCheck, csrfToken, config);
+        const results = await inspectAllFiles(filesSyntaxCheck, csrfToken, config, variant);
 
         // Process results
         for (const result of results) {
@@ -1485,15 +1579,37 @@ Examples:
 
       case 'tree': {
         const packageArgIndex = args.indexOf('--package');
-        if (packageArgIndex === -1 || packageArgIndex + 1 >= args.length) {
+        if (packageArgIndex === -1) {
           console.error('Error: --package parameter required');
           console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
-          console.error('Example: abapgit-agent tree --package $ZMY_PACKAGE');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
+          process.exit(1);
+        }
+
+        // Check if package value is missing (happens when shell variable expands to empty)
+        if (packageArgIndex + 1 >= args.length) {
+          console.error('Error: --package parameter value is missing');
+          console.error('');
+          console.error('Tip: If you are using a shell variable, make sure to quote it:');
+          console.error('  abapgit-agent tree --package "$ZMY_PACKAGE"');
+          console.error('  or escape the $ character:');
+          console.error('  abapgit-agent tree --package \\$ZMY_PACKAGE');
+          console.error('');
+          console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
           process.exit(1);
         }
 
         const packageName = args[packageArgIndex + 1];
 
+        // Check for empty/whitespace-only package name
+        if (!packageName || packageName.trim() === '') {
+          console.error('Error: --package parameter cannot be empty');
+          console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
+          process.exit(1);
+        }
+
         // Optional depth parameter
         const depthArgIndex = args.indexOf('--depth');
         let depth = 3;

package/docs/inspect-command.md

@@ -15,6 +15,12 @@ abapgit-agent inspect --files zcl_my_class.clas.abap,zcl_other.clas.abap
 
 # With path
 abapgit-agent inspect --files abap/zcl_my_class.clas.abap
+
+# With Code Inspector variant
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant ALL_CHECKS
+
+# With no variant (uses default SAP standard checks)
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant EMPTY
 ```
 
 ## Prerequisite
@@ -27,6 +33,7 @@ abapgit-agent inspect --files abap/zcl_my_class.clas.abap
 | Parameter | Required | Description |
 |-----------|----------|-------------|
 | `--files` | Yes | Comma-separated list of files to inspect |
+| `--variant` | No | Code Inspector variant name (e.g., `ALL_CHECKS`, `EMPTY`) |
 
 ---
 
@@ -54,7 +61,8 @@ GET /health (with X-CSRF-Token: fetch)
 **Request Body:**
 ```json
 {
-  "files": ["ZCL_MY_CLASS.CLASS.ABAP"]
+  "files": ["ZCL_MY_CLASS.CLASS.ABAP"],
+  "variant": "ALL_CHECKS"
 }
 ```
 
@@ -140,6 +148,9 @@ abapgit-agent inspect --files zcl_my_class.clas.abap
 
 # Multiple files
 abapgit-agent inspect --files abap/zcl_my_class.clas.abap,abap/zcl_other.clas.abap
+
+# With Code Inspector variant
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant ALL_CHECKS
 ```
 
 ## Use Case