abapgit-agent 1.3.0 → 1.5.0

package/bin/abapgit-agent

@@ -23,6 +23,74 @@ const TERM_WIDTH = getTermWidth();
 
 const COOKIE_FILE = '.abapgit_agent_cookies.txt';
 
+/**
+ * Get CLI version from package.json
+ */
+function getCliVersion() {
+  const packageJsonPath = pathModule.join(__dirname, '..', 'package.json');
+  if (fs.existsSync(packageJsonPath)) {
+    const pkg = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+    return pkg.version || '1.0.0';
+  }
+  return '1.0.0';
+}
+
+/**
+ * Check version compatibility between CLI and ABAP API
+ */
+async function checkVersionCompatibility() {
+  const cliVersion = getCliVersion();
+
+  try {
+    const config = loadConfig();
+    const https = require('https');
+    const url = new URL(`/sap/bc/z_abapgit_agent/health`, `https://${config.host}:${config.sapport}`);
+
+    return new Promise((resolve) => {
+      const options = {
+        hostname: url.hostname,
+        port: url.port,
+        path: url.pathname,
+        method: 'GET',
+        headers: {
+          'Authorization': `Basic ${Buffer.from(`${config.user}:${config.password}`).toString('base64')}`,
+          'sap-client': config.client,
+          'sap-language': config.language || 'EN',
+          'Content-Type': 'application/json'
+        },
+        agent: new https.Agent({ rejectUnauthorized: false })
+      };
+
+      const req = https.request(options, (res) => {
+        let body = '';
+        res.on('data', chunk => body += chunk);
+        res.on('end', () => {
+          try {
+            const result = JSON.parse(body);
+            const apiVersion = result.version || '1.0.0';
+
+            if (cliVersion !== apiVersion) {
+              console.log(`\n⚠️  Version mismatch: CLI ${cliVersion}, ABAP API ${apiVersion}`);
+              console.log('   Some commands may not work correctly.');
+              console.log('   Update ABAP code: abapgit-agent pull\n');
+            }
+            resolve({ cliVersion, apiVersion, compatible: cliVersion === apiVersion });
+          } catch (e) {
+            resolve({ cliVersion, apiVersion: null, compatible: false, error: e.message });
+          }
+        });
+      });
+
+      req.on('error', (e) => {
+        resolve({ cliVersion, apiVersion: null, compatible: false, error: e.message });
+      });
+      req.end();
+    });
+  } catch (error) {
+    return { cliVersion, apiVersion: null, compatible: false, error: error.message };
+  }
+}
+
 /**
  * Load configuration from .abapGitAgent in current working directory
  */
@@ -42,10 +110,19 @@ function loadConfig() {
     password: process.env.ABAP_PASSWORD,
     language: process.env.ABAP_LANGUAGE || 'EN',
     gitUsername: process.env.GIT_USERNAME,
-    gitPassword: process.env.GIT_PASSWORD
+    gitPassword: process.env.GIT_PASSWORD,
+    transport: process.env.ABAP_TRANSPORT
   };
 }
 
+/**
+ * Get transport request from config or environment
+ */
+function getTransport() {
+  const config = loadConfig();
+  return config.transport;
+}
+
 /**
  * Check if ABAP integration is configured for this repo
  */
@@ -385,7 +462,7 @@ async function syntaxCheckSource(sourceFile, csrfToken, config) {
 /**
  * Inspect all files in one request
  */
-async function inspectAllFiles(files, csrfToken, config) {
+async function inspectAllFiles(files, csrfToken, config, variant = null) {
   // Convert files to uppercase names (same as syntaxCheckSource does)
   const fileNames = files.map(f => {
     const baseName = pathModule.basename(f).toUpperCase();
@@ -398,6 +475,11 @@ async function inspectAllFiles(files, csrfToken, config) {
       files: fileNames
     };
 
+    // Add variant if specified
+    if (variant) {
+      data.variant = variant;
+    }
+
     const result = await request('POST', '/sap/bc/z_abapgit_agent/inspect', data, { csrfToken: csrfToken });
 
     // Handle both table result and old single result
@@ -1195,6 +1277,12 @@ To enable integration:
     }
   }
 
+  // Version compatibility check for commands that interact with ABAP
+  const abapCommands = ['create', 'import', 'pull', 'inspect', 'unit', 'tree', 'view', 'preview'];
+  if (command && abapCommands.includes(command)) {
+    await checkVersionCompatibility();
+  }
+
   try {
     switch (command) {
       case 'init':
@@ -1390,16 +1478,21 @@ Examples:
         let gitUrl = urlArgIndex !== -1 ? args[urlArgIndex + 1] : null;
         let branch = branchArgIndex !== -1 ? args[branchArgIndex + 1] : getGitBranch();
         let files = null;
+
+        // Transport: CLI arg takes priority, then config/environment, then null
         let transportRequest = null;
+        if (transportArgIndex !== -1 && transportArgIndex + 1 < args.length) {
+          // Explicit --transport argument
+          transportRequest = args[transportArgIndex + 1];
+        } else {
+          // Fall back to config or environment variable
+          transportRequest = getTransport();
+        }
 
         if (filesArgIndex !== -1 && filesArgIndex + 1 < args.length) {
           files = args[filesArgIndex + 1].split(',').map(f => f.trim());
         }
 
-        if (transportArgIndex !== -1 && transportArgIndex + 1 < args.length) {
-          transportRequest = args[transportArgIndex + 1];
-        }
-
         if (!gitUrl) {
           gitUrl = getGitRemoteUrl();
           if (!gitUrl) {
@@ -1427,31 +1520,32 @@ Examples:
         break;
 
       case 'inspect': {
-        // TODO: Implement full inspect feature with:
-        // - Syntax check (currently implemented via /inspect)
-        // - Code Inspector checks (SE51, SCI)
-        // - ATC checks (SATC)
-        // - Custom rule checks
-        // Add --check-type parameter to specify which check to run
-
         const filesArgIndex = args.indexOf('--files');
         if (filesArgIndex === -1 || filesArgIndex + 1 >= args.length) {
           console.error('Error: --files parameter required');
-          console.error('Usage: abapgit-agent inspect --files <file1>,<file2>,...');
+          console.error('Usage: abapgit-agent inspect --files <file1>,<file2>,... [--variant <check-variant>]');
           console.error('Example: abapgit-agent inspect --files zcl_my_class.clas.abap');
+          console.error('Example: abapgit-agent inspect --files zcl_my_class.clas.abap --variant ALL_CHECKS');
           process.exit(1);
         }
 
         const filesSyntaxCheck = args[filesArgIndex + 1].split(',').map(f => f.trim());
 
+        // Parse optional --variant parameter
+        const variantArgIndex = args.indexOf('--variant');
+        const variant = variantArgIndex !== -1 ? args[variantArgIndex + 1] : null;
+
         console.log(`\n  Inspect for ${filesSyntaxCheck.length} file(s)`);
+        if (variant) {
+          console.log(`  Using variant: ${variant}`);
+        }
         console.log('');
 
         const config = loadConfig();
         const csrfToken = await fetchCsrfToken(config);
 
         // Send all files in one request
-        const results = await inspectAllFiles(filesSyntaxCheck, csrfToken, config);
+        const results = await inspectAllFiles(filesSyntaxCheck, csrfToken, config, variant);
 
         // Process results
         for (const result of results) {
@@ -1485,15 +1579,37 @@ Examples:
 
       case 'tree': {
         const packageArgIndex = args.indexOf('--package');
-        if (packageArgIndex === -1 || packageArgIndex + 1 >= args.length) {
+        if (packageArgIndex === -1) {
           console.error('Error: --package parameter required');
           console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
-          console.error('Example: abapgit-agent tree --package $ZMY_PACKAGE');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
+          process.exit(1);
+        }
+
+        // Check if package value is missing (happens when shell variable expands to empty)
+        if (packageArgIndex + 1 >= args.length) {
+          console.error('Error: --package parameter value is missing');
+          console.error('');
+          console.error('Tip: If you are using a shell variable, make sure to quote it:');
+          console.error('  abapgit-agent tree --package "$ZMY_PACKAGE"');
+          console.error('  or escape the $ character:');
+          console.error('  abapgit-agent tree --package \\$ZMY_PACKAGE');
+          console.error('');
+          console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
           process.exit(1);
         }
 
         const packageName = args[packageArgIndex + 1];
 
+        // Check for empty/whitespace-only package name
+        if (!packageName || packageName.trim() === '') {
+          console.error('Error: --package parameter cannot be empty');
+          console.error('Usage: abapgit-agent tree --package <package> [--depth <n>] [--include-objects] [--json]');
+          console.error('Example: abapgit-agent tree --package ZMY_PACKAGE');
+          process.exit(1);
+        }
+
         // Optional depth parameter
         const depthArgIndex = args.indexOf('--depth');
         let depth = 3;
@@ -1726,6 +1842,243 @@ Examples:
         break;
       }
 
+      case 'preview': {
+        const objectsArgIndex = args.indexOf('--objects');
+        if (objectsArgIndex === -1 || objectsArgIndex + 1 >= args.length) {
+          console.error('Error: --objects parameter required');
+          console.error('Usage: abapgit-agent preview --objects <table1>,<view1>,... [--type <type>] [--limit <n>] [--where <condition>] [--columns <cols>] [--vertical] [--compact] [--json]');
+          console.error('Example: abapgit-agent preview --objects SFLIGHT');
+          console.error('Example: abapgit-agent preview --objects ZC_MY_CDS_VIEW --type DDLS');
+          console.error('Example: abapgit-agent preview --objects SFLIGHT --where "CARRID = \'AA\'"');
+          process.exit(1);
+        }
+
+        const objects = args[objectsArgIndex + 1].split(',').map(o => o.trim().toUpperCase());
+        const typeArg = args.indexOf('--type');
+        const type = typeArg !== -1 ? args[typeArg + 1].toUpperCase() : null;
+        const limitArg = args.indexOf('--limit');
+        const limit = limitArg !== -1 ? parseInt(args[limitArg + 1], 10) : 10;
+        const whereArg = args.indexOf('--where');
+        const where = whereArg !== -1 ? args[whereArg + 1] : null;
+        const columnsArg = args.indexOf('--columns');
+        const columns = columnsArg !== -1 ? args[columnsArg + 1].split(',').map(c => c.trim().toUpperCase()) : null;
+        const verticalOutput = args.includes('--vertical');
+        const compactOutput = args.includes('--compact');
+        const jsonOutput = args.includes('--json');
+
+        console.log(`\n  Previewing ${objects.length} object(s)`);
+
+        const config = loadConfig();
+        const csrfToken = await fetchCsrfToken(config);
+
+        const data = {
+          objects: objects,
+          limit: Math.min(Math.max(1, limit), 100)
+        };
+
+        if (type) {
+          data.type = type;
+        }
+
+        if (where) {
+          data.where = where;
+        }
+
+        if (columns) {
+          data.columns = columns;
+        }
+
+        const result = await request('POST', '/sap/bc/z_abapgit_agent/preview', data, { csrfToken });
+
+        // Handle uppercase keys from ABAP
+        const success = result.SUCCESS || result.success;
+        const previewObjects = result.OBJECTS || result.objects || [];
+        const message = result.MESSAGE || result.message || '';
+        const error = result.ERROR || result.error;
+
+        if (!success || error) {
+          console.error(`\n  Error: ${error || 'Failed to preview objects'}`);
+          break;
+        }
+
+        if (jsonOutput) {
+          console.log(JSON.stringify(result, null, 2));
+        } else {
+          console.log(`\n  ${message}`);
+          console.log('');
+
+          // Track if columns were explicitly specified
+          const columnsExplicit = columns !== null;
+
+          for (let i = 0; i < previewObjects.length; i++) {
+            const obj = previewObjects[i];
+            const objName = obj.NAME || obj.name || `Object ${i + 1}`;
+            const objType = obj.TYPE || obj.type || '';
+            const objTypeText = obj.TYPE_TEXT || obj.type_text || '';
+            // Parse rows - could be a JSON string or array
+            let rows = obj.ROWS || obj.rows || [];
+            if (typeof rows === 'string') {
+              try {
+                rows = JSON.parse(rows);
+              } catch (e) {
+                rows = [];
+              }
+            }
+            const fields = obj.FIELDS || obj.fields || [];
+            const rowCount = obj.ROW_COUNT || obj.row_count || 0;
+            const totalRows = obj.TOTAL_ROWS || obj.total_rows || 0;
+            const notFound = obj.NOT_FOUND || obj.not_found || false;
+            const accessDenied = obj.ACCESS_DENIED || obj.access_denied || false;
+
+            // Check if object was not found
+            if (notFound) {
+              console.log(`  ❌ ${objName} (${objTypeText})`);
+              console.log(`     Object not found: ${objName}`);
+              continue;
+            }
+
+            // Check if access denied
+            if (accessDenied) {
+              console.log(`  ❌ ${objName} (${objTypeText})`);
+              console.log(`     Access denied to: ${objName}`);
+              continue;
+            }
+
+            console.log(`  📊 Preview: ${objName} (${objTypeText})`);
+
+            // Check for errors first
+            const objError = obj.ERROR || obj.error;
+            if (objError) {
+              console.log(`     ❌ Error: ${objError}`);
+              continue;
+            }
+
+            if (rows.length === 0) {
+              console.log('     No data found');
+              continue;
+            }
+
+            // Get all unique field names from all rows
+            const allFields = new Set();
+            rows.forEach(row => {
+              Object.keys(row).forEach(key => allFields.add(key));
+            });
+            const allFieldNames = Array.from(allFields);
+
+            // Display as table - use fields metadata only if --columns was explicitly specified
+            let fieldNames;
+            let columnsAutoSelected = false;
+            if (columnsExplicit && fields && fields.length > 0) {
+              // Use fields from metadata (filtered by explicit --columns)
+              fieldNames = fields.map(f => f.FIELD || f.field);
+            } else {
+              // Use all fields - let terminal handle wrapping if needed
+              // Terminal width detection is unreliable without a proper TTY
+              fieldNames = allFieldNames;
+            }
+
+            // Calculate column widths - use reasonable defaults
+            const colWidths = {};
+            const maxColWidth = compactOutput ? 10 : 20;
+            fieldNames.forEach(field => {
+              let maxWidth = field.length;
+              rows.forEach(row => {
+                const value = String(row[field] || '');
+                maxWidth = Math.max(maxWidth, value.length);
+              });
+              // Cap at maxColWidth (truncates both headers and data in compact mode)
+              colWidths[field] = Math.min(maxWidth, maxColWidth);
+            });
+
+            // Render output - either vertical or table
+            if (verticalOutput) {
+              // Vertical format: each field on its own line
+              rows.forEach((row, rowIndex) => {
+                if (rows.length > 1) {
+                  console.log(`\n  Row ${rowIndex + 1}:`);
+                  console.log('  ' + '─'.repeat(30));
+                }
+                fieldNames.forEach(field => {
+                  const value = String(row[field] || '');
+                  console.log(`  ${field}: ${value}`);
+                });
+              });
+              console.log('');
+              continue;
+            }
+
+            // Build table header
+            let headerLine = '  ┌';
+            let separatorLine = '  ├';
+            fieldNames.forEach(field => {
+              const width = colWidths[field];
+              headerLine += '─'.repeat(width + 2) + '┬';
+              separatorLine += '─'.repeat(width + 2) + '┼';
+            });
+            headerLine = headerLine.slice(0, -1) + '┐';
+            separatorLine = separatorLine.slice(0, -1) + '┤';
+
+            // Build header row
+            let headerRow = '  │';
+            fieldNames.forEach(field => {
+              const width = colWidths[field];
+              let displayField = String(field);
+              if (displayField.length > width) {
+                displayField = displayField.slice(0, width - 3) + '...';
+              }
+              headerRow += ' ' + displayField.padEnd(width) + ' │';
+            });
+
+            console.log(headerLine);
+            console.log(headerRow);
+            console.log(separatorLine);
+
+            // Build data rows
+            rows.forEach(row => {
+              let dataRow = '  │';
+              fieldNames.forEach(field => {
+                const width = colWidths[field];
+                const value = String(row[field] || '');
+                const displayValue = value.length > width ? value.slice(0, width - 3) + '...' : value;
+                dataRow += ' ' + displayValue.padEnd(width) + ' │';
+              });
+              console.log(dataRow);
+            });
+
+            // Build bottom border
+            let bottomLine = '  └';
+            fieldNames.forEach(field => {
+              const width = colWidths[field];
+              bottomLine += '─'.repeat(width + 2) + '┴';
+            });
+            bottomLine = bottomLine.slice(0, -1) + '┘';
+            console.log(bottomLine);
+
+            // Show row count
+            if (totalRows > rowCount) {
+              console.log(`\n  Showing ${rowCount} of ${totalRows} rows`);
+            } else {
+              console.log(`\n  ${rowCount} row(s)`);
+            }
+
+            // Note about hidden columns only when --columns was explicitly specified
+            const columnsDisplayed = fieldNames.length;
+            let columnsHidden = [];
+
+            if (columnsExplicit) {
+              columnsHidden = obj.COLUMNS_HIDDEN || obj.columns_hidden || [];
+              if (columnsHidden.length > 0) {
+                console.log(`\n  ⚠️  ${columnsHidden.length} more columns hidden (${columnsHidden.join(', ')})`);
+                console.log('     Use --json for full data');
+              }
+            }
+
+            console.log('');
+          }
+        }
+        break;
+      }
+
       case 'help':
       case '--help':
       case '-h':

package/docs/commands.md

@@ -14,6 +14,7 @@ All available CLI commands for abapGit Agent.
 | [tree](tree-command.md) | ✅ | Display package hierarchy tree |
 | [unit](unit-command.md) | ✅ | Run AUnit tests |
 | [view](view-command.md) | ✅ | View ABAP object source code from system |
+| [preview](preview-command.md) | 🔄 | Preview table/CDS view data |
 | [health](health-command.md) | ✅ | Health check |
 | [status](status-command.md) | ✅ | Status check |
 
@@ -70,6 +71,10 @@ abapgit-agent tree --package $MY_PACKAGE
 abapgit-agent view --objects ZCL_MY_CLASS
 abapgit-agent view --objects SFLIGHT --type TABL
 
+# Preview table/CDS view data
+abapgit-agent preview --objects SFLIGHT
+abapgit-agent preview --objects ZC_MY_CDS_VIEW --type DDLS
+
 # Check configuration
 abapgit-agent status
 

package/docs/inspect-command.md

@@ -15,6 +15,12 @@ abapgit-agent inspect --files zcl_my_class.clas.abap,zcl_other.clas.abap
 
 # With path
 abapgit-agent inspect --files abap/zcl_my_class.clas.abap
+
+# With Code Inspector variant
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant ALL_CHECKS
+
+# With no variant (uses default SAP standard checks)
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant EMPTY
 ```
 
 ## Prerequisite
@@ -27,6 +33,7 @@ abapgit-agent inspect --files abap/zcl_my_class.clas.abap
 | Parameter | Required | Description |
 |-----------|----------|-------------|
 | `--files` | Yes | Comma-separated list of files to inspect |
+| `--variant` | No | Code Inspector variant name (e.g., `ALL_CHECKS`, `EMPTY`) |
 
 ---
 
@@ -54,7 +61,8 @@ GET /health (with X-CSRF-Token: fetch)
 **Request Body:**
 ```json
 {
-  "files": ["ZCL_MY_CLASS.CLASS.ABAP"]
+  "files": ["ZCL_MY_CLASS.CLASS.ABAP"],
+  "variant": "ALL_CHECKS"
 }
 ```
 
@@ -140,6 +148,9 @@ abapgit-agent inspect --files zcl_my_class.clas.abap
 
 # Multiple files
 abapgit-agent inspect --files abap/zcl_my_class.clas.abap,abap/zcl_other.clas.abap
+
+# With Code Inspector variant
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap --variant ALL_CHECKS
 ```
 
 ## Use Case