abapgit-agent 1.19.0 → 1.19.2

package/abap/guidelines/abapgit-xml-only.md

@@ -6,9 +6,9 @@ parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---
 
-# abapGit XML Metadata — XML-Only Objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG, SUSO)
+# abapGit XML Metadata — XML-Only Objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG, SUSO, PINF)
 
-XML templates for ABAP Dictionary objects that have no `.abap` source file — TABL, STRU, DTEL, TTYP, DOMA, message classes (MSAG), and authorization objects (SUSO).
+XML templates for ABAP Dictionary objects that have no `.abap` source file — TABL, STRU, DTEL, TTYP, DOMA, message classes (MSAG), authorization objects (SUSO), and package interfaces (PINF).
 
 > **CRITICAL: Always write XML files with a UTF-8 BOM (`\ufeff`) as the very first character**, before `<?xml ...`.
 > Without the BOM, abapGit shows the object as **"M" (modified)** after every pull.
@@ -19,7 +19,7 @@ XML templates for ABAP Dictionary objects that have no `.abap` source file — T
 > **For CLAS, INTF, PROG, DDLS, DCLS, FUGR** (have source files): see `abapgit-agent ref --topic abapgit`
 > **For DDLS, DCLS** (CDS — have source files): also see `abapgit-agent ref --topic abapgit`
 
-**Searchable keywords**: table xml, structure xml, data element xml, table type xml, domain xml, message class xml, tabl, stru, dtel, ttyp, doma, msag, suso, authorization object, dictionary
+**Searchable keywords**: table xml, structure xml, data element xml, table type xml, domain xml, message class xml, tabl, stru, dtel, ttyp, doma, msag, suso, authorization object, dictionary, pinf, package interface
 
 ---
 
@@ -511,3 +511,52 @@ abapGit uses the view `DD01V` as the root element (not `DD01L`). The serializer
 **Note**: Authorization objects (SUSO) are the SU21 objects that group authorization fields (AUTH/SU20)
 together. An object like `AUD_SCOPEM` uses fields `ACTVT`, `BO_SERVICE`, and `AUD_GROUP`.
 
+---
+
+### Package Interface (PINF)
+
+**Filename**: `src/zmy_pinf.pinf.xml`
+
+> Pull with: `pull --files src/zmy_pinf.pinf.xml`
+>
+> View with: `view --objects ZMY_PINF --type PINF`
+
+A package interface declares which objects a package makes visible to other packages — it is the "API" of an ABAP package. Packages that use these objects must depend on the package that owns the interface.
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_PINF" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <PINF>
+    <ATTRIBUTES>
+     <INTF_NAME>ZMY_PINF</INTF_NAME>
+     <DESCRIPT>Package interface for ZMY</DESCRIPT>
+    </ATTRIBUTES>
+    <ELEMENTS>
+     <SCOMELDTLN>
+      <INTF_NAME>ZMY_PINF</INTF_NAME>
+      <ELEM_TYPE>CLAS</ELEM_TYPE>
+      <ELEM_KEY>ZCL_MY_CLASS</ELEM_KEY>
+     </SCOMELDTLN>
+     <SCOMELDTLN>
+      <INTF_NAME>ZMY_PINF</INTF_NAME>
+      <ELEM_TYPE>INTF</ELEM_TYPE>
+      <ELEM_KEY>ZIF_MY_INTERFACE</ELEM_KEY>
+     </SCOMELDTLN>
+    </ELEMENTS>
+   </PINF>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+**Key Fields**:
+- `ATTRIBUTES/INTF_NAME`: Package interface name (max 30 chars, stored in `SCOMPARAMET.INTF_NAME`)
+- `ATTRIBUTES/DESCRIPT`: Description text
+- `ELEMENTS/SCOMELDTLN`: One entry per exported object; each has:
+  - `INTF_NAME`: Same as the interface name (repeated on every row)
+  - `ELEM_TYPE`: Object type — `CLAS`, `INTF`, `DTEL`, `TABL`, `STRU`, `TTYP`, `DOMA`, `SUSO`, `ENQU`, `STOB`, `VIEW`
+  - `ELEM_KEY`: Object name
+
+**Note**: No UTF-8 BOM — unlike TABL/DTEL/MSAG, the PINF serializer (`LCL_OBJECT_PINF`) does not write a BOM. Do not add `\ufeff` before `<?xml ...>`.

package/abap/guidelines/naming-limits.md

@@ -42,6 +42,8 @@ grand_parent: ABAP Development
 | Local variable name | **30** |
 | Local type/class name | **30** |
 | Test class name (local) | **30** |
+| Package Interface name (PINF) | **30** |
+| **Authorization Object name (SUSO)** | **10** |
 
 ---
 
@@ -150,6 +152,8 @@ These limits come from the ABAP Dictionary (DDIC) and ABAP kernel:
 | 40 chars (CDS names) | CDS objects stored in `DD02L.TABNAME CHAR(40)` — intentionally larger for CDS |
 | 20 chars (MSAG) | Message class name stored in `T100A.ARBGB CHAR(20)` |
 | 26 chars (FUGR) | Function group internally prefixed with `SAPL` (4 chars) for the main include |
+| **10 chars (SUSO)** | Authorization object name stored in `TOBJ.OBJCT CHAR(10)` — notably shorter than other types |
+| 30 chars (PINF) | Package interface name stored in `SCOMPARAMET.INTF_NAME CHAR(30)` |
 
 ---
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abapgit-agent",
-  "version": "1.19.0",
+  "version": "1.19.2",
   "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
   "files": [
     "bin/",

package/src/commands/drop.js

@@ -8,7 +8,8 @@ const { printHttpError } = require('../utils/format-error');
 const EXT_TO_TYPE = {
   clas: 'CLAS', intf: 'INTF', prog: 'PROG', fugr: 'FUGR',
   tabl: 'TABL', dtel: 'DTEL', ttyp: 'TTYP', doma: 'DOMA',
-  ddls: 'DDLS', dcls: 'DCLS', msag: 'MSAG', stru: 'STRU', enho: 'ENHO'
+  ddls: 'DDLS', dcls: 'DCLS', msag: 'MSAG', stru: 'STRU', enho: 'ENHO',
+  suso: 'SUSO'
 };
 
 /**

package/src/commands/inspect.js

@@ -48,8 +48,10 @@ function buildInspectJUnit(results) {
 
     const testcases = [];
 
+    const inspectClass = `${escapeXml(objectName)}.Inspect`;
+
     if (errorCount === 0 && warnCount === 0) {
-      testcases.push(`    <testcase name="Inspect / Syntax check" classname="${escapeXml(objectName)}"/>`);
+      testcases.push(`    <testcase name="Syntax check" classname="${inspectClass}"/>`);
     }
 
     for (const err of errors) {
@@ -67,9 +69,9 @@ function buildInspectJUnit(results) {
         text
       ].filter(Boolean).join('\n');
       const checkId  = checkClass && checkCode ? `${checkClass}/${checkCode}` : null;
-      const caseName = checkId ? `Inspect / ${checkId}` : (methodName ? `${methodName} line ${line}` : `Line ${line}`);
+      const caseName = checkId ? checkId : (methodName ? `${methodName} line ${line}` : `Line ${line}`);
       testcases.push(
-        `    <testcase name="${escapeXml(caseName)}" classname="${escapeXml(objectName)}">\n` +
+        `    <testcase name="${escapeXml(caseName)}" classname="${inspectClass}">\n` +
         `      <failure type="SyntaxError" message="${escapeXml(text)}">${escapeXml(detail)}</failure>\n` +
         `    </testcase>`
       );
@@ -89,9 +91,9 @@ function buildInspectJUnit(results) {
         text
       ].filter(Boolean).join('\n');
       const checkId  = checkClass && checkCode ? `${checkClass}/${checkCode}` : null;
-      const caseName = checkId ? `Inspect / ${checkId}` : (methodName ? `${methodName} line ${line}` : `Line ${line}`);
+      const caseName = checkId ? checkId : (methodName ? `${methodName} line ${line}` : `Line ${line}`);
       testcases.push(
-        `    <testcase name="${escapeXml(caseName)}" classname="${escapeXml(objectName)}">\n` +
+        `    <testcase name="${escapeXml(caseName)}" classname="${inspectClass}">\n` +
         `      <failure type="Warning" message="${escapeXml(text)}">${escapeXml(detail)}</failure>\n` +
         `    </testcase>`
       );
@@ -427,6 +429,20 @@ Examples:
 
     let filesSyntaxCheck = [...new Set(args[filesArgIndex + 1].split(',').map(f => f.trim()))];
 
+    // Skip XML-only object types that have no ABAP source to inspect
+    const XML_ONLY_EXTENSIONS = [
+      '.pinf.xml', '.suso.xml', '.msag.xml', '.doma.xml',
+      '.dtel.xml', '.ttyp.xml', '.tabl.xml',
+    ];
+    const beforeXmlOnly = filesSyntaxCheck.length;
+    filesSyntaxCheck = filesSyntaxCheck.filter(f => {
+      const lower = pathModule.basename(f).toLowerCase();
+      return !XML_ONLY_EXTENSIONS.some(ext => lower.endsWith(ext));
+    });
+    if (beforeXmlOnly > filesSyntaxCheck.length && !args.includes('--json')) {
+      console.log(`  Skipped ${beforeXmlOnly - filesSyntaxCheck.length} XML-only file(s) (no source to inspect)`);
+    }
+
     // Parse optional --variant parameter; fall back to project config
     const variantArgIndex = args.indexOf('--variant');
     const variantArg = variantArgIndex !== -1 ? args[variantArgIndex + 1] : null;

package/src/commands/unit.js

@@ -158,6 +158,9 @@ function buildUnitJUnit(results) {
     const failedMethods = methods.filter(m => !m.passed);
     const syntheticFailures = thresholdFailure ? 1 : 0;
     const totalFailures = failedMethods.length + syntheticFailures;
+    // classname "ZCL_MY_TEST.LTCL_UNIT_TEST" groups under the same ABAP class node
+    // as "ZCL_MY_TEST.Inspect" from the inspect report — one node per ABAP class.
+    const suiteLabel = className;
 
     const lines = [];
 
@@ -170,13 +173,12 @@ function buildUnitJUnit(results) {
     }
 
     if (testCount === 0) {
-      lines.push(`    <testcase name="(no tests)" classname="${escapeXml(className)}"/>`);
+      lines.push(`    <testcase name="(no tests)" classname="${escapeXml(suiteLabel)}"/>`);
     } else {
       for (const m of methods) {
         const timeAttr = m.executionTime != null ? ` time="${m.executionTime}"` : '';
-        // Use "ZCL_MY_TEST.LTCL_UNIT_TEST" so Jenkins groups by ABAP class first,
-        // then local test class — giving a clear package hierarchy in the test report.
-        const testClass = m.testClassName ? `${className}.${m.testClassName}` : className;
+        // "Unit Tests / ZCL_MY_TEST.LTCL_UNIT_TEST" groups by namespace → class → local test class.
+        const testClass = m.testClassName ? `${suiteLabel}.${m.testClassName}` : suiteLabel;
         if (m.passed) {
           lines.push(`    <testcase name="${escapeXml(m.name)}" classname="${escapeXml(testClass)}"${timeAttr}/>`);
         } else {
@@ -195,14 +197,14 @@ function buildUnitJUnit(results) {
 
     if (thresholdFailure) {
       lines.push(
-        `    <testcase name="coverage_threshold" classname="${escapeXml(className)}">\n` +
+        `    <testcase name="coverage_threshold" classname="${escapeXml(suiteLabel)}">\n` +
         `      <failure type="FAILURE" message="${escapeXml(thresholdFailure)}">${escapeXml(thresholdFailure)}</failure>\n` +
         `    </testcase>`
       );
     }
 
     return (
-      `  <testsuite name="${escapeXml(className)}" ` +
+      `  <testsuite name="${escapeXml(suiteLabel)}" ` +
       `tests="${Math.max(testCount + syntheticFailures, 1)}" failures="${totalFailures}" errors="0">\n` +
       lines.join('\n') + '\n' +
       `  </testsuite>`

package/src/commands/view.js

@@ -593,6 +593,50 @@ Examples:
                 console.log(`   ${desc}`);
               }
             }
+          } else if (objType === 'PINF' || objType === 'Package Interface') {
+            // PINF: description box, then members grouped by type
+            const description = obj.DESCRIPTION || obj.description || '';
+            const devclass    = obj.DEVCLASS    || obj.devclass    || '';
+            const boxWidth = 50;
+            const boxTop = '  ┌' + '─'.repeat(boxWidth) + '┐';
+            const boxBot = '  └' + '─'.repeat(boxWidth) + '┘';
+            const boxRow = (text) => '  │ ' + String(text || '').substring(0, boxWidth - 2).padEnd(boxWidth - 2) + ' │';
+
+            console.log(`  PACKAGE INTERFACE ${objName}:`);
+            console.log(boxTop);
+            if (description) console.log(boxRow(description));
+            if (devclass)    console.log(boxRow(`Package: ${devclass}`));
+            console.log(boxBot);
+
+            // Parse components: DESCRIPTION = "ELEM_TYPE: ELEM_KEY"
+            const members = components.map(c => {
+              const desc = String(c.DESCRIPTION || c.description || '');
+              const colonIdx = desc.indexOf(': ');
+              return colonIdx !== -1
+                ? { type: desc.substring(0, colonIdx), key: desc.substring(colonIdx + 2) }
+                : { type: '?', key: desc };
+            });
+
+            if (members.length > 0) {
+              // Group by type, preserving order of first occurrence
+              const groups = [];
+              const seen = new Map();
+              for (const m of members) {
+                if (!seen.has(m.type)) { seen.set(m.type, []); groups.push(m.type); }
+                seen.get(m.type).push(m.key);
+              }
+              console.log('');
+              console.log(`  Members (${members.length}):`);
+              for (const type of groups) {
+                for (const key of seen.get(type)) {
+                  console.log(`    ${type.padEnd(6)}  ${key}`);
+                }
+              }
+            } else {
+              console.log('');
+              console.log('  (no members)');
+            }
+
           } else if (objType === 'SUSO' || objType === 'Authorization Object') {
             // SUSO: property box for object class + fields, then activities list
             const classComp = components.filter(c => String(c.FIELD || c.field || '').startsWith('OCLSS'));