abapgit-agent 1.17.1 → 1.17.3

package/.abapGitAgent.example

@@ -8,5 +8,12 @@
   "protocol": "https",
   "gitUsername": "github-username",
   "gitPassword": "github-token",
-  "referenceFolder": "~/abap-reference"
+  "referenceFolder": "~/abap-reference",
+
+  "testRepos": {
+    "pull":      "https://github.com/your-org/abgagt-pull-test.git",
+    "drop":      "https://github.com/your-org/abgagt-drop-test.git",
+    "customize": "https://github.com/your-org/abgagt-customize-test.git",
+    "lifecycle": "https://github.com/your-org/abgagt-lifecycle-test.git"
+  }
 }

package/.abapgit-agent.example.json

@@ -0,0 +1,19 @@
+{
+  "project": {
+    "name": "MY_PACKAGE",
+    "description": ""
+  },
+
+  "safeguards": {
+    "requireFilesForPull": false,
+    "disablePull": false,
+    "disableRun": false,
+    "disableImport": false,
+    "requireImportMessage": false,
+    "disableProbeClasses": false
+  },
+
+  "conflictDetection": {
+    "mode": "abort"
+  }
+}

package/README.md

@@ -45,7 +45,7 @@ abapgit-agent import
 abapgit-agent pull
 ```
 
-See [Creating New ABAP Projects](INSTALL.md#creating-new-abap-projects) to set up a new ABAP repository with Claude Code integration.
+See [Creating New ABAP Projects](docs/install.md#creating-new-abap-projects) to set up a new ABAP repository with Claude Code integration.
 
 ## CLI Commands
 
@@ -99,25 +99,38 @@ abapgit-agent health                  # Verify ABAP connection
 # Install dependencies
 npm install
 
-# Run unit tests (no ABAP system needed)
-npm test
-
 # Test a command manually
 node bin/abapgit-agent --help
 node bin/abapgit-agent syntax --files src/zcl_my_class.clas.abap
+```
 
-# Run integration tests against a real ABAP system (requires .abapGitAgent)
-npm run test:integration
+## Running Tests
+
+```bash
+# Unit tests — no ABAP system needed (fast)
+npm test
+
+# Integration tests — requires a configured .abapGitAgent
+npm run test:setup   # one-time setup: clone test repos + activate ABAP objects
+npm run test:all     # full suite (setup runs automatically on first run)
+
+# Run a single suite
+npm run test:cmd         # CLI command tests
+npm run test:drop        # drop command tests
+npm run test:customize   # customize command tests
+npm run test:aunit       # ABAP unit tests
 ```
 
+> **Full integration test guide:** [docs/integration-tests.md](docs/integration-tests.md)
+
 ## Documentation
 
 | Topic | File |
 |-------|------|
 | Full Documentation | [https://sylvoscai.github.io/abapgit-agent/](https://sylvoscai.github.io/abapgit-agent/) |
-| Installation & Setup | [INSTALL.md](INSTALL.md) |
+| Installation & Setup | [docs/install.md](docs/install.md) |
 | All Commands Overview | [docs/commands.md](docs/commands.md) |
-| REST API Reference | [API.md](API.md) |
+| REST API Reference | [docs/api.md](docs/api.md) |
 
 ## Dependent Projects
 

package/abap/guidelines/run-probe-classes.md

@@ -63,5 +63,14 @@ User asks to create a probe class
 
 ### When `disableProbeClasses = true` and `scratchWorkspace` is NOT configured
 
-Refuse and tell the user to configure `scratchWorkspace` in `.abapGitAgent`.
-→ See `docs/run-command.md` (Scratch Workspace section) for setup instructions.
+Refuse and tell the user to configure `scratchWorkspace` in `.abapGitAgent`:
+
+```json
+{
+  "scratchWorkspace": {
+    "path": "/absolute/path/to/scratch-repo"
+  }
+}
+```
+
+The path must point to a separate git repo initialized with `abapgit-agent init --package <SCRATCH_PACKAGE>`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abapgit-agent",
-  "version": "1.17.1",
+  "version": "1.17.3",
   "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
   "files": [
     "bin/",
@@ -10,7 +10,8 @@
     "abap/CLAUDE.slim.md",
     "abap/.github/copilot-instructions.md",
     "abap/.github/copilot-instructions.slim.md",
-    ".abapGitAgent.example"
+    ".abapGitAgent.example",
+    ".abapgit-agent.example.json"
   ],
   "bin": {
     "abapgit-agent": "bin/abapgit-agent",
@@ -19,6 +20,7 @@
   "scripts": {
     "test": "jest",
     "test:all": "node tests/run-all.js",
+    "test:setup": "node tests/run-all.js --setup",
     "test:unit": "jest",
     "test:jest": "jest",
     "test:integration": "node tests/run-all.js --cmd",

package/src/commands/init.js

@@ -129,7 +129,7 @@ Usage:
 
 Description:
   Initialize local repository configuration.
-  Creates .abapGitAgent, .abapgit.xml, .gitignore, CLAUDE.md, and guidelines folder.
+  Creates .abapGitAgent, .abapgit-agent.json, .abapgit.xml, .gitignore, CLAUDE.md, and guidelines folder.
 
 Options:
   --package <PACKAGE>             ABAP package name (required)
@@ -562,11 +562,32 @@ Uncomment and edit the rows that differ from the defaults in \`guidelines/object
       console.log(`✅ .abapgit.xml already exists, skipped`);
     }
 
+    // Create .abapgit-agent.json with default values (team config, checked into git)
+    const projectConfigPath = pathModule.join(process.cwd(), '.abapgit-agent.json');
+    if (!fs.existsSync(projectConfigPath)) {
+      const projectConfigSamplePath = pathModule.join(__dirname, '..', '..', '.abapgit-agent.example.json');
+      if (!fs.existsSync(projectConfigSamplePath)) {
+        console.error('Error: .abapgit-agent.example.json not found.');
+        process.exit(1);
+      }
+      try {
+        const projectConfig = JSON.parse(fs.readFileSync(projectConfigSamplePath, 'utf8'));
+        projectConfig.project.name = packageName;
+        fs.writeFileSync(projectConfigPath, JSON.stringify(projectConfig, null, 2) + '\n');
+        console.log(`✅ Created .abapgit-agent.json (team config — commit this to git)`);
+      } catch (error) {
+        console.error(`Error creating .abapgit-agent.json: ${error.message}`);
+      }
+    } else {
+      console.log(`✅ .abapgit-agent.json already exists, skipped`);
+    }
+
     console.log(`
 📋 Next steps:
    1. Edit .abapGitAgent with your ABAP credentials (host, user, password)
-   2. Run 'abapgit-agent create --import' to create online repository
-   3. Run 'abapgit-agent pull' to activate objects
+   2. Review .abapgit-agent.json and commit it to git (team settings)
+   3. Run 'abapgit-agent create --import' to create online repository
+   4. Run 'abapgit-agent pull' to activate objects
 
 💡 Tips:
    • Only guidelines/objects.local.md needs to live in your repo.

package/src/commands/lint.js

@@ -59,13 +59,13 @@ Examples:
     // ── Resolve changed files ─────────────────────────────────────────────────
     let abapFiles;
     if (filesArg) {
-      abapFiles = filesArg.split(',').map(f => f.trim()).filter(f => f.endsWith('.abap'));
+      abapFiles = filesArg.split(',').map(f => f.trim()).filter(f => isLintable(f) && fs.existsSync(f));
     } else {
       abapFiles = detectChangedAbapFiles(baseBranch);
     }
 
     if (abapFiles.length === 0) {
-      console.log('No changed .abap files found — nothing to lint.');
+      console.log('No changed .abap/.asddls files found — nothing to lint.');
       return;
     }
 
@@ -102,34 +102,29 @@ Examples:
     // keep <file> blocks for the originally changed files — suppressing any
     // pre-existing issues in dependency files that were not part of this change.
     try {
-      if (outformat === 'checkstyle') {
-        // Run to a temp file, filter, then write to the final destination.
-        const tempOut = '.abaplint-raw.xml';
-        const abapFilesSet = new Set(abapFiles.map(f => path.resolve(f)));
-        try {
-          const result = spawnSync(
-            `npx @abaplint/cli@latest ${scopedConfig} --outformat checkstyle --outfile ${tempOut}`,
-            { stdio: 'pipe', shell: true }
-          );
-          const raw = fs.existsSync(tempOut) ? fs.readFileSync(tempOut, 'utf8') : '<checkstyle version="8.0"/>';
-          const filtered = filterCheckstyleToFiles(raw, abapFilesSet);
+      const tempOut = '.abaplint-raw.xml';
+      const abapFilesSet = new Set(abapFiles.map(f => path.resolve(f)));
+      try {
+        spawnSync(
+          `npx @abaplint/cli@latest ${scopedConfig} --outformat checkstyle --outfile ${tempOut}`,
+          { stdio: 'pipe', shell: true }
+        );
+        const raw = fs.existsSync(tempOut) ? fs.readFileSync(tempOut, 'utf8') : '<checkstyle version="8.0"/>';
+        const filtered = filterCheckstyleToFiles(raw, abapFilesSet);
+        if (outformat === 'checkstyle') {
           if (outfile) {
             fs.writeFileSync(outfile, filtered);
           } else {
             process.stdout.write(filtered);
           }
-          const issueCount = (filtered.match(/<error /g) || []).length;
-          if (issueCount > 0) process.exitCode = 1;
-        } finally {
-          if (fs.existsSync(tempOut)) fs.unlinkSync(tempOut);
+        } else {
+          // Interactive: print issues as human-readable text, scoped to changed files only.
+          printCheckstyleAsText(filtered);
         }
-      } else {
-        // Interactive: inherit stdio so abaplint's human-readable output flows through.
-        const result = spawnSync(
-          `npx @abaplint/cli@latest ${scopedConfig}`,
-          { stdio: 'inherit', shell: true }
-        );
-        if (result.status !== 0) process.exitCode = result.status;
+        const issueCount = (filtered.match(/<error /g) || []).length;
+        if (issueCount > 0) process.exitCode = 1;
+      } finally {
+        if (fs.existsSync(tempOut)) fs.unlinkSync(tempOut);
       }
     } finally {
       fs.unlinkSync(scopedConfig);
@@ -156,12 +151,12 @@ function detectChangedAbapFiles(baseBranch) {
 
   let diffCmd;
   if (base) {
-    diffCmd = `git diff --name-only ${base}...HEAD -- '*.abap'`;
+    diffCmd = `git diff --name-only ${base}...HEAD -- '*.abap' '*.asddls'`;
   } else {
     // Fall back to uncommitted changes first, then last commit
-    const uncommitted = runGit('git diff --name-only HEAD -- *.abap').filter(Boolean);
+    const uncommitted = runGit(`git diff --name-only HEAD -- '*.abap' '*.asddls'`).filter(Boolean);
     if (uncommitted.length > 0) return filterAbapFiles(uncommitted);
-    diffCmd = `git diff --name-only HEAD~1 HEAD -- '*.abap'`;
+    diffCmd = `git diff --name-only HEAD~1 HEAD -- '*.abap' '*.asddls'`;
   }
 
   return filterAbapFiles(runGit(diffCmd));
@@ -190,7 +185,7 @@ function buildFileIndex(abapDir) {
       const full = path.join(dir, entry.name);
       if (entry.isDirectory()) {
         walk(full);
-      } else if (entry.name.endsWith('.abap') || entry.name.endsWith('.xml')) {
+      } else if (entry.name.endsWith('.abap') || entry.name.endsWith('.xml') || entry.name.endsWith('.asddls')) {
         index.set(entry.name.toLowerCase(), full);
       }
     }
@@ -304,13 +299,47 @@ function filterCheckstyleToFiles(xml, abapFilesSet) {
 }
 
 /**
- * Keep only files that look like ABAP source files
- * (name.type.abap or name.type.subtype.abap).
+ * Print checkstyle XML as human-readable text, mirroring abaplint's default output format:
+ *   path/to/file.clas.abap:line - severity - message (rule)
+ */
+function printCheckstyleAsText(xml) {
+  const fileRe  = /<file\s+name="([^"]*)"([\s\S]*?)<\/file>/g;
+  const errorRe = /<error\s+[^>]*line="(\d+)"[^>]*severity="([^"]*)"[^>]*message="([^"]*)"[^>]*source="([^"]*)"/g;
+  let fileMatch;
+  let issueCount = 0;
+  while ((fileMatch = fileRe.exec(xml)) !== null) {
+    const filePath = fileMatch[1];
+    const block    = fileMatch[2];
+    errorRe.lastIndex = 0;
+    let errMatch;
+    while ((errMatch = errorRe.exec(block)) !== null) {
+      const [, line, severity, message, source] = errMatch;
+      const rule = source.split('.').pop();
+      const text = message.replace(/&amp;/g, '&').replace(/&quot;/g, '"').replace(/&lt;/g, '<').replace(/&gt;/g, '>').replace(/&#39;/g, "'");
+      console.log(`${filePath}:${line} - ${severity} - ${text} (${rule})`);
+      issueCount++;
+    }
+  }
+  if (issueCount === 0) {
+    console.log('No issues found.');
+  }
+}
+
+/**
+ * Returns true if the file is a type abaplint can analyse.
+ * - .abap — all ABAP source files (CLAS, INTF, PROG, FUGR, ENHO, etc.)
+ * - .asddls — CDS view / view entity sources (DDLS)
+ */
+function isLintable(f) {
+  const lower = f.toLowerCase();
+  return lower.endsWith('.abap') || lower.endsWith('.asddls');
+}
+
+/**
+ * Keep only lintable files (name.type.abap / name.type.subtype.abap / name.ddls.asddls)
+ * that still exist on disk. Deleted files appear in git diff output but must not
+ * be passed to abaplint.
  */
 function filterAbapFiles(files) {
-  return files.filter(f => {
-    const parts = path.basename(f).split('.');
-    return (parts.length === 3 || parts.length === 4) &&
-           parts[parts.length - 1].toLowerCase() === 'abap';
-  });
+  return files.filter(f => isLintable(f) && fs.existsSync(f));
 }

package/src/utils/backgroundJobPoller.README.md

@@ -215,4 +215,4 @@ npm test -- tests/unit/backgroundJobPoller.test.js
 
 - [Background Job Architecture](../../docs/architecture/README.md) - Complete architecture documentation
 - [Import Command](../commands/import.js) - Reference implementation
-- [API Documentation](../../API.md) - REST API for async commands
+- [API Documentation](../../docs/api.md) - REST API for async commands