abapgit-agent 1.15.1 → 1.15.3

package/abap/.github/copilot-instructions.slim.md

@@ -36,8 +36,14 @@ The folder is configured in `.abapGitAgent` (property: `folder`):
 
 Each ABAP object needs an XML metadata file. Local helper/test-double classes use separate `.locals_def.abap` / `.locals_imp.abap` files.
 
+**Name length limits** (verify before naming anything):
+- CLAS, INTF: name **30 chars** | method names: **30 chars**
+- TABL, STRU: name **30 chars** | **field names: 16 chars** ← most common mistake
+- DDLS (CDS view entity): **40 chars** | field alias: 30 | FUGR: 26 | MSAG: 20 | PROG/DTEL/DOMA/TTYP: 30
+
 ```bash
-abapgit-agent ref --topic object-creation   # XML templates and local class setup
+abapgit-agent ref --topic naming-limits    # full length reference
+abapgit-agent ref --topic object-creation  # XML templates and local class setup
 ```
 
 ### 4. Use Syntax Command Before Commit (for CLAS, INTF, PROG, DDLS)
@@ -65,6 +71,24 @@ abapgit-agent ref --topic debug-session       # full debug guide
 abapgit-agent ref --topic debug-dump          # dump analysis guide
 ```
 
+### 7. Never Run `run` Command Proactively
+
+Never call `abapgit-agent run` unless the user explicitly asks — it can modify data or trigger RFCs.
+
+### 8. Probe and PoC Objects — Always Z/Y, Never in SAP Packages
+
+When `objects.local.md` shows SAP namespace (`CL_*`, `IF_*`, `/NAMESPACE/*`) and the user asks to create a new object, always ask first: *"Is this a production object, a PoC, or a probe?"*
+
+→ `abapgit-agent ref --topic probe-poc`
+
+### 9. abaplint — Optional, Project-Controlled
+
+Only run if `.abaplint.json` exists. Run after `syntax`, before commit. Always check `ref --topic abaplint` before applying any quickfix.
+
+```bash
+ls .abaplint.json 2>/dev/null && abapgit-agent lint
+```
+
 ---
 
 ## Development Workflow
@@ -77,6 +101,8 @@ Checked into the repository — applies to all developers. **Read this file at t
 |---------|--------|
 | `safeguards.requireFilesForPull: true` | Always include `--files` in every `pull` |
 | `safeguards.disablePull: true` | Do not run `abapgit-agent pull` at all |
+| `safeguards.disableRun: true` | Do not run `abapgit-agent run` at all |
+| `safeguards.disableProbeClasses: true` | Use `scratchWorkspace` for probe classes instead |
 | `conflictDetection.mode: "abort"` | Abort pull on conflict — inform user |
 | `transports.allowCreate/allowRelease: false` | Blocked — inform user |
 
@@ -97,10 +123,15 @@ abapgit-agent ref --topic branch-workflow
 ```
 Modified ABAP files?
 ├─ CLAS/INTF/PROG/DDLS files?
-│  ├─ Independent files?  → syntax → commit → push → pull
-│  └─ Dependent files?    → skip syntax → commit → push → pull
+│  ├─ Independent files?  → syntax → [abaplint] → commit → push → pull --sync-xml
+│  └─ Dependent files?    → skip syntax → [abaplint] → commit → push → pull --sync-xml
 └─ Other types (FUGR, TABL, etc.)?
-   → skip syntax → commit → push → pull → (if errors: inspect)
+   ├─ XML-only (TABL, STRU, DTEL, TTYP, DOMA, MSAG)?
+   │  → skip syntax → [abaplint] → commit → push → pull --files <name>.tabl.xml --sync-xml
+   └─ FUGR and others?
+      → skip syntax → [abaplint] → commit → push → pull --sync-xml → (if errors: inspect)
+
+[abaplint] = run lint only if .abaplint.json exists; ref --topic abaplint before any quickfix
 ```
 
 ```bash

package/abap/CLAUDE.md

@@ -1,11 +1,11 @@
 ---
 layout: default
-title: Claude Code Instructions (Template)
+title: AI Agent Instructions
 nav_order: 1
 parent: ABAP Development
 ---
 
-# Claude Code Instructions - Template
+# AI Agent Instructions
 
 This file provides guidelines for **generating ABAP code** in abapGit repositories.
 
@@ -99,6 +99,20 @@ Never assume Z/Y prefix without checking.
            XML-only objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG) need ONLY the XML file
 ```
 
+**Before choosing a name, verify the length limit for the object type:**
+
+| Object type | Name limit | Field/sub-element limit |
+|---|---|---|
+| CLAS, INTF | **30 chars** | method names: **30 chars** |
+| TABL, STRU | **30 chars** | **field names: 16 chars** |
+| DDLS (CDS view entity) | **40 chars** | field alias: **30 chars** |
+| DCLS (CDS access control) | **40 chars** | — (name must match its DDLS view) |
+| FUGR (function group) | **26 chars** | function module name: **30 chars** |
+| MSAG (message class) | **20 chars** | — |
+| PROG, DTEL, DOMA, TTYP | **30 chars** | — |
+
+→ Full length reference: `abapgit-agent ref --topic naming-limits`
+
 Use the object name from `objects.local.md` (or `objects.md` as fallback) in place of `<name>`:
 
 | Object Type | Source File | XML File |
@@ -110,7 +124,7 @@ Use the object name from `objects.local.md` (or `objects.md` as fallback) in pla
 | CDS Access Control (DCLS) | `<name>.dcls.asdcls` | `<name>.dcls.xml` |
 | Function Group (FUGR) | `<name>.fugr.abap` + includes | `<name>.fugr.xml` |
 | Table (TABL) | *(none)* | `<name>.tabl.xml` |
-| Structure (STRU) | *(none)* | `<name>.stru.xml` |
+| Structure (STRU) | *(none)* | `<name>.tabl.xml` ⚠️ NOT `.stru.xml` |
 | Data Element (DTEL) | *(none)* | `<name>.dtel.xml` |
 | Table Type (TTYP) | *(none)* | `<name>.ttyp.xml` |
 | Domain (DOMA) | *(none)* | `<name>.doma.xml` |
@@ -143,7 +157,7 @@ Anything else (SAP namespace object, or SAP-delivered package)?
 
         Object:   <NAME> (<Type>)
         Package:  <PACKAGE>
-        Files:    <folder>/<name>.<ext>.abap
+        Files:    <folder>/<name>.<ext>.abap    ← omit this line for XML-only types (TABL/STRU/DTEL/TTYP/DOMA/MSAG)
                   <folder>/<name>.<ext>.xml
 
       Shall I proceed?"
@@ -157,10 +171,11 @@ Anything else (SAP namespace object, or SAP-delivered package)?
 ```
 
 > **Tip for project setup**: Add package rules to `objects.local.md` so Claude never
-> needs to ask. See `guidelines/objects.md` for examples.
+> needs to ask. Run: `abapgit-agent ref --topic objects`
 
 → For exact XML templates: `abapgit-agent ref --topic abapgit` (CLAS/INTF/PROG/DDLS/DCLS/FUGR) or `abapgit-agent ref --topic abapgit-xml-only` (TABL/STRU/DTEL/TTYP/DOMA/MSAG)
 → For local helper/test-double class files: `abapgit-agent ref --topic object-creation`
+→ For documentation comment format (shorttext, @parameter, CDS): `abapgit-agent ref --topic comments`
 
 ---
 
@@ -213,9 +228,15 @@ abapgit-agent pull --files src/<intf_name>.intf.abap,src/<class_name>.clas.abap
 
 ### 5. Local Helper / Test-Double Classes
 
-→ See `guidelines/object-creation.md` — run: `abapgit-agent ref --topic object-creation`
+When a class needs local helper classes or test doubles, create separate include files alongside the main class file:
 
-**XML metadata when adding test classes:**
+```
+<name>.clas.locals_def.abap   ← local type/class definitions
+<name>.clas.locals_imp.abap   ← local class implementations
+<name>.clas.testclasses.abap  ← unit test classes (FOR TESTING)
+```
+
+**XML metadata when adding these files:**
 
 ```
 Adding .clas.testclasses.abap to an existing class?
@@ -228,6 +249,7 @@ Adding .clas.locals_def.abap (local type definitions)?
         <CLSCCINCL>X</CLSCCINCL>
 ```
 
+→ For exact XML flag placement and test double class patterns: `abapgit-agent ref --topic object-creation`
 → For exact XML flag placement: `abapgit-agent ref --topic abapgit` (search "WITH_UNIT_TESTS")
 
 ---
@@ -330,8 +352,11 @@ AI thought process:
 
 ### 7. CDS Unit Tests
 
-Use `CL_CDS_TEST_ENVIRONMENT` for unit tests that read CDS views.
-→ See `guidelines/cds-testing.md` — run: `abapgit-agent ref --topic cds-testing`
+If a class under test reads a CDS view, use `CL_CDS_TEST_ENVIRONMENT` to provide test data — do **not** mock the database layer manually. Without this, test data setup is unreliable and tests may pass locally but fail on other systems.
+
+**Trigger**: your class calls `SELECT FROM <cds_view>` directly or via a helper.
+
+→ For full setup pattern and test double configuration: `abapgit-agent ref --topic cds-testing`
 
 ---
 
@@ -369,10 +394,7 @@ DATA(lo_cut) = NEW zcl_my_class( io_agent = lo_agent ).
 DATA(ls_actual) = lo_cut->execute( ).
 ```
 
-→ Full API reference (EXPORT params, exceptions, inherited methods, common mistakes):
-  `abapgit-agent ref --topic unit-testable-code`
-
-→ For class design rules (constructor injection, interfaces for dependencies):
+→ For full API reference (EXPORT params, exceptions, inherited methods, common mistakes) and class design rules (constructor injection, interfaces for dependencies):
   `abapgit-agent ref --topic unit-testable-code`
 
 #### Running tests — use `unit` command
@@ -435,7 +457,7 @@ Never assume — wait for the user's answer before proceeding.
 | HTTP 500 / runtime crash (ST22) | `dump` | Error already occurred |
 | Wrong output, no crash | `debug` | Need to trace logic |
 
-→ See `guidelines/debug-dump.md` — run: `abapgit-agent ref --topic debug-dump`
+→ `abapgit-agent ref --topic debug-dump`
 
 **Critical rules for `debug` sessions:**
 
@@ -496,7 +518,7 @@ abapgit-agent debug vars --json
 abapgit-agent debug step --type continue --json     # 4. release
 ```
 
-→ See `guidelines/debug-session.md` — run: `abapgit-agent ref --topic debug-session`
+→ `abapgit-agent ref --topic debug-session`
 
 ---
 
@@ -546,7 +568,7 @@ Projects can add their own abaplint notes to `guidelines/abaplint-local.md` in t
 project repository. After running `abapgit-agent ref export`, the `ref` command
 surfaces both bundled and project-specific guidance together.
 
-→ See `guidelines/abaplint.md` — run: `abapgit-agent ref --topic abaplint`
+→ `abapgit-agent ref --topic abaplint`
 
 ---
 
@@ -600,7 +622,7 @@ git push origin feature/my-change --force-with-lease
 abapgit-agent pull --files src/<name>.clas.abap --sync-xml
 ```
 
-→ See `guidelines/branch-workflow.md` — run: `abapgit-agent ref --topic branch-workflow`
+→ `abapgit-agent ref --topic branch-workflow`
 
 ### Trunk Workflow (`"mode": "trunk"`)
 
@@ -708,6 +730,9 @@ Modified ABAP files?
 └─ Other types (FUGR, TABL, STRU, DTEL, TTYP, etc.)?
    ├─ XML-only objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG)?
    │  └─ ✅ Use: skip syntax → [abaplint] → commit → push → pull --files abap/ztable.tabl.xml --sync-xml
+   ├─ DCLS (CDS access control)?
+   │  └─ ✅ Use: skip syntax → [abaplint] → commit → push → pull --files abap/zc_view.dcls.xml --sync-xml
+   │         ⚠️  Pass the .xml file — pull --files does NOT accept .asdcls extensions
    └─ FUGR and other complex objects?
       └─ ✅ Use: skip syntax → [abaplint] → commit → push → pull --sync-xml → (if errors: inspect)
 
@@ -716,47 +741,39 @@ Modified ABAP files?
 ```
 
 → For creating new objects (what files to write): `abapgit-agent ref --topic object-creation`
-→ See `guidelines/workflow-detailed.md` — run: `abapgit-agent ref --topic workflow-detailed`
+→ For full workflow decision tree and error indicators: `abapgit-agent ref --topic workflow-detailed`
 
 ---
 
 ## Guidelines Index
 
-> **Note:** If the `guidelines/` folder doesn't exist in your repo, the `ref` command
-> automatically uses bundled guidelines from the package. Access them with:
-> ```bash
-> abapgit-agent ref --topic <topic>   # e.g. ref --topic sql
-> abapgit-agent ref "<pattern>"       # e.g. ref "SELECT"
-> ```
-
-Detailed guidelines are available in the `guidelines/` folder:
-
-| File | Topic |
-|------|-------|
-| `guidelines/index.md` | Overview and usage |
-| `guidelines/sql.md` | ABAP SQL Best Practices |
-| `guidelines/exceptions.md` | Exception Handling |
-| `guidelines/testing.md` | Unit Testing (including CDS) |
-| `guidelines/cds.md` | CDS Views |
-| `guidelines/classes.md` | ABAP Classes and Objects |
-| `guidelines/objects.md` | Object Naming Conventions (defaults) |
-| `guidelines/objects.local.md` | **Project** Naming Conventions — overrides `objects.md` (created by `init`, never overwritten) |
-| `guidelines/json.md` | JSON Handling |
-| `guidelines/abapgit.md` | abapGit XML Metadata Templates — CLAS, INTF, PROG, DDLS, DCLS, FUGR |
-| `guidelines/abapgit-xml-only.md` | abapGit XML Metadata Templates — XML-only objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG) |
-| `guidelines/unit-testable-code.md` | Unit Testable Code Guidelines (Dependency Injection) |
-| `guidelines/common-errors.md` | Common ABAP Errors - Quick Fixes |
-| `guidelines/debug-session.md` | Debug Session Guide |
-| `guidelines/debug-dump.md` | Dump Analysis Guide |
-| `guidelines/run-probe-classes.md` | run Command — AI Guidelines (probe classes, scratchWorkspace) |
-| `guidelines/probe-poc.md` | Probe and PoC — Full Decision Flow |
-| `guidelines/branch-workflow.md` | Branch Workflow |
-| `guidelines/workflow-detailed.md` | Development Workflow (Detailed) |
-| `guidelines/object-creation.md` | Object Creation (XML metadata, local classes) |
-| `guidelines/cds-testing.md` | CDS Testing (Test Double Framework) |
-| `guidelines/abaplint.md` | abaplint Rule Guidelines (prefer_inline trap, safe patterns) |
-
-These guidelines are automatically searched by the `ref` command.
+| Command | Topic |
+|---------|-------|
+| `ref --topic sql` | ABAP SQL Best Practices |
+| `ref --topic exceptions` | Exception Handling |
+| `ref --topic classes` | ABAP Classes and Objects |
+| `ref --topic objects` | Object Naming Conventions (defaults) |
+| `ref --topic naming-limits` | Naming Length Limits — 30/16/40 char rules per type (CRITICAL before naming anything) |
+| `ref --topic comments` | Documentation Comments (ABAP DOC, shorttext, @parameter, CDS `//`, program `*&---`) |
+| `ref --topic testing` | Unit Testing |
+| `ref --topic unit-testable-code` | Unit Testable Code (Dependency Injection) |
+| `ref --topic cds` | CDS Views |
+| `ref --topic cds-testing` | CDS Testing (Test Double Framework) |
+| `ref --topic json` | JSON Handling |
+| `ref --topic common-errors` | Common ABAP Errors - Quick Fixes |
+| `ref --topic abapgit` | abapGit XML Metadata — **use for CDS/DDLS XML**, also CLAS, INTF, PROG, DCLS, FUGR |
+| `ref --topic abapgit-xml-only` | abapGit XML Metadata — XML-only objects (TABL, STRU, DTEL, TTYP, DOMA, MSAG) |
+| `ref --topic abapgit-fugr` | abapGit XML Metadata — Function Group (FUGR) details |
+| `ref --topic abaplint` | abaplint Rule Guidelines (prefer_inline trap, safe patterns) |
+| `ref --topic debug-session` | Debug Session Guide |
+| `ref --topic debug-dump` | Dump Analysis Guide |
+| `ref --topic branch-workflow` | Branch Workflow |
+| `ref --topic workflow-detailed` | Development Workflow (Detailed) |
+| `ref --topic object-creation` | Object Creation (XML metadata, local classes) |
+| `ref --topic run-probe-classes` | run Command — AI Guidelines (probe classes, scratchWorkspace) |
+| `ref --topic probe-poc` | Probe and PoC — Full Decision Flow |
+
+> `objects.local.md` — **Project** Naming Conventions (created by `init`, never overwritten). Read directly from `guidelines/objects.local.md` — no ref topic.
 
 ---
 

package/abap/guidelines/abapgit-fugr.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: abapGit XML Metadata — Function Group (FUGR)
-nav_order: 11
+nav_order: 15
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---
@@ -22,10 +22,13 @@ A FUGR with group name `ZMY_FUGR` and one FM `ZMY_MY_FUNCTION` requires these fi
 | `zmy_fugr.fugr.xml` | Main XML: group description, includes list, FM interfaces |
 | `zmy_fugr.fugr.lzmy_fugrtop.abap` | TOP include source |
 | `zmy_fugr.fugr.lzmy_fugrtop.xml` | TOP include metadata (`SUBC=I`) |
-| `zmy_fugr.fugr.saplzmy_fugr.abap` | Main include source |
+| `zmy_fugr.fugr.saplzmy_fugr.abap` | Main include source (lists all U-includes) |
 | `zmy_fugr.fugr.saplzmy_fugr.xml` | Main include metadata (`SUBC=F`) |
+| `zmy_fugr.fugr.lzmy_fugru01.abap` | FM implementation include (one per FM: U01, U02, …) |
 | `zmy_fugr.fugr.zmy_my_function.abap` | FM source (one file per FM, named after FM in lowercase) |
 
+> **7 files total for one FM** (6 without the U01 include causes a pull error — the SAPL source references `LZMY_FUGRU01` which abapGit can't find). For a second FM, add `lzmy_fugru02.abap` and `zmy_second_function.abap`.
+
 ---
 
 ### `zmy_fugr.fugr.xml`
@@ -145,15 +148,28 @@ FUNCTION zmy_my_function.
 ENDFUNCTION.
 ```
 
+### `zmy_fugr.fugr.lzmy_fugru01.abap`
+
+The FM implementation include — **always required**. The SAPL source references `INCLUDE LZMY_FUGRU01.` so this file must exist or the pull fails.
+
+```abap
+*----------------------------------------------------------------------*
+***INCLUDE LZMY_FUGRU01.
+*----------------------------------------------------------------------*
+```
+
+For a second FM, create `zmy_fugr.fugr.lzmy_fugru02.abap` with the same pattern (replacing `U01` with `U02`).
+
 ---
 
 ## Key Rules
 
-- **Include naming**: TOP = `L<GROUP>TOP`, main = `SAPL<GROUP>` — uppercase in XML and filenames
+- **Include naming**: TOP = `L<GROUP>TOP`, main = `SAPL<GROUP>`, FM implementation = `L<GROUP>U01` (U02, U03, …) — uppercase in XML and filenames
 - **FM source file**: named after the FM in **lowercase** (`zmy_my_function.abap`, not `ZMY_MY_FUNCTION.abap`)
+- **U-include file required**: `lzmy_fugru01.abap` must exist — the SAPL source references it; missing it causes a pull error
 - **`INCLUDES` list** in the main XML: only lists TOP and SAPL includes — FM source includes are implicit
 - **`REMOTE_CALL>R`**: add only for RFC-enabled FMs; omit for local FMs
 - **Optional parameters**: include both `<OPTIONAL>X</OPTIONAL>` and `<DEFAULT>...</DEFAULT>`
-- **`DOCUMENTATION` section**: omit entirely if no parameter descriptions needed — missing docs cause no diff
+- **`DOCUMENTATION` section**: the serializer always writes `<DOCUMENTATION>` with one `<RSFDO>` entry per parameter (containing only `<PARAMETER>` and `<KIND>P</KIND>`, no `<STEXT>`). Always include it — omitting it causes a permanent "M" diff
 - **Screens/CUA**: omit `DYNPROS`/`CUA` sections for screenless function groups
 - **Multiple FMs**: add one `<item>` per FM in `FUNCTIONS`; add one `INCLUDE` line per FM in the SAPL source

package/abap/guidelines/abapgit-xml-only.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: abapGit XML Metadata — XML-Only Objects
-nav_order: 10
+nav_order: 14
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---
@@ -170,6 +170,12 @@ A **text table** stores translatable texts for another table (the "main table").
 
 > Pull with: `pull --files src/zmy_dtel.dtel.xml`
 
+**Two variants — choose based on whether the DTEL defines its own type or references a domain:**
+
+#### Variant 1: Built-in type (no domain)
+
+Use when the data element directly defines `DATATYPE` and `LENG` without referencing a domain.
+
 ```xml
 <?xml version="1.0" encoding="utf-8"?>
 <abapGit version="v1.0.0" serializer="LCL_OBJECT_DTEL" serializer_version="v1.0.0">
@@ -192,13 +198,38 @@ A **text table** stores translatable texts for another table (the "main table").
 </abapGit>
 ```
 
+#### Variant 2: Domain reference
+
+Use when the data element's type and length come from an existing domain (`DOMNAME`). Do **not** include `DATATYPE` or `LENG` — the domain owns those.
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DTEL" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DD04V>
+    <ROLLNAME>ZMY_DTEL</ROLLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>Description of data element</DDTEXT>
+    <REPTEXT>Description</REPTEXT>
+    <SCRTEXT_S>Short text</SCRTEXT_S>
+    <SCRTEXT_M>Medium text</SCRTEXT_M>
+    <SCRTEXT_L>Long description text</SCRTEXT_L>
+    <DTELMASTER>E</DTELMASTER>
+    <DOMNAME>ZMY_DOMAIN</DOMNAME>
+   </DD04V>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
 **Key Fields**:
 - `ROLLNAME`: Data element name
 - `DDTEXT`: Description (**not** `DESCRIPT`)
 - `REPTEXT` / `SCRTEXT_S` / `SCRTEXT_M` / `SCRTEXT_L`: Field labels (report heading, short, medium, long)
 - `DTELMASTER`: Language key for label master (`E` for English)
-- `DATATYPE`: Data type (`CHAR`, `NUMC`, `DATS`, `TIMS`, `INT4`, etc.)
-- `LENG`: Length padded to 6 digits (e.g. `000010` for 10 characters)
+- `DATATYPE` + `LENG`: Use for built-in type variant only (e.g. `CHAR` + `000010`)
+- `DOMNAME`: Use for domain-reference variant only — omit `DATATYPE` and `LENG` entirely
 
 **Omit `<PARAMID>`** unless you specifically need a SET/GET parameter ID — the serializer omits it when empty.
 
@@ -206,10 +237,14 @@ A **text table** stores translatable texts for another table (the "main table").
 
 ### Structure (STRU)
 
-**Filename**: `src/zmy_struct.stru.xml`
+**Filename**: `src/zmy_struct.tabl.xml`
 
-> abapGit uses the same TABL serializer for STRU.
-> Pull with: `pull --files src/zmy_struct.stru.xml`
+> ⚠️ **Use `.tabl.xml` extension, NOT `.stru.xml`** — abapGit serializes structures with the TABL
+> serializer and registers them as object type `TABL`. A `.stru.xml` filename causes
+> "Step DDIC is only for DDIC objects" because abapGit treats it as object type `STRU`,
+> which is not in its DDIC activation list.
+>
+> Pull with: `pull --files src/zmy_struct.tabl.xml`
 
 ```xml
 <?xml version="1.0" encoding="utf-8"?>
@@ -221,16 +256,37 @@ A **text table** stores translatable texts for another table (the "main table").
     <DDLANGUAGE>E</DDLANGUAGE>
     <TABCLASS>INTTAB</TABCLASS>
     <DDTEXT>Description of the structure</DDTEXT>
-    <CONTFLAG>A</CONTFLAG>
+    <EXCLASS>1</EXCLASS>
    </DD02V>
+   <DD03P_TABLE>
+    <DD03P>
+     <FIELDNAME>FIELD1</FIELDNAME>
+     <ROLLNAME>S_CARR_ID</ROLLNAME>
+     <ADMINFIELD>0</ADMINFIELD>
+     <SHLPORIGIN>D</SHLPORIGIN>
+     <COMPTYPE>E</COMPTYPE>
+    </DD03P>
+    <DD03P>
+     <FIELDNAME>FIELD2</FIELDNAME>
+     <ROLLNAME>S_CARRNAME</ROLLNAME>
+     <ADMINFIELD>0</ADMINFIELD>
+     <COMPTYPE>E</COMPTYPE>
+    </DD03P>
+   </DD03P_TABLE>
   </asx:values>
  </asx:abap>
 </abapGit>
 ```
 
-**Key difference from TABL**: `TABCLASS` is `INTTAB` (internal table / structure) instead of `TRANSP`.
+**Key differences from TABL**:
+- `TABCLASS` is `INTTAB` instead of `TRANSP`
+- No `<CONTFLAG>` — omit it (not written by serializer for structures)
+- `<EXCLASS>1</EXCLASS>` — include it
+- Include `<DD03P_TABLE>` with field definitions from the start (unlike TABL where it is optional on creation)
 
-**Note**: Like TABL, after the first pull abapGit expands the XML with `<DD03P_TABLE>` field definitions.
+**`DD03P` field rules** (same as TABL):
+- Fields with `ROLLNAME` (data element): include `ROLLNAME`, `ADMINFIELD>0`, `SHLPORIGIN` (when domain provides value help — `D` for domain fixed values), `COMPTYPE>E`
+- Fields with raw type (no data element): include `ADMINFIELD>0`, `INTTYPE`, `INTLEN`, `DATATYPE`, `MASK` (before any text fields)
 
 ---
 
@@ -248,13 +304,13 @@ A **text table** stores translatable texts for another table (the "main table").
    <DD40V>
     <TYPENAME>ZMY_TTYP</TYPENAME>
     <DDLANGUAGE>E</DDLANGUAGE>
-    <DDTEXT>Description of table type</DDTEXT>
     <ROWTYPE>ZMY_STRUCT</ROWTYPE>
     <ROWKIND>S</ROWKIND>
-    <DATATYPE>TABLE_T</DATATYPE>
+    <DATATYPE>STRU</DATATYPE>
     <ACCESSMODE>T</ACCESSMODE>
     <KEYDEF>D</KEYDEF>
     <KEYKIND>N</KEYKIND>
+    <DDTEXT>Description of table type</DDTEXT>
    </DD40V>
   </asx:values>
  </asx:abap>
@@ -265,7 +321,7 @@ A **text table** stores translatable texts for another table (the "main table").
 - `TYPENAME`: Table type name
 - `ROWTYPE`: Row type (a structure or data element name)
 - `ROWKIND`: Row kind — `S`=Structure/Type, `D`=Data element, `R`=Reference
-- `DATATYPE`: Always `TABLE_T` for table types
+- `DATATYPE`: `STRU` when row type is a structure (`ROWKIND=S`); `TABLE_T` only for elementary-type row types
 - `ACCESSMODE`: Table kind — `T`=Standard, `S`=Sorted, `H`=Hashed
 - `KEYDEF`: Key definition — `D`=Default (standard key), `K`=User-defined
 - `KEYKIND`: Key uniqueness — `N`=Non-unique, `U`=Unique
@@ -372,7 +428,7 @@ abapGit uses the view `DD01V` as the root element (not `DD01L`). The serializer
      <SPRSL>E</SPRSL>
      <ARBGB>ZMY_MSGS</ARBGB>
      <MSGNR>000</MSGNR>
-     <TEXT>Object &1 not found</TEXT>
+     <TEXT>Object &amp;1 not found</TEXT>
     </T100>
     <T100>
      <SPRSL>E</SPRSL>

package/abap/guidelines/abapgit.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: abapGit XML Metadata
-nav_order: 9
+nav_order: 13
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---
@@ -265,7 +265,7 @@ abapGit's serializer **omits fields that have their default value**. Writing ext
 - `SOURCE_TYPE W` → View Entity (`define view entity`, modern — **use by default**)
 - `SOURCE_TYPE V` → View (`define view` + `@AbapCatalog.sqlViewName`, legacy)
 
-→ For DDL source syntax: `abapgit-agent ref --topic cds-abapgit`
+→ For DDL source syntax: `abapgit-agent ref --topic cds`
 
 ---
 
@@ -290,6 +290,7 @@ abapGit's serializer **omits fields that have their default value**. Writing ext
 
 - `DCLNAME` matches the CDS view name
 - Source file contains the DCL (`@MappingRole ... define role ...`)
+- **Pull with the `.xml` file, not `.asdcls`**: `pull --files src/zc_my_view.dcls.xml` — the `pull --files` filter does not accept `.asdcls` extensions
 
 ---
 

package/abap/guidelines/abaplint-local.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: abaplint Local Rules
-nav_order: 21
+nav_order: 17
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---

package/abap/guidelines/abaplint.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: abaplint Rule Guidelines
-nav_order: 20
+nav_order: 16
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---

package/abap/guidelines/branch-workflow.md

@@ -1,7 +1,7 @@
 ---
 layout: default
 title: Branch Workflow
-nav_order: 17
+nav_order: 20
 parent: ABAP Coding Guidelines
 grand_parent: ABAP Development
 ---