abapgit-agent 1.13.1 → 1.13.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -115,7 +115,6 @@ npm run pull -- --url <git-url> --branch main
115
115
  | Installation & Setup | [INSTALL.md](INSTALL.md) |
116
116
  | All Commands Overview | [docs/commands.md](docs/commands.md) |
117
117
  | REST API Reference | [API.md](API.md) |
118
- | Error Handling | [ERROR_HANDLING.md](ERROR_HANDLING.md) |
119
118
 
120
119
  ## Dependent Projects
121
120
 
package/abap/CLAUDE.md CHANGED
@@ -359,7 +359,7 @@ edit src/zcl_auth_handler.clas.abap
359
359
  abapgit-agent syntax --files src/zcl_auth_handler.clas.abap
360
360
  git add . && git commit -m "feat: add authentication handler"
361
361
  git push origin main
362
- abapgit-agent pull --files src/zcl_auth_handler.clas.abap
362
+ abapgit-agent pull --files src/zcl_auth_handler.clas.abap --sync-xml
363
363
  ```
364
364
 
365
365
  ### AI Tool Guidelines
@@ -425,6 +425,11 @@ abapgit-agent pull --files src/zcl_auth_handler.clas.abap
425
425
  1. ✗ Do not run `abapgit-agent transport release`
426
426
  2. ✓ Inform the user that transport release is disabled for this project
427
427
 
428
+ **After every pull that creates or modifies ABAP objects:**
429
+ 1. ✓ Always pass `--sync-xml` — rewrites any XML metadata files that differ from the ABAP serializer output, amends the commit, and re-pulls so git and the ABAP system stay in sync
430
+ 2. ✓ If pull output shows `⚠️ X XML file(s) differ from serializer output`, re-run immediately with `--sync-xml`
431
+ 3. ✗ Never leave a pull without `--sync-xml` when you authored the objects — abapGit will show **M (modified)** permanently otherwise
432
+
428
433
  ---
429
434
 
430
435
  ### Quick Decision Tree for AI
@@ -435,11 +440,11 @@ abapgit-agent pull --files src/zcl_auth_handler.clas.abap
435
440
  Modified ABAP files?
436
441
  ├─ CLAS/INTF/PROG/DDLS files?
437
442
  │ ├─ Independent files (no cross-dependencies)?
438
- │ │ └─ ✅ Use: syntax → commit → push → pull
443
+ │ │ └─ ✅ Use: syntax → commit → push → pull --sync-xml
439
444
  │ └─ Dependent files (interface + class, class uses class)?
440
- │ └─ ✅ Use: skip syntax → commit → push → pull
445
+ │ └─ ✅ Use: skip syntax → commit → push → pull --sync-xml
441
446
  └─ Other types (DDLS, FUGR, TABL, etc.)?
442
- └─ ✅ Use: skip syntax → commit → push → pull → (if errors: inspect)
447
+ └─ ✅ Use: skip syntax → commit → push → pull --sync-xml → (if errors: inspect)
443
448
  ```
444
449
 
445
450
  → See `guidelines/workflow-detailed.md` — run: `abapgit-agent ref --topic workflow-detailed`
@@ -10,6 +10,8 @@ Read the full ABAP development guide by running:
10
10
  abapgit-agent guide
11
11
  ```
12
12
 
13
+ **Never pipe `abapgit-agent guide` or `abapgit-agent ref` through `head`, `tail`, or any other truncation command. Always read the full output.**
14
+
13
15
  This guide covers: development workflow, ABAP syntax guidelines, object naming, unit testing, and debugging.
14
16
 
15
17
  > **Humans:** Full guide online at https://sylvoscai.github.io/abapgit-agent/pages/abap-coding-guidelines.html
@@ -26,16 +26,12 @@ Structure | z*.stru.abap | z*.stru.xml
26
26
  Table Type | z*.ttyp.abap | z*.ttyp.xml
27
27
  ```
28
28
 
29
- ```
30
- Key XML Settings:
31
- Class EXPOSURE: 2=Public, 3=Protected, 4=Private
32
- Class STATE: 1=Active
33
- Table TABCLASS: TRANSP, POOL, CLUSTER
34
- Table DELIVERY: A=Application, C=Customizing
35
- CDS SOURCE_TYPE: W=View Entity (modern), V=View (legacy)
36
- Test Class XML: <WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
37
- Local Classes: <CLSCCINCL>X</CLSCCINCL>
38
- ```
29
+ > **CRITICAL: Always write XML files with a UTF-8 BOM (`\ufeff`) as the very first character**, before `<?xml ...`.
30
+ > Without the BOM, abapGit shows the object as **"M" (modified)** after every pull because the
31
+ > serializer always produces XML with BOM — and every byte matters.
32
+
33
+ > **CRITICAL: Only include fields that abapGit's serializer actually writes. Never add fields with
34
+ > default values.** Extra fields cause a permanent "M" (modified) diff. Follow the exact templates below.
39
35
 
40
36
  **Searchable keywords**: class xml, interface xml, table xml, cds xml, test class, exposure, serializer, abapgit
41
37
 
@@ -46,14 +42,50 @@ abapGit needs XML files to:
46
42
  - Store object attributes (description, exposure, state, etc.)
47
43
  - Handle object-specific configurations
48
44
 
45
+ ## Field Presence Rules (CRITICAL)
46
+
47
+ abapGit's serializer **omits fields that have their default value**. Writing extra fields causes permanent
48
+ "M" (modified) status in abapGit UI. Follow these rules strictly:
49
+
50
+ ### CLAS — Field Presence Rules
51
+
52
+ | Field | Include when | Omit when |
53
+ |---|---|---|
54
+ | `CLSNAME` | Always | — |
55
+ | `LANGU` | Always | — |
56
+ | `DESCRIPT` | Always | — |
57
+ | `CATEGORY` | Non-standard class (`40`=exception, `05`=test double) | Standard class (default `00`) — **omit** |
58
+ | `EXPOSURE` | **Never for CLAS** | **Always omit** — public (`2`) is the default and is never written |
59
+ | `STATE` | Always (`1`) | — |
60
+ | `CLSCCINCL` | `.clas.locals_def.abap` file exists | No local class files — **omit** |
61
+ | `FIXPT` | Always (`X`) | — |
62
+ | `UNICODE` | Always (`X`) | — |
63
+ | `WITH_UNIT_TESTS` | `.clas.testclasses.abap` file exists | No test class file — **omit** |
64
+ | `MSG_ID` | Class has a message class | No message class — **omit** |
65
+
66
+ **Field order**: `CLSNAME → LANGU → DESCRIPT → [CATEGORY] → STATE → [CLSCCINCL] → FIXPT → UNICODE → [WITH_UNIT_TESTS] → [MSG_ID]`
67
+
68
+ ### INTF — Field Presence Rules
69
+
70
+ | Field | Include when | Omit when |
71
+ |---|---|---|
72
+ | `CLSNAME` | Always | — |
73
+ | `LANGU` | Always | — |
74
+ | `DESCRIPT` | Always | — |
75
+ | `EXPOSURE` | Always (`2`) | — (interfaces always have EXPOSURE, unlike classes) |
76
+ | `STATE` | Always (`1`) | — |
77
+ | `UNICODE` | Always (`X`) | — |
78
+
49
79
  ## Object Types and XML Templates
50
80
 
51
81
  ### Class (CLAS)
52
82
 
53
83
  **Filename**: `src/zcl_my_class.clas.xml`
54
84
 
85
+ **Standard public class** (no local includes, no test class):
86
+
55
87
  ```xml
56
- <?xml version="1.0" encoding="utf-8"?>
88
+ <?xml version="1.0" encoding="utf-8"?>
57
89
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
58
90
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
59
91
  <asx:values>
@@ -61,29 +93,85 @@ abapGit needs XML files to:
61
93
  <CLSNAME>ZCL_MY_CLASS</CLSNAME>
62
94
  <LANGU>E</LANGU>
63
95
  <DESCRIPT>Description of the class</DESCRIPT>
64
- <EXPOSURE>2</EXPOSURE>
65
96
  <STATE>1</STATE>
97
+ <FIXPT>X</FIXPT>
66
98
  <UNICODE>X</UNICODE>
99
+ </VSEOCLASS>
100
+ </asx:values>
101
+ </asx:abap>
102
+ </abapGit>
103
+ ```
104
+
105
+ **Class with test class** (`.clas.testclasses.abap` exists — add `WITH_UNIT_TESTS`):
106
+
107
+ ```xml
108
+ <?xml version="1.0" encoding="utf-8"?>
109
+ <abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
110
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
111
+ <asx:values>
112
+ <VSEOCLASS>
113
+ <CLSNAME>ZCL_MY_CLASS</CLSNAME>
114
+ <LANGU>E</LANGU>
115
+ <DESCRIPT>Description of the class</DESCRIPT>
116
+ <STATE>1</STATE>
67
117
  <FIXPT>X</FIXPT>
118
+ <UNICODE>X</UNICODE>
119
+ <WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
68
120
  </VSEOCLASS>
69
121
  </asx:values>
70
122
  </asx:abap>
71
123
  </abapGit>
72
124
  ```
73
125
 
74
- **Key Fields**:
75
- - `CLSNAME`: Class name (must match filename)
76
- - `DESCRIPT`: Class description
77
- - `EXPOSURE`: Exposure (2 = Public, 3 = Protected, 4 = Private)
78
- - `STATE`: State (1 = Active)
79
- - `UNICODE`: Unicode encoding (X = Yes)
80
- - `FIXPT`: Fixed-point arithmetic (X = Yes) - **Always include for correct decimal arithmetic**
126
+ **Class with local includes** (`.clas.locals_def.abap` exists — add `CLSCCINCL` before `FIXPT`):
81
127
 
82
- **Note**: `<FIXPT>X</FIXPT>` is default for modern ABAP. Without it, decimals treated as integers.
128
+ ```xml
129
+ <?xml version="1.0" encoding="utf-8"?>
130
+ <abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
131
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
132
+ <asx:values>
133
+ <VSEOCLASS>
134
+ <CLSNAME>ZCL_MY_CLASS</CLSNAME>
135
+ <LANGU>E</LANGU>
136
+ <DESCRIPT>Description of the class</DESCRIPT>
137
+ <STATE>1</STATE>
138
+ <CLSCCINCL>X</CLSCCINCL>
139
+ <FIXPT>X</FIXPT>
140
+ <UNICODE>X</UNICODE>
141
+ <WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
142
+ </VSEOCLASS>
143
+ </asx:values>
144
+ </asx:abap>
145
+ </abapGit>
146
+ ```
147
+
148
+ **Exception class** (`CATEGORY>40` — add `CATEGORY` after `DESCRIPT`):
149
+
150
+ ```xml
151
+ <?xml version="1.0" encoding="utf-8"?>
152
+ <abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
153
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
154
+ <asx:values>
155
+ <VSEOCLASS>
156
+ <CLSNAME>ZCX_MY_EXCEPTION</CLSNAME>
157
+ <LANGU>E</LANGU>
158
+ <DESCRIPT>My exception</DESCRIPT>
159
+ <CATEGORY>40</CATEGORY>
160
+ <STATE>1</STATE>
161
+ <CLSCCINCL>X</CLSCCINCL>
162
+ <FIXPT>X</FIXPT>
163
+ <UNICODE>X</UNICODE>
164
+ </VSEOCLASS>
165
+ </asx:values>
166
+ </asx:abap>
167
+ </abapGit>
168
+ ```
83
169
 
84
- **Local Classes**: If the class has local classes (e.g., test doubles), add:
85
- - `<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>` - for test classes
86
- - `<CLSCCINCL>X</CLSCCINCL>` - for local class definitions
170
+ **Key rules**:
171
+ - ❌ **Never include `<EXPOSURE>`** in a CLAS XML — public (2) is the default and abapGit omits it
172
+ - ✅ Always include `<FIXPT>X</FIXPT>` and `<UNICODE>X</UNICODE>`
173
+ - ✅ Add `<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>` only when `.clas.testclasses.abap` exists
174
+ - ✅ Add `<CLSCCINCL>X</CLSCCINCL>` only when `.clas.locals_def.abap` exists
87
175
 
88
176
  **Local Class Files**:
89
177
  | File | Purpose |
@@ -98,7 +186,7 @@ abapGit needs XML files to:
98
186
  **Filename**: `src/zif_my_interface.intf.xml`
99
187
 
100
188
  ```xml
101
- <?xml version="1.0" encoding="utf-8"?>
189
+ <?xml version="1.0" encoding="utf-8"?>
102
190
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_INTF" serializer_version="v1.0.0">
103
191
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
104
192
  <asx:values>
@@ -115,6 +203,9 @@ abapGit needs XML files to:
115
203
  </abapGit>
116
204
  ```
117
205
 
206
+ **Key rules**:
207
+ - ✅ `<EXPOSURE>2</EXPOSURE>` is **always present** for interfaces (unlike classes where it is omitted)
208
+
118
209
  ---
119
210
 
120
211
  ### Program (PROG)
@@ -122,13 +213,13 @@ abapGit needs XML files to:
122
213
  **Filename**: `src/zmy_program.prog.xml`
123
214
 
124
215
  ```xml
125
- <?xml version="1.0" encoding="utf-8"?>
216
+ <?xml version="1.0" encoding="utf-8"?>
126
217
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_PROG" serializer_version="v1.0.0">
127
218
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
128
219
  <asx:values>
129
220
  <PROGDIR>
130
221
  <NAME>ZMY_PROGRAM</NAME>
131
- <SUBC>I</SUBC>
222
+ <SUBC>1</SUBC>
132
223
  <RLOAD>E</RLOAD>
133
224
  <FIXPT>X</FIXPT>
134
225
  <UCCHECK>X</UCCHECK>
@@ -140,8 +231,12 @@ abapGit needs XML files to:
140
231
 
141
232
  **Key Fields**:
142
233
  - `NAME`: Program name
143
- - `SUBC`: Subc (I = Include, 1 = Executable, F = Function Group, M = Module Pool, S = Subroutine Pool)
144
- - `RLOAD`: Rload (E = External, I = Internal)
234
+ - `SUBC`: Program type (`1`=Executable, `I`=Include, `F`=Function Group, `M`=Module Pool, `S`=Subroutine Pool)
235
+ - `RLOAD`: `E`=External
236
+ - `FIXPT`: Fixed-point arithmetic (`X`=Yes) — include for executables
237
+ - `UCCHECK`: Unicode checks active (`X`=Yes)
238
+
239
+ **Note**: The serializer may also write a `<TPOOL>` section after `<PROGDIR>` if the program has a title text. You do not need to write this when creating new programs — abapGit will add it on the next pull if needed.
145
240
 
146
241
  ---
147
242
 
@@ -150,7 +245,7 @@ abapGit needs XML files to:
150
245
  **Filename**: `src/zmy_table.tabl.xml`
151
246
 
152
247
  ```xml
153
- <?xml version="1.0" encoding="utf-8"?>
248
+ <?xml version="1.0" encoding="utf-8"?>
154
249
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_TABL" serializer_version="v1.0.0">
155
250
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
156
251
  <asx:values>
@@ -168,9 +263,20 @@ abapGit needs XML files to:
168
263
 
169
264
  **Key Fields**:
170
265
  - `TABNAME`: Table name
171
- - `DDTEXT`: Description (NOT DESCRIPT)
172
- - `TABCLASS`: Table class (TRANSP = Transparent)
173
- - `CONTFLAG`: Delivery class (A = Application table)
266
+ - `DDTEXT`: Description (**not** `DESCRIPT`)
267
+ - `TABCLASS`: `TRANSP`=Transparent (most common), `POOL`, `CLUSTER`
268
+ - `CONTFLAG`: Delivery class — `A`=Application, `C`=Customizing, `S`=System, `G`=Customizing protected
269
+
270
+ **Note**: When abapGit serializes an existing table it also writes `<DD09L>` (technical settings) and `<DD03P_TABLE>` (field definitions). These sections are generated automatically from the ABAP Dictionary on pull — you only need the `<DD02V>` header when creating a new table. After the first pull the XML will be expanded with those sections.
271
+
272
+ **`DD03P` field-level rules** (apply when editing an existing table XML that includes `<DD03P_TABLE>`):
273
+
274
+ | Rule | Detail |
275
+ |---|---|
276
+ | `SHLPORIGIN` | Include `<SHLPORIGIN>D</SHLPORIGIN>` on fields where the Dictionary provides a value help (e.g. fields with a domain that has fixed values or a search help). Omit on fields with no value help. |
277
+ | Field order for raw-type fields | For fields with no `ROLLNAME` (raw type, e.g. `CHAR`, `NUMC`), the serializer writes `<MASK>` **before** `<DDTEXT>`. For fields with a `ROLLNAME`, only `ROLLNAME` appears (no `MASK` or `DDTEXT`). |
278
+
279
+ **Why this matters**: Missing `SHLPORIGIN` or wrong `MASK`/`DDTEXT` order causes a permanent diff between git and the system-serialized XML.
174
280
 
175
281
  ---
176
282
 
@@ -181,7 +287,7 @@ abapGit needs XML files to:
181
287
  The XML format is identical for both types — only `SOURCE_TYPE` differs:
182
288
 
183
289
  ```xml
184
- <?xml version="1.0" encoding="utf-8"?>
290
+ <?xml version="1.0" encoding="utf-8"?>
185
291
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
186
292
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
187
293
  <asx:values>
@@ -208,7 +314,7 @@ The XML format is identical for both types — only `SOURCE_TYPE` differs:
208
314
  **Filename**: `src/zmy_dtel.dtel.xml`
209
315
 
210
316
  ```xml
211
- <?xml version="1.0" encoding="utf-8"?>
317
+ <?xml version="1.0" encoding="utf-8"?>
212
318
  <abapGit version="v1.0.0" serializer="LCL_OBJECT_DTEL" serializer_version="v1.0.0">
213
319
  <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
214
320
  <asx:values>
@@ -231,9 +337,9 @@ The XML format is identical for both types — only `SOURCE_TYPE` differs:
231
337
 
232
338
  **Key Fields**:
233
339
  - `ROLLNAME`: Data element name
234
- - `DDTEXT`: Description (NOT DESCRIPT)
235
- - `DATATYPE`: Data type (CHAR, NUMC, etc.)
236
- - `LENG`: Length (e.g., 000010 for 10 characters)
340
+ - `DDTEXT`: Description (**not** `DESCRIPT`)
341
+ - `DATATYPE`: Data type (`CHAR`, `NUMC`, `DATS`, `TIMS`, `INT4`, etc.)
342
+ - `LENG`: Length padded to 6 digits (e.g. `000010` for 10 characters)
237
343
 
238
344
  ---
239
345
 
package/bin/abapgit-agent CHANGED
@@ -34,32 +34,7 @@ async function main() {
34
34
  const args = process.argv.slice(2);
35
35
  const command = args[0];
36
36
 
37
- // Load command modules (Phase 2 refactoring)
38
- const commandModules = {
39
- help: require('../src/commands/help'),
40
- health: require('../src/commands/health'),
41
- status: require('../src/commands/status'),
42
- create: require('../src/commands/create'),
43
- delete: require('../src/commands/delete'),
44
- import: require('../src/commands/import'),
45
- inspect: require('../src/commands/inspect'),
46
- unit: require('../src/commands/unit'),
47
- syntax: require('../src/commands/syntax'),
48
- tree: require('../src/commands/tree'),
49
- list: require('../src/commands/list'),
50
- view: require('../src/commands/view'),
51
- preview: require('../src/commands/preview'),
52
- where: require('../src/commands/where'),
53
- dump: require('../src/commands/dump'),
54
- debug: require('../src/commands/debug'),
55
- run: require('../src/commands/run'),
56
- ref: require('../src/commands/ref'),
57
- guide: require('../src/commands/guide'),
58
- init: require('../src/commands/init'),
59
- pull: require('../src/commands/pull'),
60
- upgrade: require('../src/commands/upgrade'),
61
- transport: require('../src/commands/transport')
62
- };
37
+ const commandModules = require('../src/commands/index');
63
38
 
64
39
  // Check if this is a modular command
65
40
  if (commandModules[command] || command === '--help' || command === '-h') {
package/package.json CHANGED
@@ -1,8 +1,7 @@
1
1
  {
2
2
  "name": "abapgit-agent",
3
- "version": "1.13.1",
3
+ "version": "1.13.3",
4
4
  "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
5
- "main": "src/index.js",
6
5
  "files": [
7
6
  "bin/",
8
7
  "src/",
@@ -18,8 +17,6 @@
18
17
  "abgagt": "bin/abgagt"
19
18
  },
20
19
  "scripts": {
21
- "start": "node src/server.js",
22
- "dev": "nodemon src/server.js",
23
20
  "test": "jest",
24
21
  "test:all": "node tests/run-all.js",
25
22
  "test:unit": "jest",
@@ -30,6 +27,7 @@
30
27
  "test:cmd:demo": "node tests/run-all.js --cmd --demo",
31
28
  "test:cmd:syntax": "node tests/run-all.js --cmd --command=syntax",
32
29
  "test:cmd:pull": "node tests/run-all.js --cmd --command=pull",
30
+ "test:sync-xml": "node tests/run-all.js --sync-xml",
33
31
  "test:cmd:inspect": "node tests/run-all.js --cmd --command=inspect",
34
32
  "test:cmd:unit": "node tests/run-all.js --cmd --command=unit",
35
33
  "test:cmd:view": "node tests/run-all.js --cmd --command=view",
@@ -51,16 +49,13 @@
51
49
  "unrelease": "node scripts/unrelease.js"
52
50
  },
53
51
  "dependencies": {
54
- "cors": "^2.8.5",
55
52
  "dotenv": "^16.3.1",
56
- "express": "^4.18.2",
57
53
  "node-fetch": "^2.7.0",
58
54
  "uuid": "^9.0.0",
59
55
  "winston": "^3.11.0"
60
56
  },
61
57
  "devDependencies": {
62
58
  "jest": "^29.7.0",
63
- "nodemon": "^3.0.1",
64
59
  "supertest": "^7.2.2"
65
60
  },
66
61
  "engines": {
@@ -0,0 +1,33 @@
1
+ 'use strict';
2
+
3
+ /**
4
+ * abapgit-agent command registry
5
+ *
6
+ * Each entry maps a CLI command name to its command module.
7
+ * Command modules must export: { name, description, requiresAbapConfig, execute }
8
+ */
9
+ module.exports = {
10
+ help: require('./help'),
11
+ health: require('./health'),
12
+ status: require('./status'),
13
+ create: require('./create'),
14
+ delete: require('./delete'),
15
+ import: require('./import'),
16
+ inspect: require('./inspect'),
17
+ unit: require('./unit'),
18
+ syntax: require('./syntax'),
19
+ tree: require('./tree'),
20
+ list: require('./list'),
21
+ view: require('./view'),
22
+ preview: require('./preview'),
23
+ where: require('./where'),
24
+ dump: require('./dump'),
25
+ debug: require('./debug'),
26
+ run: require('./run'),
27
+ ref: require('./ref'),
28
+ guide: require('./guide'),
29
+ init: require('./init'),
30
+ pull: require('./pull'),
31
+ upgrade: require('./upgrade'),
32
+ transport: require('./transport')
33
+ };
@@ -5,16 +5,45 @@
5
5
  const { printHttpError } = require('../utils/format-error');
6
6
  const fs = require('fs');
7
7
  const pathModule = require('path');
8
-
8
+ const { execSync } = require('child_process');
9
+
10
+ // Calculate display width accounting for emoji (2 cells) vs ASCII (1 cell)
11
+ function calcWidth(str) {
12
+ if (!str) return 0;
13
+ let width = 0;
14
+ let i = 0;
15
+ while (i < str.length) {
16
+ const code = str.codePointAt(i);
17
+ if (!code) break;
18
+ // Variation selectors (FE00-FE0F) and ZWJ (200D) take 0 width
19
+ if (code >= 0xFE00 && code <= 0xFE0F) { i += 1; continue; }
20
+ if (code === 0x200D) { i += 1; continue; } // Zero width joiner
21
+ // Emoji and wide characters take 2 cells
22
+ if (code > 0xFFFF) { width += 2; i += 2; } // Skip surrogate pair
23
+ else if (code > 127) { width += 2; i += 1; }
24
+ else { width += 1; i += 1; }
25
+ }
26
+ return width;
27
+ }
28
+
29
+ // Pad string to display width
30
+ function padToWidth(str, width) {
31
+ const s = str || '';
32
+ const currentWidth = calcWidth(s);
33
+ return s + ' '.repeat(Math.max(0, width - currentWidth));
34
+ }
9
35
  module.exports = {
10
36
  name: 'pull',
11
37
  description: 'Pull and activate ABAP objects from git repository',
12
38
  requiresAbapConfig: true,
13
39
  requiresVersionCheck: true,
40
+ _calcWidth: calcWidth,
41
+ _padToWidth: padToWidth,
14
42
 
15
43
  async execute(args, context) {
16
44
  const { loadConfig, AbapHttp, gitUtils, getTransport, getSafeguards, getConflictSettings, getTransportSettings } = context;
17
45
  const verbose = args.includes('--verbose');
46
+ const syncXml = args.includes('--sync-xml');
18
47
 
19
48
  // Check project-level safeguards
20
49
  const safeguards = getSafeguards();
@@ -171,13 +200,13 @@ module.exports = {
171
200
  }
172
201
  }
173
202
 
174
- await this.pull(gitUrl, branch, files, transportRequest, loadConfig, AbapHttp, jsonOutput, undefined, conflictMode, verbose);
203
+ await this.pull(gitUrl, branch, files, transportRequest, loadConfig, AbapHttp, jsonOutput, undefined, conflictMode, verbose, syncXml);
175
204
  },
176
205
 
177
- async pull(gitUrl, branch = 'main', files = null, transportRequest = null, loadConfig, AbapHttp, jsonOutput = false, gitCredentials = undefined, conflictMode = 'abort', verbose = false) {
206
+ async pull(gitUrl, branch = 'main', files = null, transportRequest = null, loadConfig, AbapHttp, jsonOutput = false, gitCredentials = undefined, conflictMode = 'abort', verbose = false, syncXml = false, isRepull = false) {
178
207
  const TERM_WIDTH = process.stdout.columns || 80;
179
208
 
180
- if (!jsonOutput) {
209
+ if (!jsonOutput && !isRepull) {
181
210
  console.log(`\n🚀 Starting pull for: ${gitUrl}`);
182
211
  console.log(` Branch: ${branch}`);
183
212
  if (files && files.length > 0) {
@@ -281,44 +310,6 @@ module.exports = {
281
310
  return icons[type] || '';
282
311
  };
283
312
 
284
- // Calculate display width accounting for emoji (2 cells) vs ASCII (1 cell)
285
- const calcWidth = (str) => {
286
- if (!str) return 0;
287
- let width = 0;
288
- let i = 0;
289
- while (i < str.length) {
290
- const code = str.codePointAt(i);
291
- if (!code) break;
292
- // Variation selectors (FE00-FE0F) and ZWJ (200D) take 0 width
293
- if (code >= 0xFE00 && code <= 0xFE0F) {
294
- i += 1;
295
- continue;
296
- }
297
- if (code === 0x200D) { // Zero width joiner
298
- i += 1;
299
- continue;
300
- }
301
- // Emoji and wide characters take 2 cells
302
- if (code > 0xFFFF) {
303
- width += 2;
304
- i += 2; // Skip surrogate pair
305
- } else if (code > 127) {
306
- width += 2;
307
- i += 1;
308
- } else {
309
- width += 1;
310
- i += 1;
311
- }
312
- }
313
- return width;
314
- };
315
-
316
- // Pad string to display width
317
- const padToWidth = (str, width) => {
318
- const s = str || '';
319
- const currentWidth = calcWidth(s);
320
- return s + ' '.repeat(Math.max(0, width - currentWidth));
321
- };
322
313
 
323
314
  if (success === 'X' || success === true) {
324
315
  console.log(`✅ Pull completed successfully!`);
@@ -449,6 +440,71 @@ module.exports = {
449
440
  throw err;
450
441
  }
451
442
 
443
+ // --- Post-pull XML sync ---
444
+ // abapGit's status calculation already identified which XML files differ
445
+ // (match=false) — only those are returned in local_xml_files.
446
+ const localXmlFiles = result.local_xml_files || result.LOCAL_XML_FILES || [];
447
+
448
+ if (localXmlFiles.length > 0) {
449
+ const diffFiles = [];
450
+ for (const f of localXmlFiles) {
451
+ const relPath = ((f.path || f.PATH || '') + (f.filename || f.FILENAME || '')).replace(/^\//, '');
452
+ const absPath = pathModule.join(process.cwd(), relPath);
453
+ if (!fs.existsSync(absPath)) continue;
454
+ const incoming = Buffer.from(f.data || f.DATA, 'base64');
455
+ // Double-check: only write if bytes actually differ (guard against encoding quirks)
456
+ const current = fs.readFileSync(absPath);
457
+ if (!current.equals(incoming)) {
458
+ diffFiles.push({ relPath, absPath, incoming });
459
+ }
460
+ }
461
+
462
+ if (diffFiles.length > 0 && !syncXml) {
463
+ console.log(`\n⚠️ ${diffFiles.length} XML file(s) differ from serializer output:`);
464
+ for (const f of diffFiles) console.log(` ${f.relPath}`);
465
+ console.log(` Run with --sync-xml to accept serializer output and amend the last commit`);
466
+ } else if (diffFiles.length > 0 && syncXml) {
467
+ console.log(`\n🔄 Syncing ${diffFiles.length} XML file(s) to match serializer output:`);
468
+ for (const f of diffFiles) console.log(` ${f.relPath}`);
469
+
470
+ // 1. Write serializer XML to disk
471
+ for (const f of diffFiles) fs.writeFileSync(f.absPath, f.incoming);
472
+
473
+ // 2. Stage changed XML files
474
+ const quotedPaths = diffFiles.map(f => `"${f.relPath}"`).join(' ');
475
+ execSync(`git add ${quotedPaths}`, { cwd: process.cwd() });
476
+
477
+ // 3. Amend last commit
478
+ execSync('git commit --amend --no-edit', { cwd: process.cwd() });
479
+
480
+ // 4. Push with force-with-lease; if no upstream, set it automatically
481
+ let pushed = false;
482
+ try {
483
+ execSync('git push --force-with-lease', { cwd: process.cwd(), stdio: 'pipe' });
484
+ pushed = true;
485
+ } catch (pushErr) {
486
+ const msg = (pushErr.stderr || pushErr.stdout || pushErr.message || '').toString();
487
+ if (msg.includes('no upstream branch') || msg.includes('has no upstream')) {
488
+ // Branch not yet pushed — set upstream and force push (amend requires force)
489
+ execSync(`git push --force-with-lease --set-upstream origin ${branch}`, { cwd: process.cwd(), stdio: 'pipe' });
490
+ pushed = true;
491
+ }
492
+ // Any other push error (no remote at all, auth failure, etc.) → skip silently
493
+ }
494
+
495
+ if (pushed) {
496
+ console.log(` Re-pulling so ABAP system matches the amended commit...`);
497
+ // 5. Re-pull so ABAP system matches the amended commit (no sync loop)
498
+ await this.pull(gitUrl, branch, files, transportRequest, loadConfig, AbapHttp, jsonOutput, gitCredentials, conflictMode, verbose, false, true);
499
+ console.log(`\n✅ Synced ${diffFiles.length} XML file(s), amended commit, re-pulled`);
500
+ } else {
501
+ // No remote at all — files are written and committed locally
502
+ console.log(`\n✅ Synced ${diffFiles.length} XML file(s), amended commit`);
503
+ console.log(` Push skipped (no remote). Push manually to sync with remote.`);
504
+ }
505
+ }
506
+ }
507
+
452
508
  return result;
453
509
  } catch (error) {
454
510
  if (error._isPullError) {
@@ -167,6 +167,8 @@ module.exports = {
167
167
  description: 'View ABAP object definitions from ABAP system',
168
168
  requiresAbapConfig: true,
169
169
  requiresVersionCheck: true,
170
+ _buildMethodLineMap: buildMethodLineMap,
171
+ _findFirstExecutableLine: findFirstExecutableLine,
170
172
 
171
173
  async execute(args, context) {
172
174
  const { loadConfig, AbapHttp } = context;
package/src/agent.js DELETED
@@ -1,512 +0,0 @@
1
- /**
2
- * ABAP Git Agent - Main agent class
3
- * Uses AbapHttp for all ABAP communication
4
- */
5
-
6
- const { AbapHttp } = require('./utils/abap-http');
7
- const { getAbapConfig } = require('./config');
8
- const logger = require('./logger');
9
-
10
- class ABAPGitAgent {
11
- constructor() {
12
- this.config = getAbapConfig();
13
- this.http = new AbapHttp(this.config);
14
- }
15
-
16
- /**
17
- * Pull repository and activate objects
18
- * @param {string} repoUrl - Git repository URL
19
- * @param {string} branch - Branch name (default: main)
20
- * @param {string} username - Git username (optional)
21
- * @param {string} password - Git password/token (optional)
22
- * @param {Array} files - Specific files to pull (optional)
23
- * @param {string} transportRequest - Transport request number (optional)
24
- * @returns {object} Pull result with success, job_id, message, error_detail
25
- */
26
- async pull(repoUrl, branch = 'main', username = null, password = null, files = null, transportRequest = null) {
27
- logger.info('Starting pull operation', { repoUrl, branch, username: !!username, files, transportRequest });
28
-
29
- try {
30
- const csrfToken = await this.http.fetchCsrfToken();
31
-
32
- const data = {
33
- url: repoUrl,
34
- branch: branch,
35
- username: username || this.config.gitUsername,
36
- password: password || this.config.gitPassword
37
- };
38
-
39
- if (files && files.length > 0) {
40
- data.files = files;
41
- }
42
-
43
- if (transportRequest) {
44
- data.transport_request = transportRequest;
45
- }
46
-
47
- const result = await this.http.post('/sap/bc/z_abapgit_agent/pull', data, { csrfToken });
48
-
49
- // Return the result directly from ABAP (handle uppercase keys from /UI2/CL_JSON)
50
- return {
51
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
52
- job_id: result.JOB_ID || result.job_id,
53
- message: result.MESSAGE || result.message,
54
- error_detail: result.ERROR_DETAIL || result.error_detail || null,
55
- activated_count: result.ACTIVATED_COUNT || result.activated_count || 0,
56
- failed_count: result.FAILED_COUNT || result.failed_count || 0,
57
- activated_objects: result.ACTIVATED_OBJECTS || result.activated_objects || [],
58
- failed_objects: result.FAILED_OBJECTS || result.failed_objects || []
59
- };
60
-
61
- } catch (error) {
62
- logger.error('Pull failed', { error: error.message });
63
- throw new Error(`Pull failed: ${error.message}`);
64
- }
65
- }
66
-
67
- /**
68
- * Health check
69
- * @returns {object} Health status
70
- */
71
- async healthCheck() {
72
- try {
73
- const result = await this.http.get('/sap/bc/z_abapgit_agent/health');
74
- return {
75
- status: 'healthy',
76
- abap: 'connected',
77
- version: result.version || '1.4.0'
78
- };
79
- } catch (error) {
80
- return {
81
- status: 'unhealthy',
82
- abap: 'disconnected',
83
- error: error.message
84
- };
85
- }
86
- }
87
-
88
- /**
89
- * Check syntax of an ABAP object (legacy - not used by CLI)
90
- * @param {string} objectType - ABAP object type (e.g., 'CLAS', 'PROG', 'INTF')
91
- * @param {string} objectName - ABAP object name
92
- * @returns {object} Syntax check result with errors (if any)
93
- */
94
- async syntaxCheck(objectType, objectName) {
95
- logger.info('Starting syntax check', { objectType, objectName });
96
-
97
- try {
98
- const csrfToken = await this.http.fetchCsrfToken();
99
- const data = {
100
- object_type: objectType,
101
- object_name: objectName
102
- };
103
-
104
- const result = await this.http.post('/sap/bc/z_abapgit_agent/syntax-check', data, { csrfToken });
105
- return {
106
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
107
- object_type: result.OBJECT_TYPE || result.object_type,
108
- object_name: result.OBJECT_NAME || result.object_name,
109
- error_count: result.ERROR_COUNT || result.error_count || 0,
110
- errors: result.ERRORS || result.errors || []
111
- };
112
- } catch (error) {
113
- logger.error('Syntax check failed', { error: error.message });
114
- throw new Error(`Syntax check failed: ${error.message}`);
115
- }
116
- }
117
-
118
- /**
119
- * Check syntax of ABAP source code directly (without pull/activation)
120
- * Supported types: CLAS, INTF, PROG
121
- * @param {Array} objects - Array of {type, name, source, locals_def?, locals_imp?}
122
- * @param {string} uccheck - Unicode check mode ('X' for Standard, '5' for Cloud)
123
- * @returns {object} Syntax check results with success, results array
124
- */
125
- async syntaxCheckSource(objects, uccheck = 'X') {
126
- logger.info('Starting source syntax check', { objectCount: objects.length, uccheck });
127
-
128
- try {
129
- const csrfToken = await this.http.fetchCsrfToken();
130
- const data = {
131
- objects: objects,
132
- uccheck: uccheck
133
- };
134
-
135
- const result = await this.http.post('/sap/bc/z_abapgit_agent/syntax', data, { csrfToken });
136
- const success = result.SUCCESS === 'X' || result.SUCCESS === true ||
137
- result.success === 'X' || result.success === true;
138
- const results = result.RESULTS || result.results || [];
139
- const message = result.MESSAGE || result.message || '';
140
-
141
- // Normalize results
142
- const normalizedResults = results.map(r => ({
143
- object_type: r.OBJECT_TYPE || r.object_type,
144
- object_name: r.OBJECT_NAME || r.object_name,
145
- success: r.SUCCESS === 'X' || r.SUCCESS === true || r.success === 'X' || r.success === true,
146
- error_count: r.ERROR_COUNT || r.error_count || 0,
147
- errors: r.ERRORS || r.errors || [],
148
- warnings: r.WARNINGS || r.warnings || [],
149
- message: r.MESSAGE || r.message || ''
150
- }));
151
-
152
- return {
153
- success,
154
- message,
155
- results: normalizedResults
156
- };
157
- } catch (error) {
158
- logger.error('Source syntax check failed', { error: error.message });
159
- throw new Error(`Source syntax check failed: ${error.message}`);
160
- }
161
- }
162
-
163
- /**
164
- * Run unit tests for package or objects
165
- * @param {string} packageName - Package name to run tests for (optional)
166
- * @param {Array} objects - Array of {object_type, object_name} objects (optional)
167
- * @returns {object} Unit test results with test_count, passed_count, failed_count, results
168
- */
169
- async unitCheck(packageName = null, objects = []) {
170
- logger.info('Starting unit tests', { package: packageName, objects });
171
-
172
- try {
173
- const csrfToken = await this.http.fetchCsrfToken();
174
- const data = {};
175
-
176
- if (packageName) {
177
- data.package = packageName;
178
- }
179
-
180
- if (objects && objects.length > 0) {
181
- data.objects = objects;
182
- }
183
-
184
- const result = await this.http.post('/sap/bc/z_abapgit_agent/unit', data, { csrfToken });
185
- return {
186
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
187
- test_count: result.TEST_COUNT || result.test_count || 0,
188
- passed_count: result.PASSED_COUNT || result.passed_count || 0,
189
- failed_count: result.FAILED_COUNT || result.failed_count || 0,
190
- message: result.MESSAGE || result.message || '',
191
- errors: result.ERRORS || result.errors || []
192
- };
193
- } catch (error) {
194
- logger.error('Unit tests failed', { error: error.message });
195
- throw new Error(`Unit tests failed: ${error.message}`);
196
- }
197
- }
198
-
199
- /**
200
- * Create a new online repository
201
- * @param {string} repoUrl - Git repository URL
202
- * @param {string} packageName - ABAP package name
203
- * @param {string} branch - Branch name (default: 'main')
204
- * @param {string} displayName - Display name for the repository (optional)
205
- * @param {string} name - Repository name (optional)
206
- * @param {string} folderLogic - Folder logic: 'PREFIX' or 'FULL' (default: 'PREFIX')
207
- * @returns {object} Create result with success, repo_key, repo_name, message
208
- */
209
- async create(repoUrl, packageName, branch = 'main', displayName = null, name = null, folderLogic = 'PREFIX') {
210
- logger.info('Creating repository', { repoUrl, packageName, branch });
211
-
212
- try {
213
- const csrfToken = await this.http.fetchCsrfToken();
214
- const data = {
215
- url: repoUrl,
216
- package: packageName,
217
- branch: branch
218
- };
219
-
220
- if (displayName) {
221
- data.display_name = displayName;
222
- }
223
-
224
- if (name) {
225
- data.name = name;
226
- }
227
-
228
- if (folderLogic) {
229
- data.folder_logic = folderLogic;
230
- }
231
-
232
- const result = await this.http.post('/sap/bc/z_abapgit_agent/create', data, { csrfToken });
233
- return {
234
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
235
- repo_key: result.REPO_KEY || result.repo_key,
236
- repo_name: result.REPO_NAME || result.repo_name,
237
- message: result.MESSAGE || result.message || '',
238
- error: result.ERROR || result.error || null
239
- };
240
- } catch (error) {
241
- logger.error('Create failed', { error: error.message });
242
- throw new Error(`Create failed: ${error.message}`);
243
- }
244
- }
245
-
246
- /**
247
- * Import existing objects from package to git repository
248
- * @param {string} repoUrl - Git repository URL
249
- * @param {string} message - Commit message (optional)
250
- * @returns {object} Import result with success, files_staged, commit_sha
251
- */
252
- async import(repoUrl, message = null) {
253
- logger.info('Starting import operation', { repoUrl, message });
254
-
255
- try {
256
- const csrfToken = await this.http.fetchCsrfToken();
257
- const data = {
258
- url: repoUrl
259
- };
260
-
261
- if (message) {
262
- data.message = message;
263
- }
264
-
265
- const result = await this.http.post('/sap/bc/z_abapgit_agent/import', data, { csrfToken });
266
- return {
267
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
268
- files_staged: result.FILES_STAGED || result.files_staged || 0,
269
- commit_sha: result.COMMIT_SHA || result.commit_sha || '',
270
- message: result.MESSAGE || result.message || '',
271
- error: result.ERROR || result.error || null
272
- };
273
- } catch (error) {
274
- logger.error('Import failed', { error: error.message });
275
- throw new Error(`Import failed: ${error.message}`);
276
- }
277
- }
278
-
279
- /**
280
- * Get package hierarchy tree
281
- * @param {string} packageName - ABAP package name
282
- * @param {number} depth - Maximum depth to traverse (default: 3)
283
- * @param {boolean} includeObjects - Include object counts breakdown
284
- * @returns {object} Tree result with hierarchy, summary, and metadata
285
- */
286
- async tree(packageName, depth = 3, includeObjects = false) {
287
- logger.info('Getting package tree', { package: packageName, depth, includeObjects });
288
-
289
- try {
290
- const csrfToken = await this.http.fetchCsrfToken();
291
- const data = {
292
- package: packageName,
293
- depth: Math.min(Math.max(1, depth), 10),
294
- include_objects: includeObjects
295
- };
296
-
297
- const result = await this.http.post('/sap/bc/z_abapgit_agent/tree', data, { csrfToken });
298
- return {
299
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
300
- command: result.COMMAND || result.command || 'TREE',
301
- package: result.PACKAGE || result.package,
302
- message: result.MESSAGE || result.message || '',
303
- hierarchy: result.HIERARCHY || result.hierarchy || null,
304
- summary: result.SUMMARY || result.summary || null,
305
- error: result.ERROR || result.error || null
306
- };
307
- } catch (error) {
308
- logger.error('Tree command failed', { error: error.message });
309
- throw new Error(`Tree command failed: ${error.message}`);
310
- }
311
- }
312
-
313
- /**
314
- * Preview data from ABAP tables or CDS views
315
- * @param {Array} objects - Array of table/view names
316
- * @param {string} type - Object type (TABL, DDLS, etc.)
317
- * @param {number} limit - Maximum rows to return
318
- * @param {number} offset - Number of rows to skip
319
- * @param {string} where - WHERE clause filter
320
- * @param {Array} columns - Array of column names to display
321
- * @returns {object} Preview result with rows, fields, and metadata
322
- */
323
- async preview(objects, type = null, limit = 100, offset = 0, where = null, columns = null) {
324
- logger.info('Previewing data', { objects, type, limit, offset, where, columns });
325
-
326
- try {
327
- const csrfToken = await this.http.fetchCsrfToken();
328
- const data = {
329
- objects: objects,
330
- limit: Math.min(Math.max(1, limit), 500),
331
- offset: Math.max(0, offset)
332
- };
333
-
334
- if (type) {
335
- data.type = type;
336
- }
337
-
338
- if (where) {
339
- // Convert ISO date format (YYYY-MM-DD) to ABAP DATS format (YYYYMMDD)
340
- data.where = this.convertDatesInWhereClause(where);
341
- }
342
-
343
- if (columns) {
344
- data.columns = columns;
345
- }
346
-
347
- const result = await this.http.post('/sap/bc/z_abapgit_agent/preview', data, { csrfToken });
348
- return {
349
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
350
- command: result.COMMAND || result.command || 'PREVIEW',
351
- message: result.MESSAGE || result.message || '',
352
- objects: result.OBJECTS || result.objects || [],
353
- summary: result.SUMMARY || result.summary || null,
354
- pagination: result.PAGINATION || result.pagination || null,
355
- error: result.ERROR || result.error || null
356
- };
357
- } catch (error) {
358
- logger.error('Preview command failed', { error: error.message });
359
- throw new Error(`Preview command failed: ${error.message}`);
360
- }
361
- }
362
-
363
- /**
364
- * Convert ISO date formats to ABAP DATS format in WHERE clause
365
- * @param {string} whereClause - SQL WHERE clause
366
- * @returns {string} - WHERE clause with dates converted to YYYYMMDD format
367
- */
368
- convertDatesInWhereClause(whereClause) {
369
- if (!whereClause) return whereClause;
370
-
371
- const isoDatePattern = /'\\d{4}-\\d{2}-\\d{2}'/g;
372
- return whereClause.replace(isoDatePattern, (match) => {
373
- const dateContent = match.slice(1, -1);
374
- const [year, month, day] = dateContent.split('-');
375
- return `'${year}${month}${day}'`;
376
- });
377
- }
378
-
379
- /**
380
- * List objects in an ABAP package
381
- * @param {string} packageName - ABAP package name
382
- * @param {string} type - Comma-separated object types to filter (optional)
383
- * @param {string} name - Name pattern to filter (optional)
384
- * @param {number} limit - Maximum number of objects to return (default: 100)
385
- * @param {number} offset - Offset for pagination (default: 0)
386
- * @returns {object} List result with objects, by_type, total, and error
387
- */
388
- async list(packageName, type = null, name = null, limit = 100, offset = 0) {
389
- logger.info('Listing objects', { package: packageName, type, name, limit, offset });
390
-
391
- try {
392
- const csrfToken = await this.http.fetchCsrfToken();
393
- const data = {
394
- package: packageName,
395
- limit: Math.min(Math.max(1, limit), 1000),
396
- offset: Math.max(0, offset)
397
- };
398
-
399
- if (type) {
400
- data.type = type;
401
- }
402
-
403
- if (name) {
404
- data.name = name;
405
- }
406
-
407
- const result = await this.http.post('/sap/bc/z_abapgit_agent/list', data, { csrfToken });
408
-
409
- // Normalize objects array to use lowercase keys
410
- const rawObjects = result.OBJECTS || result.objects || [];
411
- const normalizedObjects = rawObjects.map(obj => ({
412
- type: obj.TYPE || obj.type,
413
- name: obj.NAME || obj.name
414
- }));
415
-
416
- // Normalize by_type array to use lowercase keys
417
- const rawByType = result.BY_TYPE || result.by_type || [];
418
- const normalizedByType = rawByType.map(item => ({
419
- type: item.TYPE || item.type,
420
- count: item.COUNT || item.count || 0
421
- }));
422
-
423
- return {
424
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
425
- command: result.COMMAND || result.command || 'LIST',
426
- package: result.PACKAGE || result.package || packageName,
427
- message: result.MESSAGE || result.message || '',
428
- objects: normalizedObjects,
429
- by_type: normalizedByType,
430
- total: result.TOTAL || result.total || 0,
431
- error: result.ERROR || result.error || null
432
- };
433
- } catch (error) {
434
- logger.error('List command failed', { error: error.message });
435
- throw new Error(`List command failed: ${error.message}`);
436
- }
437
- }
438
-
439
- /**
440
- * View ABAP object definitions
441
- * @param {Array} objects - Array of object names to view
442
- * @param {string} type - Object type (optional, e.g., 'CLAS', 'TABL')
443
- * @returns {object} View result with object definitions
444
- */
445
- async view(objects, type = null) {
446
- logger.info('Viewing objects', { objects, type });
447
-
448
- try {
449
- const csrfToken = await this.http.fetchCsrfToken();
450
- const data = {
451
- objects: objects
452
- };
453
-
454
- if (type) {
455
- data.type = type;
456
- }
457
-
458
- const result = await this.http.post('/sap/bc/z_abapgit_agent/view', data, { csrfToken });
459
- return {
460
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
461
- command: result.COMMAND || result.command || 'VIEW',
462
- objects: result.OBJECTS || result.objects || [],
463
- error: result.ERROR || result.error || null
464
- };
465
- } catch (error) {
466
- logger.error('View command failed', { error: error.message });
467
- throw new Error(`View command failed: ${error.message}`);
468
- }
469
- }
470
-
471
- /**
472
- * Find where-used list for ABAP objects
473
- * @param {Array} objects - Array of object names to search
474
- * @param {string} type - Object type (optional)
475
- * @param {number} limit - Maximum results (default: 100, max: 500)
476
- * @param {number} offset - Number of results to skip (default: 0)
477
- * @returns {object} Where-used result with found objects
478
- */
479
- async where(objects, type = null, limit = 100, offset = 0) {
480
- logger.info('Finding where-used', { objects, type, limit, offset });
481
-
482
- try {
483
- const csrfToken = await this.http.fetchCsrfToken();
484
- const data = {
485
- objects: objects,
486
- limit: Math.min(Math.max(1, limit), 500),
487
- offset: Math.max(0, offset)
488
- };
489
-
490
- if (type) {
491
- data.type = type;
492
- }
493
-
494
- const result = await this.http.post('/sap/bc/z_abapgit_agent/where-used', data, { csrfToken });
495
- return {
496
- success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
497
- command: result.COMMAND || result.command || 'WHERE',
498
- objects: result.OBJECTS || result.objects || [],
499
- message: result.MESSAGE || result.message || '',
500
- pagination: result.PAGINATION || result.pagination || null,
501
- error: result.ERROR || result.error || null
502
- };
503
- } catch (error) {
504
- logger.error('Where command failed', { error: error.message });
505
- throw new Error(`Where command failed: ${error.message}`);
506
- }
507
- }
508
- }
509
-
510
- module.exports = {
511
- ABAPGitAgent
512
- };
package/src/index.js DELETED
@@ -1,48 +0,0 @@
1
- /**
2
- * ABAP Git Agent - Package Entry Point
3
- *
4
- * Exports functions for programmatic use:
5
- * const { pull, healthCheck } = require('abapgit-agent');
6
- */
7
-
8
- const { ABAPGitAgent } = require('./agent');
9
-
10
- /**
11
- * Pull repository and activate objects
12
- * @param {string} repoUrl - Git repository URL
13
- * @param {string} branch - Branch name (default: main)
14
- * @param {string} username - Git username (optional)
15
- * @param {string} password - Git password/token (optional)
16
- * @returns {object} Pull result with success, job_id, message, error_detail
17
- */
18
- async function pull(repoUrl, branch = 'main', username = null, password = null) {
19
- const agent = new ABAPGitAgent();
20
- return await agent.pull(repoUrl, branch, username, password);
21
- }
22
-
23
- /**
24
- * Check agent health
25
- * @returns {object} Health status
26
- */
27
- async function healthCheck() {
28
- const agent = new ABAPGitAgent();
29
- return await agent.healthCheck();
30
- }
31
-
32
- /**
33
- * Check if integration is configured for current directory
34
- * @returns {boolean} True if .abapGitAgent exists
35
- */
36
- function isConfigured() {
37
- const fs = require('fs');
38
- const path = require('path');
39
- const repoConfigPath = path.join(process.cwd(), '.abapGitAgent');
40
- return fs.existsSync(repoConfigPath);
41
- }
42
-
43
- module.exports = {
44
- pull,
45
- healthCheck,
46
- isConfigured,
47
- ABAPGitAgent
48
- };
package/src/server.js DELETED
@@ -1,116 +0,0 @@
1
- /**
2
- * HTTP Server for Claude Integration
3
- */
4
-
5
- const express = require('express');
6
- const cors = require('cors');
7
- const { ABAPGitAgent } = require('./agent');
8
- const { getAgentConfig } = require('./config');
9
- const logger = require('./logger');
10
-
11
- class Server {
12
- constructor() {
13
- this.app = express();
14
- this.agent = new ABAPGitAgent();
15
- this.agentConfig = getAgentConfig();
16
-
17
- this.setupMiddleware();
18
- this.setupRoutes();
19
- }
20
-
21
- setupMiddleware() {
22
- this.app.use(cors());
23
- this.app.use(express.json());
24
-
25
- // Request logging
26
- this.app.use((req, res, next) => {
27
- logger.debug(`${req.method} ${req.path}`, { body: req.body });
28
- next();
29
- });
30
-
31
- // Error handling
32
- this.app.use((err, req, res, next) => {
33
- logger.error('Request error', { error: err.message, stack: err.stack });
34
- res.status(500).json({
35
- success: false,
36
- error: err.message
37
- });
38
- });
39
- }
40
-
41
- setupRoutes() {
42
- // Health check
43
- this.app.get('/api/health', async (req, res) => {
44
- try {
45
- const health = await this.agent.healthCheck();
46
- res.json(health);
47
- } catch (error) {
48
- res.status(503).json({
49
- status: 'unhealthy',
50
- error: error.message
51
- });
52
- }
53
- });
54
-
55
- // Pull repository (synchronous - returns immediately with result)
56
- this.app.post('/api/pull', async (req, res) => {
57
- try {
58
- const { url, branch, username, password } = req.body;
59
-
60
- if (!url) {
61
- return res.status(400).json({
62
- success: false,
63
- error: 'Missing required parameter: url'
64
- });
65
- }
66
-
67
- const result = await this.agent.pull(url, branch, username, password);
68
- res.json(result);
69
-
70
- } catch (error) {
71
- logger.error('Pull failed', { error: error.message });
72
- res.status(500).json({
73
- success: false,
74
- error: error.message
75
- });
76
- }
77
- });
78
- }
79
-
80
- start() {
81
- const port = this.agentConfig.port || 3000;
82
-
83
- this.server = this.app.listen(port, () => {
84
- logger.info(`ABAP AI Bridge server started on port ${port}`);
85
- console.log(`\n🚀 ABAP AI Bridge is running!`);
86
- console.log(` Health: http://localhost:${port}/api/health`);
87
- console.log(` Pull: POST http://localhost:${port}/api/pull`);
88
- console.log(`\n📚 API Documentation:`);
89
- console.log(` POST /api/pull { "url": "git-url", "branch": "main" }`);
90
- });
91
-
92
- // Graceful shutdown
93
- process.on('SIGTERM', () => this.shutdown());
94
- process.on('SIGINT', () => this.shutdown());
95
- }
96
-
97
- shutdown() {
98
- logger.info('Shutting down server...');
99
- if (this.server) {
100
- this.server.close(() => {
101
- logger.info('Server closed');
102
- process.exit(0);
103
- });
104
- }
105
- }
106
- }
107
-
108
- // Start server if run directly
109
- if (require.main === module) {
110
- const server = new Server();
111
- server.start();
112
- }
113
-
114
- module.exports = {
115
- Server
116
- };