abapgit-agent 1.12.0 → 1.12.1

package/abap/CLAUDE.md

@@ -248,13 +248,27 @@ By default, probe/throwaway classes may be created in the current project. When
 | HTTP 500 / runtime crash (ST22) | `dump` | Error already occurred |
 | Wrong output, no crash | `debug` | Need to trace logic |
 
-Quick start:
+→ See `guidelines/debug-dump.md` for dump analysis workflow
+
+**Critical rules for `debug` sessions:**
+
+1. **Always use `--json`** for all debug commands (`attach`, `vars`, `stack`, `step`) — human output is not machine-parseable
+2. **Attach BEFORE trigger** — start `debug attach --json` in background first, wait for `"Listener active"`, THEN fire the trigger (`unit`/`pull`/`run`)
+3. **Never pull to trigger** if a simpler trigger works — use `unit` when a test exists, `run` for a class runner; use `pull` only when the bug is specifically in the pull flow
+4. **Never pass `--session`** to `step/vars/stack` — it bypasses the daemon and causes errors
+5. **Always finish with `step --type continue --json`** — releases the frozen ABAP work process
+
+Minimal correct sequence:
 ```bash
-abapgit-agent dump --date TODAY --detail 1    # inspect last crash
-abapgit-agent debug set --objects ZCL_FOO:42  # set breakpoint then attach
-abapgit-agent run --class ZCL_MY_RUNNER       # execute and inspect output
+abapgit-agent debug set --objects ZCL_FOO:42        # 1. set breakpoint
+abapgit-agent debug attach --json > /tmp/a.json 2>&1 &   # 2. attach (background)
+until grep -q "Listener active" /tmp/a.json 2>/dev/null; do sleep 0.3; done
+abapgit-agent unit --files src/zcl_foo.clas.testclasses.abap > /tmp/t.json 2>&1 &  # 3. trigger
+# poll for session, then inspect
+abapgit-agent debug vars --json
+abapgit-agent debug step --type continue --json     # 4. release
 ```
-→ See `guidelines/debug-dump.md` for dump analysis workflow
+
 → See `guidelines/debug-session.md` for full debug session guide, breakpoint tips, and pull flow architecture
 
 ---
@@ -363,6 +377,12 @@ abapgit-agent pull --files src/zcl_auth_handler.clas.abap
 1. ✗ Do not run `abapgit-agent transport create`
 2. ✓ Inform the user that transport creation is disabled for this project
 
+**When pull result contains `missing_abapgit_xml: true` (JSON mode) or warning about `.abapgit.xml`:**
+1. ✓ Inform the user that `.abapgit.xml` is missing from the repository root
+2. ✓ Suggest running `abapgit-agent init --package <PACKAGE>` to create it
+3. ✓ If `ACTIVATED_COUNT=0` with an empty log, suspect this as the cause
+4. ✗ Do not retry the pull — fix the missing file first
+
 **When `transports.allowRelease = false`:**
 1. ✗ Do not run `abapgit-agent transport release`
 2. ✓ Inform the user that transport release is disabled for this project

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abapgit-agent",
-  "version": "1.12.0",
+  "version": "1.12.1",
   "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
   "main": "src/index.js",
   "files": [

package/src/commands/init.js

@@ -129,7 +129,7 @@ Usage:
 
 Description:
   Initialize local repository configuration.
-  Creates .abapGitAgent, .gitignore, CLAUDE.md, and guidelines folder.
+  Creates .abapGitAgent, .abapgit.xml, .gitignore, CLAUDE.md, and guidelines folder.
 
 Options:
   --package <PACKAGE>             ABAP package name (required)
@@ -500,6 +500,34 @@ Uncomment and edit the rows that differ from the defaults in \`guidelines/object
       console.error(`Error creating folder: ${error.message}`);
     }
 
+    // Create .abapgit.xml with correct STARTING_FOLDER so abapGit's remove_ignored_files()
+    // keeps files inside the source folder. Without this file the stored starting_folder in
+    // the ABAP persistence may not match the actual folder, causing all remote files to be
+    // silently ignored and pull to return ACTIVATED_COUNT=0 with an empty log.
+    const abapgitXmlPath = pathModule.join(process.cwd(), '.abapgit.xml');
+    if (!fs.existsSync(abapgitXmlPath)) {
+      const language = (config.language || 'E').toUpperCase().charAt(0);
+      const abapgitXml = `<?xml version="1.0" encoding="utf-8"?>
+<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+ <asx:values>
+  <DATA>
+   <MASTER_LANGUAGE>${language}</MASTER_LANGUAGE>
+   <STARTING_FOLDER>${folder}</STARTING_FOLDER>
+   <FOLDER_LOGIC>${folderLogic}</FOLDER_LOGIC>
+  </DATA>
+ </asx:values>
+</asx:abap>
+`;
+      try {
+        fs.writeFileSync(abapgitXmlPath, abapgitXml);
+        console.log(`✅ Created .abapgit.xml (STARTING_FOLDER=${folder}, FOLDER_LOGIC=${folderLogic})`);
+      } catch (error) {
+        console.error(`Error creating .abapgit.xml: ${error.message}`);
+      }
+    } else {
+      console.log(`✅ .abapgit.xml already exists, skipped`);
+    }
+
     console.log(`
 📋 Next steps:
    1. Edit .abapGitAgent with your ABAP credentials (host, user, password)

package/src/commands/pull.js

@@ -3,6 +3,8 @@
  */
 
 const { printHttpError } = require('../utils/format-error');
+const fs = require('fs');
+const pathModule = require('path');
 
 module.exports = {
   name: 'pull',
@@ -84,6 +86,20 @@ module.exports = {
         console.error('   Example: --files src/zcl_my_class.clas.abap');
         process.exit(1);
       }
+
+      // Validate that every specified file exists on disk.
+      // Skip when --url is explicit: the files belong to a different repository
+      // and won't be present in the current working directory.
+      if (urlArgIndex === -1) {
+        const fs = require('fs');
+        const missingFiles = files.filter(f => !fs.existsSync(f));
+        if (missingFiles.length > 0) {
+          console.error('❌ Error: the following file(s) do not exist:');
+          missingFiles.forEach(f => console.error(`     ${f}`));
+          console.error('   Check the path and try again.');
+          process.exit(1);
+        }
+      }
     }
 
     // SAFEGUARD 2: Check if files are required but not provided
@@ -102,22 +118,30 @@ module.exports = {
     if (!transportRequest && !jsonOutput) {
       const { selectTransport, isNonInteractive, _getTransportHookConfig } = require('../utils/transport-selector');
 
-      // Check if this package requires a transport before showing the interactive
-      // picker. Skip the status round-trip in non-interactive mode — selectTransport
-      // already returns null there without prompting, so the extra HTTP call is wasted.
-      let transportRequired = true; // Safe default: assume transport needed
-      if (!isNonInteractive()) {
-        try {
-          const config = loadConfig();
-          const http = new AbapHttp(config);
-          const csrfToken = await http.fetchCsrfToken();
-          const statusResult = await http.post('/sap/bc/z_abapgit_agent/status', { url: gitUrl }, { csrfToken });
-          if (statusResult.transport_required === false || statusResult.transport_required === 'false') {
-            transportRequired = false;
-          }
-        } catch (e) {
-          // Status check failed — proceed with selector as safe default
-        }
+      // Check repository status — confirms the repo is registered and tells us
+      // whether a transport is required. If the check fails, abort: pulling into
+      // an uninitialised repository does not make sense.
+      let transportRequired = false;
+      let statusResult;
+      try {
+        const config = loadConfig();
+        const http = new AbapHttp(config);
+        const csrfToken = await http.fetchCsrfToken();
+        statusResult = await http.post('/sap/bc/z_abapgit_agent/status', { url: gitUrl }, { csrfToken });
+      } catch (e) {
+        console.error(`❌ Repository status check failed: ${e.message}`);
+        console.error('   Make sure the repository is registered with abapgit-agent (run "abapgit-agent create").');
+        process.exit(1);
+      }
+
+      if (!statusResult || statusResult.status === 'Not found') {
+        console.error(`❌ Repository not found in ABAP system: ${gitUrl}`);
+        console.error('   Run "abapgit-agent create" to register it first.');
+        process.exit(1);
+      }
+
+      if (statusResult.transport_required === true || statusResult.transport_required === 'true') {
+        transportRequired = true;
       }
 
       if (transportRequired) {
@@ -147,10 +171,10 @@ module.exports = {
       }
     }
 
-    await this.pull(gitUrl, branch, files, transportRequest, loadConfig, AbapHttp, jsonOutput, undefined, conflictMode);
+    await this.pull(gitUrl, branch, files, transportRequest, loadConfig, AbapHttp, jsonOutput, undefined, conflictMode, verbose);
   },
 
-  async pull(gitUrl, branch = 'main', files = null, transportRequest = null, loadConfig, AbapHttp, jsonOutput = false, gitCredentials = undefined, conflictMode = 'abort') {
+  async pull(gitUrl, branch = 'main', files = null, transportRequest = null, loadConfig, AbapHttp, jsonOutput = false, gitCredentials = undefined, conflictMode = 'abort', verbose = false) {
     const TERM_WIDTH = process.stdout.columns || 80;
 
     if (!jsonOutput) {
@@ -196,12 +220,26 @@ module.exports = {
 
       const result = await http.post('/sap/bc/z_abapgit_agent/pull', data, { csrfToken });
 
+      // Detect missing .abapgit.xml — without it abapGit's stored starting_folder
+      // may not match the actual source folder, causing pull to silently return ACTIVATED_COUNT=0
+      const missingAbapgitXml = fs.existsSync(pathModule.join(process.cwd(), '.git')) &&
+          !fs.existsSync(pathModule.join(process.cwd(), '.abapgit.xml'));
+
       // JSON output mode
       if (jsonOutput) {
+        if (missingAbapgitXml) {
+          result.missing_abapgit_xml = true;
+        }
         console.log(JSON.stringify(result, null, 2));
         return result;
       }
 
+      if (missingAbapgitXml) {
+        console.warn('⚠️  .abapgit.xml not found in repository root.');
+        console.warn('   Pull may return ACTIVATED_COUNT=0 if the ABAP-side starting_folder is wrong.');
+        console.warn('   Run: abapgit-agent init --package <PACKAGE> to create it.\n');
+      }
+
       console.log('\n');
 
       // Display raw result for debugging